WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2677 closed theme (not-approved)

THEME: Custom Community - 1.7.0.2

Reported by: svenl77 Owned by: cais
Priority: Keywords: theme-custom-community, buddypress
Cc: mail@…

Description

Custom Community - 1.7.0.2

Create your BuddyPress community within minutes. Custom Community is a Buddypress theme that enables you to build your site with all the features you love. Easy to use jQuery slideshow. List your posts with thumbnail integration and fancy mouse over effect. A powerful admin option page to customize every part of the theme. Clean and simple css-design. 5 widget areas and 3 special widgets. 100% WP 3.0 compatible.

Theme URL - http://themekraft.com/theme/custom-community/
Author URL - http://themekraft.com/

SVN - http://themes.svn.wordpress.org/custom-community/1.7.0.2
ZIP - http://wordpress.org/extend/themes/download/custom-community.1.7.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/custom-community/1.7.0.1&new_path=/custom-community/1.7.0.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-custom-community&order=priority

https://themes.svn.wordpress.org/custom-community/1.7.0.2/screenshot.png

Change History (39)

comment:1 svenl773 years ago

Hi, please use this version the older tickets can be closed.

The theme check errors are all from buddypress files. I do not want to change buddypress files, we just overwrite them with every buddypress update.
It wouldn't make sense for me to touch such files.

This should be fixed in Buddypress.

thanks

comment:2 emiluzelac3 years ago

  • Owner set to emiluzelac
  • Status changed from new to assigned

comment:3 emiluzelac3 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Theme Check: Passed

Theme Options:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB6.6; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; Tablet PC 2.0)
Timestamp: Sun, 30 Jan 2011 19:20:06 UTC

Message: HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)
Line: 0
Char: 0
Code: 0
URI: /admin.php?page=cheezcap.php

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB6.6; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; Tablet PC 2.0)
Timestamp: Sun, 30 Jan 2011 19:23:05 UTC

Message: HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)
Line: 0
Char: 0
Code: 0
URI: /admin.php?page=cheezcap.php

Message: Exception thrown and not caught
Line: 10
Char: 180369
Code: 0
URI: https://ajax.googleapis.com/ajax/libs/jqueryui/1.7.1/jquery-ui.min.js?ver=1.7.1

Note:
To work around this problem, write script blocks that modify only closed containers or that modify only the script's immediate container element. To do this, you can use a placeholder to close the target container, or you can move the script block into the container that you want to modify.

Theme Options do not work in IE8.

Other Errors:
Fatal error: Call to undefined function bp_loggedin_user_domain() in /wp-content/themes/custom-community/core/cc_widgets.php on line 77

Unfortunetely there are few errors in this Theme and because of that we cannot approve. Please correct this and submit your theme again. If you have any questions post them here and one of us will be more than happy to assist.

Thank You

comment:4 svenl773 years ago

Hi emiluzelac,

Thanks a lot for your review, we will fix all and upload a new version.

But for now, please approve the theme. The version 1.7.0.2 is a huge improvement and has plenty of bugfixes. It is a very important update. The theme is already in the repository and people download a buggy theme every day. The theme has 200 - 300 downloads every day.

People mail us for this and I have to tell them the theme stucks in the review process.

So please give us some time, because this week is blocked and approve this version for now.

Thanks Sven and Konrad

comment:5 emiluzelac3 years ago

Hi Sven and Konrad,

Theme Review must meet the WordPress guidelines before we can approve it. Like you, we also need to follow the same rules. Since this was previously approved theme, the wait time is much shorter than if the theme was submitted for the first time.

Thank you for understanding.

comment:6 svenl773 years ago

This update fixes a lot of critical bugs in the live version. So it's very important people can update their theme. I'm aware of your review now, and it will come to a new version. But to let the people download a broken theme in the meantime, I cannot understand.

I had this situation before and it was no problem.
Have a look here please:
http://themes.trac.wordpress.org/ticket/1977

comment:7 emiluzelac3 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

The author says that the fixes are very critical and he's aware of the minor issues with the theme. Theme Check passed. Reopening from closed not approved to open and approved after that.

comment:8 emiluzelac3 years ago

  • Resolution set to approved
  • Status changed from reopened to closed

comment:9 mercime3 years ago

Some users need to update to latest version of this theme and issues are brought up in BuddyPress forums.

It has already been approved here and updated files are available in SVN but users can only download version 1.6 http://wordpress.org/extend/themes/custom-community. What's holding this up?

http://wordpress.org/support/topic/custom-community-theme-new-version-172?replies=1

http://make.wordpress.org/themes/2011/03/11/i-thought-we-already-allowed-child-theme/

EDIT - ooops, this is not a bp-default child theme :) Nevertheless, it has been approved, right?

Last edited 3 years ago by mercime (previous) (diff)

comment:10 emiluzelac3 years ago

Hello,

Let me check that for you.

Emil

comment:11 cais3 years ago

mea culpa, mea culpa ... anytime a Theme with a resolution of "Approved" does not go live into Extend within 24 hours please send an email as a reminder; sometimes one will get missed.

PS: This is now live in Extend.

comment:12 emiluzelac3 years ago

Thank you Cais :)

comment:13 Otto423 years ago

After 6 weeks, the errors in this theme were never corrected and the theme was pushed through due to unnamed "critical" fixes.

I'm going to suggest removal of this theme from the directory entirely, unless the author addresses the given issues with the theme immediately.

Last edited 3 years ago by Otto42 (previous) (diff)

comment:14 Otto423 years ago

Also, the theme really shouldn't be using the various jquery stuff from google directly. jQuery-UI and jQuery are loaded from Google in /core/core-loader.php. This looks like it may be a part of all the cheezcap stuff, which may need to be rewritten. Loading a lot of different versions of jquery and jquery-ui and stuff makes it weird, at best.

comment:15 svenl773 years ago

We are working on the new version 1.7.3, and it will come out in the next days.
We have fixed all bugs and improved the theme a lot. So please do not remove it from the repository. Also, we spend a lot of time, to build a new version, and the theme have never been listed in the repository.

We would have done this faster, if the theme were listed. But it has been approved today.

So please give us some moments.

All will be done. Thanks a lot for all this engagement.

Last edited 3 years ago by svenl77 (previous) (diff)

comment:16 cais3 years ago

Due to the oversights by the team in general, we will leave the theme live for a very short term; but, if a new submitted version addressing all of the items as noted above does not correct them in that time-frame (as suggested by the author) we will be taking the suggestion of "removal" under serious consideration.

comment:17 cais3 years ago

  • Resolution approved deleted
  • Status changed from closed to reopened

Re-opening ticket to monitor; please advise when new version has been submitted by noting its ticket here. Thank you.

comment:18 cais3 years ago

  • Owner changed from emiluzelac to cais
  • Status changed from reopened to assigned

comment:19 emiluzelac3 years ago

Just an FYI this Theme was originally set to not-approved by me, as you can see above, however the author said that this was a critical upgrade for his customers that is why I re-opened already not-approved and approved it. That's partially my bad for trying to help out.

comment:20 cais3 years ago

@Emil - We do our best to help with getting the "critical" items into the repository but it is just as important to insure the Theme itself meets the current guidelines well enough to justify a "quick fix" approval. Minor issues are fine to let through given the author intends to correct, but more significant issues should still be addressed regardless of the "critical" nature of the update.

PS: The clock is ticking ...

comment:21 svenl773 years ago

If I read all these comments, I don't feel treated nicely.

"PS: The clock is ticking ..."

Are you waiting to shoot us off?

When I came into the open source world, people helped each other, teaching, committing bugs, and treating respectfully. We by ourselves help people every day with their problems on our forums.

We do our best and we love the fun factor. We are working for it. Let's treat each other respectfully.

We didn't want to treat anybody badly. We push all our free time into this. And we love to become better with every feedback.

Sven and Konrad

Last edited 3 years ago by svenl77 (previous) (diff)

comment:22 cais3 years ago

@Sven -

Everyone, your team and ours, deserves to be treated fairly and nicely, but as you have noted yourself you had every intent to address any outstanding issues; and, as has also been noted there are some significant issues that have been brought to light that require your attention, too.

The "clock is ticking" is just a simple reminder ... your planned time-line to have these updates done and submitted would be greatly appreciated.

comment:23 svenl773 years ago

Hi,

I want to give some feedback and let you know the status, we are still working on the new version. It takes longer as we thought before.
The last two days I have spent to rewrite the cheezcap. It's now error free in the themecheck.
No eval() and so on. Also reworked the complete jQuery. The theme is in the testing period. I have sent it to some people for testing propose.

After this testing phase, I will submit it.

Version 0, edited 3 years ago by svenl77 (next)

comment:24 cais3 years ago

Great! Thanks for the update.

Please note the new ticket here after you have submitted the latest version.

comment:25 cais3 years ago

As noted in various comments and given that a fair amount of time has been allowed for the proper corrections to be addressed and submitted. This theme ticket will be resolved to "not-approved" and the theme will be suspended from the Extend repository.

If a new submission is made please note on the ticket the theme may be under suspension.

comment:26 cais3 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

comment:27 follow-up: svenl773 years ago

We have spent a lot of time to fix all bugs. We installed the newest themecheck plugin to verify that there is nothing left.

We set wp debug = true too and worked down all. Also the notices.

After testing all with different testers, we finally check in and failed the test.

WARNING: file_get_contents was found in the file cheezcap.php possible file operations.

We have never get this warning before with the plugin tests and we need it for a XML import and export of our settings. Is there anything we can use instead of file_get_contents function of PHP?

We spent much time now figuring out all the needs to get the theme back into the repository. Many people contacted us asking why its gone.

We did all possible, and checked it with your tools. And now we fail again. It's really frustrating, and we also have no time left for the next weeks.

Last edited 3 years ago by svenl77 (previous) (diff)

comment:28 svenl773 years ago

ok, i have fixed it "Results of Automated Theme Scanning: Pass"

comment:29 in reply to: ↑ 27 Otto423 years ago

Replying to svenl77:

We have never get this warning before with the plugin tests and we need it for a XML import and export of our settings. Is there anything we can use instead of file_get_contents function of PHP?

We've had discussions on this matter, and basically there's no legitimate reason for a theme to be reading files like that.

Import and export of options is kind of a strange process for a theme to be implementing in the first place, IMO. However, if you want to do it, the problem there would be on import, as export is simply a matter of sending a file download to the user's browser directly.

The WP_Filesystem code can be used to do file reading. It supports a get_contents() function that would work. Alternatively, the file() function is not blocked and can read in a file as an array. And really, assuming your file has some kind of format to it, like XML or an INI or something, then there's more file-specific functions you could be using. parse_ini_file() can read in an INI file, simplexml_load_file() can read an XML file, that sort of thing. Half a dozen other ways.

We may unblock file_get_contents() in the future. The reason it's blocked is that virtually all malware that we've seen in themes uses it, and legit code generally doesn't need it or has more thought out methodologies than simply reading in whole files into memory as flat strings.

comment:30 svenl773 years ago

Hi @Otto42,

I have already changed the function and fixed it.

I uploaded it again and it passed the check.

I will do it again with a new version.

Last edited 3 years ago by svenl77 (previous) (diff)

comment:31 svenl773 years ago

just added the new version 1.7.2

comment:32 svenl773 years ago

Hi @All,

Is there something left I need to do? Or just wait? I have already uploaded a new version like mentioned in the comment before.

But I didn't get any mail, and now I'm not sure, what to do. Any instructions would be great.

Thanks Sven

comment:33 Otto423 years ago

sven: No new version has been uploaded, or at least not accepted.

The last version you uploaded was this one, 1.7.0.2.

http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-custom-community&order=priority

comment:34 svenl773 years ago

ok, I have uploaded a new version 1.7.3 right now. I went under Themes/Theme Authors and upload the new version

Results of Automated Theme Scanning: Pass

RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
INFO: core-loader.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
INFO: cheezcap.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
INFO: bp-templatetags.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
INFO: activity-loop.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

is it now in? or what did I wrong?
Thanks for the fast help.

Sven

comment:35 Otto423 years ago

Nope, still not there. Theme upload can fail for other reasons than just the theme-check. Email me the ZIP file and I'll check it out: otto@…

comment:36 svenl773 years ago

Hi Otto42, instead of your email address I just see otto@... which domain?

Last edited 3 years ago by svenl77 (previous) (diff)

comment:37 Otto423 years ago

otto at ottodestruct dot com

comment:38 Otto423 years ago

Okay, I emailed you what the issue is, but I'm putting it in here too just for completeness sake.

The theme-check is not the only check that is performed. The uploader has always performed some checks, the latest addition of the theme-check tool is just that, an addition. It is not the only thing that has to pass.

Specifically, when you upload the theme, this message appears at the bottom of the screen, after the theme-check output:

You don't appear to be showing the blog tagline anywhere. Please add this feature to your theme.

The theme check tool doesn't check for this, but the uploader does and always has. Specifically, it's looking for bloginfo('description') in the theme somewhere.

Now, this particular check normally gets ignored for buddypress-child-themes, however you've removed the Template: tag from the style.css file, so it's not a child theme anymore, so it's requiring that sort of thing.

Adding Template: bp-default into the style.css file will make it a proper buddypress child-theme again. You'll want to test this change first though, obviously.

BTW, you don't have to up the version number every time you try to upload. The latest version of your theme uploaded and accepted into the system is 1.7.0.2. Anything higher than that, including 1.7.1 is acceptable. Only when it takes the theme and makes a ticket and you get an email does the version count as legitimate.

comment:39 svenl773 years ago

Thanks so much for your help Otto, we finally got it!
http://themes.trac.wordpress.org/ticket/3423 ;-)

Note: See TracTickets for help on using tickets.