WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#26796 closed theme (not-approved)

THEME: Best Reloaded – 0.6

Reported by: williampatton Owned by: WEN Solutions
Priority: new theme Keywords: theme-best-reloaded
Cc: will@…

Description

Best Reloaded - 0.6

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

SVN - https://themes.svn.wordpress.org/best-reloaded/0.6
ZIP - https://wordpress.org/themes/download/best-reloaded.0.6.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions

(this ticket)

#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin
#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.6/screenshot.png

Change History (7)

#1 @themetracbot
2 years ago

  • Owner set to WEN Solutions
  • Status changed from new to reviewing

#2 @WEN Solutions
2 years ago

Hello @williampatton,

I have done a QUICK review of your theme and found following issues that you need to resolve them before I approved your theme. Let me know if you have any queries regarding any points stated below.

[REQUIRED]

Theme Options

Console

Screenshot

Language

Reference Link: https://codex.wordpress.org/I18n_for_WordPress_Developers

License

files

  • Please remove package.json and similarly check others too. Unwanted file is now allowed on theme.

Validation and Sanitization

style.css

js/css

code

  • Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. http://themereview.co/prefix-all-the-things
  • Please remove unwanted and commented code. For reference ads-posts.php line 15. Please check on other files too.
  • Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. Some Functions name missing prefix. Check on all files too.

http://themereview.co/prefix-all-the-things/

RECOMMENDED

  • Code indentation is necessary for making readable format.

Theme Check

  • No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Possible hard-coded links were found in the file options.php. Remove hardcoded links.

Line 152: 'std' => '&copy; 2014-2015 <a href='http://www.pattonwebz.com/'>PattonWebz</a>',

  • Possible hard-coded links were found in the file header.php. Line 31: <!--[if lt IE 7]><p class=chromeframe>Your browser is <em>ancient!</em> <a href='http://browsehappy.com/'>Upgrade to a different browser</a> or <a href='htt
  • options.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
  • options-framework.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

NOTE

  • REQUIRED points should be resolved to make theme approved on wordpress.org. RECOMMENDED points includes best practices on theme development but theme will not be rejected on the base of RECOMMENDED points.
  • Please fix issues and reupload your theme. Update your theme version and changelog. https://wordpress.org/themes/upload/
  • Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Best Regards,
wensolution :)

#3 @williampatton
2 years ago

Hey @WEN Solutions,

Lots of problems preventing approval here but luckily I've already dealt with a good number of these issues (sanitization, validation, prefixing, removing unneeded files/comments) while waiting on this ticket getting assigned.

I won't be able to deal with the rest of them or upload an updated version at the moment though as my wife has just given birth and I'm taking some time off just now to bond and get used to him being here.

I actually got the email about you being assigned and your first preliminary review when we were in the delivery room. I shouldn't have been checking emails at that time but... Just don't tell my wife haha

It'll likely be more than 7 days before I get back to this so this ticket may well be auto-closed but I will definetly be back at this as soon as I have the time.

Thanks for doing the first review already though, give me plenty to tackle once I get back to work.

Regards,
Will

Edit: if you can give me some advice to keep this ticket from being marked as not-approved on an auto-close that would be greatly appreciated.

Last edited 2 years ago by williampatton (previous) (diff)

#4 @WEN Solutions
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Thanks @williampatton for letting me know about your situation, I understood, although it's already late.
It seems like you still need some more time (considering a situation going around you) so you'd better take your time to fix and verify all those noted issues again and re-upload your new version of theme. Trying making it as soon as possible though.

In my case, I'm closing this thread and left it as not approved since I need to proceed with other themes already waiting in my queue for review.

All the best!

Regards,
WEN Solutions

#5 @williampatton
2 years ago

Hey again @WEN Solutions,

Thanks for updating me, although I have to say I am soarly disappointed that you chose to close and mark 'not-approved'. All the rules I can find (including one stated directly in your first reply) say that a response is needed within 7 days or the ticket will auto-close. I responded before it was auto-closed, explained my situation and yet you still manually marked 'not-approved'? Really???

Will I need to wait an additional 8 weeks to have this theme re-allocated to a reviewer once I upload a new version? If that is the case then I'm completely shocked that is how the review process works as I see numerous other theme tickets which exceed 7 days between uploads and those are not marked as 'not-approved'.

Can I please have some clarification here? I certainly do not want to wait it out through the entire que again (adding 7-8 additional weeks to the timeframe here).

Also if you could explain to me how it's already too late as 7 days did not pass before I responded.

Regards,
Will

Last edited 2 years ago by williampatton (previous) (diff)

This ticket was mentioned in Slack in #themereview by williampatton. View the logs.


2 years ago

#7 @williampatton
2 years ago

Hey @WEN Solutions

Apologies for the previous reply which may have seemed quite frustrated about the 'not-approved' tagging. It was not intended to be directly aimed at you - it was mainly the fact that, due to unfortunate timing of this being assigned, I was potentially facing the prospect of waiting out the queue again.

I jumped into the #themereview channel on slack (linked above) and explained the situation - someone very kindly said that they could take over the review if I needed them too so if you need to move along to the next theme in your review queue and would not have time to circle back to this anytime soon that is fine by me.

I realize that review queues are long and that a hold up on my end could cause a significant slowdown in the overall flow of things so I do understand your need to move on.

Thanks again for your first review though as it did highlight a few things I completely missed.

Regards,
Will

Note: See TracTickets for help on using tickets.