WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#27063 closed theme (live)

THEME: Shophistic Lite – 1.0.4

Reported by: nicoandrade Owned by: Kenshino
Priority: new theme Keywords: theme-shophistic-lite
Cc: nicoandrade@…

Description

Shophistic Lite - 1.0.0

Beautiful theme for WooCommerce

Theme URL - http://www.quemalabs.com/theme/vito/?utm_source=WordPress&utm_medium=wp%20buttons&utm_campaign=Shophistic%20Lite%20Theme%20URI
Author URL - http://www.quemalabs.com/?utm_source=WordPress&utm_medium=wp%20buttons&utm_campaign=Author%20URI

SVN - https://themes.svn.wordpress.org/shophistic-lite/1.0.0
ZIP - https://wordpress.org/themes/download/shophistic-lite.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#27063 THEME: Shophistic Lite – 1.0.4 closed live Kenshino

(this ticket)

#28794 THEME: Shophistic Lite – 1.0.5 closed live karmatosed
#29807 THEME: Shophistic Lite – 1.0.6 closed live Otto42
#30023 THEME: Shophistic Lite – 1.0.7 closed live emiluzelac
#30647 THEME: Shophistic Lite – 1.0.8 closed live jcastaneda
#31447 THEME: Shophistic Lite – 1.0.9 closed live themetracbot
#32244 THEME: Shophistic Lite – 1.0.10 closed live themetracbot
#34733 THEME: Shophistic Lite – 1.0.11 closed live themetracbot
#34862 THEME: Shophistic Lite – 1.0.12 closed live themetracbot
#41969 THEME: Shophistic Lite – 1.0.13 closed live themetracbot
#42040 THEME: Shophistic Lite – 1.0.14 closed live themetracbot
#42274 THEME: Shophistic Lite Butik – 1.0.15 closed not-approved rabmalin
#43408 THEME: Shophistic Lite – 1.0.15 closed live themetracbot
#43984 THEME: Shophistic Lite – 1.0.16 closed live themetracbot
#44319 THEME: Shophistic Lite – 1.0.17 closed live themetracbot


https://themes.svn.wordpress.org/shophistic-lite/1.0.0/screenshot.png

Change History (22)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Shophistic Lite – 1.0.0 to THEME: Shophistic Lite – 1.0.1

Shophistic Lite - 1.0.1

Shophistic Lite is the perfect theme for your shop online. With a beautiful and unique design, is responsive and fully compatible with WooCommerce. The easiest way to create your store online. If you need more features you should check the PRO version, Shophistic: https://www.quemalabs.com/theme/shophistic/

Theme URL - https://www.quemalabs.com/theme/shophistic-lite/
Author URL - https://www.quemalabs.com/

SVN - https://themes.svn.wordpress.org/shophistic-lite/1.0.1
ZIP - https://wordpress.org/themes/download/shophistic-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shophistic-lite/1.0.0&new_path=shophistic-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#27063 THEME: Shophistic Lite – 1.0.4 closed live Kenshino

(this ticket)

#28794 THEME: Shophistic Lite – 1.0.5 closed live karmatosed
#29807 THEME: Shophistic Lite – 1.0.6 closed live Otto42
#30023 THEME: Shophistic Lite – 1.0.7 closed live emiluzelac
#30647 THEME: Shophistic Lite – 1.0.8 closed live jcastaneda
#31447 THEME: Shophistic Lite – 1.0.9 closed live themetracbot
#32244 THEME: Shophistic Lite – 1.0.10 closed live themetracbot
#34733 THEME: Shophistic Lite – 1.0.11 closed live themetracbot
#34862 THEME: Shophistic Lite – 1.0.12 closed live themetracbot
#41969 THEME: Shophistic Lite – 1.0.13 closed live themetracbot
#42040 THEME: Shophistic Lite – 1.0.14 closed live themetracbot
#42274 THEME: Shophistic Lite Butik – 1.0.15 closed not-approved rabmalin
#43408 THEME: Shophistic Lite – 1.0.15 closed live themetracbot
#43984 THEME: Shophistic Lite – 1.0.16 closed live themetracbot
#44319 THEME: Shophistic Lite – 1.0.17 closed live themetracbot


https://themes.svn.wordpress.org/shophistic-lite/1.0.1/screenshot.png

#2 @themetracbot
2 years ago

  • Summary changed from THEME: Shophistic Lite – 1.0.1 to THEME: Shophistic Lite – 1.0.2

Shophistic Lite - 1.0.2

Shophistic Lite is the perfect theme for your shop online. With a beautiful and unique design, is responsive and fully compatible with WooCommerce. The easiest way to create your store online. If you need more features you should check the PRO version, Shophistic: https://www.quemalabs.com/theme/shophistic/

Theme URL - https://www.quemalabs.com/theme/shophistic-lite/
Author URL - https://www.quemalabs.com/

SVN - https://themes.svn.wordpress.org/shophistic-lite/1.0.2
ZIP - https://wordpress.org/themes/download/shophistic-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shophistic-lite/1.0.1&new_path=shophistic-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#27063 THEME: Shophistic Lite – 1.0.4 closed live Kenshino

(this ticket)

#28794 THEME: Shophistic Lite – 1.0.5 closed live karmatosed
#29807 THEME: Shophistic Lite – 1.0.6 closed live Otto42
#30023 THEME: Shophistic Lite – 1.0.7 closed live emiluzelac
#30647 THEME: Shophistic Lite – 1.0.8 closed live jcastaneda
#31447 THEME: Shophistic Lite – 1.0.9 closed live themetracbot
#32244 THEME: Shophistic Lite – 1.0.10 closed live themetracbot
#34733 THEME: Shophistic Lite – 1.0.11 closed live themetracbot
#34862 THEME: Shophistic Lite – 1.0.12 closed live themetracbot
#41969 THEME: Shophistic Lite – 1.0.13 closed live themetracbot
#42040 THEME: Shophistic Lite – 1.0.14 closed live themetracbot
#42274 THEME: Shophistic Lite Butik – 1.0.15 closed not-approved rabmalin
#43408 THEME: Shophistic Lite – 1.0.15 closed live themetracbot
#43984 THEME: Shophistic Lite – 1.0.16 closed live themetracbot
#44319 THEME: Shophistic Lite – 1.0.17 closed live themetracbot


https://themes.svn.wordpress.org/shophistic-lite/1.0.2/screenshot.png

#3 @themetracbot
2 years ago

  • Owner set to khoshino
  • Status changed from new to reviewing

#4 @nicoandrade
2 years ago

Hi @khoshino

Hope you enjoy reviewing my theme.
Let me know if you need anything.

This ticket was mentioned in Slack in #themereview by nicoandrade. View the logs.


2 years ago

#6 @jcastaneda
2 years ago

  • Owner changed from khoshino to Kenshino

#7 @Kenshino
2 years ago

Hello,

Not much change you need to do.

Required

404.php & footer.php

  • You have unnecesary esc_html, it's just a static string, simply _e

content-single-product.php

  • Your meta tag is missing the property attribute

Need your answer on this

Is your pro version licensed under GPL?

Recommended

Waiting for @jcastaneda to chime in

This ticket was mentioned in Slack in #themereview by kenshino. View the logs.


2 years ago

#9 @themetracbot
2 years ago

  • Summary changed from THEME: Shophistic Lite – 1.0.2 to THEME: Shophistic Lite – 1.0.3

Shophistic Lite - 1.0.3

Shophistic Lite is the perfect theme for your shop online. With a beautiful and unique design, is responsive and fully compatible with WooCommerce. The easiest way to create your store online. If you need more features you should check the PRO version, Shophistic: https://www.quemalabs.com/theme/shophistic/

Theme URL - https://www.quemalabs.com/theme/shophistic-lite/
Author URL - https://www.quemalabs.com/

SVN - https://themes.svn.wordpress.org/shophistic-lite/1.0.3
ZIP - https://wordpress.org/themes/download/shophistic-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shophistic-lite/1.0.2&new_path=shophistic-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#27063 THEME: Shophistic Lite – 1.0.4 closed live Kenshino

(this ticket)

#28794 THEME: Shophistic Lite – 1.0.5 closed live karmatosed
#29807 THEME: Shophistic Lite – 1.0.6 closed live Otto42
#30023 THEME: Shophistic Lite – 1.0.7 closed live emiluzelac
#30647 THEME: Shophistic Lite – 1.0.8 closed live jcastaneda
#31447 THEME: Shophistic Lite – 1.0.9 closed live themetracbot
#32244 THEME: Shophistic Lite – 1.0.10 closed live themetracbot
#34733 THEME: Shophistic Lite – 1.0.11 closed live themetracbot
#34862 THEME: Shophistic Lite – 1.0.12 closed live themetracbot
#41969 THEME: Shophistic Lite – 1.0.13 closed live themetracbot
#42040 THEME: Shophistic Lite – 1.0.14 closed live themetracbot
#42274 THEME: Shophistic Lite Butik – 1.0.15 closed not-approved rabmalin
#43408 THEME: Shophistic Lite – 1.0.15 closed live themetracbot
#43984 THEME: Shophistic Lite – 1.0.16 closed live themetracbot
#44319 THEME: Shophistic Lite – 1.0.17 closed live themetracbot


https://themes.svn.wordpress.org/shophistic-lite/1.0.3/screenshot.png

#10 @nicoandrade
2 years ago

Hi @Kenshino

Required

404.php & footer.php
Those are translatable strings, I think they should be escaped following the underscore _s standards here:
https://github.com/Automattic/_s/blob/master/footer.php

Because we should not rely on the translations files.
I did notice that I was adding my own URL as a translatable string, which is unnecessary and I fixed that on this new release.

content-single-product.php
What do you mean exactly? Are you talking about line 85?:

<meta itemprop="url" content="<?php the_permalink(); ?>" />

I think only Open Graph tags use the property attribute. Let me know if that is correct please.

Is your pro version licensed under GPL?
Yes it is. All themes on Quema Labs are 100% GPL.

Yes, I am improving my code gradually.

Thanks! :)

#11 @Kenshino
2 years ago

@nicoandrade

Good answers :)

I agree with your replies.

As for the OG portion, I'd say you're right. I'm just so used to doing it.

I'd recommend you to maybe add property="og:url" - might as well?

Either way, once @jcastaneda confirms on the TGM Plugin Activation, we can move ahead. But though does it really make sense to use that to ask for WooCommerce activation?

#12 @nicoandrade
2 years ago

At first I also think to add property="og:url" but as you can see it includes 'og' and that's why is only for Open Graph tags, and this is not.
It will be incorrect if I add that parameter.

About the TGM Class, I know that is ok to include it on themes.
Here is a note on the TRT Blog letting know authors to update the Class:
https://make.wordpress.org/themes/2015/04/25/theme-authors-update-tgm-plugin-activation/
It is allowed as long only plugins hosted on the WordPress.org plugin repository are recommended.

#13 @nicoandrade
2 years ago

Following on the TGM question.
@jcastaneda already answered here:
https://wordpress.slack.com/archives/themereview/p1414516534000337

Hope that helps.

#14 @Kenshino
2 years ago

  • Status changed from reviewing to approved

@nicoandrade

Thanks for the initiative :)

Sending it up as approved :)

#15 @nicoandrade
2 years ago

Thank you for your time @Kenshino :)

#16 @alex27
2 years ago

  • Status changed from approved to reopened

Hi there!

I'm afraid I'm gonna have to reopen this one. When I open the Customizer, I get the following PHP Notice:
Notice: Undefined index: woocommerce in /wp-content/themes/shophistic-lite/framework/functions/woocommerce_support.php on line 339

#17 @themetracbot
2 years ago

  • Summary changed from THEME: Shophistic Lite – 1.0.3 to THEME: Shophistic Lite – 1.0.4

Shophistic Lite - 1.0.4

Shophistic Lite is the perfect theme for your shop online. With a beautiful and unique design, is responsive and fully compatible with WooCommerce. The easiest way to create your store online. If you need more features you should check the PRO version, Shophistic: https://www.quemalabs.com/theme/shophistic/

Theme URL - https://www.quemalabs.com/theme/shophistic-lite/
Author URL - https://www.quemalabs.com/

SVN - https://themes.svn.wordpress.org/shophistic-lite/1.0.4
ZIP - https://wordpress.org/themes/download/shophistic-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shophistic-lite/1.0.3&new_path=shophistic-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#27063 THEME: Shophistic Lite – 1.0.4 closed live Kenshino

(this ticket)

#28794 THEME: Shophistic Lite – 1.0.5 closed live karmatosed
#29807 THEME: Shophistic Lite – 1.0.6 closed live Otto42
#30023 THEME: Shophistic Lite – 1.0.7 closed live emiluzelac
#30647 THEME: Shophistic Lite – 1.0.8 closed live jcastaneda
#31447 THEME: Shophistic Lite – 1.0.9 closed live themetracbot
#32244 THEME: Shophistic Lite – 1.0.10 closed live themetracbot
#34733 THEME: Shophistic Lite – 1.0.11 closed live themetracbot
#34862 THEME: Shophistic Lite – 1.0.12 closed live themetracbot
#41969 THEME: Shophistic Lite – 1.0.13 closed live themetracbot
#42040 THEME: Shophistic Lite – 1.0.14 closed live themetracbot
#42274 THEME: Shophistic Lite Butik – 1.0.15 closed not-approved rabmalin
#43408 THEME: Shophistic Lite – 1.0.15 closed live themetracbot
#43984 THEME: Shophistic Lite – 1.0.16 closed live themetracbot
#44319 THEME: Shophistic Lite – 1.0.17 closed live themetracbot


https://themes.svn.wordpress.org/shophistic-lite/1.0.4/screenshot.png

#18 @nicoandrade
2 years ago

Hi @alex27

Thanks for that, it was fixed.

This ticket was mentioned in Slack in #themereview by nicoandrade. View the logs.


2 years ago

#20 @Kenshino
2 years ago

  • Status changed from reopened to approved

Hello.

Checked. No more Notice in Customiser when WooCommerce is not activated.

Sending it back up.

#21 @karmatosed
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

This ticket was mentioned in Slack in #themereview by kenshino. View the logs.


21 months ago

Note: See TracTickets for help on using tickets.