WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 22 months ago

#27222 closed theme (not-approved)

THEME: Sassify – 1.0.0

Reported by: nadzhq Owned by: ambrosey
Priority: new theme Keywords: theme-sassify
Cc: nadzhq@…

Description

Change History (5)

#1 @karmatosed
2 years ago

This is just a note, the screenshot should be as close to what happens when you default load the theme. A mocked up image or single image will prevent the theme from being passed for review. Please resolve this before the review can be completed.

#2 @karmatosed
23 months ago

  • Owner set to ambrosey
  • Status changed from new to reviewing

#3 @ambrosey
23 months ago

Hi @nadzhq ,

Unfortunately, we can't approve your theme in its current state. However, these all look like very workable changes to implement here. If you're interested in the procedure we used to get these results, please visit:

https://make.wordpress.org/themes/handbook/review/required/

Required

The obvious biggest problem is the menu. There are no dropdown for subpages, and there is a random “Primary Menu” button that does nothing. On smaller screen widths, there is no menu. If you want to allow only top level menus that needs to be specifically documented in the readme

You need to actually write your Readme file - it is just underscores

The 404 page is present and meets the minimum concept, but it looks like you didn’t format it.

You need to remove your Gruntfile.js and SASS files. These may be useful for development, but shouldn’t be a needed part of your theme.

The header image in customizer does not seem to work. If you don’t want this in your theme, you need to remove it from the customizer - everything in the customizer must “work”.

Use *_url() template tags, rather than bloginfo() equivalents. I suggest you do a multifile search for bloginfo( to replace each occurrence with the appropriate replacement.

This theme needs a screenshot as provided in previous comment.

Style.css

  • Theme URI should point to something about your theme, or be removed. It is an optional field
  • Description needs to be edited

Strongly Recommended

  • The header text (headline, tagline) seem to get very very small on pages. They seem to get down to 9px in size. It appears to be unintentional, and jumps around.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @ambrosey
22 months ago

Just a reminder, to communicate your intent in this thread if you plan on working on this theme. It has been 6 days. If there is no response after 7 days, this ticket will be closed.

#5 @ambrosey
22 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.