WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 18 months ago

#27563 closed theme (not-approved)

THEME: MarketingBlog Lite – 1.5.7

Reported by: techjewel Owned by: DenUsenko
Priority: new theme Keywords: theme-marketingblog-lite
Cc: cep.jewel@…

Description

MarketingBlog Lite - 1.0

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.0
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.0/screenshot.png

Change History (79)

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


2 years ago

#2 @Otto42
2 years ago

Quick look at this, that's not a very good way to load a json file like that. Using wp_remote_get for this is a bit on the silly side for a local file.

While we do block file_get_contents, a better approach is simply to not have to parse the JSON at all. Put it in a PHP file as a native array instead. Then simply include that file.

#3 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.0 to THEME: MarketingBlog Lite – 1.0.1

MarketingBlog Lite - 1.0.1

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.0.1
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.0&new_path=marketingblog-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.0.1/screenshot.png

#4 @techjewel
2 years ago

@Otto42
I have updated the new version.
Thanks for your suggestion

#5 @karmatosed
2 years ago

This is just a note, the screenshot should be as close to what happens when you default load the theme. A mocked up image or single image will prevent the theme from being passed for review. Please resolve this before the review can be completed.

#6 @techjewel
2 years ago

Thanks @Karmatosed
I am also a theme reviewer but new.
I just wondering that many themes have mocked up images and those are approved. So I would like to know more about it.

Example: https://wordpress.org/themes/rational-start/ This theme have totally different mocked up image.

#7 @karmatosed
2 years ago

The fact you've found another site doing something that shouldn't be done, doesn't mean you can do it. If that theme came through for an update and I saw it, I would be flagging it also.

Please change your image.

#8 @techjewel
2 years ago

Thanks @karmatosed
Actually I asked because I also review theme so for the next time I will check that too.

:)

#9 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.0.1 to THEME: MarketingBlog Lite – 1.1

MarketingBlog Lite - 1.1

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.1
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.0.1&new_path=marketingblog-lite/1.1

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.1/screenshot.png

#10 @techjewel
2 years ago

It's around 2 months. Anyone please review the theme.
Thanks

#11 @themetracbot
2 years ago

  • Owner set to carlou5
  • Status changed from new to reviewing

#12 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.1 to THEME: MarketingBlog Lite – 1.2

MarketingBlog Lite - 1.2

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.2
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.1&new_path=marketingblog-lite/1.2

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.2/screenshot.png

#13 @techjewel
2 years ago

Hello @carlou5
Would you please review the theme. It's around 3 months and The theme is not reviewed yet.
I highly appreciate your quick time to review the theme.

Thanks in advance.

#14 @carlou5
2 years ago

  • Status changed from reviewing to approved

I don't know how I ended up being the reviewer for this theme but I'm not qualified to do this. It seems that I joined this 3 days ago somehow. How can I exit this reviewing process? I'm sorry for the incovenience.

Last edited 2 years ago by carlou5 (previous) (diff)

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


2 years ago

#16 @grapplerulrich
2 years ago

  • Status changed from approved to reopened

@carlou5 you clicked a button to review a theme and that is why you were assigned it. I will take you off and let someone else review it.

#17 @grapplerulrich
2 years ago

  • Owner carlou5 deleted
  • Status changed from reopened to reviewing

#18 @themetracbot
2 years ago

  • Owner set to weblizar

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


2 years ago

#20 @Otto42
2 years ago

  • Owner weblizar deleted

@weblizar If you're not going to actually review themes, then don't pick themes to review.

#21 @themetracbot
2 years ago

  • Owner set to manandharsudin

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


2 years ago

#23 @manandharsudin
2 years ago

Hi,

Here is the list of initial review. Please fix these issue and re-upload for further review.

Style.css
REQUIRED: Text domain should be marketingblog-lite.

Language
REQUIRED: Text domain should be marketingblog-lite.
REQUIRED: All strings are not translatable. Please fix it. You can check it with Pig Latin plugin https://wordpress.org/plugins/piglatin/
REQUIRED: Please recreate .pot file. File name should be same as Text Domain in style.css.

Code
REQUIRED: Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. http://themereview.co/prefix-all-the-things/
REQUIRED: Validate and sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: Data Validation. https://codex.wordpress.org/Data_Validation )
RECOMMENDED: Please check this link for best practice in sanitizing customizer fields. https://github.com/WPTRT/code-examples/blob/master/customizer/sanitization-callbacks.php

#24 @manandharsudin
2 years ago

Hi @techjewel,

Please let me know if you are going to upload an update within 24 hours or I will need to close the ticket due to inactivity.

Thanks

#25 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.2 to THEME: MarketingBlog Lite – 1.3

MarketingBlog Lite - 1.3

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.3
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.2&new_path=marketingblog-lite/1.3

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.3/screenshot.png

#26 @techjewel
2 years ago

Hello @manandharsudin
I have updated the theme. Please check

Thanks

#27 @manandharsudin
2 years ago

Hi @techjewel

REQUIRED: Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. http://themereview.co/prefix-all-the-things/
For eg. Your Function name should be "marketingblog_lite_setup" not "marketingblog_setup". So please check all the function, classes, image size name, script and style handles.

REQUIRED: Validate and sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: Data Validation. https://codex.wordpress.org/Data_Validation )
For eg. line no. 41 missing escaping and translation in header.php. Mising escaping of url in line no 18 of 404.php. Please check for other files as well.

REQUIRED: All strings are not translatable. Please fix it. You can check it with Pig Latin plugin https://wordpress.org/plugins/piglatin/
For eg. Line no. 30 of content-big_image_format.php
REQUIRED: Please recreate .pot file. File name should be same as Text Domain in style.css. There no pot file in language folder.

Please fix these issues and I'll do further detail review.

Thanks

#28 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.3 to THEME: MarketingBlog Lite – 1.4

MarketingBlog Lite - 1.4

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.4
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.3&new_path=marketingblog-lite/1.4

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.4/screenshot.png

#29 @techjewel
2 years ago

Hello @manandharsudin , I have updated the theme. Please check.
Thanks

#30 @techjewel
2 years ago

@manandharsudin
Any update?

#31 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.4 to THEME: MarketingBlog Lite – 1.4.1

MarketingBlog Lite - 1.4.1

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.4.1
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.4.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.4&new_path=marketingblog-lite/1.4.1

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.4.1/screenshot.png

#32 @themetracbot
2 years ago

  • Summary changed from THEME: MarketingBlog Lite – 1.4.1 to THEME: MarketingBlog Lite – 1.4.2

MarketingBlog Lite - 1.4.2

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.4.2
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.4.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.4.1&new_path=marketingblog-lite/1.4.2

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.4.2/screenshot.png

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


23 months ago

#34 @grapplerulrich
23 months ago

  • Owner manandharsudin deleted

Removing the reviewer due to no response.

#35 @themetracbot
23 months ago

  • Owner set to papacoderrs

This ticket was mentioned in Slack in #themereview by papacoderrs. View the logs.


23 months ago

#37 @jcastaneda
23 months ago

  • Owner papacoderrs deleted

#38 @jcastaneda
23 months ago

  • Owner set to DenUsenko

#39 @DenUsenko
23 months ago

Hello, @techjewel!
Sorry for the delay, I will post my review in a few hours.

#40 @techjewel
23 months ago

Thanks @DenUsenko
I really appreciate it.

#41 @DenUsenko
23 months ago

OUTCOME

Your theme still has some issues. Please, fix required items I've listed below and re-upload the new version.

REQUIRED

  • Provide a unique prefix for everything the Theme defines

http://themereview.co/prefix-all-the-things/
Image size names:

  add_image_size( 'marketingblog-featured', 770);
  add_image_size( 'tab-small', 60, 60 , true); // Small Thumbnail
  add_image_size( 'marketingblog-blog-featured', 500);
  • Able to have child themes made from them. (Child theme ready)

Functions should be easily overwritten by a child theme:

if ( ! function_exists( 'marketingblog_lite_example' ) ) :
function marketingblog_lite_example() {
//Some code here
}
endif;
  • The theme tags and description must match the what the theme actually does in respect to functionality and design.

-- Post Formats are not implemented. Please remove theme tag and add_theme_support( 'post-formats'.... in functions.php
-- Responsive Layout - main navigation menu on small screen doesn't show second level items. Please fix it.
-- Red, Green - I think this two colors are used only for small controls. The color must be a main part in the design. Remove them from theme tags.

  • Declare licenses of any resources included such as fonts or images.

Add glyphicons license info to readme.txt

  • All theme text strings are to be translatable.

404.php, alt "Go back Home" needs translation:

<img alt="Go Back Home" src="<?php echo esc_url(get_template_directory_uri()); ?>/inc/img/404.jpg" />
  • Validate and sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.

Check inputs and escape everything. You're doing it right 95% , but there are 5% to fix. Please double check.
https://vip.wordpress.com/2014/06/20/the-importance-of-escaping-all-the-things/

Example: I can put this

<script>alert("Hacked!")</script>

in a Title field for marketingblog Categories widget. This script executes successfully on the front-end, when user opens a page.

  • No minification of scripts or files unless provide original files.

check /inc/js folder

  • It's better to log your changes in changelog.txt file. You also might want to update theme version in readme.txt

NOTES

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.
Re-upload your theme here https://wordpress.org/themes/upload/
The theme must have the same name. You need to change the Version tag in style.css.

#42 @techjewel
23 months ago

Hello @DenUsenko ,
Thanks for your nice review. I am going to fix the issues and I will upload the new version in few days.

#43 @techjewel
22 months ago

I will upload the new version later today. Sorry for the late

#44 @DenUsenko
22 months ago

Hello, @techjewel !
Any updates ?

#45 @techjewel
22 months ago

I am going to upload the new version in few hours. Sorry for the late again

#46 @themetracbot
22 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.4.2 to THEME: MarketingBlog Lite – 1.5.0

MarketingBlog Lite - 1.5.0

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.0
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.4.2&new_path=marketingblog-lite/1.5.0

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.0/screenshot.png

#47 @themetracbot
22 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.0 to THEME: MarketingBlog Lite – 1.5.1

MarketingBlog Lite - 1.5.1

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.1
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.0&new_path=marketingblog-lite/1.5.1

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.1/screenshot.png

#48 @techjewel
22 months ago

Hello @DenUsenko
Did you get a minute to take a look?
Thanks

#49 @DenUsenko
22 months ago

Hello, @techjewel !
I'll do my best to post updated review today.
Best regards

#50 @DenUsenko
22 months ago

Hello, @techjewel !
In your update 1.5.1 "inc" , "languages" folders are missing, so your theme crushes at activation stage.
I've used folders from 1.5.0 and found issues mentioned earlier.
To be sure, please upload 1.5.2 with inc and languages folders in your theme folder.

#51 @themetracbot
22 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.1 to THEME: MarketingBlog Lite – 1.5.2

MarketingBlog Lite - 1.5.2

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.2
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.1&new_path=marketingblog-lite/1.5.2

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.2/screenshot.png

#52 @techjewel
22 months ago

Sorry about this silly mistake.
I have reuploaded the version 1.5.2

Thanks

#53 @DenUsenko
21 months ago

Hello, @techjewel !

NOT FIXED

1) All untrusted data should be escaped before output.

Example, /inc/widgets/widget-categories.php, line 27

echo $title;

We can't trust data from your custom widget. It should be escaped with esc_html function.
Otherwise JS can be executed on the front-end.

Please, check other custom widgets.

2) Please, check https://glyphicons.com/license/ If it's the font you're using in /inc/fonts you're actually can't use it:
"You must not include icons in open-source projects, since this license is not compatible with most of the open-source licenses"

#54 @themetracbot
21 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.2 to THEME: MarketingBlog Lite – 1.5.3

MarketingBlog Lite - 1.5.3

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.3
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.2&new_path=marketingblog-lite/1.5.3

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.3/screenshot.png

#55 @techjewel
21 months ago

Hello,
I have fixed the point 1. But the problem with point two is that the font files are embedded with twitter bootstrap framework. And I think all other theme developers using it for example: ( https://wordpress.org/themes/bootstrap-canvas-wp/ )

Here is discussion in github: https://github.com/twbs/bootstrap/issues/3942

Please let me know if there has any more issues.

Thanks

#56 @DenUsenko
21 months ago

Hello, @techjewel !
Doing final checks, will post the results soon

#57 @DenUsenko
21 months ago

Hello, @techjewel !

NOT FIXED

  1. All untrusted data should be escaped before output. /inc/widgets/widget-popular-posts.php, line 22
  echo $title;

After this fix I will approve this theme for admin review.

#58 @themetracbot
21 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.3 to THEME: MarketingBlog Lite – 1.5.4

MarketingBlog Lite - 1.5.4

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://themewagon.com/MarketingBlog
Author URL - https://themewagon.com/

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.4
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.3&new_path=marketingblog-lite/1.5.4

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.4/screenshot.png

#59 @techjewel
21 months ago

Hello @DenUsenko
I have added the filter as you have asked. Hope The theme will be approved soon.
Thanks

#60 @DenUsenko
21 months ago

  • Status changed from reviewing to approved

#61 @techjewel
21 months ago

Any idea when the theme will be published?

This ticket was mentioned in Slack in #themereview by techjewel. View the logs.


21 months ago

#64 @kevinhaig
19 months ago

I will take this final.

#65 @kevinhaig
19 months ago

  • Status changed from approved to reopened

Theme Name & Version
MarketingBlog Lite 1.5.4
======================
Hi, I am @kevinhaig and I have done the final review of your theme.

The review process follows procedures found in the Theme Handbook->https://make.wordpress.org/themes/handbook/review/. If you do not understand a requirement or anything else in the review, or if you do not agree with anything, please comment in the ticket. I can then help you, or if I am not sure of something I will certainly seek a second opinion from an admin.
The second review is done to double check that all requirements have been met.

Outcome

  • Theme left as reviewing for 7 days, and it may be closed after that if there is no response. Note that if you need more time, please make a comment in the ticket.
  • Sorry but I have had to reopen your theme because certain requirements have not been met.

Required

Code

Core Functionality and Features

  • Use WordPress functionality and features first, if available.
    • must use add_theme_support('custom-background'), if using optional backgrounds
      • You have added support for custom backgrounds but have removed the options from customizer.
  • The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design. (See: Theme Tag List)
    • Please remove post-formats tag as you do not support them.

Language

  • Please change your text domain from marketingblog_lite to marketingblog-lite. The language pack API does not like underscores in the text domain. Make sure you also change it in style.css as well.
  • All theme text strings are to be translatable.
    • There are untranslated strings in customizer.php, for exmple descriptions in options and select and radio option displayed text.
    • You have not translated line 41 in header.php correctly, two underscores are needed.

Licensing

  • Declare licenses of any resources included such as fonts or images, including screenshot images
    • For resources please include: declaration (ex Copyright 2015, by John Smith), resource download link, license type, and license download
    • Below is an example of a resource declaration specifying resource name, resource download link, copyright declaration, license type, license link:
      jQuery Nivo Slider v3.2, http://nivo.dev7studios.com
      Copyright 2012, Dev7studios, MIT License, http://www.opensource.org/licenses/mit-license.php
      
      • Font Awesome has a SIL license for the font and a MIT license for the css, please declare both.
      • Please declare modernizer.js
    • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      
      • Please declare 404.jpg and the 2 images in your screenshot.
  • ref: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/
  • ref: https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses

Options and Settings

  • Save options in a single array.
    • your custom css is being saved separate from the other options
    • Why are you using options instead of theme_mod for option type? By doing this you will not be able to keep a separate set of options for the child theme.
  • If you are a themeshop you should be selling under GPL to be in the WordPress.org repo.
    • When I check your author site I go to a theme shop which lists under Terms and Conditions that all themes must be CC3.0 this is not compatible with GPL. When I check your License terms I see that licensing terms are very difficult to understand. For example Free Templates are CC 4.0 which is not compatible with GPL. For licensed products, please explain the term to the extent the GPL applies in the following statement If the item was created using materials which are the subject of a GNU General Public License (GPL), your use of the item is subject to the terms of the GPL in place of the foregoing conditions (to the extent the GPL applies).
    • Please note that all WordPress themes on that site need to be sold under GPL. GPL means free to use on unlimited sites, free to modify, and free to redistribute without any restrictions such as attribution or price. Your wording in your licence and terms needs to be very explicit in this regard, and not lead the user to interpret restrictions of any kind.
    • ref: https://developer.wordpress.org/themes/getting-started/wordpress-licensing-the-gpl/

Stylesheets and Scripts

  • No hard coding of scripts and styles unless a browser workaround script. Everything should be enqueued.
    • IE Workarounds are no longer need to be hardcoded, check out the twentysixteen theme functions.php for a example of doing this in a setup function. For example :
      // Load the html5 shiv.
      wp_enqueue_script( 'twentysixteen-html5', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' );
      wp_script_add_data( 'twentysixteen-html5', 'conditional', 'lt IE 9' );
      
  • No minification of scripts or files unless provide original files.
    • please provide an unminified version of font-awesome.min.css in the ame folder as the minified one.

#66 @kevinhaig
19 months ago

@grapplerulrich please assign back to @DenUsenko

DenUsenko, can you please continue the review? Please let me know when it is approved and I will run a final check before setting it live.

#67 @grapplerulrich
19 months ago

  • Status changed from reopened to reviewing

#68 @DenUsenko
19 months ago

@kevinhaig Roger that!

#69 @techjewel
19 months ago

Thanks Guys,
I am going to upload a new version tomorrow.

#70 @grapplerulrich
19 months ago

@techjewel - It has been 8 days...

#71 @techjewel
19 months ago

please give me one more day.

#72 @DenUsenko
19 months ago

@techjewel any news ?

#73 @themetracbot
18 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.4 to THEME: MarketingBlog Lite – 1.5.5

MarketingBlog Lite - 1.5.5

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://github.com/techjewel/marketingblog-lite
Author URL - https://authlab.io

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.5
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.4&new_path=marketingblog-lite/1.5.5

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.5/screenshot.png

#74 @themetracbot
18 months ago

  • Summary changed from THEME: MarketingBlog Lite – 1.5.5 to THEME: MarketingBlog Lite – 1.5.7

MarketingBlog Lite - 1.5.7

MarketingBlog Lite is a clean minimal and responsive WordPress theme well suited for marketing, travel, health, business, finance, portfolio, design, art, photography, personal and any other creative websites and Blogs. Developed using Bootstrap 3 that makes it mobile and tablets friendly. Theme comes with 2 different layout, social icon integration, author bio, popular posts widget and improved category widget, 100 google fonts, unlimited color variation, fully customizer compatible. marketingblog incorporates latest web standards such as HTML5 and CSS3 and is SEO friendly thanks to its clean structure and codebase. It has dozens of Theme Options to change theme layout, colors, fonts, typography and much more. Theme is also translation and multilingual ready, compatible with WPML. marketingblog is a free WordPress theme with tons of premium functionality and design. This theme is optimized to work with bbPress, Contact Form 7, Jetpack and other popular free and premium plugins.

Theme URL - https://github.com/techjewel/marketingblog-lite
Author URL - https://authlab.io

SVN - https://themes.svn.wordpress.org/marketingblog-lite/1.5.7
ZIP - https://wordpress.org/themes/download/marketingblog-lite.1.5.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marketingblog-lite/1.5.5&new_path=marketingblog-lite/1.5.7

History:

Ticket Summary Status Resolution Owner
#27563 THEME: MarketingBlog Lite – 1.5.7 closed not-approved DenUsenko

(this ticket)


https://themes.svn.wordpress.org/marketingblog-lite/1.5.7/screenshot.png

#75 @kevinhaig
18 months ago

@DenUsenko are you going to continue the review?

#76 @DenUsenko
18 months ago

@kevinhaig @techjewel Doing the review, will post soon

#77 @DenUsenko
18 months ago

Hello, @techjewel !

OUTCOME

Your theme still has some issues. Please, fix required items I've listed below and re-upload the new version.

REQUIRED

Code

  • Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: Data Validation)

Kevin has pointed out them above, but they are not fixed yet

Core Functionality and Features

  • Please remove add_theme_support('custom-background') as you're not using it in customizer

Language

  • Please change your text domain from marketingblog_lite to marketingblog-lite in style.css
  • There are untranslated strings in customizer.php

line 49

        'choices'    => array(
            'small_thumb'   => 'Small Thumb',
            'big_thumb'     => 'Big Featured Image'

line 69

        'choices'    => array(
            'right'   => 'Right Side',
            'left'     => 'Left Side'

line 198

        'description' => 'This will show at the footer (left) of the site',

Licensing

  • Declare licenses of any resources included such as fonts or images, including screenshot images

1) for Font Awesome ( SIL and MIT), modernizer.js
2) you most likely have rights to use images for 404 page and images on screenshot.png but they are not GPL as you mention in readme.txt "Unless otherwise specified, all the theme files, scripts and images are licensed under GPLv2". Please make sure they are free to use and declare licenses with link to prove that in your readme file.

Options and Settings

  • Save options in a single array

Your custom css is being saved separate from the other options. See customizer.php, line 215

Stylesheets and Scripts

  • Remove condition comment header.php, line 11:
<html class="no-js" <?php language_attributes(); ?>> <!--<![endif]-->
  • Please use the same fontawesome version for minified and regular fontawesome stylesheets:
font-awesome.css - version 4.6.3
font-awesome.min.css - version 4.3.0

NOTES

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.
Re-upload your theme here https://wordpress.org/themes/upload/
The theme must have the same name. You need to change the Version tag in style.css.

#78 @grapplerulrich
18 months ago

@techjewel Please can you upload an update or the ticket will be closed.

#79 @grapplerulrich
18 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing the ticket due to no response from the theme author.

Note: See TracTickets for help on using tickets.