WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2760 closed theme (not-approved)

THEME: SWIFT - 5.56

Reported by: gandham Owned by: Fingli
Priority: Keywords: theme-swift,
Cc: satish_g2009@…

Description

SWIFT - 5.56

SWIFT, as the name says, is the fastest loading, SEO optimized, AdSense ready, server friendly WordPress theme. It features Magazine layout,two different header styles, tabbed interface, two different featured post sliders, 6 custom widgets. Bundled with lot of options to build your own unique, professional and browser-safe WordPress Theme.WordPress 3.0 ready with three menu locations and custom post types.SWIFT is the perfect choice for those who need a powerful and customizable theme. You can easily move your options from development server to live server with the built in import/export options function, a feature unique to SWIFT.Valid CSS3 & HTML.SWIFT has a active user community to help you with support queries.

Theme URL - http://swiftthemes.com/
Author URL - http://TechBU.com

SVN - http://themes.svn.wordpress.org/swift/5.56
ZIP - http://wordpress.org/extend/themes/download/swift.5.56.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/swift/5.55&new_path=/swift/5.56

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-swift&order=priority

https://themes.svn.wordpress.org/swift/5.56/screenshot.png

Attachments (1)

cap.jpg (31.9 KB) - added by Fingli 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Fingli3 years ago

  • Owner set to Fingli
  • Status changed from new to assigned

Fingli3 years ago

comment:2 Fingli3 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

=> Presence of 'include (TEMPLATEPATH . "/searchform.php");' in includes/archive-listing.php [Use get_search_form() instead]
=> Embedded video goes beyond the content area.

  • In functions.php line 26 $content_width = 960; should be the width of the content area but not the width of the site-template. In this particular case it should be 580px
    • Example:
if ( ! isset( $content_width ) ) $content_width = 580;

=> Presence of two credit links in footer. [Only one credit link is allowed]
=> Images with captons are not styled well

---

This is a tertiary review. Next reviewer might find more so please do everything you can to adhere to the documentation on what is accepted in the theme review.

  • Developer needs to thoroughly read the Theme Review and find all the must-haves and update their theme(s) accordingly, this theme will continue to not pass until all requirements are met.
  • It's useful if the authors check their themes with Theme-Check plugin and with set WP_DEBUG to 'true' in wp-config.php

Items marked with => are reasons for not being approved
Items marked with / are just suggestions
Items marked with - are notes

Once the points above have been addressed appropriately using the available information found at the links above; please thoroughly review your theme and re-submit it using the uploader tool: http://wordpress.org/extend/themes/upload/ this will generate a new Trac ticket.


Responding To This Review

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net (or via http://webchat.freenode.net/)

comment:3 follow-up: gandham3 years ago

Some pages have content width 960px. When i asked about this on the mailing list, they suggested I use the maximum possible width.

Fixed the other problems, new version here

http://themes.trac.wordpress.org/ticket/2979

comment:4 in reply to: ↑ 3 Fingli3 years ago

Would you please provide me the info about the emails with this suggestion? I'm a subscriber so I can easily find them.
Also, I can't find where you use width 960, please explain clearer.

Replying to gandham:

Some pages have content width 960px. When i asked about this on the mailing list, they suggested I use the maximum possible width.

Fixed the other problems, new version here

http://themes.trac.wordpress.org/ticket/2979

comment:5 follow-up: gandham3 years ago

Screenshot of the mail
http://d.pr/TGbd

Full width page template uses 960px

comment:6 in reply to: ↑ 5 Fingli3 years ago

Otto said it good enough width that make sense for the theme, your default layout had content area 580px so the content_width should be 580. You may have many many different options in your theme but the default design have to be clean of any issues. All other is up to user to decide what he/she will use.
Or if you like make 960px template default for your theme.

Replying to gandham:

Screenshot of the mail
http://d.pr/TGbd

Full width page template uses 960px

comment:7 gandham3 years ago

I really don't get what you guys have against my theme, you people just want to find an excuse to reject my theme. While other themes get away with warning messages generated by the theme check plugin.

Anyway i changed the content width.

FYI: My theme automatically resizes images that over flow the content area, I haven't seen a theme that does this.

http://themes.trac.wordpress.org/ticket/2982

http://wordpress.org/support/topic/to-theme-review-team-why-the-bias

Note: See TracTickets for help on using tickets.