WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 22 months ago

#27603 closed theme (live)

THEME: Amethyst – 1.0.4

Reported by: featherplain Owned by: poena
Priority: new theme Keywords: theme-amethyst
Cc: info@…

Description

Amethyst - 1.0.0

Amethyst is a simple theme based on Foundation. The design is kept simple to keep the simplicity of the Foundation. Features are, 100% responsive layouts, Genericons, Gulp use, Sass.

Theme URL - http://amethyst.asknode.net/
Author URL - http://asknode.net/

SVN - https://themes.svn.wordpress.org/amethyst/1.0.0
ZIP - https://wordpress.org/themes/download/amethyst.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#27603 THEME: Amethyst – 1.0.4 closed live poena

(this ticket)

#29820 THEME: Amethyst – 1.1.0 closed live Otto42
#31926 THEME: Amethyst – 2.0.0 closed live themetracbot
#31931 THEME: Amethyst – 2.0.1 closed live themetracbot
#32611 THEME: Amethyst – 2.0.2 closed live themetracbot
#34155 THEME: Amethyst – 2.0.3 closed live themetracbot


https://themes.svn.wordpress.org/amethyst/1.0.0/screenshot.png

Change History (8)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Amethyst – 1.0.0 to THEME: Amethyst – 1.0.1

Amethyst - 1.0.1

Amethyst is a simple theme based on Foundation. The design is kept simple to keep the simplicity of the Foundation. Features are, 100% responsive layouts, Genericons, Gulp use, Sass.

Theme URL - http://amethyst.asknode.net/
Author URL - http://asknode.net/

SVN - https://themes.svn.wordpress.org/amethyst/1.0.1
ZIP - https://wordpress.org/themes/download/amethyst.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=amethyst/1.0.0&new_path=amethyst/1.0.1

History:

Ticket Summary Status Resolution Owner
#27603 THEME: Amethyst – 1.0.4 closed live poena

(this ticket)

#29820 THEME: Amethyst – 1.1.0 closed live Otto42
#31926 THEME: Amethyst – 2.0.0 closed live themetracbot
#31931 THEME: Amethyst – 2.0.1 closed live themetracbot
#32611 THEME: Amethyst – 2.0.2 closed live themetracbot
#34155 THEME: Amethyst – 2.0.3 closed live themetracbot


https://themes.svn.wordpress.org/amethyst/1.0.1/screenshot.png

#2 @themetracbot
2 years ago

  • Summary changed from THEME: Amethyst – 1.0.1 to THEME: Amethyst – 1.0.2

Amethyst - 1.0.2

Amethyst is a simple theme based on Foundation. The design is kept simple to keep the simplicity of the Foundation. Features are, 100% responsive layouts, Genericons, Gulp use, Sass.

Theme URL - http://amethyst.asknode.net/
Author URL - http://asknode.net/

SVN - https://themes.svn.wordpress.org/amethyst/1.0.2
ZIP - https://wordpress.org/themes/download/amethyst.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=amethyst/1.0.1&new_path=amethyst/1.0.2

History:

Ticket Summary Status Resolution Owner
#27603 THEME: Amethyst – 1.0.4 closed live poena

(this ticket)

#29820 THEME: Amethyst – 1.1.0 closed live Otto42
#31926 THEME: Amethyst – 2.0.0 closed live themetracbot
#31931 THEME: Amethyst – 2.0.1 closed live themetracbot
#32611 THEME: Amethyst – 2.0.2 closed live themetracbot
#34155 THEME: Amethyst – 2.0.3 closed live themetracbot


https://themes.svn.wordpress.org/amethyst/1.0.2/screenshot.png

#3 @themetracbot
2 years ago

  • Summary changed from THEME: Amethyst – 1.0.2 to THEME: Amethyst – 1.0.3

Amethyst - 1.0.3

Amethyst is a simple theme based on Foundation. The design is kept simple to keep the simplicity of the Foundation. Features are, 100% responsive layouts, Genericons, Gulp use, Sass.

Theme URL - http://amethyst.asknode.net/
Author URL - http://asknode.net/

SVN - https://themes.svn.wordpress.org/amethyst/1.0.3
ZIP - https://wordpress.org/themes/download/amethyst.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=amethyst/1.0.2&new_path=amethyst/1.0.3

History:

Ticket Summary Status Resolution Owner
#27603 THEME: Amethyst – 1.0.4 closed live poena

(this ticket)

#29820 THEME: Amethyst – 1.1.0 closed live Otto42
#31926 THEME: Amethyst – 2.0.0 closed live themetracbot
#31931 THEME: Amethyst – 2.0.1 closed live themetracbot
#32611 THEME: Amethyst – 2.0.2 closed live themetracbot
#34155 THEME: Amethyst – 2.0.3 closed live themetracbot


https://themes.svn.wordpress.org/amethyst/1.0.3/screenshot.png

#4 @poena
22 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#5 follow-up: @poena
22 months ago

Hi!
I have completed my review and I found some minor issues that needs to be fixed.
Your theme has been tested against these guidelines: https://make.wordpress.org/themes/handbook/review/required/
Please submit an update or reply within 7 days or your ticket will be closed as not approved.

Required:
Missing copyright for the theme itself, example: Copyright featherplain 2015.

No minification of scripts or files unless you provide original files.
I can't find the original files for lib.min.js, foundation.min.js.
If there are files that are not used by the theme, please remove them.

The sidebar descriptions needs to be made translatable.
Translated text in "placeholder" needs to be escaped. (amethyst_search_form() functions.php)

Please prefix the thumbnail image sizes.

#6 @themetracbot
22 months ago

  • Summary changed from THEME: Amethyst – 1.0.3 to THEME: Amethyst – 1.0.4

Amethyst - 1.0.4

Amethyst is a simple theme based on Foundation. The design is kept simple to keep the simplicity of the Foundation. Features are, 100% responsive layouts, Genericons, Gulp use, Sass.

Theme URL - http://amethyst.asknode.net/
Author URL - http://asknode.net/

SVN - https://themes.svn.wordpress.org/amethyst/1.0.4
ZIP - https://wordpress.org/themes/download/amethyst.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=amethyst/1.0.3&new_path=amethyst/1.0.4

History:

Ticket Summary Status Resolution Owner
#27603 THEME: Amethyst – 1.0.4 closed live poena

(this ticket)

#29820 THEME: Amethyst – 1.1.0 closed live Otto42
#31926 THEME: Amethyst – 2.0.0 closed live themetracbot
#31931 THEME: Amethyst – 2.0.1 closed live themetracbot
#32611 THEME: Amethyst – 2.0.2 closed live themetracbot
#34155 THEME: Amethyst – 2.0.3 closed live themetracbot


https://themes.svn.wordpress.org/amethyst/1.0.4/screenshot.png

#7 in reply to: ↑ 5 @featherplain
22 months ago

Replying to poena:

Hi poena, Thank you for reviewing! I fixed some issues you found.
Updated 1.0.3 -> 1.0.4.

## 1

Required:
Missing copyright for the theme itself, example: Copyright featherplain 2015.

Declared copyright and add license information in readme.txt. please check.


## 2

No minification of scripts or files unless you provide original files.
I can't find the original files for lib.min.js, foundation.min.js.

Deleted unnecessary files and changed directory structure. please check src/js and assets/js.


## 3

The sidebar descriptions needs to be made translatable.

Fix it. Made descriptions to be translatable.

Translated text in "placeholder" needs to be escaped.
(amethyst_search_form() functions.php)

Fix it. Made placeholder text to be escaped.


## 4

Please prefix the thumbnail image sizes.

I re-read guidelines, codex for Post Thumbnails and checked my theme code.
but I can't find issues what you mean "prefix the thumbnail image sizes".
Do you mean that "set parameters", or something else?

And also I modified functions.php, content-single.php, content-page.php, and content.php
because I found there were not used post thumbnail sizes.

[ previous ]
functions.php:

<?php
/*
 * Enable support for Post Thumbnails on posts and pages.
 */
add_theme_support( 'post-thumbnails' );
/*
 * Extra image sizes.
 */
set_post_thumbnail_size( 774, 400, true );
add_image_size( 'thumb774x400', 774, 400, true );
add_image_size( 'thumb288x154', 288, 154, true );

content-*.php:

<?php // post thumbnail
$size = 'thumb744x400';
the_post_thumbnail( $size, array( 'class' => 'attachment-' . $size . ' post__image' ) );
?>

[ modified ]
functions.php:

<?php
/*
 * Enable support for post thumbnails on posts and pages.
 */
add_theme_support( 'post-thumbnails' );
set_post_thumbnail_size( 774, 400, true );

content-*.php:

<?php if ( has_post_thumbnail() ) : ?>
        <div class="post__image"><?php the_post_thumbnail(); ?></div>
<?php endif; ?>

## 5
There are some additional updates. See at "Change Log" in readme.txt!

Last edited 22 months ago by featherplain (previous) (diff)

#8 @poena
22 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi!
Your theme should be live shortly.

Prefixing the thumbnail sizes is no longer an issues since you removed

 add_image_size( 'thumb774x400', 774, 400, true );

What I meant was something similar to this example:

 add_image_size( 'amethyst_thumb774x400', 774, 400, true );

One issue remains, but you can fix that in your next update.
In functions.php, where you are filtering the search form, escape the translated text in the placeholder.
(Compare to the default form: https://developer.wordpress.org/reference/functions/get_search_form/)

Note: See TracTickets for help on using tickets.