WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 17 months ago

#28045 closed theme (not-approved)

THEME: Winters – 1.0.8

Reported by: wiloke Owned by: phillip.nunes
Priority: new theme Keywords: theme-winters
Cc: piratesmorefun@…, djrmom

Change History (56)

#1 @karmatosed
2 years ago

This is just a note, the screenshot should be as close to what happens when you default load the theme. A mocked up image or single image will prevent the theme from being passed for review. Please resolve this before the review can be completed.

#2 @greenshady
2 years ago

Just a note that any themes/plugins you sell/distribute from your Web site must be 100% licensed under the GPL or a GPL-compatible license. Currently, you have several themes under a proprietary license.

#3 @wiloke
2 years ago

Hi
I can't commit sv. I receive this error : POST of '/!svn/me': 403 Forbidden (

#4 @limestreet
2 years ago

Hi @wiloke if you need upload new version just bump theme version in style.css and go to: https://wordpress.org/themes/upload/ - just like first time :)

#5 @themetracbot
22 months ago

  • Owner set to thekirankumardash
  • Status changed from new to reviewing

#6 @karmatosed
21 months ago

  • Owner thekirankumardash deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#7 @themetracbot
21 months ago

  • Owner set to mynamevenu24

#8 @mynamevenu24
21 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

#9 @grapplerulrich
21 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Reopening the ticket as there was no review.

#10 @grapplerulrich
20 months ago

  • Owner mynamevenu24 deleted
  • Status changed from reopened to reviewing

Removing reviewer so to get back in the queue.

#11 @themetracbot
20 months ago

  • Owner set to phillip.nunes

#12 @phillip.nunes
20 months ago

Hi,
Thank you for making an interesting theme for the community.

I am doing this review, and i have a question. I found in theme folder a file called instagram-flickr.php, but it is empty.

What was your idea in relation to this file?

Thanks!
Phillip.

This ticket was mentioned in Slack in #themereview by phillipnunes. View the logs.


20 months ago

#14 @grapplerulrich
20 months ago

@wiloke - Please can you reply to the question above or the ticket will be closed due to no response.

#15 @wiloke
20 months ago

Hi
Firstly, thanks for your reviewing.
About your question: Yes, it's an empty folder. We will remove this folder in the update version.
Thanks

#16 @themetracbot
20 months ago

  • Summary changed from THEME: Winters – 1.0 to THEME: Winters – 1.0.1

#17 @phillip.nunes
20 months ago

Hi @wiloke, how are you?

Here is my review. If you have not already done so, I suggest you read the following links. By doing the analysis I used them as standard:

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/

Also read:
https://make.wordpress.org/themes/2015/04/22/details-on-the-new-theme-settings-customizer-guideline/

============================================================================================
REQUIRED:
Remove google analytics link from Header. This is plugin territory, so no analytics or tracking.

Don’t include any plugins (zipped or not). A theme can recommend plugins but not include those plugins in the theme code. Remember, only recommend and NOT require.

Declare licenses of any resources included such as fonts, images or scripts.

Use the Customizer for implementing theme options (Actually you are replacing Customizer options. See: http://prntscr.com/abz70x).

No minification of scripts or files unless provide original files. Actually you have some scripts without original files, like bootstrap and font-awesome.
============================================================================================

Anything just talk.

Best regards,
Phillip.

#18 @themetracbot
20 months ago

  • Summary changed from THEME: Winters – 1.0.1 to THEME: Winters – 1.0.2

#19 @wiloke
20 months ago

Hi
Thanks for your feedback!
Version 1.0.2.
Bugs Fixed:

  1. Remove Google analytics
  2. Remove all zip files
  3. Declare licenses of all scripts
  4. No minification
  5. Change Customizer Settings

#20 @phillip.nunes
20 months ago

@wiloke,
You said things that are not made, such as the removal of .zip files, check admin\plugin-activation\plugins\zip-files-here

Also I found minified files without their corresponding, for example admin\source\css\open-your-files...If found here , probably exist elsewhere.

Fix all aspects already mentioned above so that we can continue.

~ Phillip.

Last edited 20 months ago by phillip.nunes (previous) (diff)

#21 @themetracbot
20 months ago

  • Summary changed from THEME: Winters – 1.0.2 to THEME: Winters – 1.0.3

#22 @wiloke
20 months ago

Hi
Fixed it.
Thanks

#23 @greenshady
20 months ago

Just a couple of quick notes:

License

I brought this up 5 months ago in this ticket (see: https://themes.trac.wordpress.org/ticket/28045#comment:2) It should've been corrected by now.

The site this theme is hosted on has non-GPL, proprietary plugins bundled from the looks of it. Two non-GPL plugins that I see:

  • Visual Composer
  • Revolution Slider

The site is also selling themes under ThemeForest's "Regular License", which is incompatible with the GPL. All themes and plugins distributed/sold from your site must be under a GPL or compatible license. No proprietary licenses are allowed.

Theme URI

The Theme URI must link to a page about the theme or be removed. The link cannot be a demo.

#24 @themetracbot
20 months ago

  • Summary changed from THEME: Winters – 1.0.3 to THEME: Winters – 1.0.4

#25 follow-up: @wiloke
20 months ago

Hi

  1. Visual Composer + Revolution Slider: Sorry but I just checked it, never see these plugins in Winters.
  2. We removed Winters on ThemeForest long time ago.
  3. Removed Theme URI

Thanks

#26 @phillip.nunes
20 months ago

@greenshady, about the things you mentioned. Now it's all right?

I did not quite understand the problem , or how to check it.

#27 in reply to: ↑ 25 @greenshady
20 months ago

Replying to wiloke:

  1. Visual Composer + Revolution Slider: Sorry but I just checked it, never see these plugins in Winters.
  2. We removed Winters on ThemeForest long time ago.

You're distributing the Visual Composer and Revolution Slider plugins through your site via a theme bundle. They are not 100% GPL.

You have other themes on your site being sold under a non-GPL license. In order for your theme to be hosted here on WordPress.org, all themes/plugins you distribute or sell through your site must be under a 100% GPL or compatible license. The ThemeForest themes that you're selling through your site are under a proprietary license.

Replying to phillip.nunes:

@greenshady, about the things you mentioned. Now it's all right?

I did not quite understand the problem , or how to check it.

No, it's not all right. The theme author didn't change the items on the site. This theme really should've never been reviewed until the licensing issue was cleared up.

Basically, any links in the Winters theme, including both the Author URI and Theme URI, can only distribute or sell themes that are under a 100% GPL or compatible license. We do not allow theme authors to host their themes here on WordPress.org unless they follow this rule.

Here's an example of one theme on the site being sold under ThemeForest's "Regular License" (there's more than one): http://wiloke.net/titan-an-elegant-wordpress-blog-theme-2/

Here's a theme that has Revolution Slider and Visual Composer bundled with it, both of which are well-known plugins that do not carry a 100% GPL or compatible license. At least it appears to bundled, according to the text. http://wiloke.net/landing/rose/

#28 follow-up: @wiloke
20 months ago

Hi @greenshady,
Thanks for your replying!
So now I need to remove Theme URI and Theme Author URI in style.css, it's right?

#30 @wiloke
19 months ago

@greenshady @phillip.nunes I just changed Theme URI and Author URI

#31 in reply to: ↑ 28 @greenshady
19 months ago

Replying to wiloke:

Hi @greenshady,
Thanks for your replying!
So now I need to remove Theme URI and Theme Author URI in style.css, it's right?

No, that's not what I said at all. I said that we don't allow themes to be hosted here on WordPress.org from sites that distribute or sell themes/plugins that are not 100% under a GPL or compatible license.

#32 @themetracbot
19 months ago

  • Summary changed from THEME: Winters – 1.0.5 to THEME: Winters – 1.0.6

#33 @wiloke
19 months ago

@greenshady @phillip.nunes Changed Author URI.
There are no premium themes/plugins now.
Thanks

#34 @greenshady
19 months ago

  • Owner phillip.nunes deleted

@phillip.nunes - Do you plan to continue the review? If not, I'm going to put this back into the queue so that another reviewer will pick it up.

#35 @phillip.nunes
19 months ago

I was actually hoping you comment something @greenshady because the things he hit were the ones mentioned by you. So I do not not say anything in two weeks.

You can put me back as reviewer of this theme. From my point of view there are no more problems.

#36 @greenshady
19 months ago

  • Owner set to phillip.nunes

Sorry, I didn't mean to remove you until you responded. You're the ticket owner again.

#37 @phillip.nunes
19 months ago

  • Status changed from reviewing to approved

@wiloke, in my understanding it's all right.
Let's wait for someone more experienced to analyze if your theme can be approved.

See you.

#38 @djrmom
18 months ago

  • Status changed from approved to reopened

#39 @phillip.nunes
18 months ago

Hi @djrmom, are you going to do some last review, or what?

Regards,
Phillip.

#40 @djrmom
18 months ago

  • Cc djrmom added

Hi @wiloke,

There are a few required issues that need to be fixed before your theme is made live. However, first we need to get the 100% GPL issue straight.

It would be great if you decided to make all your themes at wiloke.net 100% GPL.

If you are going to sell non-100% GPL WordPress products from wiloke.net then you need to remove all links that lead there from your theme.

There are links in readme.txt and admin/page/settings.php

Your Author URL that now links to your WordPress.org profile, links back to your website.

The demo-data.xml file you have included also is pulling from your domain, @greenshady is including demo xml files even allowed?

Please let me know if you have any questions.

Thanks,
Jenny

#41 @djrmom
18 months ago

Hi @phillip.nunes, thanks for being on top of the review process. I am going to wait until we get the GPL resolved before continuing the rest of the final review. Thanks.

#42 @greenshady
18 months ago

Demo XML files aren't really suited for inclusion with the theme. That should be a separate download from the theme author's site.

#44 @wiloke
18 months ago

Hi @djrmom
I just changed Author URI and removed Demo XML in the package

#45 @grapplerulrich
18 months ago

  • Status changed from reopened to reviewing

#46 @djrmom
18 months ago

Thanks @wiloke,

Just to confirm, you have decided to host your themeforest themes at http://wiloke.net/ and your 100% GPL themes at http://wiloke.com/?

You will also need to update https://themes.svn.wordpress.org/winters/1.0.7/readme.txt and https://themes.svn.wordpress.org/winters/1.0.7/admin/page/settings.php to use the new url.

Also, there are a lot of links back to wiloke.net and/or themeforest from wiloke.com linking to your blog, social media, and support forum. @greenshady, can you confirm, do these indirect links back to the themeforest themes need to be removed from http://wiloke.com?

Your Theme URL - http://blog.wiloke.net/blog/winters/ needs to be a page about the theme, not a demo, the url you are using for Author URL would be appropriate instead http://wiloke.com/downloads/winters-a-responsive-wordpress-blog-theme/

Thanks,
Jenny

#48 @wiloke
18 months ago

Thanks @djrmom
I just updated a new version of Winters.

  • Yes, We changed from wiloke.net to wiloke.com
  • We changed Theme URI as your requirement
  • We updated readme.txt and admin->page->settings.php to use the new URL

#49 @grapplerulrich
18 months ago

If you don't want to licence the theme on ThemeForest under GPL then. You need to create a new user that has no link and reference to the company "Wiloke".

The theme on wiloke.com is also not licenced under GPL.

#50 @wiloke
18 months ago

Thanks @grapplerulrich
So I also need to move Winters's demo to another domain?
Thanks

#51 @grapplerulrich
18 months ago

You need to use a new WordPress.org account that does not lead back to Wiloke.

#52 @wiloke
18 months ago

And my theme will be started over again?

#53 @grapplerulrich
18 months ago

We would set the theme live and then assign the theme to the new account.

#54 @djrmom
18 months ago

Hi @wiloke, are you still working on this?

Thanks,
Jenny

#55 @grapplerulrich
17 months ago

@wiloke Please provide an update or the ticket will be closed.

#56 @grapplerulrich
17 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to no response from the theme author.

Note: See TracTickets for help on using tickets.