WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 21 months ago

#28149 closed theme (closed-newer-version-uploaded)

THEME: Splendor – 1.0.1

Reported by: stephencottontail Owned by: tahi1990
Priority: new theme Keywords: theme-splendor
Cc: stephencottontail@…

Description

Splendor - 1.0.0

Splendor is a bright photoblogging theme, featuring a logo, clean typography, and five user-selectable color schemes. With its large featured images, Splendor makes your photoblog look, if you’ll forgive the wordplay, splendid.

Theme URL -
Author URL - http://stephencottontail.wordpress.com/

SVN - https://themes.svn.wordpress.org/splendor/1.0.0
ZIP - https://wordpress.org/themes/download/splendor.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#28149 THEME: Splendor – 1.0.1 closed closed-newer-version-uploaded tahi1990

(this ticket)

#31054 THEME: Splendor – 1.0.3 closed live tahi1990


https://themes.svn.wordpress.org/splendor/1.0.0/screenshot.png

Change History (18)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Splendor – 1.0.0 to THEME: Splendor – 1.0.1

Splendor - 1.0.1

Splendor is a bright photoblogging theme, featuring a logo, clean typography, and five user-selectable color schemes. With its large featured images, Splendor makes your photoblog look, if you’ll forgive the wordplay, splendid.

Theme URL -
Author URL - http://stephencottontail.wordpress.com/

SVN - https://themes.svn.wordpress.org/splendor/1.0.1
ZIP - https://wordpress.org/themes/download/splendor.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=splendor/1.0.0&new_path=splendor/1.0.1

History:

Ticket Summary Status Resolution Owner
#28149 THEME: Splendor – 1.0.1 closed closed-newer-version-uploaded tahi1990

(this ticket)

#31054 THEME: Splendor – 1.0.3 closed live tahi1990


https://themes.svn.wordpress.org/splendor/1.0.1/screenshot.png

#2 @themetracbot
2 years ago

  • Owner set to lawkidd205
  • Status changed from new to reviewing

#3 @karmatosed
23 months ago

  • Owner lawkidd205 deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#4 @themetracbot
23 months ago

  • Owner set to KEN RENE LUNDING

#5 @grapplerulrich
22 months ago

  • Owner changed from KEN RENE LUNDING to grapplerulrich

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#6 @grapplerulrich
22 months ago

  • Owner grapplerulrich deleted

#7 @themetracbot
22 months ago

  • Owner set to tahi1990

#8 @tahi1990
22 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @themetracbot,

I've reviewed this theme. Here is the review result

THEME CHECK

For theme check I found three messages:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

CODE

  • No PHP or JS errors.
  • Should provide unique prefix to all js and php file name in inc and js folder.

Core Functionality and Features

  • Don’t include admin/feature pointers. FAILED

The side include admin pointers at the top left

Licensing

  • 100% GPL and/or 100% GPL-compatible licensed.

Stylesheets and Scripts

Templates

  • If post has no title, it should display permalink.

Thanks

Last edited 22 months ago by tahi1990 (previous) (diff)

This ticket was mentioned in Slack in #themereview by tahi1990. View the logs.


22 months ago

#10 @tahi1990
22 months ago

Hi @themetracbot,

I've mistakenly closed ticket, could you reopen it? Thanks and sorry for inconvinient.

#11 @grapplerulrich
22 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#12 @grapplerulrich
22 months ago

  • Status changed from reopened to reviewing

#13 @stephencottontail
22 months ago

Replying to tahi1990:

Sorry this has been sitting so long; I must've missed the email.

Core Functionality and Features

  • Don’t include admin/feature pointers. FAILED

The side include admin pointers at the top left

Can you clarify what you mean by this?

Stylesheets and Scripts

On which specific page do you see the errors?

Templates

  • If post has no title, it should display permalink.

There is a permalink on the date, next to the author. Is this no longer acceptable? Should I display some sort of generic text if a post has no title?

Last edited 22 months ago by stephencottontail (previous) (diff)

#14 follow-up: @tahi1990
22 months ago

Hi @stephencottontail,

Don’t include admin/feature pointers. FAILED
The side include admin pointers at the top left

Can you clarify what you mean by this?

The avatar in the top left of page now point to wp-admin. But sorry, I'm wrong with this. It's accepted.

HTML Errors and Warnings found. Please validate / Fix them using W3 validator https://validator.w3.org/#validate_by_input

On which specific page do you see the errors?

I checked on the homepage and see the warnings and errors.

If post has no title, it should display permalink.

There is a permalink on the date, next to the author. Is this no longer acceptable? Should I display some sort of generic text if a post has no title?

It's fine.

This is my first review theme so maybe has some misunderstandings. If the stylesheet was validated then the theme's fine.

#15 in reply to: ↑ 14 @stephencottontail
22 months ago

Replying to tahi1990:

Hi @stephencottontail,

Don’t include admin/feature pointers. FAILED
The side include admin pointers at the top left

Can you clarify what you mean by this?

The avatar in the top left of page now point to wp-admin. But sorry, I'm wrong with this. It's accepted.

Thanks for clarifying. This is a mistake, though; the logo should go back home, not to the Dashboard. I'm going to upload a new version that fixes that and a couple of issues either today or tomorrow.

#16 @grapplerulrich
21 months ago

@stephencottontail Please can you upload the update or the ticket will be closed.

#17 @stephencottontail
21 months ago

Huh, I didn't notice this happened until now, but when I uploaded the update it created a new ticket: https://themes.trac.wordpress.org/ticket/31054

Can these be merged somehow?

#18 @grapplerulrich
21 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.