WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 17 months ago

Last modified 17 months ago

#28299 closed theme (live)

THEME: wpbo – 1.3.5

Reported by: closemarketing Owned by: imranaliweb
Priority: previously reviewed Keywords: theme-wpbo
Cc: david@…, @…

Description

wpbo - 1.3

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/wpbo-theme/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3
ZIP - https://wordpress.org/themes/download/wpbo.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.2&new_path=wpbo/1.3

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3/screenshot.png

Attachments (1)

wpbo.zip (950.4 KB) - added by davidperez 18 months ago.
WPBO theme 1.3.4

Download all attachments as: .zip

Change History (49)

#1 @davidperez
21 months ago

Please review this theme.

#2 @themetracbot
21 months ago

  • Owner set to admin.morsheed
  • Status changed from new to reviewing

#3 @karmatosed
21 months ago

  • Owner admin.morsheed deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

This ticket was mentioned in Slack in #themereview by davidperez. View the logs.


21 months ago

#5 @closemarketing
21 months ago

Hello,

Yes, I'm theme reviewer. It's a good idea.

#6 @grapplerulrich
21 months ago

  • Owner set to DenUsenko

#7 @davidperez
21 months ago

Hello @grapplerulrich,
Please send me any doubt that you could have with the theme. Consider that I'm using it for parent theme. In child theme, I make all changes.

Regards.

#8 @DenUsenko
20 months ago

Hello, @davidperez !
Sorry for the delay, I will post my review in a few hours.

#9 @DenUsenko
20 months ago

OUTCOME

Your theme still has some issues. Please, fix required items I've listed below and re-upload the new version.

REQUIRED

Code

  • No PHP or JS errors.
NOTICE: USE OF UNDEFINED CONSTANT WPLANG - ASSUMED 'WPLANG' IN /SRV/WWW/THEMEREVIEW/HTDOCS/WP-CONTENT/THEMES/WPBO/PARTIALS/CONTENT-META.PHP ON LINE 6
  • Must meet all Theme Check requirements
WARNING: Both DOS and UNIX style line endings were found in the file functions.php. This causes a problem with SVN repositories and must be corrected before the theme can be accepted. Please change the file to use only one style of line endings.
  • Provide a unique prefix for everything the Theme defines. The domain found is wpbo.

http://themereview.co/prefix-all-the-things/
Image size names:

add_image_size( 'wpbs-featured', 848, 300, true );
add_image_size( 'wpbs-featured-home', 970, 311, true);
add_image_size( 'wpbs-featured-carousel', 970, 400, true);

Core Functionality and Features

  • Able to have child themes made from them. (Child theme ready)

Functions should be easily overwritten by a child theme:

if ( ! function_exists( 'wpbo_example' ) ) :
function wpbo_example() {
//Some code here
}
endif;

Documentation

That doesn't look right. Readme.txt:

2. Type in Twenty Ten in the search form and press the 'Enter' key in your keyboard.

Stylesheets and Scripts

  • No minification of scripts or files unless provide original files.
modernizr.full.min.js
  • Design

Theme logo covers a bit of content area. You may change logo size (shrink it) on page scroll.

  • Theme Check
RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
RECOMMENDED: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.
RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: Tags: is either empty or missing in style.css header.
  • It's better to log your changes in changelog.txt file. You also might want to update theme version in readme.txt
  • Spell “WordPress” correctly, with both an uppercase W and P. Found "Wordpress" in comments of your php files.

NOTES

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.
Re-upload your theme here https://wordpress.org/themes/upload/
The theme must have the same name. You need to change the Version tag in style.css.

#10 @closemarketing
20 months ago

Hello, @DenUsenko What do you mean is not ready for child theme? it has a directory called wpbo-child that is ready for child theme.

I've uploaded the updated version 1.3.1.

Thanks.
Regards

#11 @themetracbot
20 months ago

  • Summary changed from THEME: wpbo – 1.3 to THEME: wpbo – 1.3.1

wpbo - 1.3.1

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/wpbo-theme/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3.1
ZIP - https://wordpress.org/themes/download/wpbo.1.3.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.3&new_path=wpbo/1.3.1

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3.1/screenshot.png

#12 @DenUsenko
20 months ago

Hello, @davidperez !
I will post my review today

#13 @DenUsenko
20 months ago

Hello, @davidperez !
I'm sorry to have kept you waiting

REQUIRED

1) single.php, line 40
Use edit_theme_options capability for determining user permission to edit options, rather than rely on a role (e.g. “administrator”), or a different capability (e.g. “edit_themes”, “manage_options”).
Looks like you do both checks.
Consider using edit_post_link() to eliminate unnecessary checks.

if( $user_level > 0 ) {
?>
<a href="<?php echo get_edit_post_link(); ?>" class="btn btn-success edit-post"><i class="icon-pencil icon-white"></i> <?php _e("Edit post","wpbo"); ?></a>
<?php } ?>

Example (Twenty Sixteen):

<?php
	edit_post_link(
		sprintf(
			/* translators: %s: Name of current post */
			__( 'Edit<span class="screen-reader-text"> "%s"</span>', 'twentysixteen' ),
			get_the_title()
		),
		'<span class="edit-link">',
		'</span>'
	);
?>

2) header.php, line 44
Missing file /img/logom.png

            <a class="navbar-brand" title="<?php echo get_bloginfo('description'); ?>" href="<?php echo home_url(); ?>">
                <img src="<?php echo esc_url( get_stylesheet_directory_uri() );?>/img/logo.png" srcset="<?php echo esc_url( get_stylesheet_directory_uri() );?>/img/logom.png 480w,<?php echo esc_url( get_stylesheet_directory_uri() );?>/img/logo.png 2000w" alt="<?php bloginfo('description');?>" />
            </a>

3) footer.php, line 19
Do you need to translate your website link ?

 <a href="<?php echo esc_url( __('https://www.closemarketing.es/', 'wpbo'));?>"

4) /partials/content-author.php , line 15

Fix alt & title attributes in links
Where can I set values for twitter, g+, linkedin links ?

 <li>
     <a href="<?php the_author_meta('googleplus'); ?>"><img src="<?php echo get_template_directory_uri();?>/images/google_plus.png" alt="Twitter" title="Twitter" /></a>
 </li>
 <li>
     <a href="<?php the_author_meta('url'); ?>">
     <img src="<?php echo get_template_directory_uri();?>/images/linkedin.png" alt="Twitter" title="Twitter" /></a>
 </li>

5) Rename files with names like page-{some-text} to something like template-page-{some-text}
page-{some-text} is recognized as page-{slug} https://developer.wordpress.org/themes/basics/template-hierarchy/#single-page

6) Please add license information to you readme file about Bootstrap, Glyphicons, Bones etc.

#14 @closemarketing
20 months ago

Hello, I've made the changes:
1) removed this lines.
2) removed logo mobile.
3) it was written like that becouse of other ticket. It has been changed.
4) Solved. I've made in functions.php Users meta for social media author. In content-author, I've updated the links and texts.
5) done.
6) done. Added license.txt and updated readme.txt.

Regards.

I'll upload version 1.3.2.

Last edited 20 months ago by closemarketing (previous) (diff)

#15 @themetracbot
20 months ago

  • Summary changed from THEME: wpbo – 1.3.1 to THEME: wpbo – 1.3.2

wpbo - 1.3.2

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/wpbo-theme/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3.2
ZIP - https://wordpress.org/themes/download/wpbo.1.3.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.3.1&new_path=wpbo/1.3.2

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3.2/screenshot.png

#16 @closemarketing
20 months ago

Updated.
Thanks for your work.

#17 @closemarketing
20 months ago

Hello @DenUsenko ... is the theme ready to publish?

This ticket was mentioned in Slack in #themereview by davidperez. View the logs.


20 months ago

#19 @grapplerulrich
20 months ago

  • Owner DenUsenko deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#20 @themetracbot
20 months ago

  • Owner set to triatomic

#21 @davidperez
20 months ago

Hello, thanks.

#22 @triatomic
19 months ago

Hello, @davidperez !
I'm sorry to have kept you waiting.

I did a wrong pull from the SVN, and will re-conducting the review process.
You will be hearing from me on couple hours.

Last edited 19 months ago by triatomic (previous) (diff)

This ticket was mentioned in Slack in #themereview by davidperez. View the logs.


19 months ago

#24 @grapplerulrich
19 months ago

@triatomic - Where are you with the review? If you don't have time I can reassign the ticket. It's no problem :D

#25 @davidperez
19 months ago

@grapplerulrich I don't see any response in days in any way...

#26 @grapplerulrich
19 months ago

  • Owner triatomic deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#28 @themetracbot
19 months ago

  • Owner set to imranaliweb

#29 @imranaliweb
19 months ago

Hi

Kindly Find and Solved Below Issue

  1. Registration of theme features : Implementation of add_theme_support() add_theme_support() was found in the file bones.php. However get_post_format and/or has_post_format were not found, and no use of formats in the CSS was detected.
  1. Use of includes : Use of include or require The theme appears to use include or require : admin.php Line 57: include_once(ABSPATH . WPINC . '/feed.php'); include the r If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead. Otherwise, use include_once or require_once instead. The theme appears to use include or require : bones.php Line 16: if ( is_readable($locale_file) ) require_once($locale_file); If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead. Otherwise, use include_once or require_once instead.
  1. Possible hard-coded links were found in the file footer.php.

Line 19: <a href='https://www.closemarketing.es/' target='_blank' title='Dise&ntilde;o Web Wo

Thanks.

Last edited 19 months ago by imranaliweb (previous) (diff)

#30 @davidperez
19 months ago

Hello,
Thanks for your review. I've solved all issues.

The first one is as comment, because I'll plan it to make it in next versions.

I've uploaded the version 1.3.3. Please confirm as soon as possible.

Regards.

#31 @themetracbot
19 months ago

  • Summary changed from THEME: wpbo – 1.3.2 to THEME: wpbo – 1.3.3

wpbo - 1.3.3

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/wpbo-theme/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3.3
ZIP - https://wordpress.org/themes/download/wpbo.1.3.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.3.2&new_path=wpbo/1.3.3

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3.3/screenshot.png

#32 @imranaliweb
19 months ago

  • Status changed from reviewing to approved

Hi

Approved This Theme, Not other issue found

Thanks.

#33 @davidperez
19 months ago

Nice work!
Thanks!

This ticket was mentioned in Slack in #themereview by davidperez. View the logs.


19 months ago

#35 @chipbennett
18 months ago

  • Status changed from approved to reopened

Required

  • ThemeURI is returning a 404 error
  • Must use front-page.php template file for the site homepage template (template-page-homepage.php)
  • License: style.css indicates Theme is dual-licensed under GPLv2 and Apache 2.0. readme.txt indicates Theme is licensed under GPLv2 or later. Which is correct? Either is fine, but you need to be consistent.
  • License: Theme must list, in readme.txt or a dedicated license file, any resources from which it was derived (e.g. Underscores, Bootstrap, Bones), and any resources that have been bundled - including proper copyright attribution and license declaration. Also, please be clear about what is derived vs bundled.
  • Scripts and stylesheet links in the document head must be enqueued
  • Remove default favicon link
  • Remove default logo image
  • Scripts output in the document footer must be enqueued
  • Put add_image_size(), add_theme_support(), etc. - basically, all Theme-related core function calls in functions.php inside of callbacks, hooked into an appropriate action
  • Do not unset user profile fields. This is Plugin territory.
  • Use core paginate_links() function for page navigation
  • Remove everything in library/admin.php. It is either Plugin territory or otherwise inappropriate.
  • Remove wpbo_bootstrap_head_cleanup in admin/bones.php. This is Plugin territory.
  • Remove bundled child Theme

This is not an exhaustive review.

Recommended

  • Use custom nav menu for social profile links

#36 @chipbennett
18 months ago

  • Status changed from reopened to reviewing

#37 @chipbennett
18 months ago

  • Cc @… added

@imranaliweb:

First, thank you for taking the time to contribute by doing Theme reviews. We greatly appreciate your time, effort, and willingness to contribute.

That said: please note that doing Theme reviews requires more than merely running the Theme through Theme Check, and reporting results. If that were the case, we could eliminate human reviews altogether (and that is our ultimate goal). Please review the "Resources" links on the following page, for information about how to conduct a full and thorough review:

https://make.wordpress.org/themes/handbook/review/resources/

If you have any questions, please don't hesitate to ask. We are here to help you.

#38 @davidperez
18 months ago

Hello @chipbennett . I reply you with all tasks:

1) done.
2) done.
3) License readme. I've attached in readme all sources that I've used to make the theme. What do you need more?
4) done.
5) done.
6) Used custom logo function.
7) done
8) done
9) removed unset.
10) changed to paginate_links wordpress function.
11) removed.
12) removed function
13) why? cannot have it in some directory? removed but please clarify.

I've made all changes in version 1.3.4.

Regards.
David

Last edited 18 months ago by davidperez (previous) (diff)

@davidperez
18 months ago

WPBO theme 1.3.4

#39 @themetracbot
18 months ago

  • Summary changed from THEME: wpbo – 1.3.3 to THEME: wpbo – 1.3.4

wpbo - 1.3.4

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/wpbo-theme/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3.4
ZIP - https://wordpress.org/themes/download/wpbo.1.3.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.3.3&new_path=wpbo/1.3.4

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3.4/screenshot.png

#40 @chipbennett
18 months ago

Hi @imranaliweb, will you be able to continue the review?

#41 @davidperez
18 months ago

But @chipbennett you've already made the last review. How many times the theme has to be reviewed?

This ticket was mentioned in Slack in #themereview by davidperez. View the logs.


18 months ago

#43 @grapplerulrich
17 months ago

I checked the update and the theme and found the following issues:

  • The theme URI is still not working
  • wpbo_bootstrap_rss_version() is plugin territory
  • wpbo_bootstrap_queue_js should hook into wp_enqueue_scripts
  • Please translate the title in wpbo_bootstrap_excerpt_more
  • Adding user meta data is plugin territory
  • Please prefix global e.g $custom_meta_fields
  • Please place add_editor_style('editor-style.css'); within a function
  • Please prefix wp_enqueue_style( 'prefix-font-awesome' correctly
  • you have not registered modernizer anywhere. It should be prefixed too wp_enqueue_script('modernizr');
  • If you get the date setting from WP then you do not need to add custom code like this if($locale=='es_ES') the_time('j \d\e\ F \d\e\ Y '); else the_time('F jS, Y'); ?>
  • Please remove JS files that are not in use
  • Please remove the favicon and logo from the theme.

#44 @closemarketing
17 months ago

1) changed.
2) removed.
3) done.
4) done.
5) removed.
6) done
7) not using the function anymore.
8) done
9) commented the line.
10) Thanks. I didn't know.
11) done
12) done

Uploaded version 1.3.5.
Regards.

#45 @themetracbot
17 months ago

  • Summary changed from THEME: wpbo – 1.3.4 to THEME: wpbo – 1.3.5

wpbo - 1.3.5

A naked responsive theme based on the Bootstrap framework. Includes multiple page templates, two different sidebars and a theme options panel.

Theme URL - https://www.closemarketing.es/servicios-agencia-granada/desarrollo-web-wordpress/tema-wpbo/
Author URL - https://www.closemarketing.es

SVN - https://themes.svn.wordpress.org/wpbo/1.3.5
ZIP - https://wordpress.org/themes/download/wpbo.1.3.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpbo/1.3.4&new_path=wpbo/1.3.5

History:

Ticket Summary Status Resolution Owner
#19596 THEME: WPBoot - 1.0.1 closed live bijayyadav
#22791 THEME: WPBoot - 1.1 closed live nishasingh
#22822 THEME: WPBoot - 1.3 closed live karmatosed
#26605 THEME: wpbo – 1.2 closed not-approved catchthemes
#28299 THEME: wpbo – 1.3.5 closed live imranaliweb

(this ticket)

#34584 THEME: wpbo – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/wpbo/1.3.5/screenshot.png

#46 @imranaliweb
17 months ago

  • Status changed from reviewing to approved

Hi

All issue Fixed

Approved this version.

Thanks.

#47 @chipbennett
17 months ago

  • Resolution set to live
  • Status changed from approved to closed

Based on spot-check of diff, looks good. Marking this version as "live". Congratulations, and thanks for contributing to WordPress!

#48 @davidperez
17 months ago

Thanks to all.

Note: See TracTickets for help on using tickets.