WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#28404 closed theme (live)

THEME: Three – 1.3.7

Reported by: miyauchi Owned by: poena
Priority: new theme Keywords: theme-three child-theme parent-twentythirteen
Cc: miya@…

Description

Three - 1.0.0

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.0.0
ZIP - https://wordpress.org/themes/download/three.1.0.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.0.0/screenshot.png

Change History (18)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.0.0 to THEME: Three – 1.1.0

Three - 1.1.0

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.1.0
ZIP - https://wordpress.org/themes/download/three.1.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.0.0&new_path=three/1.1.0

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.1.0/screenshot.png

#2 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.1.0 to THEME: Three – 1.2.0

Three - 1.2.0

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.2.0
ZIP - https://wordpress.org/themes/download/three.1.2.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.1.0&new_path=three/1.2.0

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.2.0/screenshot.png

#3 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.2.0 to THEME: Three – 1.3.0

Three - 1.3.0

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.0
ZIP - https://wordpress.org/themes/download/three.1.3.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.2.0&new_path=three/1.3.0

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.0/screenshot.png

#4 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.0 to THEME: Three – 1.3.1

Three - 1.3.1

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.1
ZIP - https://wordpress.org/themes/download/three.1.3.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.0&new_path=three/1.3.1

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.1/screenshot.png

#5 @poena
2 years ago

  • Keywords changed from theme-three, child-theme, parent-twentythirteen to theme-three child-theme parent-twentythirteen
  • Owner set to poena
  • Status changed from new to reviewing

#6 follow-up: @poena
2 years ago

Hi!
This was rather interesting, nice work.

A few questions though:
I read that it was supposed to be a full screen effect? I viewed the theme in chrome and firefox, and the effect is only on the header.

Do you mind explaining why the parent stylesheet needs to be loaded in this manner?

	wp_enqueue_style(
		'twentythirteen-style',
		get_stylesheet_directory_uri() . '/twentythirteen.css',
		array(),
		'1.3.1'
	);

This will be problematic when the parent theme is updated.

During the review I found the following issues:

Required:
I can't find the license for the inluded images or js. The theme needs to be 100% GPL compatible.

The screenshot only shows the header, not how the theme looks with the default settings loaded.

Please remove the .gitignore file.


Please post an update or reply within seven days, or your ticket will be closed as not-approved.

#7 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.1 to THEME: Three – 1.3.3

Three - 1.3.3

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.3
ZIP - https://wordpress.org/themes/download/three.1.3.3.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.1&new_path=three/1.3.3

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.3/screenshot.png

#8 @miyauchi
2 years ago

Hi poena,

Thanks for review.
I will fix your suggestions.

I wasn't aware of your review, so please ignore v1.3.3.

Last edited 2 years ago by miyauchi (previous) (diff)

#9 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.3 to THEME: Three – 1.3.4

Three - 1.3.4

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D effect.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.4
ZIP - https://wordpress.org/themes/download/three.1.3.4.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.3&new_path=three/1.3.4

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.4/screenshot.png

#10 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.4 to THEME: Three – 1.3.5

Three - 1.3.5

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D-VR effect on smartphone.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.5
ZIP - https://wordpress.org/themes/download/three.1.3.5.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.4&new_path=three/1.3.5

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.5/screenshot.png

#11 in reply to: ↑ 6 @miyauchi
2 years ago

Hi @poena,

I read that it was supposed to be a full screen effect? I viewed the theme in chrome and firefox, and the effect is only on the header.

Full-screen effect is only on mobile, so I have updated description.

Do you mind explaining why the parent stylesheet needs to be loaded in this manner?

	wp_enqueue_style(
		'twentythirteen-style',
		get_stylesheet_directory_uri() . '/twentythirteen.css',
		array(),
		'1.3.1'
	);

This will be problematic when the parent theme is updated.

There is many changes from twentythirteen's css.
I have changed file name from twentythirteen.css from custom-twentythirteen.css, because it was confusing.

Required:
I can't find the license for the inluded images or js. The theme needs to be 100% GPL compatible.

I have added license.txt.

The screenshot only shows the header, not how the theme looks with the default settings loaded.

I have updated screenshot.png

Please remove the .gitignore file.

I have removed .gitignore.

I have updated three times this theme after your review.
Following is all changeset.

https://themes.trac.wordpress.org/changeset?old_path=three/1.3.1&new_path=three/1.3.5

Thanks!

#12 @poena
2 years ago

Hi!
There is still an issue with the licenses. I meant that you need to specify the licenses of the included resources, not only the theme itself.

For example, https://github.com/WestLangley/three.js/blob/master/LICENSE is GPL compatible but the license for this pack is MIT not GPL v2.

Where are the images from?

#13 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.5 to THEME: Three – 1.3.6

Three - 1.3.6

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D-VR effect on smartphone.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.6
ZIP - https://wordpress.org/themes/download/three.1.3.6.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.5&new_path=three/1.3.6

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.6/screenshot.png

#14 @miyauchi
2 years ago

Hi @poena

I've added a readme.txt including about licence.
cloud.png is contained in three.js and search-icon.png is based on twentythirteen's it.

Thanks!

#15 @themetracbot
2 years ago

  • Summary changed from THEME: Three – 1.3.6 to THEME: Three – 1.3.7

Three - 1.3.7

Three theme is a child theme of Twenty Thirteen . It has a full-screen 3D-VR effect on smartphone.

Theme URL - https://github.com/miya0001/three
Author URL - http://firegoby.jp/

SVN - https://themes.svn.wordpress.org/three/1.3.7
ZIP - https://wordpress.org/themes/download/three.1.3.7.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

以前のバージョンとの差分: https://themes.trac.wordpress.org/changeset?old_path=three/1.3.6&new_path=three/1.3.7

History:

Ticket Summary Status Resolution Owner
#19648 THEME: Three Nine Eight - 1.1.3 closed live sampression
#19766 THEME: Three By - 0.2 closed live sittestaccount
#21071 THEME: Three By - 0.4 closed live tskk
#23129 THEME: Threeway – 1.0 closed live poena
#28404 THEME: Three – 1.3.7 closed live poena

(this ticket)

#45212 THEME: Threeway – 1.1 closed live themetracbot
#46631 THEME: ThreeSixtyBlog Lite – 1.0 closed not-approved gookaani


https://themes.svn.wordpress.org/three/1.3.7/screenshot.png

#16 @miyauchi
2 years ago

Hi @poena

Sorry I updated readme.txt because there is mistake...

#17 @poena
2 years ago

  • Status changed from reviewing to approved

Great, all issues have been fixed.

#18 @karmatosed
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.