WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 23 months ago

#28480 closed theme (not-approved)

THEME: Herosense – 1.1.0

Reported by: Creativecoon Owned by: psdtohtmlguru
Priority: new theme Keywords: theme-herosense accessibility-ready
Cc: hello@…, joedolson

Description

Herosense - 1.1.0

A minimalistic free wordpress theme, that focuses on content hierarchy and content engagement by the reader.

Theme URL - http://creativecoon.com/herosense
Author URL - http://creativecoon.com/

SVN - https://themes.svn.wordpress.org/herosense/1.1.0
ZIP - https://wordpress.org/themes/download/herosense.1.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#28480 THEME: Herosense – 1.1.0 closed not-approved psdtohtmlguru

(this ticket)


https://themes.svn.wordpress.org/herosense/1.1.0/screenshot.png

Change History (16)

#1 @themetracbot
2 years ago

  • Owner set to vinaya99
  • Status changed from new to reviewing

#2 @grapplerulrich
2 years ago

  • Keywords changed from theme-herosense, accessibility-ready to theme-herosense accessibility-ready
  • Owner vinaya99 deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#3 @jcastaneda
2 years ago

  • Owner set to psdtohtmlguru

Thanks for helping out @psdtohtmlguru

#4 @psdtohtmlguru
2 years ago

Hi there, i have reviewed your theme, here we go:
Required:

  1. Please escape all data using available escaping functions https://codex.wordpress.org/Data_Validation , ex. featured-image:6 $image var
  2. I know your theme is build on a framework, but WordPress standard requires to have only one theme slug used for translation function across all files and that should be your theme name, not 'foundationpress'
  3. Please keep all functions in functions.php, you have a custom function added in search.php .
  4. Please make sure you prefix all functions with your theme slug
  5. Make sure you check if functions exists before declaring them
  6. Please include all licenses in your readme.txt file ( that also includes all assets included in the framework )
  7. There is a PHP notice: NOTICE: D:\work\htdocs\ti\zoommerce\wp-content\themes\herosense\library\social.php:42 - Array to string conversion
  8. Please add word-wrap: break-word; for your titles, posts etc.
  9. Images captions are not readeable https://nimbus.everhelper.me/client/notes/share/407147/mupis2etk8nc888yew2k

Recommanded:

  1. flush_widget_cache() found in the file custom-widgets.php. Deprecated since version 4.4.
  2. make sure you check your theme for edge content to avoid this situation: https://nimbus.everhelper.me/client/notes/share/407146/if7arlc82qcokouwogqa , you can also add images sizes and WordPress will automatically resize them

#5 @psdtohtmlguru
2 years ago

Also i see that you have accessibility-ready tag but there are none requirements meet, please see https://make.wordpress.org/themes/handbook/review/accessibility/ and apply the changes or remove the tag.

#6 @Creativecoon
2 years ago

Hello @psdtohtmlguru will be doing these changes asap. Thanks for taking the time to review the theme.

#7 @Creativecoon
2 years ago

@psdtohtmlguru Can I have a bit more time to get these fixes ready? I don't want the ticket to be rejected because of my slow response with an update.

#8 @psdtohtmlguru
2 years ago

Hi there, it's ok.

#9 @psdtohtmlguru
2 years ago

@Creativecoon Hi there, it's everything ok?

#10 @Creativecoon
2 years ago

Yes, althow I have a few quesitons.

  1. "Please escape all data using available escaping functions https://codex.wordpress.org/Data_Validation , ex. featured-image:6 $image var" - I have checked the theme, and all functions are escaped. Can you point me to exactly the line in question?

The rest I think I got them fixed. Ill have a version to review monday or tuesday if that's ok :)

Thanks for being awesome and patient :)

#11 @psdtohtmlguru
2 years ago

Hi,

For example have a look at /parts/featured-image.php line 6 and at a simple search i see there are a couple more who needs escaping, not all, there are a couple of exceptions but still. http://snag.gy/Eg8Zw.jpg

Cheers!

#12 @joedolson
2 years ago

  • Cc joedolson added

Theme will need an accessibility-ready review. On my list!

#13 @psdtohtmlguru
2 years ago

@joedolson should i assign you all tickets with accesibility-ready tag?

#14 @joedolson
2 years ago

No, no need to do that. Just handle them as normal reviews, but pass them to me for an accessibility-ready review before approving them. I'll do the accessibility review, then make a comment when the theme is approved for the tag or if the developer chooses to remove the tag.

#15 @grapplerulrich
23 months ago

@Creativecoon - It has been 3 weeks since your last response. Please update the theme or the ticket will be closed.

#16 @grapplerulrich
23 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to no response.

Note: See TracTickets for help on using tickets.