WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 23 months ago

#28481 closed theme (live)

THEME: Poseidon – 1.0.3

Reported by: ThemeZee Owned by: kenjigarland
Priority: new theme Keywords: theme-poseidon
Cc: contact@…

Description

Poseidon - 1.0

Poseidon is a beautiful designed Magazine WordPress theme with a responsive layout. The theme comes with a gorgeous Post Slider, Magazine Homepage template and a Header Widget area. Settings can be configured easily in the Customizer.

Theme URL - http://themezee.com/themes/poseidon/
Author URL - http://themezee.com

SVN - https://themes.svn.wordpress.org/poseidon/1.0
ZIP - https://wordpress.org/themes/download/poseidon.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#28481 THEME: Poseidon – 1.0.3 closed live kenjigarland

(this ticket)

#31106 THEME: Poseidon – 1.0.4 closed live themetracbot
#31314 THEME: Poseidon – 1.0.5 closed live themetracbot
#32191 THEME: Poseidon – 1.0.6 closed live themetracbot
#32996 THEME: Poseidon – 1.0.7 closed live themetracbot
#33880 THEME: Poseidon – 1.0.8 closed live themetracbot
#34529 THEME: Poseidon – 1.0.9 closed live themetracbot
#34884 THEME: Poseidon – 1.1.0 closed live themetracbot
#35827 THEME: Poseidon – 1.1.1 closed live themetracbot
#36411 THEME: Poseidon – 1.1.2 closed live themetracbot
#37662 THEME: Poseidon – 1.1.3 closed live themetracbot
#38052 THEME: Poseidon – 1.1.4 closed live themetracbot
#38336 THEME: Poseidon – 1.1.5 closed live themetracbot
#38807 THEME: Poseidon – 1.1.6 closed live themetracbot
#39957 THEME: Poseidon – 1.1.7 closed live themetracbot
#39978 THEME: Poseidon – 1.1.8 closed live themetracbot
#41186 THEME: Poseidon – 1.2 closed live themetracbot
#41234 THEME: Poseidon – 1.2.1 closed live themetracbot
#41271 THEME: Poseidon – 1.2.2 closed live themetracbot
#42356 THEME: Poseidon – 1.2.3 closed live themetracbot
#42882 THEME: Poseidon – 1.2.4 closed live themetracbot
#44012 THEME: Poseidon – 1.2.5 closed live themetracbot
#44515 THEME: Poseidon – 1.3 closed live themetracbot
#45538 THEME: Poseidon – 1.4 closed live themetracbot
#46144 THEME: Poseidon – 1.4.1 closed live themetracbot
#47722 THEME: Poseidon – 1.4.2 closed live themetracbot
#50094 THEME: Poseidon – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/poseidon/1.0/screenshot.jpg

Change History (10)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Poseidon – 1.0 to THEME: Poseidon – 1.0.1

Poseidon - 1.0.1

Poseidon is an elegant designed WordPress theme featuring a splendid fullscreen image slideshow. The clean typography and spacious white layout makes it great to share your stories. You can use the theme as simple blog or easily create a news website with the widget-based Magazine Homepage template.

Theme URL - https://themezee.com/themes/poseidon/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/poseidon/1.0.1
ZIP - https://wordpress.org/themes/download/poseidon.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=poseidon/1.0&new_path=poseidon/1.0.1

History:

Ticket Summary Status Resolution Owner
#28481 THEME: Poseidon – 1.0.3 closed live kenjigarland

(this ticket)

#31106 THEME: Poseidon – 1.0.4 closed live themetracbot
#31314 THEME: Poseidon – 1.0.5 closed live themetracbot
#32191 THEME: Poseidon – 1.0.6 closed live themetracbot
#32996 THEME: Poseidon – 1.0.7 closed live themetracbot
#33880 THEME: Poseidon – 1.0.8 closed live themetracbot
#34529 THEME: Poseidon – 1.0.9 closed live themetracbot
#34884 THEME: Poseidon – 1.1.0 closed live themetracbot
#35827 THEME: Poseidon – 1.1.1 closed live themetracbot
#36411 THEME: Poseidon – 1.1.2 closed live themetracbot
#37662 THEME: Poseidon – 1.1.3 closed live themetracbot
#38052 THEME: Poseidon – 1.1.4 closed live themetracbot
#38336 THEME: Poseidon – 1.1.5 closed live themetracbot
#38807 THEME: Poseidon – 1.1.6 closed live themetracbot
#39957 THEME: Poseidon – 1.1.7 closed live themetracbot
#39978 THEME: Poseidon – 1.1.8 closed live themetracbot
#41186 THEME: Poseidon – 1.2 closed live themetracbot
#41234 THEME: Poseidon – 1.2.1 closed live themetracbot
#41271 THEME: Poseidon – 1.2.2 closed live themetracbot
#42356 THEME: Poseidon – 1.2.3 closed live themetracbot
#42882 THEME: Poseidon – 1.2.4 closed live themetracbot
#44012 THEME: Poseidon – 1.2.5 closed live themetracbot
#44515 THEME: Poseidon – 1.3 closed live themetracbot
#45538 THEME: Poseidon – 1.4 closed live themetracbot
#46144 THEME: Poseidon – 1.4.1 closed live themetracbot
#47722 THEME: Poseidon – 1.4.2 closed live themetracbot
#50094 THEME: Poseidon – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/poseidon/1.0.1/screenshot.jpg

#2 @themetracbot
2 years ago

  • Summary changed from THEME: Poseidon – 1.0.1 to THEME: Poseidon – 1.0.2

Poseidon - 1.0.2

Poseidon is an elegant designed WordPress theme featuring a splendid fullscreen image slideshow. The clean typography and spacious white layout makes it great to share your stories. You can use the theme as simple blog or easily create a news website with the widget-based Magazine Homepage template.

Theme URL - https://themezee.com/themes/poseidon/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/poseidon/1.0.2
ZIP - https://wordpress.org/themes/download/poseidon.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=poseidon/1.0.1&new_path=poseidon/1.0.2

History:

Ticket Summary Status Resolution Owner
#28481 THEME: Poseidon – 1.0.3 closed live kenjigarland

(this ticket)

#31106 THEME: Poseidon – 1.0.4 closed live themetracbot
#31314 THEME: Poseidon – 1.0.5 closed live themetracbot
#32191 THEME: Poseidon – 1.0.6 closed live themetracbot
#32996 THEME: Poseidon – 1.0.7 closed live themetracbot
#33880 THEME: Poseidon – 1.0.8 closed live themetracbot
#34529 THEME: Poseidon – 1.0.9 closed live themetracbot
#34884 THEME: Poseidon – 1.1.0 closed live themetracbot
#35827 THEME: Poseidon – 1.1.1 closed live themetracbot
#36411 THEME: Poseidon – 1.1.2 closed live themetracbot
#37662 THEME: Poseidon – 1.1.3 closed live themetracbot
#38052 THEME: Poseidon – 1.1.4 closed live themetracbot
#38336 THEME: Poseidon – 1.1.5 closed live themetracbot
#38807 THEME: Poseidon – 1.1.6 closed live themetracbot
#39957 THEME: Poseidon – 1.1.7 closed live themetracbot
#39978 THEME: Poseidon – 1.1.8 closed live themetracbot
#41186 THEME: Poseidon – 1.2 closed live themetracbot
#41234 THEME: Poseidon – 1.2.1 closed live themetracbot
#41271 THEME: Poseidon – 1.2.2 closed live themetracbot
#42356 THEME: Poseidon – 1.2.3 closed live themetracbot
#42882 THEME: Poseidon – 1.2.4 closed live themetracbot
#44012 THEME: Poseidon – 1.2.5 closed live themetracbot
#44515 THEME: Poseidon – 1.3 closed live themetracbot
#45538 THEME: Poseidon – 1.4 closed live themetracbot
#46144 THEME: Poseidon – 1.4.1 closed live themetracbot
#47722 THEME: Poseidon – 1.4.2 closed live themetracbot
#50094 THEME: Poseidon – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/poseidon/1.0.2/screenshot.jpg

#3 @themetracbot
2 years ago

  • Owner set to kenjigarland
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #themereview by kenjigarland. View the logs.


2 years ago

#5 @kenjigarland
2 years ago

Hi, @ThemeZee,

Thank you for submitting Poseidon to the theme repository. I've reviewed the latest version, and it looks nice; I have just a handful of requirements and recommendations before I can mark it as approved. The Required items must be fulfilled in order for me to approve your theme, but the Recommended ones are only suggestions, so you can choose to follow them or not as you see fit.

Required

  • The theme tags include "editor-style", but no editor stylesheet is present. Please either add one or remove the editor-style tag.
  • Two of the "Magazine Posts" widgets ("Columns" and "Boxed") cause PHP notices (quoted below) when they're used with titles, because the Poseidon_Magazine_Posts_Columns_Widget::category_title() and Poseidon_Magazine_Posts_Boxed_Widget::widget_title() functions both refer to a key in the $settings array that isn't present. Please fix these notices, either by using isset() or by skipping the check for the missing array member altogether.

Notice: Undefined index: category_link in /srv/www/wordpress-default/wp-content/themes/poseidon/inc/widgets/widget-magazine-posts-columns.php on line 286

Notice: Undefined index: category_link in /srv/www/wordpress-default/wp-content/themes/poseidon/inc/widgets/widget-magazine-posts-boxed.php on line 370

Recommended

  • template-parts/header-bar.php looks for menu locations that aren't registered by the theme. I'd suggest registering them so users can add items to these menu locations.
  • I think you already know this, because you've done a really thorough job of it for the most part, but it's best practice to escape all values retrieved from the database before using them directly – including using them in filenames. Several templates include a line like the this:
    get_template_part( 'template-parts/content', $theme_options['post_content'] );
    where $theme_options['post_content'] isn't escaped. In this particular case I don't think this is an issue that an attacker could actually exploit to any practical end, which is why I've put this under the Recommended header; but it wouldn't hurt to use sanitize_key() again here, like you do before saving in poseidon_sanitize_select().

When you've had a chance to address the required items (and recommendations, if you choose to), please upload a new version of the theme and I'll review it again. As long as I don't see any new issues, I'll be happy to approve it.

Thanks!

#6 @themetracbot
2 years ago

  • Summary changed from THEME: Poseidon – 1.0.2 to THEME: Poseidon – 1.0.3

Poseidon - 1.0.3

Poseidon is an elegant designed WordPress theme featuring a splendid fullscreen image slideshow. The clean typography and spacious white layout makes it great to share your stories. You can use the theme as simple blog or easily create a news website with the widget-based Magazine Homepage template.

Theme URL - https://themezee.com/themes/poseidon/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/poseidon/1.0.3
ZIP - https://wordpress.org/themes/download/poseidon.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=poseidon/1.0.2&new_path=poseidon/1.0.3

History:

Ticket Summary Status Resolution Owner
#28481 THEME: Poseidon – 1.0.3 closed live kenjigarland

(this ticket)

#31106 THEME: Poseidon – 1.0.4 closed live themetracbot
#31314 THEME: Poseidon – 1.0.5 closed live themetracbot
#32191 THEME: Poseidon – 1.0.6 closed live themetracbot
#32996 THEME: Poseidon – 1.0.7 closed live themetracbot
#33880 THEME: Poseidon – 1.0.8 closed live themetracbot
#34529 THEME: Poseidon – 1.0.9 closed live themetracbot
#34884 THEME: Poseidon – 1.1.0 closed live themetracbot
#35827 THEME: Poseidon – 1.1.1 closed live themetracbot
#36411 THEME: Poseidon – 1.1.2 closed live themetracbot
#37662 THEME: Poseidon – 1.1.3 closed live themetracbot
#38052 THEME: Poseidon – 1.1.4 closed live themetracbot
#38336 THEME: Poseidon – 1.1.5 closed live themetracbot
#38807 THEME: Poseidon – 1.1.6 closed live themetracbot
#39957 THEME: Poseidon – 1.1.7 closed live themetracbot
#39978 THEME: Poseidon – 1.1.8 closed live themetracbot
#41186 THEME: Poseidon – 1.2 closed live themetracbot
#41234 THEME: Poseidon – 1.2.1 closed live themetracbot
#41271 THEME: Poseidon – 1.2.2 closed live themetracbot
#42356 THEME: Poseidon – 1.2.3 closed live themetracbot
#42882 THEME: Poseidon – 1.2.4 closed live themetracbot
#44012 THEME: Poseidon – 1.2.5 closed live themetracbot
#44515 THEME: Poseidon – 1.3 closed live themetracbot
#45538 THEME: Poseidon – 1.4 closed live themetracbot
#46144 THEME: Poseidon – 1.4.1 closed live themetracbot
#47722 THEME: Poseidon – 1.4.2 closed live themetracbot
#50094 THEME: Poseidon – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/poseidon/1.0.3/screenshot.jpg

#7 @ThemeZee
2 years ago

Hi there,

Thank you so much for taking the time to review the theme! I have just uploaded a new version which should fix all required and recommend items.

I highly appreciate your thourough review and feedback, it is very helpful to improve Poseidon and the overall quality of my code.

  • Editor styling was on my ToDo list for one of the next updates, but you are right that the tag should be added later then as well. I have just added the editor-style.css now ;)
  • PHP Notices: Good catch, don't know how I could miss these. WP_DEBUG is enabled of course!
  • I have removed the unused header-bar.php. I'm experimenting a little bit and have made the header bar part of the Pro Version with Poseidon. Usually it is a free feature and I forgot to remove the file.
  • I think security is very important and I'm very glad about every suggestion to improve it. I guess the security risk is minimal because any unwanted output there would load the default content.php file, but there is also no harm to escape it. I have used esc_attr(), because sanitization is more for database input and not output.

Cheers,
Thomas

#8 @kenjigarland
2 years ago

  • Status changed from reviewing to approved

Hi, Thomas,

This looks good to me! Thanks for going the extra mile with the recommendations. I'm marking this update as approved. Note that a theme review administrator will have to do another brief review before it goes live. Cheers!

Kenji

#9 @ThemeZee
2 years ago

Thank you :)

#10 @jcastaneda
23 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations! Your theme is now live!

Note: See TracTickets for help on using tickets.