WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 14 months ago

Last modified 14 months ago

#28496 closed theme (live)

THEME: Brood – 1.8.0

Reported by: orahmax Owned by: cristiano.zanca
Priority: new theme Keywords: theme-brood
Cc: mohitchawla127@…

Description

Brood - 1.0.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.0.0
ZIP - https://wordpress.org/themes/download/brood.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.0.0/screenshot.png

Attachments (1)

aweber-web-form-widget.1.1.17.zip (35.1 KB) - added by lisa74 16 months ago.
aweber

Download all attachments as: .zip

Change History (41)

#1 @themetracbot
20 months ago

  • Summary changed from THEME: Brood – 1.0.0 to THEME: Brood – 1.1.0

Brood - 1.1.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.1.0
ZIP - https://wordpress.org/themes/download/brood.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.0.0&new_path=brood/1.1.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.1.0/screenshot.png

#2 @themetracbot
17 months ago

  • Summary changed from THEME: Brood – 1.1.0 to THEME: Brood – 1.2.0

Brood - 1.2.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.2.0
ZIP - https://wordpress.org/themes/download/brood.1.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.1.0&new_path=brood/1.2.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.2.0/screenshot.png

#3 @themetracbot
17 months ago

  • Owner set to lisa74
  • Status changed from new to reviewing

#4 @orahmax
16 months ago

I am here to correct any problem in the theme. Please update with your review.

#5 @orahmax
16 months ago

Can you elaborate your last comment.

#6 @grapplerulrich
16 months ago

  • Owner lisa74 deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#7 @themetracbot
16 months ago

  • Owner set to cristiano.zanca

#8 @cristiano.zanca
16 months ago

Hi @orahmax ,

I'm now reviewing your theme.

Kind Regards

#9 @cristiano.zanca
16 months ago

file custom-comments.php line 23 should be changed
from:

<label for="comment">' . _x( 'Comment', 'noun') . '</label>

to

<label for="comment">' . _x( 'Comment', 'noun','brood' ) . '</label>

reference https://developer.wordpress.org/themes/functionality/internationalization/#disambiguation-by-context

If you agree I will write single issue and we can fix together and than upload a new version, or if you prefer I write only a bigger list of issues later.

Kind Regards

#10 @cristiano.zanca
16 months ago

footer.php line 41

from

<?php printf( esc_html__( '%1$s Theme by %2$s.', 'brood' ), 'Brood: ', '<a href="http://tidyhive.com/" rel="designer">Tidyhive</a>' ); ?>

to

<a href="<?php echo esc_url( __('http://tidyhive.com/', 'brood'));?>" target="_blank">Theme by Tidyhive</a>

reference: http://codex.wordpress.org/Function_Reference/esc_url

Kind Regards

#11 @orahmax
16 months ago

First of all i would like to thank you for review. It has already been almost 4 months. Will update soon with above mentioned points.

Last edited 16 months ago by orahmax (previous) (diff)

#12 @cristiano.zanca
16 months ago

You are welcome.

the third issue I've so far discovered: the footer's background is transparent

http://i.imgur.com/j6XHQdQ.png

Kind Regards

Last edited 16 months ago by cristiano.zanca (previous) (diff)

#13 @themetracbot
16 months ago

  • Summary changed from THEME: Brood – 1.2.0 to THEME: Brood – 1.3.0

Brood - 1.3.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.3.0
ZIP - https://wordpress.org/themes/download/brood.1.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.2.0&new_path=brood/1.3.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.3.0/screenshot.png

#14 @orahmax
16 months ago

I have made all the changes which you mentioned in Version 1.3.0, which you can check n above attachment.

#15 @cristiano.zanca
16 months ago

Hi @orahmax ,

I've checked the old issues and now they are fixed, great.

I've found so far 2 other issues:

1) menu depth must be working at list for 3 levels , now only 1

http://i.imgur.com/p4foazz.png

2) the file bootstrap/js/npm.js http://codepad.org/UdpmlUVm seems to be deleted.

I'm still reviewing, so I suggest you to wait for other issues to avoid wasting time with too many release svn upload.

Kind Regards

#16 @cristiano.zanca
16 months ago

Hi @orahmax ,

an update about the menu:

"if the menu has one or two levels, it is best to notify in the readme.txt that there's a limitation with the menu."

You can solve it also in this way.

Kind Regards

Last edited 16 months ago by cristiano.zanca (previous) (diff)

#17 @orahmax
16 months ago

  • I have added the text to notify about limitation of dropdown menu.
  • There was no need for npmjs folder so removed it.

#18 @cristiano.zanca
16 months ago

Hi @orahmax ,

in customize section

Tagline is customizable but is not present in front-end

http://i.imgur.com/Be73VMU.png

Header bkg img is customizable but doesn't appear

http://i.imgur.com/Iwh8TNg.png

Footer copyright section is customizable but doesn't update
http://i.imgur.com/qgfsA8V.png

Kind regards

#19 @orahmax
16 months ago

  • Issue 1 - Added support for site description/tagline.
  • Issue 2 - Its the part of _s framework, don't know what to do. Shall i remove it?
  • Issue 3 - I updated the text and link. Both works fine. 'Theme by tidyhive' won't change through this option.

#20 @cristiano.zanca
16 months ago

Hi @orahmax ,

1 ok
2 reading at the top of custom-header.php you can make it work adding this code

	<?php if ( get_header_image() ) : ?>
	<a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home">
		<img src="<?php header_image(); ?>" width="<?php echo esc_attr( get_custom_header()->width ); ?>" height="<?php echo esc_attr( get_custom_header()->height ); ?>" alt="">
	</a>
	<?php endif; // End header image check. ?>

in header.php

3 ok, so it's better to change the second part like this "WordPress Theme by tidyhive"

4 - in languages/brood.pot in the first lines there are some generic data like this

"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"

that are to be personalized.

Kind regards

#21 @orahmax
16 months ago

Hi cristiano,

I have made all the changes. Though i didn't get the 4th point. And are there any guidelines regarding Footer text, can i add my theme name with a link.

Thanks and regards

#22 @cristiano.zanca
16 months ago

Hi @orahmax ,

the 4th is about localization file languages/brood.pot generated by _s witch have general data Last-Translator and Language team that are to be personalized

# Copyright (C) 2015 Automattic
# This file is distributed under the GNU General Public License v2 or later.
msgid ""
msgstr ""
"Project-Id-Version: _s 1.0.0\n"
"Report-Msgid-Bugs-To: http://wordpress.org/tags/_s\n"
"POT-Creation-Date: 2015-06-12 21:51:31+0000\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"PO-Revision-Date: 2015-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"

In the footer you can solve with this code:

WordPress Theme by <a href="<?php echo esc_url( __('http://tidyhive.com/', 'brood'));?>" target="_blank"> Tidyhive</a>

After these changes if you want you can submit the next theme version so I can check the changes.

Kind Regards

#23 @themetracbot
16 months ago

  • Summary changed from THEME: Brood – 1.3.0 to THEME: Brood – 1.4.0

Brood - 1.4.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.4.0
ZIP - https://wordpress.org/themes/download/brood.1.4.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.3.0&new_path=brood/1.4.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.4.0/screenshot.png

#24 follow-up: @cristiano.zanca
16 months ago

Hi @orahmax ,

the menu is not working in 1.4 version, in 1.3 it works

It works only if a header image is used.

Can you please check why?

Kind Regards

Last edited 16 months ago by cristiano.zanca (previous) (diff)

#25 in reply to: ↑ 24 @orahmax
16 months ago

Hi @cristiano.zanca,

That was a minor issue. Menu dropdown wasn't working. Fixed.

#26 @orahmax
16 months ago

Waiting for your reply to make any further changes.

#27 @cristiano.zanca
16 months ago

Hi @orahmax ,

two simple issues:

1) /js/npm.js I think is removable
2) in footer http://i.imgur.com/n00uUtS.png the theme's must be separated from "by" and WordPress must have capital P.

If you want you can send a new version where I can check the solved menu issue and that could be the final one, before the next step.

Kind Regards

#28 @themetracbot
16 months ago

  • Summary changed from THEME: Brood – 1.4.0 to THEME: Brood – 1.5.0

Brood - 1.5.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.5.0
ZIP - https://wordpress.org/themes/download/brood.1.5.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.4.0&new_path=brood/1.5.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.5.0/screenshot.png

#29 @orahmax
15 months ago

Hi @cristiano.zanca ,

Please update me if any other change needs to be made.

Thanks

Last edited 15 months ago by orahmax (previous) (diff)

#30 @cristiano.zanca
15 months ago

  • Status changed from reviewing to approved

Hi @orahmax ,

for me the theme it's ok, now it will be checked in the final review.

If there will be something more to review we will check it again.

Thanks for submitting your theme

Kind Regards

Last edited 15 months ago by cristiano.zanca (previous) (diff)

#31 @greenshady
14 months ago

I'm doing the admin review for this theme. I will post back shortly with the results.

#32 @greenshady
14 months ago

  • Status changed from approved to reopened

#33 @greenshady
14 months ago

  • Status changed from reopened to reviewing

The following items must be cleaned up before the theme can go live.

WordPress Spelling

WordPress must be spelled correctly in all public-facing text. The correct spelling is "WordPress".

Currently, your footer shows "Proudly Powered by wordpress". Make sure to change this for the customizer option too.

Auto-adding the http:// for the copyright link is incorrect. This breaks for sites that use SSL. Let the user enter the http or https on their own.

That way, you can properly escape it with esc_url() in your footer.php template.

Translating footer text

This text cannot be translated in footer.php:

<span class="sep"> | </span>
	WordPress Theme by <a href="<?php echo esc_url( __('http://tidyhive.com/', 'brood'));?>" target="_blank">Tidyhive</a>

Translating customizer options

The defaults and labels for the customizer options need to be internationalized.

Storing theme options

Themes are only allowed to store a single database option. If you want to save multiple options, you need to save them as an array.

The recommended method is to simply store as theme mods. That way, storing as an array is already handled for you.

Use esc_url_raw()

In your copyright_url_sanitize() function, use esc_url_raw() (for saving to DB) instead of esc_url() (for escaping on output).

Missing internationalization

content.php:

<?php echo '<a href="'.get_permalink().'">Continue Reading</a>'; ?>

Also, wrap get_permalink() in esc_url().

searchform.php:

<input type="text" name="s" id="s" class="form-control" size="19" placeholder="Enter search text"/>

header.php:

<span class="sr-only">Toggle navigation</span>

Security Issue

In searchform.php, the $_SERVER variable can be exploited when unescaped.

<form id="searchform" class="search-form" method="get" action="<?php echo $_SERVER['PHP_SELF']; ?>">

Instead, use esc_url( home_url( '/' ) ).

Escaping

searchform.php - Use esc_attr_e() instead of _e():

<input type="submit" class="btn btn-cta" value="<?php _e('Search', 'brood'); ?>" />

rtl.css

Remove this file since it's not being used. Otherwise, it causes an additional HTTP request for RTL users.

Unsupported tags

These tags need to be removed from style.css since the theme doesn't support them:

  • fluid-layout
  • editor-style
  • post-formats
  • rtl-language-support

#34 @orahmax
14 months ago

I have taken note of issues, will update the theme soon.

#35 @themetracbot
14 months ago

  • Summary changed from THEME: Brood – 1.5.0 to THEME: Brood – 1.6.0

Brood - 1.6.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.6.0
ZIP - https://wordpress.org/themes/download/brood.1.6.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.5.0&new_path=brood/1.6.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.6.0/screenshot.png

#36 @greenshady
14 months ago

Not everything was corrected from my previous notes. I would allow the theme to pass with the issues to be fixed in the next update, but since one of the issues is security-related, we need to make sure to get this cleared up.

Translating footer text

This text still cannot be translated:

<span class="sep"> | </span>
	WordPress Theme by <a href="<?php echo esc_url( 'http://tidyhive.com/' );?>" target="_blank">Tidyhive</a>

Translating in the customizer

'title' => 'Footer Options',
            'description' => 'This is a Footer options section.',

'default' 			=> 	'Proudly powered by wordpress',

Translating in search form

Make sure to wrap the text string in esc_attr_e():

<input type="text" name="s" id="s" class="form-control" size="19" placeholder="<?php _e( 'Enter search text', 'brrod' ); ?>"/>

Always use esc_attr_e() (for outputting) or esc_attr__() (for returning) when translating an HTML attribute. Otherwise, you create a security issue that can be exploited.

Theme URI and Author URI (new)

I'm not sure why I overlooked this earlier. It's generally the first thing I check.

The Theme URI needs to link to a page specifically about the theme (a theme info page). We do not allow this to be a demo. It must have info about the theme we'll be hosting here on WordPress.org. Otherwise, this should be removed.

The Author URI should should be a valid link to an actual site. The site only shows this right now:

Welcome to tidyhive.com

#37 @orahmax
14 months ago

I have corrected the above issues except the last one related to link. My site will be live within a week.

  • So, can i keep the link ?
  • Is it alright to put theme link along with main site link in footer?

#38 @themetracbot
14 months ago

  • Summary changed from THEME: Brood – 1.6.0 to THEME: Brood – 1.7.0

Brood - 1.7.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL - http://brood.tidyhive.com/
Author URL - http://tidyhive.com/

SVN - https://themes.svn.wordpress.org/brood/1.7.0
ZIP - https://wordpress.org/themes/download/brood.1.7.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.6.0&new_path=brood/1.7.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.7.0/screenshot.png

#39 @themetracbot
14 months ago

  • Summary changed from THEME: Brood – 1.7.0 to THEME: Brood – 1.8.0

Brood - 1.8.0

Brood is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/brood/1.8.0
ZIP - https://wordpress.org/themes/download/brood.1.8.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brood/1.7.0&new_path=brood/1.8.0

History:

Ticket Summary Status Resolution Owner
#28496 THEME: Brood – 1.8.0 closed live cristiano.zanca

(this ticket)

#33192 THEME: Brood – 1.9.0 closed live themetracbot
#33193 THEME: Brood – 2.0.0 closed live themetracbot
#33202 THEME: Brood – 2.0.1 closed live themetracbot
#33244 THEME: Brood – 2.0.5 closed live themetracbot
#35921 THEME: Brood – 2.0.7 closed live themetracbot
#35922 THEME: Brood – 2.0.8 closed live themetracbot
#37042 THEME: Brood – 3.0.0 closed live themetracbot
#41514 THEME: Brood – 3.5.0 closed live themetracbot


https://themes.svn.wordpress.org/brood/1.8.0/screenshot.png

#40 @greenshady
14 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Everything looks good. When your site is live, you can re-add the links.

Please note that your Theme URI cannot be merely a link to a demo (e.g., http://brood.tidyhive.com/). It must link to a page with information specifically about the theme if used.

Last edited 14 months ago by greenshady (previous) (diff)
Note: See TracTickets for help on using tickets.