WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 20 months ago

#28535 closed theme (live)

THEME: Activello – 1.0.2

Reported by: silkalns Owned by: poena
Priority: new theme Keywords: theme-activello
Cc: silkalns

Description

Activello - 1.0.0

Activello description

Theme URL - http://Activello.com
Author URL -

SVN - https://themes.svn.wordpress.org/activello/1.0.0
ZIP - https://wordpress.org/themes/download/activello.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#28535 THEME: Activello – 1.0.2 closed live poena

(this ticket)

#30481 THEME: Activello2 – 3.0.1 closed not-approved poena
#32723 THEME: Activellon – 4.5.1 closed not-approved poena
#33408 THEME: Activello Child – 1.0.3 closed not-approved emiluzelac
#34739 THEME: ActivelloforUkrnavyTheme URI: https://colorlib.com/wp/themes/activello/ – 2.0.2 closed not-approved rabmalin
#36275 THEME: Activellonick – 1.0.3 closed not-approved djrmom
#36718 THEME: Activelloo – 2.3.2 closed not-approved rabmalin
#37037 THEME: Activello – 1.1.1 closed live themetracbot
#37883 THEME: Activellora – 3.3.3 closed not-approved rabmalin
#39489 THEME: Activello New – 1.1.2 closed not-approved rabmalin
#40260 THEME: Activello 2.0Theme URI: https://colorlib.com/wp/themes/activello/ – 2.0 closed not-approved rabmalin
#40261 THEME: Activello 3.0 Theme URI: https://colorlib.com/wp/themes/activello/ – 3.0 closed not-approved rabmalin
#40952 THEME: Activello – 1.2 closed live themetracbot
#40981 THEME: Activello – 1.2.1 closed live themetracbot
#41039 THEME: Activello – 1.2.2 closed live themetracbot
#41303 THEME: Activello – 1.2.3 closed live themetracbot
#42938 THEME: Activello – 1.3 closed live themetracbot
#42940 THEME: Activello – 1.3.1 closed live themetracbot
#43509 THEME: Activello test – 2.0.1 closed not-approved rabmalin
#44289 THEME: Activello my – 3.2.0 closed not-approved rabmalin
#44335 THEME: Activello – 1.3.2 closed live themetracbot
#44600 THEME: Activello – 1.3.3 closed live themetracbot
#45509 THEME: Activello – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/activello/1.0.0/screenshot.png

Change History (21)

#1 @poena
22 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
22 months ago

  • Cc silkalns added

Hi Arielle, do you represent Colorlib? I need to know if this theme was uploaded by mistake or not, since the theme URI is not working and Colorlib themes are usually uploaded from a different username.

https://colorlib.com/wp/themes/activello/

#3 @silkalns
22 months ago

@poena

I didn't submit this theme myself. But you can add me as an author for this and will take care of necessary change for this theme to make it WordPress.org compliant.

Is that possible as it would save a valuable place in review queue?

#4 @poena
22 months ago

  • Cc otto42 added

We can ask the admins. @Otto42, can this theme be moved to the correct author?

#5 @Otto42
22 months ago

No. If the theme was uploaded by somebody who does not represent the theme, then it should be closed and not-approved. If the theme is commercial or otherwise not free, then it will be deleted from our servers.

#6 @silkalns
22 months ago

I don't think that it will work as you will still have to change the author because I cannot upload my theme and I get duplicate error.

#7 @Otto42
22 months ago

Please explain the case here. Why was this theme uploaded by a different person than the author?

#8 @silkalns
22 months ago

Someone rushed before me because it was published on Github while I was working on it. It wasn't complete and ready for public debut.

#9 @Otto42
22 months ago

Is it ready now? Is it going to be ready in the next 7 days?

Because if not, then we'll close this ticket and you can submit it again later when you are ready. At that time, then I'll consider going in and manually adjusting the database to let you upload the theme, however if you're just trying to reserve this name in advance, then that's not okay.

Basically, I'm not going to go in and manually change things around unless you're immediately ready to take such actions that require me to do so.

Also consider that normally, we'd require you to change the theme's name if somebody else jumped the gun and took the name with their own theme. This is a special case since it's actually the same theme, but regardless, names in our system are first-come first-serve.

#10 @silkalns
22 months ago

Thank you for your patience and effort! I really appreciate it!

I am ready to submit this theme for review right away without hesitation.

#11 @Otto42
22 months ago

Okay. I have adjusted the theme to be associated with the user name "silkalns". You should be able to upload updated versions of this theme now.

#12 @themetracbot
22 months ago

  • Summary changed from THEME: Activello – 1.0.0 to THEME: Activello – 1.0.1

Activello - 1.0.1

Activello is a clean and minimal WordPress blog theme with premium look and feel well suited for food, fashion, travel, lifestyle, sports and any other awesome blogs. This theme features WooCommerce integration that allows you to create fully functional eCommerce website side by side with your blog. This theme has several customization options that are available WordPress Theme Customizer. Theme is also multilingual ready and translated in several languages. Activello is the only WordPress blog theme you will ever need.

Theme URL - https://colorlib.com/wp/themes/activello/
Author URL - http://colorlib.com

SVN - https://themes.svn.wordpress.org/activello/1.0.1
ZIP - https://wordpress.org/themes/download/activello.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activello/1.0.0&new_path=activello/1.0.1

History:

Ticket Summary Status Resolution Owner
#28535 THEME: Activello – 1.0.2 closed live poena

(this ticket)

#30481 THEME: Activello2 – 3.0.1 closed not-approved poena
#32723 THEME: Activellon – 4.5.1 closed not-approved poena
#33408 THEME: Activello Child – 1.0.3 closed not-approved emiluzelac
#34739 THEME: ActivelloforUkrnavyTheme URI: https://colorlib.com/wp/themes/activello/ – 2.0.2 closed not-approved rabmalin
#36275 THEME: Activellonick – 1.0.3 closed not-approved djrmom
#36718 THEME: Activelloo – 2.3.2 closed not-approved rabmalin
#37037 THEME: Activello – 1.1.1 closed live themetracbot
#37883 THEME: Activellora – 3.3.3 closed not-approved rabmalin
#39489 THEME: Activello New – 1.1.2 closed not-approved rabmalin
#40260 THEME: Activello 2.0Theme URI: https://colorlib.com/wp/themes/activello/ – 2.0 closed not-approved rabmalin
#40261 THEME: Activello 3.0 Theme URI: https://colorlib.com/wp/themes/activello/ – 3.0 closed not-approved rabmalin
#40952 THEME: Activello – 1.2 closed live themetracbot
#40981 THEME: Activello – 1.2.1 closed live themetracbot
#41039 THEME: Activello – 1.2.2 closed live themetracbot
#41303 THEME: Activello – 1.2.3 closed live themetracbot
#42938 THEME: Activello – 1.3 closed live themetracbot
#42940 THEME: Activello – 1.3.1 closed live themetracbot
#43509 THEME: Activello test – 2.0.1 closed not-approved rabmalin
#44289 THEME: Activello my – 3.2.0 closed not-approved rabmalin
#44335 THEME: Activello – 1.3.2 closed live themetracbot
#44600 THEME: Activello – 1.3.3 closed live themetracbot
#45509 THEME: Activello – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/activello/1.0.1/screenshot.png

#13 @Otto42
22 months ago

  • Reporter changed from arielletipa to silkalns

#14 @silkalns
22 months ago

@Otto42

Thank you for your time and effort!

#15 @poena
22 months ago

  • Cc arielle.tipa@… otto42 removed

Looks like a popular theme: I will close "Activello2" (ticket nr 30481) and start the review shortly.

#16 @poena
22 months ago

Hi again.
So here are the findings from my review. The theme has been tested against these guidelines: https://make.wordpress.org/themes/handbook/review/required/
There are a couple of things that needs to be fixed before your theme can be approved.
(Please post a reply or an update within 7 days, or your ticket will be closed due to inactivity. )

Required

Code
There must be no php or js errors
When I activate the category widget I get the following notice:
Notice: Undefined index: limit in themes\activello\inc\widgets\widget-categories.php on line 22

In index.php, line 19, you are missing a " after class="site-main <?php echo "page-".$paged;?>, breaking the html.

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
In functions.php, please prefix get_single_category()
navwalker.php: wp_bootstrap_navwalker
socialnav.php: register_social_menu
extras.php: custom_password_form

Please remove any and all code that is not used.
You forgot to remove the scripts for the instagram widget.
In extras.php, I think activello_footer_links() and activello_add_favicon() can be removed?
wpcom.php and woo_setup.php does not seem to be used (and the wpcom probably shouldn't be used for .org :) ).
The function activello_woo_setup() is duplicated, it is also in functions.php.

Core Functionality and Features
Use WordPress functionality and features first, if available.
In header.php, you need to replace the hard coded search form with get_search_form().

Sanitizing and escaping
In widget-categories.php and widget-recent-posts.php you are escpaing the data on output in the widget form, but
not on output when the widget is displayed in the theme.
Please sanitize the title (esc_html) and limit (make sure it is a number) before saving.

In metaboxes.php, sanitize the

$_POST['site_layout']

before saving (line 97)

All options need to be escaped in output, including the colors in the css in get_activello_theme_setting().
In footer.php line 21: please escape the get_theme_mod( 'activello_footer_copyright', 'Activello' );

Scripts and styles
You can use minified js and css, but you need to include the original, non-minified versions as well.
Missing the original version of font-awesome.min.css, bootstrap.min.js, flexslider.min.js, modernizr.min.js

Fuctionality
When I activate the slider and there are posts in the category that doesn't have featured images, the code for the slider is printed and it is running, but it is also 'invisible'. The slider seems to adjust it's height to the height of the image?

Language
These texts needs to be made translatable:
header.php, line 40: Toggle navigation
searchform.php line 14, search
extras.php line 54, Untitled
navwalker.php line 196, Add a menu
metaboxes.php line 58, Default

Translated text in attributes needs to be escaped.
There are 4 placeholders in comments.php line 77 and forward where the translated text needs to be escaped.

Licenses
The list of licenses in the readme.txt seem to be incomplete, neither glyphicons halflings or modernizr are included.

Documentation
Any custom features, options or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided.
Please include some documentation or help on how to set up the social widget. It doesn't say that you also need to activate the social menu, so it's a little confusing.

Upsell
Please remove your twitter and facebook links and the documentation link. You can re-add the documentation link when the page is ready.

#17 @silkalns
22 months ago

@poena

Thank you for your detailed review!

Will make sure to fix everything and resubmit updated version.

#18 @themetracbot
21 months ago

  • Summary changed from THEME: Activello – 1.0.1 to THEME: Activello – 1.0.2

Activello - 1.0.2

Activello is a clean and minimal WordPress blog theme with premium look and feel well suited for food, fashion, travel, lifestyle, sports and any other awesome blogs. This theme features WooCommerce integration that allows you to create fully functional eCommerce website side by side with your blog. This theme has several customization options that are available WordPress Theme Customizer. Theme is also multilingual ready and translated in several languages. This awesome blog theme is also SEO friendly helping you to achieve the highest positions on Google. Activello is the only WordPress blog theme you will ever need.

Theme URL - https://colorlib.com/wp/themes/activello/
Author URL - http://colorlib.com

SVN - https://themes.svn.wordpress.org/activello/1.0.2
ZIP - https://wordpress.org/themes/download/activello.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activello/1.0.1&new_path=activello/1.0.2

History:

Ticket Summary Status Resolution Owner
#28535 THEME: Activello – 1.0.2 closed live poena

(this ticket)

#30481 THEME: Activello2 – 3.0.1 closed not-approved poena
#32723 THEME: Activellon – 4.5.1 closed not-approved poena
#33408 THEME: Activello Child – 1.0.3 closed not-approved emiluzelac
#34739 THEME: ActivelloforUkrnavyTheme URI: https://colorlib.com/wp/themes/activello/ – 2.0.2 closed not-approved rabmalin
#36275 THEME: Activellonick – 1.0.3 closed not-approved djrmom
#36718 THEME: Activelloo – 2.3.2 closed not-approved rabmalin
#37037 THEME: Activello – 1.1.1 closed live themetracbot
#37883 THEME: Activellora – 3.3.3 closed not-approved rabmalin
#39489 THEME: Activello New – 1.1.2 closed not-approved rabmalin
#40260 THEME: Activello 2.0Theme URI: https://colorlib.com/wp/themes/activello/ – 2.0 closed not-approved rabmalin
#40261 THEME: Activello 3.0 Theme URI: https://colorlib.com/wp/themes/activello/ – 3.0 closed not-approved rabmalin
#40952 THEME: Activello – 1.2 closed live themetracbot
#40981 THEME: Activello – 1.2.1 closed live themetracbot
#41039 THEME: Activello – 1.2.2 closed live themetracbot
#41303 THEME: Activello – 1.2.3 closed live themetracbot
#42938 THEME: Activello – 1.3 closed live themetracbot
#42940 THEME: Activello – 1.3.1 closed live themetracbot
#43509 THEME: Activello test – 2.0.1 closed not-approved rabmalin
#44289 THEME: Activello my – 3.2.0 closed not-approved rabmalin
#44335 THEME: Activello – 1.3.2 closed live themetracbot
#44600 THEME: Activello – 1.3.3 closed live themetracbot
#45509 THEME: Activello – 1.3.6 closed live themetracbot


https://themes.svn.wordpress.org/activello/1.0.2/screenshot.png

#19 @silkalns
21 months ago

@poena

Thank you for your patience! I have submitted updated version of this theme as well as wrote a documentation with several videos.

Let me know if there is anything else that needs to be changes or improved.

#20 @poena
21 months ago

  • Status changed from reviewing to approved

Hi
All required issues have been fixed. I will mark the theme as approved, and an admin will have a final look.

#21 @jcastaneda
20 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations! Your theme is live!

Note: See TracTickets for help on using tickets.