Make WordPress Themes

Opened 2 months ago

Closed 2 months ago

#290412 closed theme (not-approved)

THEME: Tema Institucional – 1.3.2

Reported by: caoszone Owned by: franchidesign
Priority: previously reviewed Keywords: theme-tema-institucional
Cc: rafael@…

Description

Tema Institucional - 1.3.0

Tema institucional base para portais de universidades federais.

Theme URL -
Author URL - ​https://dti.unilab.edu.br/

Trac Browser - https://themes.trac.wordpress.org/browser/tema-institucional/1.3.0
WordPress.org - ​https://wordpress.org/themes/tema-institucional/

SVN - ​https://themes.svn.wordpress.org/tema-institucional/1.3.0
ZIP - ​https://downloads.wordpress.org/theme/tema-institucional.1.3.0.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [348265] https://themes.trac.wordpress.org/changeset?old_path=tema-institucional/1.2&new_path=tema-institucional/1.3.0

History:

Ticket Summary Status Resolution Owner
#279273 THEME: Tema Institucional – 1.0.0 closed not-approved bijayyadav
#283704 THEME: Tema Institucional – 1.1.0 closed not-approved bijayyadav
#286335 THEME: Tema Institucional – 1.2 closed not-approved fahimmurshed
#290412 THEME: Tema Institucional – 1.3.2 closed not-approved franchidesign

(this ticket)

#292531 THEME: Tema Institucional – 1.6.3 closed live franchidesign


https://themes.svn.wordpress.org/tema-institucional/1.3.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (4)

#2 @themetracbot
2 months ago

  • Keywords accessibility-ready removed
  • Summary THEME: Tema Institucional – 1.3.1 → THEME: Tema Institucional – 1.3.2

#3 @franchidesign
2 months ago

  • Owner set to franchidesign
  • Status new → reviewing

#4 @franchidesign
2 months ago

  • Resolution → not-approved
  • Status reviewing → closed

Hi @caoszone,

I have look at the theme and at this point, it does not follow the requirements. The Theme Review Team does not hard reject themes, we want you to resubmit your theme, but we need you to read the requirements more carefully...

Theme Check passed. This is a classic PHP theme, so skip links, the Your latest posts front-page setting, and Customizer Background must work on the front end.

Required

1. Skip link is not visible on keyboard focus
​https://make.wordpress.org/themes/handbook/review/required/#accessibility

header.php outputs a skip link (href="#conteudo") and #conteudo exists. On Tab, the link does not appear.

Cause: .skip-link also has .screen-reader-text. .skip-link:focus only moves left/top. .screen-reader-text still uses clip / clip-path and has no :focus unclip (style.css).

Right after that, template-parts/acessibilidade.php outputs four more links inside #acessibilidade.ocultar. .ocultar clips them (lib/macisso/css/grades-e-estruturas.css) but they stay in the tab order, so the first several Tab stops are invisible.

A conforming skip link must be the first focusable control, visible on focus, and move focus to the main content.

2. “Your latest posts” as the homepage does not show the posts index
​https://make.wordpress.org/themes/handbook/review/required/#classic-themes

There is no home.php or front-page.php. With Settings → Reading → Your latest posts, WordPress uses index.php.

The default branch of index.php is not the main Loop. It always loads the institutional landing (noticias-por-banner, noticias-por-card, noticias-por-link, atalhos). Extra WP_Query calls look for categories such as banner-principal. The Reading setting is ignored.

If a static front page is used and a Posts page is assigned, that posts page also falls through to this landing, because home.php is missing.

The front page must show latest posts when that Reading option is selected. A marketing home belongs on a static front page (or a user-chosen template), not in place of the posts index.

3. Custom Background color and image do not apply
​https://make.wordpress.org/themes/handbook/review/required/#functionality-and-features

functions.php registers custom-background (default f5f6f9). Core prints the color/image on body.custom-background.

The visible canvas is #site, which is painted with background: var(--cor-de-fundo-da-pagina) (#F5F6F9) in dist/css/tema.css. #template is also forced to full viewport height in style.css. Body background never shows.

If the theme keeps this support, Customizer background color and image must actually appear. If they should not, remove custom-background support so the controls are not offered.

The same applies to custom-header in functions.php: Header Image appears in the Customizer, but no template calls get_header_image() / the_custom_header_markup().

4. Front-end copyright is the theme author’s, not the user’s
​https://make.wordpress.org/themes/handbook/review/required/#licensing-copyright

template-parts/rodape.php prints SPA/DSI/DTI/UNILAB plus © 2021/…. tema_institucional_proteger_creditos() restores that block if the signature is removed. Front-end copyright must be the user’s (site name / site owner), not the theme author’s. A credit link is optional and must not be forced.

5. More than one front-facing credit link
​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

Allowed: one link to Theme URI or Author URI (https://dti.unilab.edu.br/ is Author URI). Footer already uses that.

When a custom logo is set, template-parts/custom-logo.php always adds a second link to https://unilab.edu.br with a bundled Unilab logo. That is a second credit/branding link. Remove it, or make both the extra logo and the extra URL optional and off by default.

6. Incomplete Resources list
​https://make.wordpress.org/themes/handbook/review/required/#licensing-copyright

readme.txt lists Alegreya Sans, Bootstrap, Navwalker, Camera, Easing, Font Awesome, and MaCiSSo, plus a generic “theme images” line. Bundled images still need individual source/license/copyright, including at least:

  • screenshot.png (or .jpg)
  • assets/img/logo-unilab.png
  • assets/icon/ (android-chrome-*.png, apple-touch-icon.png, favicon-16x16.png, favicon-32x32.png)
  • Camera assets under lib/jquery-camera/images/ (sem-imagem.jpg, blank.gif, camera-loader.gif, camera_skins.png)

7. Unprefixed public names
​https://make.wordpress.org/themes/handbook/review/required/#code

Examples: post meta prefacio, metabox id custom-field-code (functions.php), script handle tema-sidebar-menu (dist/js/sidebar-menu.js). Prefix with the theme slug (four or more characters), e.g. tema_institucional_. Third-party Navwalker can keep its upstream names.

8. Admin CSS loads on every admin screen
​https://make.wordpress.org/themes/handbook/review/required/#theme-settings-pages-and-onboarding

tema_institucional_admin_assets() on admin_enqueue_scripts enqueues inline CSS globally. Scope it with $hook_suffix (or equivalent) so it does not leak.

9. Comments on pages
​https://make.wordpress.org/themes/handbook/review/theme-unit-test/

single.php calls comments_template(). page.php does not. If comments are open on a page, they must display.

10. Unescaped search query in the search form
​https://make.wordpress.org/themes/handbook/review/required/#code

searchform.php uses echo get_search_query(). Escape on output, e.g. esc_attr( get_search_query() ).

Recommended

  • #conteudo has role="main" and wraps another <main> (header.php). Use one main landmark.
  • lib/navwalker/ still ships composer.lock, tests/, CODE_OF_CONDUCT.md, etc. Drop files that are not needed to run the theme.
  • site.webmanifest plus bundled favicon/app icons look like PWA/favicon setup. Site icons should come from Settings → General / Site Icon, not from the theme.
  • header.php still outputs a hardcoded meta name="author". Leave SEO metadata to core/plugins.
  • tema_institucional_customize_register() returns immediately and is unused dead code.

Please read the full required list before the next upload: ​​https://make.wordpress.org/themes/handbook/review/required/

Regards,
Denis

Note: See TracTickets for help on using tickets.