WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 20 months ago

#29323 closed theme (live)

THEME: Tora – 1.07

Reported by: vladff Owned by: WPDevHQ
Priority: new theme Keywords: theme-tora
Cc: flyfreemedia@…

Description

Tora - 1.01

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.01
ZIP - https://wordpress.org/themes/download/tora.1.01.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.01/screenshot.png

Attachments (1)

ExcerptLength.png (7.8 KB) - added by WPDevHQ 21 months ago.
Field is non functional

Download all attachments as: .zip

Change History (30)

#1 @themetracbot
22 months ago

  • Summary changed from THEME: Tora – 1.01 to THEME: Tora – 1.02

Tora - 1.02

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.02
ZIP - https://wordpress.org/themes/download/tora.1.02.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=tora/1.01&new_path=tora/1.02

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.02/screenshot.png

#2 @themetracbot
22 months ago

  • Owner set to davide_entratici
  • Status changed from new to reviewing

#3 @davide_entratici
22 months ago

Hi Author, my name is David, I begin to review your theme!

#4 @vladff
22 months ago

Hi,

Looking forward to your review :)

Vlad

#5 @vladff
22 months ago

Hi,

Any news regarding the review?

Vlad

This ticket was mentioned in Slack in #themereview by vladff. View the logs.


22 months ago

#7 @grapplerulrich
22 months ago

  • Owner davide_entratici deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

This ticket was mentioned in Slack in #themereview by wpdevhq. View the logs.


22 months ago

#9 @grapplerulrich
22 months ago

  • Owner set to WPDevHQ

#10 @WPDevHQ
22 months ago

Hello @vladff,

Review in Process

I will be reviewing your theme and post my feedback as soon as possible.

  • The review will be based on the Theme Review Handbook.
  • Following feedback you'll be required to fix all items marked as Required (if any) and give consideration to recommended items.
  • Once you have made the necessary changes you'll need to submit a revised version via Theme uploder
    • For a successful upload you will need to change the Version tag in your style.css
    • Once uploaded the new version will be attached to this ticket.
    • I will then continue with the review.
  • The above process will be repeated until there remains no issues that are marked as Required.
  • Theme will be approved and moved to a new Que where an Admin will double check the review.
  • If the Admin checks return satisfactory the theme will be set to live and be available in the repository.
  • Should the Admin(s) deem the review to be incomplete the ticket will be reopened with notes and what needs fixing.
  • At any time should you have any questions please feel free to ask.

Thanks.
Zulf @WPDevHQ

#11 @WPDevHQ
22 months ago

Hello @vladff,

Initial Outcome

  • Theme left as reviewing for 7 days, and it may be closed after that if there is no response. Note that if you need more time, please make a comment in the ticket.
  • Not ready for approval for the following reasons.

General Check.
Required:

  • Please include the theme's copyright declaration in either the head of style.css or the readme file.
  • Theme tags: Please make sure that the tags used in style.css to represent the theme correctly. I could not find theme specific styles for the tag sticky post.

Code Check.
Required:

  • Please remove trailing whitespace from the end of all files especially the ones with a closing ?> tag. See Coding standards
  • File: header.php - Use a conditional check for pingback. See below
    <?php if ( is_singular() && pings_open( get_queried_object() ) ) : ?>
        <link rel="pingback" href="<?php bloginfo( 'pingback_url' ); ?>">
    <?php endif; ?>
    
  • File: functions-header.php - The text strings in the tora_header_text function need to be internationalized.
  • File: functions-footer.php - url @line 37 needs to be escapped correctly
  • File: class-tgm-plugin-activation.php uses the wrong textdomain - please go to TGM Generator to get a theme specific copy.
  • File: default.php: All public facing text strings must be internationalized.
  • File: customizer.php - Please note that esc_attr is not an input sanitization method but rather an escaping method for data output, Use appropriate sanitization methods such as sanitize_text_field for text fields, absint for numbers e.t.c

For the above follow this Codex and have a read at this post: A Guide to Writing Secure Themes

  • File: customizer.php - Themes are required to use/support core functions first if available. Custom logo is now a core function and should be used in this instance. You can do so by adding the code below inside a function callback hooked to the after_setup_theme action
        add_theme_support( 'custom-logo', array(
            'height'      => 250,
            'width'       => 75,
            'flex-height' => true,
        ) );
    

Recommended:

  • File: functions.php - The html5.js is better off enqueued as below inside the tora_scripts function instead of in a function callback hooked to the wp_head action
    wp_enqueue_script( 'tora-html5shiv', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' );
            wp_script_add_data( 'tora-html5shiv', 'conditional', 'lt IE 9' );
    
  • File: functions.php - You can enqueue tora-bootstrap from within the tora_scripts function. You do not need to have two sets of wp_enqueue_scripts actions.

Post Installation.

Required:

  • Upon theme activation the front end does not load. This is due to a Syntax error in your main.min.js...To resolve the issue change jQuery(function(e){e("a[href*=#]:not([href=#],.wc-tabs a,.activity-content a)") to jQuery(function(e){e('a[href*="#"]:not([href="#"],.wc-tabs a,.activity-content a)')
  • Customizer - The excerpt length selector does not seem to work.

Please address all of the required issues and give consideration to the recommended ones. Once done, upload a revised version for further consideration.

#12 @vladff
21 months ago

Hi Zulf,

Thank you very much for your review. I've handled most of your points and would like to clarify the rest before re-uploading:

  • theme copyright is declared in both the style.css and the readme file. Unless I'm missing something more I should declare.
  • File: functions-footer.php - url @line 37 needs to be escapped correctly : I believe it is escaped correctly as the value being escaped consists of text+url. That's how it's done in Underscores.
  • Customizer - The excerpt length selector does not seem to work. : Can you recheck please? It seems to work fine for me.

Thank you again for your time.

Regards,
Vlad

#13 @WPDevHQ
21 months ago

Replying to vladff:

Hi Zulf,

Hello Vlad.

Thank you very much for your review. I've handled most of your points and would like to clarify the rest before re-uploading:

  • theme copyright is declared in both the style.css and the readme file. Unless I'm missing something more I should declare.

    Sorry but I'm not seing the declaration. It should be something like the below format as part of the license declaration

YourThemeName
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Copyright (C) 2016 WPDevHQ http://wpdevhq.com/
  • File: functions-footer.php - url @line 37 needs to be escapped correctly : I believe it is escaped correctly as the value being escaped consists of text+url. That's how it's done in Underscores.

    My mistake there, doen't need to be escaped as its hard coded :)

  • Customizer - The excerpt length selector does not seem to work. : Can you recheck please? It seems to work fine for me.

    Still not working for me on both Firefox and Chrome. The field is blank (see screenshot) and clicking the up/down has no effect. Couldn't even enter a value manually.

Thank you again for your time.

You are most welcome :)

Regards,
Vlad

Regards,
Zulf @WPDevHQ

@WPDevHQ
21 months ago

Field is non functional

#14 @themetracbot
21 months ago

  • Summary changed from THEME: Tora – 1.02 to THEME: Tora – 1.04

Tora - 1.04

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.04
ZIP - https://wordpress.org/themes/download/tora.1.04.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=tora/1.02&new_path=tora/1.04

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.04/screenshot.png

#15 @vladff
21 months ago

Hi,

Well, I've added the copyright line in the readme file. The license was already declared there.

Sorry about the mix-up with the excerpt length, I already had all Customizer number inputs fixed in my local copy so couldn't the issue.

Regards,
Vlad

#16 @WPDevHQ
21 months ago

Hello Vlad,

Thank you for the update - the fixes look good.

Just a couple of items that needs fixing/looking at then we should be good fo approval

Required:

  • File: functions-header.php - missing textdomain for lines 29 to 32
  • File: functions-header.php - Not sure what's going on @lines 116 to 118, Are those supposed be translatable strings? If so textdomain should be tora instead of Tora

This is not a deal breaker but a recommended best practice:

  • Always put spaces before and after strings like below - see Space Usage
Last edited 21 months ago by WPDevHQ (previous) (diff)

#17 @themetracbot
21 months ago

  • Summary changed from THEME: Tora – 1.04 to THEME: Tora – 1.05

Tora - 1.05

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.05
ZIP - https://wordpress.org/themes/download/tora.1.05.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=tora/1.04&new_path=tora/1.05

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.05/screenshot.png

#18 @vladff
21 months ago

Hi,

File: functions-header.php - Not sure what's going on @lines 116 to 118, Are those supposed be translatable strings? If so textdomain should be tora instead of Tora

Nope, it's just Polylang compatibility. Tora is not meant as a textdomain there, it's there in order to show up in the plugin's interface.

Regards,
Vlad

#19 @themetracbot
21 months ago

  • Summary changed from THEME: Tora – 1.05 to THEME: Tora – 1.06

Tora - 1.06

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.06
ZIP - https://wordpress.org/themes/download/tora.1.06.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=tora/1.05&new_path=tora/1.06

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.06/screenshot.png

#20 @WPDevHQ
21 months ago

  • Status changed from reviewing to approved

Thanks for the update and clarification Vlad.

All looks good to me so approving subject to Admin final audit.

Good luck,
Zulf

#21 @greenshady
20 months ago

I'm taking on the admin review.

#22 @greenshady
20 months ago

  • Status changed from approved to reopened

Overall, this is one of the better themes I've seen come through here. We just have a few issues that need addressing.

License

I couldn't find any information on your site about the licensing of your pro themes. Can you please confirm the licensing for them? Also, it would be helpful if you added licensing info on your site.

WordPress.org requires that themes on your site be 100% GPL or compatible.

Demo Content

You need to disable the demo content from appearing:

  • Header business info
  • Banner text on front page

Font Option

This is not an acceptable way to have font options:

<link href='https://fonts.googleapis.com/css?family=Lato:400,400italic,700,700italic' rel='stylesheet' type='text/css'>

Themes must properly enqueue any stylesheets. You can have a drop-down of fonts or something like that. Then, you can enqueue the font stylesheet correctly.

#23 @greenshady
20 months ago

  • Status changed from reopened to reviewing

#24 @vladff
20 months ago

Thank you.

Just a quick remark before I reupload: The fonts are actually not loaded in the <link...> format. That's just how the user inputs his fonts selection as I find it to be the most flexible way possible. Then I'm running str_replace on that value and the actual resulting enqueue is in this format: wp_enqueue_style( 'tora-body-fonts', '//fonts.googleapis.com/css?family=Lato:400,400italic,700,700italic' );

I'll add a note in the footer that all themes are GPL.

#25 @greenshady
20 months ago

I see that. But, that method is broken altogether. The user can literally add anything as long as it contains the //fonts.googleapis.com/css?family string.

Having the user add *only* the URL is fine. That way, you can properly sanitize it with esc_url_raw() and escape it with esc_url(). But, you shouldn't be allowing arbitrary HTML that's not sanitized or validated into the DB. What you get when you call get_theme_mod() might not be the data you're looking for at all.

There are also far cleaner methods for loading multiple fonts. You really should only be hitting Google's servers with one HTTP request rather than multiple requests. That's not necessarily against the guidelines, so I didn't bring it up in the review.

#26 @themetracbot
20 months ago

  • Summary changed from THEME: Tora – 1.06 to THEME: Tora – 1.07

Tora - 1.07

Tora is an elegant and responsive business theme. You will find lots of options in the Customizer including fonts, colors, blog options, header options, sidebar position etc. Tora comes with support for the Live Composer plugin so you can quickly create amazing pages for your website. Premade layouts are also available so you can get a quickstart and have your website ready in a very small amount of time.

Theme URL - http://theme.blue/themes/tora
Author URL - http://theme.blue

SVN - https://themes.svn.wordpress.org/tora/1.07
ZIP - https://wordpress.org/themes/download/tora.1.07.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=tora/1.06&new_path=tora/1.07

History:

Ticket Summary Status Resolution Owner
#29323 THEME: Tora – 1.07 closed live WPDevHQ

(this ticket)

#34401 THEME: Tora – 1.08 closed live themetracbot
#35508 THEME: Tora – 1.09 closed live themetracbot
#48815 THEME: Toraddd – 5.0 closed not-approved Mahesh901122


https://themes.svn.wordpress.org/tora/1.07/screenshot.png

#27 @vladff
20 months ago

Yeah, makes sense about the fonts. I've switched to using URLs.

Also added some other changes I had prepared for the next update. Full changelog:

  • Fixed fullwidth single post
  • Fixed static menu option
  • Changed font options
  • Added backwards compat. for site logo (for users that downloaded until the theme review)
  • Disabled default content for header info and text

I also added the GPL statement on the site in the footer.

#28 @vladff
20 months ago

Hi,

Any news here?

Vlad

#29 @greenshady
20 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Changes look good!

Note: See TracTickets for help on using tickets.