WordPress.org

Make WordPress Themes

#29345 closed theme (live)

THEME: Travel Eye – 1.3

Reported by: wenthemes Owned by: Kenshino
Priority: new theme Keywords: theme-travel-eye
Cc: wenthemes@…, greenshady

Description

Travel Eye - 1.0.0

Simple Travel theme.

Theme URL -
Author URL - http://wenthemes.com/

SVN - https://themes.svn.wordpress.org/travel-eye/1.0.0
ZIP - https://wordpress.org/themes/download/travel-eye.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#29345 THEME: Travel Eye – 1.3 closed live Kenshino

(this ticket)

#33232 THEME: Travel Eye – 1.4 closed live themetracbot
#33317 THEME: Travel Eye12312312 – 1.8 closed not-approved emiluzelac
#33383 THEME: Travel Eye – 1.5 closed live themetracbot
#34805 THEME: Travel Eye – 1.6 closed live themetracbot
#34914 THEME: Travel Eye – 1.6.1 closed live themetracbot
#35673 THEME: Travel Eye – 1.6.2 closed live themetracbot
#38396 THEME: Travel Eye – 1.6.3 closed live themetracbot
#45132 THEME: Travel Eye – 1.6.4 closed live themetracbot


https://themes.svn.wordpress.org/travel-eye/1.0.0/screenshot.png

Change History (32)

#1 @themetracbot
19 months ago

  • Summary changed from THEME: Travel Eye – 1.0.0 to THEME: Travel Eye – 1.1

Travel Eye - 1.1

Travel Eye is a clean and professional Travel WordPress Theme. This Theme is ideal for travel agencies, hotels, tour operators or any other organization related to travel and tours. It is powered by Page Builder by Site Origin, so drag-and-drop feature will be very handy to customize the page layout as you want. It has Theme Options panel based on powerful Customizer API which makes theme pretty easy to customize and configure. Prebuilt layout is available for home page so you can get your page layout in one click. Official Support Forum: http://themepalace.com/support-forum/ Full Demo: http://demo.wenthemes.com/travel-eye/

Theme URL - http://themepalace.com/downloads/travel-eye/
Author URL - http://wenthemes.com/

SVN - https://themes.svn.wordpress.org/travel-eye/1.1
ZIP - https://wordpress.org/themes/download/travel-eye.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=travel-eye/1.0.0&new_path=travel-eye/1.1

History:

Ticket Summary Status Resolution Owner
#29345 THEME: Travel Eye – 1.3 closed live Kenshino

(this ticket)

#33232 THEME: Travel Eye – 1.4 closed live themetracbot
#33317 THEME: Travel Eye12312312 – 1.8 closed not-approved emiluzelac
#33383 THEME: Travel Eye – 1.5 closed live themetracbot
#34805 THEME: Travel Eye – 1.6 closed live themetracbot
#34914 THEME: Travel Eye – 1.6.1 closed live themetracbot
#35673 THEME: Travel Eye – 1.6.2 closed live themetracbot
#38396 THEME: Travel Eye – 1.6.3 closed live themetracbot
#45132 THEME: Travel Eye – 1.6.4 closed live themetracbot


https://themes.svn.wordpress.org/travel-eye/1.1/screenshot.png

#2 @themetracbot
19 months ago

  • Owner set to csehasib
  • Status changed from new to reviewing

#3 follow-up: @csehasib
19 months ago

Hello themetracbot,
Your theme file is more than default maximum file size of WordPress theme requirements. I have attached the screenshot for file size issue. Please deduct your all images file for or magnify code.

https://s29.postimg.org/nqcayi4g7/large_file.png

Also follow bellows steps:
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.

INFO: init.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

INFO: customizer.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

INFO: class-tgm-plugin-activation.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Thanks
Hasibul Islam

Last edited 18 months ago by Otto42 (previous) (diff)

#4 @wenthemes
19 months ago

Hello @csehasib

Thanks for taking our theme for review. Maximum allowed theme size in dot org repo is 25MB. Our theme is only 2.2 MB. Can you please re-configure your ini file and install again?
Regarding other points: INFO and RECOMMENDED are only recommended points. Themes are not rejected based on those points. Please review theme according to the TRT guideline and post comments. We will resolve issues are re-upload our updated theme.

Regards,

#5 @csehasib
19 months ago

Thanks,
"Recommended" are won’t be a grounds to not approve, but they are good theme practice. So just fix recommended issue and re-upload the theme.

#6 @wenthemes
19 months ago

Ok, we will surely fix issues. Can you please post detailed comment so that it will be easy for us to resolve all issues at once?

#7 @wenthemes
18 months ago

Hello @csehasib , waiting for your review comments. Thanks.

#8 @csehasib
18 months ago

Recommended. You can then list all the recommended items. These won’t be a grounds to not approve, but they are good theme practice.

Fix it and upload again.

This ticket was mentioned in Slack in #themereview by rabmalin. View the logs.


18 months ago

#10 in reply to: ↑ 3 @hardeepasrani
18 months ago

Replying to csehasib:

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

It totally up to the user if he wants to add that or not, just like featured images and other features. If he doesn't then you it's just fine, and most of the themes don't add this feature.

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.

Theme is using text-domain properly. This message will always appear in theme check plugin.

INFO: init.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

INFO: customizer.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

INFO: class-tgm-plugin-activation.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

All of these aren't section, so the theme is including it properly.

Apart from that, if you could find an issue then please report it here to the user else you should mark this theme as approved for the final review.

And max file size was an issue with your server. Thank you. :)

This ticket was mentioned in Slack in #themereview by wenthemes. View the logs.


18 months ago

#12 @Kenshino
18 months ago

@csehasib Please do a full review. A review does not just consist of running the theme check plugin.

Read https://make.wordpress.org/themes/handbook/review/ and the following pages on what you need to do to finish a full review.

You will have to review the code line by line.

For example:

Required

metabox.php

  • When you save meta box, do not trust that $_POST is clean. Please save it with wp_kses or wp_kses_post

content.php

  • You can probably just escape here - wp_kses is overkill

This ticket was mentioned in Slack in #themereview by wenthemes. View the logs.


18 months ago

This ticket was mentioned in Slack in #meta by kenshino. View the logs.


18 months ago

This ticket was mentioned in Slack in #themereview by kenshino. View the logs.


18 months ago

#16 @emiluzelac
18 months ago

  • Owner changed from csehasib to kenshino

This ticket was mentioned in Slack in #themereview by kenshino. View the logs.


18 months ago

#18 @chipbennett
18 months ago

  • Owner changed from kenshino to Kenshino

#19 @Kenshino
18 months ago

Oh my there was so.... much code base ;/ It took awhile to read it all

Required

metabox.php

  • When you save meta box, do not trust that $_POST is clean. Please save it with wp_kses or wp_kses_post

author-bio.php

  • Escape get_avatar

init.php

You should really use require_once for files that you use to load functions only.

content.php

  • You can probably just escape here - wp_kses is overkill

control.php

  • Line 198 - you're echoing a void function

custom.php

  • Line 621 - You should escape stuff right before you use / echo them. So line 620 isn't needed

custom.js and possibly other js files

Parse your selector into a variable if you're gonna call it more than once so that the DOM only needs to be transversed once :)

breadcrumbs.php

  • Line 32 - You declare a void method but it actually returns

style.css

  • Line 286 - extra comma

#20 @themetracbot
18 months ago

  • Summary changed from THEME: Travel Eye – 1.1 to THEME: Travel Eye – 1.2

Travel Eye - 1.2

Travel Eye is a clean and professional Travel WordPress Theme. This Theme is ideal for travel agencies, hotels, tour operators or any other organization related to travel and tours. It is powered by Page Builder by Site Origin, so drag-and-drop feature will be very handy to customize the page layout as you want. It has Theme Options panel based on powerful Customizer API which makes theme pretty easy to customize and configure. Prebuilt layout is available for home page so you can get your page layout in one click. Official Support Forum: http://themepalace.com/support-forum/ Full Demo: http://demo.wenthemes.com/travel-eye/

Theme URL -
Author URL - http://wenthemes.com/

SVN - https://themes.svn.wordpress.org/travel-eye/1.2
ZIP - https://wordpress.org/themes/download/travel-eye.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=travel-eye/1.1&new_path=travel-eye/1.2

History:

Ticket Summary Status Resolution Owner
#29345 THEME: Travel Eye – 1.3 closed live Kenshino

(this ticket)

#33232 THEME: Travel Eye – 1.4 closed live themetracbot
#33317 THEME: Travel Eye12312312 – 1.8 closed not-approved emiluzelac
#33383 THEME: Travel Eye – 1.5 closed live themetracbot
#34805 THEME: Travel Eye – 1.6 closed live themetracbot
#34914 THEME: Travel Eye – 1.6.1 closed live themetracbot
#35673 THEME: Travel Eye – 1.6.2 closed live themetracbot
#38396 THEME: Travel Eye – 1.6.3 closed live themetracbot
#45132 THEME: Travel Eye – 1.6.4 closed live themetracbot


https://themes.svn.wordpress.org/travel-eye/1.2/screenshot.png

#21 @wenthemes
18 months ago

Hello @Kenshino

All issues have been fixed except few. Please check again and provide comments.

  • breadcrumbs.php - This is external library by Justin. So, I am reluctant to modify that core file from external library.
  • get_avatar - This is not escaped as WP core will handle itself.

Thanks

#22 @chipbennett
18 months ago

  • Cc greenshady added

@wenthemes I haven't looked at the specific issue with breadcrumbs.php raised by @Kenshino, but in general, you're still responsible for issues with included, external libraries. So, if there's an issue with that code, you'll need to address it. (It might be helpful to ping @greenshady, as well, since it's his library.)

#23 @greenshady
18 months ago

The breadcrumbs inline docs should say return void|string. I think we can all live with a trivial inline doc bug until the next update. :)

#24 @wenthemes
18 months ago

Yes, I understand that for any code in our theme, we should be responsible. But this is trivial issue as mentioned by @greenshady in earlier comment. If it is critical, we will surely fix even if it is third party libraries.

Thanks

#25 @wenthemes
18 months ago

@Kenshino New update coming with above mentioned issues and other minor issues. Just give me few hours :)

#26 @Kenshino
18 months ago

Sure :)

#27 @themetracbot
18 months ago

  • Summary changed from THEME: Travel Eye – 1.2 to THEME: Travel Eye – 1.3

Travel Eye - 1.3

Travel Eye is a clean and professional Travel WordPress Theme. This Theme is ideal for travel agencies, hotels, tour operators or any other organization related to travel and tours. It is powered by Page Builder by Site Origin, so drag-and-drop feature will be very handy to customize the page layout as you want. It has Theme Options panel based on powerful Customizer API which makes theme pretty easy to customize and configure. Prebuilt layout is available for home page so you can get your page layout in one click. Official Support Forum: http://themepalace.com/support-forum/ Full Demo: http://demo.wenthemes.com/travel-eye/

Theme URL - http://wenthemes.com/item/wordpress-themes/travel-eye/
Author URL - http://wenthemes.com/

SVN - https://themes.svn.wordpress.org/travel-eye/1.3
ZIP - https://wordpress.org/themes/download/travel-eye.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=travel-eye/1.2&new_path=travel-eye/1.3

History:

Ticket Summary Status Resolution Owner
#29345 THEME: Travel Eye – 1.3 closed live Kenshino

(this ticket)

#33232 THEME: Travel Eye – 1.4 closed live themetracbot
#33317 THEME: Travel Eye12312312 – 1.8 closed not-approved emiluzelac
#33383 THEME: Travel Eye – 1.5 closed live themetracbot
#34805 THEME: Travel Eye – 1.6 closed live themetracbot
#34914 THEME: Travel Eye – 1.6.1 closed live themetracbot
#35673 THEME: Travel Eye – 1.6.2 closed live themetracbot
#38396 THEME: Travel Eye – 1.6.3 closed live themetracbot
#45132 THEME: Travel Eye – 1.6.4 closed live themetracbot


https://themes.svn.wordpress.org/travel-eye/1.3/screenshot.png

#28 @wenthemes
18 months ago

Pinging @Kenshino to confirm notification email is received. :-)

#29 @Kenshino
18 months ago

  • Status changed from reviewing to approved

Alright. Approved :)

#30 @chipbennett
18 months ago

I've looked through the code, and have only one potential concern:

https://themes.trac.wordpress.org/browser/travel-eye/1.3/inc/hook/css.php?rev=60143#L48

I'm looking for other admin opinions, but I think the custom CSS output needs to be escaped before being output.

#31 @wenthemes
18 months ago

Hello @chipbennett

We have also thought about that. We tried every escaping function for that field but could not find the appropriate. No function could handle ', " and > characters properly in CSS. So, we followed @greenshady recommendation and simply hooked it to wp_head. https://make.wordpress.org/themes/2015/02/10/custom-css-boxes-in-themes/#comment-40963
If there is any better approach for escaping, we will surely implement that.

Thanks

#32 @chipbennett
17 months ago

  • Resolution set to live
  • Status changed from approved to closed

@wenthemes that you're aware of/thinking about potential concerns is probably sufficient. If you come up with any interesting/elegant solutions, please share. I will push this one live. Congratulations, and thanks for contributing to WordPress!

Note: See TracTickets for help on using tickets.