WordPress.org

Make WordPress Themes

#29442 closed theme (live)

THEME: LIQUID – 0.9.7

Reported by: lqd Owned by: mebishalnapit
Priority: new theme Keywords: theme-liquid
Cc: info@…

Description

LIQUID - 0.9.0

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.0
ZIP - https://wordpress.org/themes/download/liquid.0.9.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.0/screenshot.png

Change History (35)

#1 @themetracbot
22 months ago

  • Summary changed from THEME: LIQUID – 0.9.0 to THEME: LIQUID – 0.9.1

LIQUID - 0.9.1

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.1
ZIP - https://wordpress.org/themes/download/liquid.0.9.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.0&new_path=liquid/0.9.1

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.1/screenshot.png

#2 @themetracbot
18 months ago

  • Owner set to imranaliweb
  • Status changed from new to reviewing

#3 follow-up: @grapplerulrich
18 months ago

  • Keywords changed from theme-liquid, accessibility-ready to theme-liquid accessibility-ready
  • Owner imranaliweb deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#4 @themetracbot
18 months ago

  • Summary changed from THEME: LIQUID – 0.9.1 to THEME: LIQUID – 0.9.2

LIQUID - 0.9.2

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.2
ZIP - https://wordpress.org/themes/download/liquid.0.9.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.1&new_path=liquid/0.9.2

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.2/screenshot.png

#5 in reply to: ↑ 3 @lqd
18 months ago

@grapplerulrich Thanks!
Also, I was fixed some of the problems.

#6 @themetracbot
18 months ago

  • Owner set to mebishalnapit

#7 @mebishalnapit
18 months ago

@lqd

Here are the list of the changes which needs to be done from my review:
Required:

  1. You need to add the title-tag support, your theme does not seem to support it.
  2. Theme should not display any error, here is the error which is shown in the debug log when viewed the single post page:
    PHP Notice:  Undefined variable: cat_name in C:\xampp\htdocs\liquid\wp-content\themes\liquid\single.php on line 121
    
  1. You seem to include the sharing feature within this theme, which is the plugin territory feture. So, you need to remove it.
  2. It looks like you are supporting the editor style, but that file has almost no support for this feature. So, please make it support fully or remove it completely.
  3. Your theme seems to have the accessibily ready tag in the style.css file, which your theme is not supporting it at all. So, you need to either remove this tag from style.css file or support it properly.
  4. Your readme.txt file with license seems improper, ie, you have declared the licene of the js file. You, need to declare it like this: Bootstrap Framework by Mark Otto and Jacob Thornton http://getbootstrap.com/ | Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE) or any other way as you prefer that would be best. The thing in declaring it is, you should provide the third party author along with the name and the license of those scipts.
  5. It seems that the bootstrap css file only have the minified version. You need to include the unminified version of this CSS file too, but, minified file can be enqueued.
  6. It seems that the bootstrap js as well as common.min.js file only have the minified version. You need to include the unminified version of this script too, but, minified file can be enqueued.
  7. You need to include the license of the image that are shown in the screenshot as well as the image license which is bundled in this theme.
  8. Your theme does not seem to be translation ready theme. So, you need to make your theme translation ready.
  9. Untranslatable strings found in the files 404.php, footer.php, header.php and check for other files too, almost all of the file do not support it.
  10. You need to always escape the output. Could not find it in the file archive.php, line number 50, 53, footer.php file line number 15 and check for other files too.
  11. Empty else statement found in index.php file line number 9-11. If it is not required, then, you can immediately close the if statement without the else statement..
  12. In single.php file, you need to change wp_reset_query() to wp_reset_postdata().
  13. In style.css file, it seems that you are importing the icomoon font using the @import feature, which need to be removed and enqueued instead.
  14. In header.php file, you have included the feature of adding the supporting the Open Graph meta tag, which need to be removed as it falls under the plugin territory.
  15. You need to remove the wp_title() function from the header.php file.
  16. You have hardcoded the styles and scripts file in the header.php, which need to be removed and enqueued instead.
  17. You need to remove the favicon feature from the theme as it is handled by WordPress itself.
  18. You need to also remove the support of the meta tags too from the header.php file as it also falls in the plugin territory.
  19. You need to remove the jquery.cookie.js from the theme file.
  20. Found the facebook feature added in your theme again in the header.php file line number 88-95. You need to remove this code as it falls under the plugin territory.
  21. It looks like you are using the feature of Header Image to be displayed as logo, which the user might get on confusion, so, please change it and use the custom logo support introduced in WordPress 4.5 for this feature. Also, this need to be removed by default too.
  22. You can add the support menu in the Customizer setting using the simple button, not including the iframe in the theme creating the menu for this purpose.
  23. You need to remove the backward compatibilty of wp_title() from your theme.
  24. You need to include the function of editor-style, content_width, post-thumbnail, enqueue_scripts feature in the after_setup_theme hook.

Recommended:

  1. It looks like you are using the same paginaton function in archive.php, search.php and index.php, so, it would be great practice if you could use it via the function to make your code more cleaner.

Thanks.

Regards.
Bishal Napit

#8 @lqd
18 months ago

@mebishalnapit

Thank you for the review.
I fix it speedily.

12

These also need to escape?
e.g.

<?php $src = get_template_directory_uri().'/images/noimage.png';
echo $src; ?>
<?php echo date('Y'); ?>
<?php echo home_url(); ?>

21

Will jquery.cookie.js can not be used?

Thanks.
Best regards.

#9 @mebishalnapit
18 months ago

@lqd

In that point, you need to esc the home_url() and the $src variable with the esc_url() function. And for the jquery.cookie.js, as far as I know it is setting up cookie for the site visitor using this theme, which can also be set up by the use of the caching plugin. So, you need to remove it too, since again it will fall under the plugin territory.

Thanks.

Regards.
Bishal Napit

#10 @themetracbot
18 months ago

  • Summary changed from THEME: LIQUID – 0.9.2 to THEME: LIQUID – 0.9.3

LIQUID - 0.9.3

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.3
ZIP - https://wordpress.org/themes/download/liquid.0.9.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.2&new_path=liquid/0.9.3

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.3/screenshot.png

#11 @lqd
18 months ago

@mebishalnapit

Thank you for more information.

Required

Fixed all!

Notes,
Jquery.cookie has been changed to localStorage.
It used to store the user display mode(RWD+).

Please kindly confirm.

Thanks.
Best regards.

#12 @mebishalnapit
18 months ago

@lqd

Here are the lists of the theme that still need to be fixed:
Required:

  1. You need to escape the translated strings too, ie, like _e() needed to be changed to esc_html_e() and so on as per the site need.
  2. You need to also escape the category_description() function too in archive.php file, line number 10.
  3. Need to escape the $cat_name variable too in archive.php file, line number 53, index.php line number 51 and search.php line number 49.
  4. Untranslated string still found in archive.php file, line number 88, 89, index.php line number 85, 86, search.php line number 84, 85.
  5. Also, I could not find the $cat_slug variable being used anywhere in the archive.php, index.php and search.php file. So, please remove it as it seems it is not needed.
  6. You should not prefix the third party included library with your theme name, ie, for eg: add the bootstrap handle only to load the bootstrap CSS and js, icomoon to add the icomoon font, and so on.
  7. Enqueue this script, ie,
    wp_enqueue_script( 'jquery' )
    
    individually is not required. You can add the dependency for jquery loading in the required scripts file.
  8. Untranstable string found in functions.php for registering the nav_menu, line number 62.
  9. Untranstable string found in functions.php sidebar areas, so please check on it. The array to be checked on it is name, for eg:
    'name' => esc_html__('Right Sidebar', 'liquid'),
    

.

  1. Remove the function add_editor_style() from functions.php file, line number 144-145.
  2. You need to also add the theme language file path in the functions.php file like this:
    load_theme_textdomain('liquid', get_template_directory() . '/languages');
    

, which need to be hooked in the after_theme_setup function. Also, move the registering nav_menu function in this hook too.

  1. You need to remove themes functions from the header.php file:
    <?php
    if (is_single()){
        echo '<meta name="description" content="'; setup_postdata($post); echo strip_tags(get_the_excerpt()); echo '">'."\n";
    } else {
        echo '<meta name="description" content="'; bloginfo('description'); echo '">'."\n";
    } ?>
    

It falls under the plugin territory.
and:

<link rel="alternate" type="application/rss+xml" title="<?php bloginfo('name'); ?> Feed" href="/feed">

It is already provided by WordPress.

  1. You need to make the string translatable, not found in header.php line number 12.
  2. Direct enqueue of the html5 and respond js found in header.php file. You need to enqueue those files.
  3. It seems that this code is of no use
    <a id="top"></a>
    

. So, please remove it. It is in header.php line number 24.

  1. Looks like there is an empty else statement in header.php file line number 60. So, if it is not required, you may not need to add that statement.
  2. Untranstable string found in page.php line number 18. Please check on it.
  3. You need to escape the variable $cat_slug and $cat_name in page.php file, line number 19.
  4. Please remove this text from readme.txt file for license
    or any other way as you prefer that would be best
    
    as it was just for your information that you could add it in any way that you would best prefer.
  5. The image in the screenshot is from shutterstock right as you mentioned, which is not GPL compatible. So, please add the image in the screenshot which is GPL compatible. Also, provide the image link too, not the website link of the image only.
  6. Untranstable string found in single.php file line number 16, 67 and 70.
  7. You need to escape the get_permalink() function in single.php file, line number 67 and 70.
  8. Add the text domain in name in the style.css file like this:
    Text Domain: liquid
    

Recommended:

  1. Prefix the sidebar id with the theme name for best practices.

Changing the jquery.cookie.js to the localStorage seems fine to me, but the admin will have the final view on this.

Thanks.

Regards.
Bishal Napit

#13 @themetracbot
18 months ago

  • Summary changed from THEME: LIQUID – 0.9.3 to THEME: LIQUID – 0.9.4

LIQUID - 0.9.4

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.4
ZIP - https://wordpress.org/themes/download/liquid.0.9.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.3&new_path=liquid/0.9.4

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.4/screenshot.png

#14 @lqd
18 months ago

@mebishalnapit

Thank you for pointing this out.

Required

No.16: It is necessary in order to smooth scroll. (Return to the top from the footer.)
If possible, I want to use.

Other was fixed.

Notes,
Removed the html5 and respond js.

Recommended

Thank you, Fix that way.

Please kindly confirm.

Thanks.
Best regards.

#15 @mebishalnapit
18 months ago

@lqd

There still seems to be issues in your theme to be approved. So, please look on the below lists to be marked as approved:

  1. It seems you have deleted the html5shiv and respond js, but has left the license as it is, ie, it is not removed. So, please remove it too. But, if you require those file, then, you can enqueue in this way described below in the enqueued function:
    wp_enqueue_script('html5shiv', get_template_directory_uri() . '/js/html5shiv.js', false);
    wp_script_add_data('html5shiv', 'conditional', 'lt IE 9');
    wp_enqueue_script('respond', get_template_directory_uri() . '/js/respond.js', false);
    wp_script_add_data('respond', 'conditional', 'lt IE 9');
    
  2. It seems that header text color option is not working, so please check on it. It is in functions.php file line number 16, change the value there from 333333 to false.
  3. Still found issue on enqueueing the scripts. It need to be done like this:
    wp_enqueue_style( 'bootstrap', get_template_directory_uri() . '/css/bootstrap.min.css', array() );
    wp_enqueue_style( 'icomoon', get_template_directory_uri() . '/css/icomoon.css', array() );
    wp_enqueue_style( 'liquid-style', get_stylesheet_uri(), array() );
    wp_enqueue_script( 'bootstrap', get_template_directory_uri() . '/js/bootstrap.min.js', array( 'jquery' ) );
    wp_enqueue_script( 'liquid-script', get_template_directory_uri() . '/js/common.min.js', array( 'jquery' ) );
    
  4. You need to change the widget id from the current one, ie,
    'id' => esc_html__('liquid_sidebar', 'liquid' ),
    
    to this
    'id' => 'liquid_sidebar',
    
    or
    'id' => 'liquid-sidebar',
    
    ie, it should not be translation ready
  5. screen-reader-text class found to be display none, you can use this CSS instead for this:
    .screen-reader-text {
        clip: rect(1px, 1px, 1px, 1px);
        position: absolute !important;
        height: 1px;
        width: 1px;
        overflow: hidden;
    }
    
  6. For this code
    <a id="top"></a>
    
    in the header.php, you can remove that and just below, you can add that id, ie,
    <div class="wrapper">
    
    can become
    <div class="wrapper" id="top">
    
  7. In single.php file, change the
    esc_html( get_permalink( $prev_post->ID ))
    
    to
    esc_url( get_permalink( $prev_post->ID ))
    
  1. Now, you can add the threaded-comments and translation-ready tag in your style.css file in the tags section.
  2. You need to provide the image licenses for the small images too used in the screenshot.

After all of the above issues are solved, your theme will be ready to be approved.

Thanks.

Regards.
Bishal Napit

Last edited 18 months ago by mebishalnapit (previous) (diff)

#16 @themetracbot
18 months ago

  • Summary changed from THEME: LIQUID – 0.9.4 to THEME: LIQUID – 0.9.5

LIQUID - 0.9.5

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.5
ZIP - https://wordpress.org/themes/download/liquid.0.9.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.4&new_path=liquid/0.9.5

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.5/screenshot.png

#17 @lqd
18 months ago

@mebishalnapit

Thank you for explaining so politely and thoroughly.

Fixed all.

9

Small image uses the same image as the large image.
https://flic.kr/p/yhwXZg

Please kindly confirm.

Thanks.
Best regards.

#18 @mebishalnapit
18 months ago

  • Status changed from reviewing to approved

@lqd

All previous issue seems to be cleared. So marking this theme as approved. Now, the admin will look after this theme, if they found any bug in this theme again, then they will report it to you and you need to fix it and again submit for review.
Meanwhile, you can find the queue of the approved theme through this link here: https://themes.trac.wordpress.org/report/24

Thanks.

Regards.
Bishal Napit

#19 @lqd
18 months ago

@mebishalnapit
Thank you for the great review!

#20 @joedolson
18 months ago

  • Status changed from approved to reopened

I'm reopening this review for the accessibility-ready audit, which is required for themes with the accessibility-ready tag. I'll get this done as soon as possible!

#21 @grapplerulrich
18 months ago

  • Status changed from reopened to reviewing

#22 @mebishalnapit
18 months ago

@joedolson

I had already asked the theme author to either support the accessibility-ready tag or to remove it from the tags declaration in the style.css file, since I could not find any single accessibility-ready feature in this theme. So, as while I was doing my review on this theme, the theme author has removed that tag from the tags declaration in style.css file. So, I would like to know that, is it required to check the accessibility-ready feature in the theme even if the tag is being removed?

Thanks.

Regards.
Bishal Napit

#23 @joedolson
18 months ago

  • Keywords accessibility-ready removed

No, certainly it's not required to do that review once the tag is removed. But, for future reference, its very helpful if there's a clear comment in the review indicating that the accessibility-ready tag has been removed *or* if the 'accessibility-ready' keyword is removed from the review keywords, so I know!

I've removed the accessibility-ready keyword; you can re-approve the theme.

#24 @mebishalnapit
18 months ago

  • Status changed from reviewing to approved

@joedolson

Thank you for the information on this one. Next time, when I review the theme with same tag, I will surely mention it. For now, I will be approving this again since that tag is removed from the theme.

Thanks.

Regards.
Bishal Napit

#25 @jcastaneda
17 months ago

I'll do the admin review on this one. Should have it done in a few hours.

#26 follow-up: @jcastaneda
16 months ago

  • Status changed from approved to reopened

Unfortunately I do have to reopen this.

Required

functions.php

  • custom header, please hook properly

index.php

  • please use core functionality and use the_category() what happens is there is more than one category the user would like to display?
  • please use core pagination or you can follow suit in Twenty Fourteen in using paginate_link() properly
  • remove: remove_filter( 'pre_term_description', 'wp_filter_kses' ); this is done in core in order to filter out bad code
  • <?php post_class( $classes );?> please use the post_class filter instead
  • please use the_time( get_option( 'date_format' ) ) or the_time( get_option( 'time_format' ) ) instead of the_time('m/d'); needs to respect user setting
  • please use core functionality for the thumbnail. There is post_thumbnail_html that you can use

comments.php

  • comment-reply script needs to be properly enqueued using wp_enqueue_scripts hook
  • Please make the text inside printf translation ready

readme

  • not sure if I missed it but what is the license/copyright for the common.js file?

Recommend

  • wp_list_categories('title_li='); no need to pass empty values, just use wp_list_categories();
  • remove commented code

Make these changes and the theme can be set live. :)

#27 @jcastaneda
16 months ago

  • Status changed from reopened to reviewing

#28 @mebishalnapit
16 months ago

@lqd

Please make the required adjustments as suggested by @jcastaneda and submit the theme. And it will be again rechecked.
Also, since now the theme tags has been changed, you have deprecated theme tags added in the style.css file of this theme. So, please check it and compare with this list and add the appropriate one and remove the deprecated ones: https://make.wordpress.org/themes/handbook/review/required/theme-tags/. Also, you need to add the theme tags all in small letter. So, please check on these issues and resubmit the theme.

Thanks.
Bishal Napit

#29 in reply to: ↑ 26 @lqd
16 months ago

@jcastaneda Thank you for the review.

functions.php

  • custom header, please hook properly

Sorry for inconveniencing you but would you explain a little more in detail?
Thanks.

#30 @mebishalnapit
16 months ago

@lqd

@jcastaneda is asking you to hook that function, in the after_setup_theme hook.

Thanks.
Bishal Napit

#31 @themetracbot
16 months ago

  • Summary changed from THEME: LIQUID – 0.9.5 to THEME: LIQUID – 0.9.6

LIQUID - 0.9.6

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.6
ZIP - https://wordpress.org/themes/download/liquid.0.9.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.5&new_path=liquid/0.9.6

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.6/screenshot.png

#32 @themetracbot
16 months ago

  • Summary changed from THEME: LIQUID – 0.9.6 to THEME: LIQUID – 0.9.7

LIQUID - 0.9.7

LIQUID is Responsive Web Design+ (RWD+) theme, based on Bootstrap 4. RWD+ is a unique feature. You can switch the mobile display and PC display on smartphones.

Theme URL - https://lqd.jp/wp/liquid.html
Author URL - https://lqd.jp/wp/

SVN - https://themes.svn.wordpress.org/liquid/0.9.7
ZIP - https://wordpress.org/themes/download/liquid.0.9.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=liquid/0.9.6&new_path=liquid/0.9.7

History:

Ticket Summary Status Resolution Owner
#21392 THEME: Liquid Blank - 1.2 closed not-approved KalenJohnson
#22219 THEME: Liquid Blank - 1.8 closed live vladff
#29442 THEME: LIQUID – 0.9.7 closed live mebishalnapit

(this ticket)

#46325 THEME: LIQUID – 0.9.8 closed live themetracbot


https://themes.svn.wordpress.org/liquid/0.9.7/screenshot.png

#33 @lqd
16 months ago

@jcastaneda

I just fixed issues and uploaded the theme.
Sorry for twice upload.

Notes: I removed the custom-header-image from other than index.

@mebishalnapit

you have deprecated theme tags added in the style.css file of this theme.

Thank you,
Theme tags fixed.

Please kindly confirm.
Best regards.

#34 @mebishalnapit
16 months ago

  • Status changed from reviewing to approved

@lqd

Everything seems to be fine now regarding this theme. So, I will be approving this theme as there is no any further issue found in this theme.

Thanks.
Bishal Napit

#35 @jcastaneda
16 months ago

  • Resolution set to live
  • Status changed from approved to closed

Looks good. Congrats your theme is now live.

Note: See TracTickets for help on using tickets.