WordPress.org

Make WordPress Themes

#29649 closed theme (live)

THEME: LitheStore – 1.0.8.1

Reported by: badjohnny Owned by: monikarao
Priority: new theme Keywords: theme-lithestore
Cc: badjohnny.woo@…, joedolson, davidakennedy

Description

LitheStore - 1.0.0

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan.

Theme URL - http://www.themevan.com/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.0
ZIP - https://wordpress.org/themes/download/lithestore.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.0/screenshot.png

Attachments (1)

lithestore.zip (2.0 MB) - added by badjohnny 22 months ago.
Updated the theme description.

Download all attachments as: .zip

Change History (50)

@badjohnny
22 months ago

Updated the theme description.

#1 @themetracbot
22 months ago

  • Summary changed from THEME: LitheStore – 1.0.0 to THEME: LitheStore – 1.0.1

LitheStore - 1.0.1

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.theemvan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.1
ZIP - https://wordpress.org/themes/download/lithestore.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.0&new_path=lithestore/1.0.1

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.1/screenshot.png

#2 @themetracbot
22 months ago

  • Summary changed from THEME: LitheStore – 1.0.1 to THEME: LitheStore – 1.0.2

LitheStore - 1.0.2

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.theemvan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.2
ZIP - https://wordpress.org/themes/download/lithestore.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.1&new_path=lithestore/1.0.2

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.2/screenshot.png

#3 @themetracbot
18 months ago

  • Owner set to monikarao
  • Status changed from new to reviewing

#4 @monikarao
18 months ago

Hello @badjohnny

I will start reviewing the theme,and I will get back to you shortly.

Thanks

#5 @monikarao
18 months ago

Hello @badjohnny

I have reviewed the theme and here are the results.
Please fix these issues and re-upload the theme with updated version number so that I can re-review it.

Theme Check Plugin:-

RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

INFO: Possible hard-coded links were found in the file intro.php.
Line 109: <a href='http://themeforest.net/item/citynews-comprehensive-newspaper-wordpress-them
Line 111: <a href='http://www.themevan.com/item/magicbook' target='_blank'><img src='http://ww
Line 113: <a href='http://www.themevan.com/item/simplekey' target='_blank'><img src='http://ww
Line 115: <a href='http://www.themevan.com/item/wonders' target='_blank'><img src='http://www.
Line 117: <a href='http://www.themevan.com/themes' target='_blank' class='button button-primar
INFO: Possible hard-coded links were found in the file intro.php.
Line 109: <a href='http://themeforest.net/item/citynews-comprehensive-newspaper-wordpress-them
Line 111: <a href='http://www.themevan.com/item/magicbook' target='_blank'><img src='http://ww
Line 113: <a href='http://www.themevan.com/item/simplekey' target='_blank'><img src='http://ww
Line 115: <a href='http://www.themevan.com/item/wonders' target='_blank'><img src='http://www.
INFO: Possible hard-coded links were found in the file intro.php.
Line 109: <a href='http://themeforest.net/item/citynews-comprehensive-newspaper-wordpress-them
Line 111: <a href='http://www.themevan.com/item/magicbook' target='_blank'><img src='http://ww
Line 113: <a href='http://www.themevan.com/item/simplekey' target='_blank'><img src='http://ww
INFO: Possible hard-coded links were found in the file intro.php.
Line 109: <a href='http://themeforest.net/item/citynews-comprehensive-newspaper-wordpress-them
Line 111: <a href='http://www.themevan.com/item/magicbook' target='_blank'><img src='http://ww
INFO: Possible hard-coded links were found in the file intro.php.
Line 109: <a href='http://themeforest.net/item/citynews-comprehensive-newspaper-wordpress-them

INFO: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.
The domains found are lithestore,woocommerce

INFO: init.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 23: if ( is_readable($locale_file) ) require_once($locale_file);
INFO: customizer.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Core Functionality:-

1.third party tool no need to enqueue using theme slug -> wp_enqueue_style( 'lithestore-fontawesome'

2.Remove comment code for custom-background in init.php

3.readme.txt > Installation > change theme name "Twenty Fourteen" to "Lithestore".

4.Could you please upload the license url of the images used in the screenshot on readme.txt file

5.Add changelog.txt file and update all changes.

6.readme.txt > https://www.themevan.com/item/lithestore Link is redirect to 404 page could you please update proper link.

7.style.css > description > http://demo.theemvan.com/lithestore Link is not redirect to proper channel.

8.All the variables name should start with theme name prefix.

9.pop.php > home_url( '/' ) should be enqueue.

10.Include text domain.pot file in language folder. The .pot file name should match exactly the theme name.

11.If you don't want to use the header text feature, you should set header-text to false. (https://codex.wordpress.org/Custom_Headers#Adding_Theme_Support), instead of:
$wp_customize->remove_control('header_textcolor');

Styling Issue:-

1.Calendar styling is broken.

2.Scroll > site title will overlap on admin bar so increase top margin on navigation.

3.Responsive > 1024px > horizontal scroll is displaying on all pages and Home Page > product category section is also broken.

4.Responsive menu icon > close button is not displaying.

Validator Error:-

Check customizer.php and main.css file on https://jigsaw.w3.org/css-validator/

That's all!
Looking forward to updated version with these fixes.

Thanks.

#6 @badjohnny
18 months ago

Thanks @monikarao

One question, did you mean I must fix all INFO and RECOMMENDED issues of theme check plugin?

Last edited 18 months ago by badjohnny (previous) (diff)

#7 @themetracbot
18 months ago

  • Summary changed from THEME: LitheStore – 1.0.2 to THEME: LitheStore – 1.0.3

LitheStore - 1.0.3

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.3
ZIP - https://wordpress.org/themes/download/lithestore.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.2&new_path=lithestore/1.0.3

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.3/screenshot.png

#8 @monikarao
18 months ago

Hello @badjohnny

Recommended items are best practices for themes but not essential if you fixed all issues then it will make your theme better.

Thanks

Last edited 18 months ago by monikarao (previous) (diff)

#9 @monikarao
18 months ago

Hello @badjohnny

I've re-reviewed the updated version of the theme and all the previous issues have been fixed.Here are the other points:-

1.Please provide licence info for Pictures: https://www.pexels.com

2.Add licence info and author name for pushy.js in readme.txt.

3.Responsive > 768px > Responsive menu icon > scroll on the icon please fix it.

4.Responsive > 1024px > Product category is not displaying in proper layout.Check this screenshot->http://www.awesomescreenshot.com/image/1231139/0cc29bdcec31f3b77345b63d6ffcc453

5.Responsive > 768px > Top Rated Product and Recent Product category list is not displaying in proper layout.

That's all!
Looking forward to updated version with these fixes.

Thanks.

#10 @themetracbot
18 months ago

  • Summary changed from THEME: LitheStore – 1.0.3 to THEME: LitheStore – 1.0.4

LitheStore - 1.0.4

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.4
ZIP - https://wordpress.org/themes/download/lithestore.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.3&new_path=lithestore/1.0.4

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.4/screenshot.png

#11 @badjohnny
18 months ago

Hi

I fixed those issues and resubmitted.

Thanks

#12 @monikarao
18 months ago

Hi @badjohnny

I've re-reviewed theme but still there is scroll on Responive -> 768px

Please fix Product Category section(after header image) on Responsive -> 768px Check this screenshot-> http://www.awesomescreenshot.com/image/1244405/e3071226b4f64967272aeb34770c2a9f

Desktop > navigation > sub-menus are not displaying please fix it.

Looking forward to updated version with these fixes.
Thanks.


Last edited 17 months ago by monikarao (previous) (diff)

#13 @themetracbot
17 months ago

  • Summary changed from THEME: LitheStore – 1.0.4 to THEME: LitheStore – 1.0.5

LitheStore - 1.0.5

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.5
ZIP - https://wordpress.org/themes/download/lithestore.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.4&new_path=lithestore/1.0.5

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.5/screenshot.png

#14 @badjohnny
17 months ago

Thanks for your reviewing and sorry for my mistake.

#15 @monikarao
17 months ago

  • Status changed from reviewing to approved

Hello @badjohnny

Thank you for submitting your theme with the required fixes. I will go ahead and approved the theme since i do not find any issues whatsoever.

#16 @badjohnny
17 months ago

Hello, @monikarao

Thank you so much! When it will be available to download on WP.org?

Last edited 17 months ago by badjohnny (previous) (diff)

#17 @monikarao
17 months ago

Hello @badjohnny

The admin will take the final review and check for accessibility-ready feature after admin-approval your theme will be available to download on WP.org.

#18 follow-up: @joedolson
17 months ago

  • Keywords changed from theme-lithestore, accessibility-ready to theme-lithestore accessibility-ready
  • Status changed from approved to reopened

Re-opening for accessibility-ready review.

@monikarao - For reference, the process is generally to do the accessibility-ready review prior to approval.

#19 in reply to: ↑ 18 @monikarao
17 months ago

Replying to joedolson:

Re-opening for accessibility-ready review.

@monikarao - For reference, the process is generally to do the accessibility-ready review prior to approval.

Thanks

#20 @grapplerulrich
16 months ago

  • Cc joedolson added
  • Status changed from reopened to reviewing

#21 @davidakennedy
16 months ago

  • Cc davidakennedy added

Hi there!

Thanks for creating a WordPress theme and submitting it to the WordPress.org directory! I'm stepping in for Joe since he's away for a few weeks.

Since your theme also includes the accessibility-ready tag, I've also reviewed it according to those requirements, which you can find here: https://make.wordpress.org/themes/handbook/review/accessibility/

Anything in marked required will need to be fixed before the theme can be approved. Anything marked recommended is optional for you to consider and/or fix.

Not related to the accessibility-ready review, I found three issues that would prevent this theme from going live:

  • I saw a PHP notice on the posts page:
    PHP NOTICE: wp-content/themes/lithestore/framework/functions/extras.php:53 - Undefined variable: big
    
  • The posts navigation (on the posts page and archive pages) does not work. The links (Page 2, Page 3, etc.) just link to the same page.
  • I saw multiple PHP warnings on the homepage template:
    Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'lithestore_product_categories' not found or invalid function name in /srv/www/wordpress-trunk/wp-includes/plugin.php on line 524
    

Keyboard Navigation

  • Required: No :focus styles appear to be set. These styles are the foundation of accessibility. Be sure to include styles for links, menus, input elements, etc. To learn more, see:

https://24ways.org/2009/dont-lose-your-focus

Controls

Pass.

Skip Links

Forms

Required: Search form should implement .screen-reader-text class properly. Currently, a screen reader can't read a label hidden with it in this theme. See Screen Reader Text below.

Headings

Required: Several of the templates need to be adjusted to include a proper heading structure.

  • On archive pages, the template starts with a <h3> rather than a <h1>.
  • The search template has no <h1>.

ARIA Landmark Roles

Pass.

Link Text

Required: Posts with featured images, which show the excerpt don't include the post title in the Continue Reading link. It should be included, like it is if the post doesn't have a featured image.

Contrasts

Required: A few colors need to have a higher contrast in order to pass.

  • Link text: 289bc1
  • Post meta (author, date, categories, tags, comment link): 999

Images

Pass.

Media

Pass.

Screen Reader Text

Required: .screen-reader-text is not implemented properly. Using display: none; means screen readers won't be able to read it. See: https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Not Allowed

  • Any positive tabindex attribute: Pass.
  • The inclusion of the accesskey attribute: Pass.
  • Spawning new windows or tabs without warning the user: Pass.

Recommended

Zoomable text: Good.
Removal of title attributes: There are a number of title attributes in the template-tags.php that could be removed.

Notes

These are just a collection of thoughts and miscellaneous things I found while reviewing your theme.

  • With a long site title, the text does not wrap. See: https://cloudup.com/cOajJCY8hg6 The actual title is: Really, Really Long Title for an Awesome Dev Site
  • The dropdown menus don't appear on :hover on large screens.

Thanks again for creating with WordPress and sharing your work! If you have any questions about your review, don't hesitate to ask!

Cheers,
Dave

#22 @badjohnny
16 months ago

@davidakennedy Thanks for your reviewing.

I'm not quite understand "The dropdown menus don't appear on :hover on large screens."

Did you mean hover on the main navigation but sub menu don't appear on large screens? Could I know the screen size?

Thanks

#23 @davidakennedy
16 months ago

Hey @badjohnny

See: https://cloudup.com/c0a0F16bnht

Yes, the hover works, but I don't see the sub menu with its items. It looks like this happens on screens 960 and above. I'm using Chrome, but can also reproduce in Firefox and Safari.

It may be an issue with z-index properties?

#24 @themetracbot
16 months ago

  • Summary changed from THEME: LitheStore – 1.0.5 to THEME: LitheStore – 1.0.6

LitheStore - 1.0.6

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.6
ZIP - https://wordpress.org/themes/download/lithestore.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.5&new_path=lithestore/1.0.6

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.6/screenshot.png

#25 @badjohnny
16 months ago

I improved those issues you mentioned, if anything I missed, please remind me, thanks for taking your time.

#26 @davidakennedy
16 months ago

Hey there,

Thanks for the updates. You've fixed most of the issues I previously listed. If it's not mentioned, consider it fixed.

Keyboard Navigation

Skip Links

  • A skip link is still needed.

Forms

Link Text

  • Posts with featured images, which show the excerpt still don't include the post title in the Continue Reading link. It should be included.

Contrasts

  • The link color still does not have high enough contrast.
  • The :focus style for links, forms, etc ffa900 does not have high enough contrast.

Let me know if you have any questions.

#27 @grapplerulrich
16 months ago

@badjohnny Please let us know what the status of the update is or the ticket will be closed.

#28 @badjohnny
16 months ago

Hi, @grapplerulrich I still make changes, because woocommerce 2.6 was released, I need to add sime new styles. I will submit it soon!

Last edited 16 months ago by badjohnny (previous) (diff)

#29 @themetracbot
16 months ago

  • Summary changed from THEME: LitheStore – 1.0.6 to THEME: LitheStore – 1.0.7

LitheStore - 1.0.7

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.7
ZIP - https://wordpress.org/themes/download/lithestore.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.6&new_path=lithestore/1.0.7

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.7/screenshot.png

#30 @themetracbot
16 months ago

  • Summary changed from THEME: LitheStore – 1.0.7 to THEME: LitheStore – 1.0.7.1

LitheStore - 1.0.7.1

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.7.1
ZIP - https://wordpress.org/themes/download/lithestore.1.0.7.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.7&new_path=lithestore/1.0.7.1

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.7.1/screenshot.png

#31 @badjohnny
16 months ago

Hi @grapplerulrich

I fixed all issues except the link issue you metioned, did you mean add the title="" propertype to the link? I rechecked that link, I 've already added the title='POST TITLE' to the continue to read link, anything I missed?

Link Text
Posts with featured images, which show the excerpt still don't include the post title in the Continue Reading link. It should be included.

Last edited 16 months ago by badjohnny (previous) (diff)

#32 @davidakennedy
15 months ago

Hey there,

Thanks for the updates. You've fixed most of the issues I previously listed. If it's not mentioned, consider it fixed.

Contrasts

  • The link color still does not have high enough contrast. The new blue is better but it comes in at 3.84:1 and it should be 4.5:1 or higher.
  • The :focus style for links, forms, etc 3484db does not have high enough contrast. Also, on forms, the outline doesn't show up because there isn't a width or border style defined.

Link Text

I fixed all issues except the link issue you metioned, did you mean add the title="" propertype to the link? I rechecked that link, I 've already added the title='POST TITLE' to the continue to read link, anything I missed?

No, not that kind of title, I mean the actual post title, hidden with screen-reader-text. See the screen shot here for how it currently is: https://cloudup.com/cPSJSdpxydF Again, this happens on posts with featured images.

Here's how you have it when the "More" tag is used: https://cloudup.com/c7yRHDrot_x This is how it should be.

Keep in mind if you're having trouble meeting these requirements from design point of view, you can go live without the accessibility-ready tag. You'd just have to remove it.

Let me know if you have any questions.

#33 @themetracbot
15 months ago

  • Summary changed from THEME: LitheStore – 1.0.7.1 to THEME: LitheStore – 1.0.7.2

LitheStore - 1.0.7.2

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. The complete demo is here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/item/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.7.2
ZIP - https://wordpress.org/themes/download/lithestore.1.0.7.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.7.1&new_path=lithestore/1.0.7.2

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.7.2/screenshot.png

#34 @badjohnny
15 months ago

Hi @davidakennedy

I removed accessibility-ready tag, because I'm not quite familar with accessibility-ready design, but I will improve the theme for the accessibility-ready in the future.

Thanks

#35 @grapplerulrich
15 months ago

  • Keywords accessibility-ready removed

Removed a11y-ready tag from ticket.

#36 @davidakennedy
15 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

#37 @davidakennedy
15 months ago

Thanks for trying on the accessibility-ready tag, and congrats on your theme!

#38 @grapplerulrich
15 months ago

  • Resolution live deleted
  • Status changed from closed to reopened

I had the take the theme offline and reopen the ticket as there a few issues that needed to be fixed first.

Required

  • To have a theme on wordpress.org all of your themes need to be released under GPL even those on theme forest.
  • Please escape all settings on output e.g. get_theme_mod('body_font', 'Lato')

Recommended

  • Please place the settings check within the function so not to have a extra database request on every page load.
if ( get_theme_mod( 'navigation_font', 'Karla' )<>'Karla' || get_theme_mod( 'body_font', 'Lato' )<>'Lato' || get_theme_mod( 'logo_font', 'Montserrat' )<>'Montserrat' || get_theme_mod( 'heading_font', 'Karla' )<>'Karla' ) {
  add_action( 'wp_enqueue_scripts', 'lithestore_custom_font_styles' );
}

#39 @badjohnny
15 months ago

Hi, @grapplerulrich

For the first question, I released the complete different theme with different coding & design on Themeforest, actually they has nothing to do with the themes on WordPress.org, so should I still to change the all the themeforest themes license to GPL?

Anyway, I will consider to change the license to GPL.

Last edited 15 months ago by badjohnny (previous) (diff)

#40 @grapplerulrich
15 months ago

  • Status changed from reopened to reviewing

Yes as the free theme is associated with themevan which sells themes that are not GPL compatable.

#41 @badjohnny
15 months ago

Hello @grapplerulrich

I fixed the issues you metioned, but except the license. Because I've suggested my team to change the license to 100% GPL on themeforest for all the themes, but they worried the sales of the themes will go down after change the license, so they don't agree with me for now at least.

Acutally I'm this theme author, so now the only thing I can do it for my theme is that I will not release my theme under that team, instead, I want to change the name of my profile from ThemeVan to my own personal website name, remove the themevan themes promotion information from my theme welcome page, and remove the theme from themevan.com, it means I will change the theme author and demo link informations.

Is that OK? Or anything I should do if I want to make this theme live? Please feel free to tell me.

Thank you!

#42 @badjohnny
15 months ago

Also, ThemeVan is welcome to change their license to 100% GPL on themeforest, but they needs transition time to do that, so that's why I don't want to release my theme under ThemeVan, because I worry about they will take long time to make changes so that my theme is complete removed by WP.org

#43 @grapplerulrich
15 months ago

If you don't have any links to ThemeVan I can set your theme live.

#44 @themetracbot
15 months ago

  • Summary changed from THEME: LitheStore – 1.0.7.2 to THEME: LitheStore – 1.0.8

LitheStore - 1.0.8

LitheStore is a free elegant E-Commerce Theme developed by ThemeVan. Please check the complete demo here http://demo.themevan.com/lithestore

Theme URL - http://www.themevan.com/lithestore
Author URL - http://www.themevan.com

SVN - https://themes.svn.wordpress.org/lithestore/1.0.8
ZIP - https://wordpress.org/themes/download/lithestore.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.7.2&new_path=lithestore/1.0.8

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.8/screenshot.png

#45 @badjohnny
15 months ago

@grapplerulrich

I fixed those PHP issues and unassociated all the themes link which is not compatible with GPL

Please let me know if any problems I missed.

Thanks

#46 @grapplerulrich
15 months ago

  • You would need to remove the themevan links in style.css and lithestore_copyright() also.
  • You have added the accessibility-ready back in again. Was this deliberate?
  • Please place load_theme_textdomain( 'lithestore', get_template_directory() . '/languages' ); within a function so that it loads at the correct time. Actually you have the code duplicated in functions.php.
  • Why are you loading the following code in the welcome-page?
    		require_once( ABSPATH . 'wp-load.php' );
    		require_once( ABSPATH . 'wp-admin/admin.php' );
    		require_once( ABSPATH . 'wp-admin/admin-header.php' );
    

#47 @themetracbot
15 months ago

  • Summary changed from THEME: LitheStore – 1.0.8 to THEME: LitheStore – 1.0.8.1

LitheStore - 1.0.8.1

LitheStore is a free elegant E-Commerce Theme that you can use it to build your online shop easily and quickly. Please check the complete demo here http://wubo.me/lithestore

Theme URL - http://wubo.me/lithestore
Author URL - http://wubo.me

SVN - https://themes.svn.wordpress.org/lithestore/1.0.8.1
ZIP - https://wordpress.org/themes/download/lithestore.1.0.8.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lithestore/1.0.8&new_path=lithestore/1.0.8.1

History:

Ticket Summary Status Resolution Owner
#29649 THEME: LitheStore – 1.0.8.1 closed live monikarao

(this ticket)

#35061 THEME: LitheStore – 1.0.9 closed live themetracbot
#35063 THEME: LitheStore – 1.0.9.1 closed live themetracbot
#35092 THEME: LitheStore – 1.1.0 closed live themetracbot
#35094 THEME: LitheStore – 1.1.0.1 closed live themetracbot
#36778 THEME: LitheStore – 1.1.1 closed live themetracbot
#37563 THEME: LitheStore – 1.1.2 closed live themetracbot
#42524 THEME: LitheStore – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/lithestore/1.0.8.1/screenshot.png

#48 @badjohnny
15 months ago

@grapplerulrich Sorry to bother you again. This time, I scaned all files to replace themevan link, removed the following codes

require_once( ABSPATH . 'wp-load.php' );
require_once( ABSPATH . 'wp-admin/admin.php' );
require_once( ABSPATH . 'wp-admin/admin-header.php' );

and add load_theme_textdomain( 'lithestore', get_template_directory() . '/languages' into function.

Thanks

#49 @grapplerulrich
15 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Setting live again.

Note: See TracTickets for help on using tickets.