WordPress.org

Make WordPress Themes

#29793 closed theme (live)

THEME: Matata – 1.1.6

Reported by: JusThemes Owned by: oceanwebthemes
Priority: new theme Keywords: theme-matata
Cc: valerioc95@…

Description

Matata - 1.0

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/matata-demo

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.0
ZIP - https://wordpress.org/themes/download/matata.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.0/screenshot.png

Change History (29)

#1 @themetracbot
16 months ago

  • Summary changed from THEME: Matata – 1.0 to THEME: Matata – 1.1

Matata - 1.1

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1
ZIP - https://wordpress.org/themes/download/matata.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.0&new_path=matata/1.1

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1/screenshot.png

#2 @themetracbot
16 months ago

  • Owner set to oceanwebthemes
  • Status changed from new to reviewing

#3 @oceanwebthemes
16 months ago

Dear @JusThemes

I am reviewing your theme, in pre study I found the following things

Required:

  1. Screenshot should be as the default installation, I do not see the slider part in default installation
  2. Slider was not showing selecting any category from the customizer
  3. in readme.txt change the Contributor to username of the WordPress.org JusThemes
  4. Please specify the URL of the images used in screenshot
  5. Please removed the unused files , in your case I havent seen the use of the min js min css files
  6. Please add the changelog.txt for the reference
  7. From WordPress 4.5 it support the custom logo , so please include that for your reference https://make.wordpress.org/core/2016/03/10/custom-logo/

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Rest Look good

thank you

#4 @themetracbot
16 months ago

  • Summary changed from THEME: Matata – 1.1 to THEME: Matata – 1.1.1

Matata - 1.1.1

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.1
ZIP - https://wordpress.org/themes/download/matata.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1&new_path=matata/1.1.1

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.1/screenshot.png

#5 @JusThemes
16 months ago

  1. Done.
  2. Please see theme documentation to enable home slider.
  3. Done.
  4. Please check in readme.txt under Credits section.
  5. It's required to provide unminified versions of all minified .css and .js files in the same folder as the minified version.
  6. Please check in readme.txt under Changelog section.
  7. Done.

Thank You

#6 @oceanwebthemes
16 months ago

@JusThemes

I appreciate your quick reply, I have checked everything but for the image license please specify the full URL like this (Resource URI: http://pixabay.com/en/office-tax-business-finance-620822/), Please recheck your language file once again after changing the code the lines are mismatching.

after that it will be done from my side

thank you

#7 @oceanwebthemes
16 months ago

@JusThemes

One more thing , Put the default screenshot for the logo section also

thank you

#8 @themetracbot
16 months ago

  • Summary changed from THEME: Matata – 1.1.1 to THEME: Matata – 1.1.2

Matata - 1.1.2

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.2
ZIP - https://wordpress.org/themes/download/matata.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1.1&new_path=matata/1.1.2

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.2/screenshot.png

#9 @themetracbot
16 months ago

  • Summary changed from THEME: Matata – 1.1.2 to THEME: Matata – 1.1.3

Matata - 1.1.3

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.3
ZIP - https://wordpress.org/themes/download/matata.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1.2&new_path=matata/1.1.3

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.3/screenshot.png

#10 @JusThemes
16 months ago

@oceanwebthemes Done.

#11 @oceanwebthemes
16 months ago

  • Status changed from reviewing to approved

Dear @JusThemes

Look good, Please wait for the senior reviewer to check your theme, mean time do not upload any files else the status will be new again, I am marking it as approved .

thank you

#12 @grapplerulrich
16 months ago

  • Status changed from approved to reopened

I need to reopen this

#13 follow-up: @grapplerulrich
16 months ago

  • Status changed from reopened to reviewing

@oceanwebthemes As this is your first review I just did a quick look over the the theme and saw some of the settings were not escaped on output. see the get_theme_mod() in inc/extras.php

The rtl.css can be removed as it empty. Are content-sidebar.css and sidebar-content.css being used?

You can approve the theme again when it is fixed :)

#14 in reply to: ↑ 13 @oceanwebthemes
16 months ago

Replying to grapplerulrich:

@oceanwebthemes As this is your first review I just did a quick look over the the theme and saw some of the settings were not escaped on output. see the get_theme_mod() in inc/extras.php

The rtl.css can be removed as it empty. Are content-sidebar.css and sidebar-content.css being used?

You can approve the theme again when it is fixed :)

@grapplerulrich thank you

Dear @JusThemes Please check the above mentioned point and upload the newer one.

#15 @JusThemes
16 months ago

@oceanwebthemes What settings do i need to escape?

#16 @oceanwebthemes
16 months ago

Dear @JusThemes

it should be like this

<?php
esc_attr( get_theme_mod($variable)); 

Please remove the unused default file of underscore like mentioned above, if your theme do not support RTL and you are not using the rtl.css remove that too.

thank you

#17 @rabmalin
16 months ago

Escaping Issue:

  • extras.php matata_custom_css function $primary_color variable
  • home-slider.php - $slidecat, $count

Check other get_theme_mod call in the theme. Note that escaping is not needed in conditionals like if. It is required when it is displayed or used in other cases.

#18 @oceanwebthemes
16 months ago

@rabmalin thank you

@JusThemes hope you understand , escaped in output

<?php
echo esc_attr( get_theme_mod($variable)); 

#19 @themetracbot
16 months ago

  • Summary changed from THEME: Matata – 1.1.3 to THEME: Matata – 1.1.4

Matata - 1.1.4

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.4
ZIP - https://wordpress.org/themes/download/matata.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1.3&new_path=matata/1.1.4

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.4/screenshot.png

#20 @JusThemes
16 months ago

Thank you. It should be ok now I think.

#21 @oceanwebthemes
16 months ago

  • Status changed from reviewing to approved

Dear @JusThemes

Seem good now , I am making it approved now, wait for the live from the admin team, do not update anything in this period.

thank you

#22 @greenshady
14 months ago

  • Status changed from approved to reopened

I'm taking over the admin review for this theme.

#23 @greenshady
14 months ago

  • Status changed from reopened to reviewing

This theme is pretty much ready to go. The code is really solid. However, there are a few minor things that need to be corrected. In particular, the first two items need to be corrected for sure.

wp_reset_postdata() vs wp_reset_query()

wp_reset_postdata() should always be used to reset the post data after a new WP_Query. wp_reset_query() should only ever be used in conjunction with query_posts(), which should rarely, if ever, be used.

  • template-parts/homepage.php
  • inc/home-slider.php

Post title in attributes

You need to use the_title_attribute() when displaying the post title in an attribute. See template-parts/content.php:

<a href="<?php the_permalink(); ?>" title="<?php the_title(); ?>"><?php the_post_thumbnail('matata-featured'); ?></a>

Deprecated tags

The following tags are no longer being used in the repository and should be removed:

white
responsive-layout
light

#24 @themetracbot
14 months ago

  • Summary changed from THEME: Matata – 1.1.4 to THEME: Matata – 1.1.5

Matata - 1.1.5

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.5
ZIP - https://wordpress.org/themes/download/matata.1.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1.4&new_path=matata/1.1.5

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.5/screenshot.png

#25 @JusThemes
14 months ago

Should i escape get_theme_mod in template-parts/content.php?

#26 @grapplerulrich
14 months ago

get_theme_mod must always be escaped.

#27 @greenshady
14 months ago

@JusThemes - You wanna send in your update with that escaped? Everything else looks good and is ready to go live.

#28 @themetracbot
14 months ago

  • Summary changed from THEME: Matata – 1.1.5 to THEME: Matata – 1.1.6

Matata - 1.1.6

Matata is a perfect responsive theme for blogs and magazines. Suitable for news, newspaper, magazine, publishing, business and any kind of sites. Support Forum: http://justhemes.com/forums Demo: http://justhemes.com/demo/matata

Theme URL - http://justhemes.com/matata
Author URL - http://justhemes.com

SVN - https://themes.svn.wordpress.org/matata/1.1.6
ZIP - https://wordpress.org/themes/download/matata.1.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=matata/1.1.5&new_path=matata/1.1.6

History:

Ticket Summary Status Resolution Owner
#29793 THEME: Matata – 1.1.6 closed live oceanwebthemes

(this ticket)

#34245 THEME: Matata – 1.1.7 closed live themetracbot
#42388 THEME: Matata – 1.1.8 closed live themetracbot


https://themes.svn.wordpress.org/matata/1.1.6/screenshot.png

#29 @greenshady
14 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.