WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2982 closed theme (not-approved)

THEME: SWIFT - 5.58

Reported by: gandham Owned by: emiluzelac
Priority: Keywords: theme-swift
Cc: satish_g2009@…

Description

SWIFT - 5.58

SWIFT, as the name says, is the fastest loading, SEO optimized, AdSense ready, server friendly WordPress theme. It features Magazine layout,two different header styles, tabbed interface, two different featured post sliders, 6 custom widgets. Bundled with lot of options to build your own unique, professional and browser-safe WordPress Theme.WordPress 3.0 ready with three menu locations and custom post types.SWIFT is the perfect choice for those who need a powerful and customizable theme. You can easily move your options from development server to live server with the built in import/export options function, a feature unique to SWIFT.Valid CSS3 & HTML.SWIFT has a active user community to help you with support queries.

Theme URL - http://swiftthemes.com/
Author URL - http://TechBU.com

SVN - http://themes.svn.wordpress.org/swift/5.58
ZIP - http://wordpress.org/extend/themes/download/swift.5.58.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/swift/5.57&new_path=/swift/5.58

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-swift&order=priority

https://themes.svn.wordpress.org/swift/5.58/screenshot.png

Change History (6)

comment:1 emiluzelac3 years ago

  • Owner set to emiluzelac
  • Status changed from new to accepted

comment:2 emiluzelac3 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

Theme check passed

Now there are few things that I see while testing the theme.

This comes up:

Notice: Undefined index: num_larger_page_numbers in /wp-content/themes/swift/includes/wp-pagenavi.php on line 47

Notice: Undefined index: larger_page_numbers_multiple in /wp-content/themes/swift/includes/wp-pagenavi.php on line 48

The Gallery

There is a long horizontal scroll, please see the screenshot and the margin around the thumbs as well.

Theme Options

The text in blue background overflows the form input, which makes impossible to use. Please see the screenshot for that as well.

Need help (sidebar) isn't on the right in IE8, it's underneath instead.

The Titles

Long titles, such as "If you say it loud enough, you’ll always sound precocious; Supercalifragilisticexpialidocious!" we use and recommend while testing the theme overflows the content. Here is the screenshot.

Additionally the screenshot doesn't match your current design, please make a note of that.

There are improvements, however also some new issues as well. While we would really love to see this theme approved, unfortunately the above mentioned does not allow us to. Please check your theme once again and please make sure that you're using the theme unit test data as well, it's very important that you do that and also check the theme in several different browsers.

Please do post your questions here.

As always if you need an additional information, please visit Theme Review resources.

Note:

This theme was tested on IE8, Google Chrome, FF and Safari.

Thanks.

Last edited 3 years ago by emiluzelac (previous) (diff)

comment:3 emiluzelac3 years ago

It was brought to my attention that the review didn't gave a clear instructions what needs to be done. Here are the additional information.

What need to be done and possible fixes as well

  • The horizontal scroll - attachments
<div class="grid_960 clearfix" id="main-container">

Line 76, Column 51: Unclosed element div, also </body> End tag for body seen but there were unclosed elements.

Blue "SWIFT premium is coming soon, subscribe to our news letter and be the first on to know."

  • #mc_embed_signup legend in themes.php

(you could add a width)

  • Need Help

(There's no class to this, there are some inline styles)

  • The Gallery Thumbs

(.gallery img is being overwritten by an .entry img take a look what happens and how the thumbs show nicely when .entry img isn't present)

  • Long Titles

(You can do few things, a) make sure that the title is inside of the content, if it isn't already b) set a width: 580px to .post-title, or set max-width: 580px, whichever you prefer better.)

Other todo

  • The notice produced by integrated plugin WP-Pagenavi
Notice: Undefined index: num_larger_page_numbers in /wp-content/themes/swift/includes/wp-pagenavi.php on line 47

Notice: Undefined index: larger_page_numbers_multiple in /wp-content/themes/swift/includes/wp-pagenavi.php on line 48

and this refers to:

$larger_page_to_show = intval($pagenavi_options['num_larger_page_numbers']);
$larger_page_multiple = intval($pagenavi_options['larger_page_numbers_multiple']);
  • Update theme's screenshot
  • One extra thing that I haven't seen earlier and I do apologize for that is two links in footer area, please keep only one.

If this review isn't clear enough, feel free to post your questions and I will gladly explain further.

Helpful Links

Theme Credit Links
Theme Review
Theme Unit Test

comment:4 gandham3 years ago

The horizontal scroll - attachments
Added the missing DIV

#mc_embed_signup legend in themes.php
Changed it to div

The Gallery Thumbs

Fixed
Long Titles
Added word-wrap CSS property

TODO

Added a isset condition

Changed the default layout to match the screen shot.

Footer links are to the same domain, there are themes in the repository that have two links
This one for example
http://wordpress.org/extend/themes/atahualpa

New version here
http://themes.trac.wordpress.org/ticket/2984

comment:5 emiluzelac3 years ago

Thank you sir :)

Note: See TracTickets for help on using tickets.