WordPress.org

Make WordPress Themes

Opened 22 months ago

Closed 16 months ago

Last modified 16 months ago

#29894 closed theme (live)

THEME: PhotoBlogger – 1.1.0

Reported by: HannibalBector Owned by: thelukemcdonald
Priority: new theme Keywords: theme-photoblogger accessibility-ready
Cc: michael.van.den.berg@…, joedolson

Description

PhotoBlogger - 1.0.0

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s one of the few themes that have passed the accessibility reviews. It supports several post formats, a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.0
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.0/screenshot.png

Change History (37)

#1 @themetracbot
21 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.0 to THEME: PhotoBlogger – 1.0.1

PhotoBlogger - 1.0.1

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s one of the few themes that have passed the accessibility reviews. It supports several post formats, a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.1
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.0&new_path=photoblogger/1.0.1

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.1/screenshot.png

#2 @themetracbot
17 months ago

  • Owner set to thelukemcdonald
  • Status changed from new to reviewing

#3 @thelukemcdonald
17 months ago

Hi @HannibalBector,

I'll be reviewing PhotoBlogger v1.0.1. When reviewing, I'll add a list of required changes, if any, that will need to be made before the next theme review. I'll also add any recommendations and/or notes that that aren't required, but may be good practice or worth mentioning.

#4 @HannibalBector
17 months ago

Hello @thelukemcdonald,

Then I'll be eagerly awaiting the review. :)

#5 @thelukemcdonald
17 months ago

Required

Required items that must be met before theme can be approved.

Code

  • Escape all attributes and content output. There are a number of places this needs done, a *few* of which I've mentioned below.
  • Escape translations using _e(), __(), _x(). e.g. searchform.php
  • Escape form action url in searchform.php
  • Escape input value in searchform.php
  • Remove echo from title and placeholder values in searchform.php. These are already printed with esc_attr_e().
  • Escape get_the_author() in inc/author-bio.php
  • Escape $autoplay in header-featured.php
  • Escape all attributes and content output in inc/custom-widgets.php
  • Update aperture_custom_header_options to use theme prefix. e.g. photoblogger_custom_header_options

Translations

  • Translate all text strings. e.g. L22 inc/customizer.php
  • Translate name string in photoblogger_register_required_plugins() on L210 functions.php

Licensing

  • Flickity URL in readme.txt is incorrect

Options and Settings

  • Add/use edit_theme_options for Customizer setting capabilities. e.g.
    $wp_customize->add_setting( 'photoblogger_slider_autoplay', array(
    	'capability' => 'edit_theme_options',
    ) );
    

Stylesheets and Scripts

  • Remove minified version Flickity script. Use original un-minified script.
  • Update theme tags with new w.org tags

Recommended

Not required but good practice.

  • Consider removing photoblogger_custom_header_url Customizer option and integration. The home_url() can be changed via Settings > General > Site Address (URL). If nothing else, consider filtering that url.
  • Consider adding custom logo support and remove Jetpack Site Logo support.
  • Consider updating TGM Plugin to current version (2.6.1)
  • Consider removing header-none.php. The else statement for this could probably be removed from header.php.
  • Consider removing searchform.php and rely on core template.
  • Consider optimizing screenshot.png to reduce filesize.
  • Consider adding a semi-colon to the end of PHP statements. e.g. L21 footer.php <?php echo date("Y") ?>. Do a search for ) ?>
  • Consider using single quotes around arguments passed in PHP functions. e.g. L21 footer.php <?php echo date("Y") ?>
  • Consider using single quotes in JavaScript files. Currently, mixed quotes styles are used.
  • Consider adding support for the Footer Credits plugin.
  • Consider the additional recommendations provided by the Theme Check plugin.
Last edited 17 months ago by thelukemcdonald (previous) (diff)

#6 @thelukemcdonald
17 months ago

Hi @HannibalBector,

Above are required, recommended, and notes for the PhotoBlogger theme. The required notes will need to be addressed before uploading a new version. At that time, the theme will be reviewed again and any additional notes will be made. I typically do a code review the first round and a design review the second go around. Let me know if you have any questions.

#7 @HannibalBector
17 months ago

Hi @thelukemcdonald,

Thank you for the extensive review!

I'm not sure if I'm able to work on this before the weekend, but I will try to update the theme as quickly as possible. :)

#8 @themetracbot
17 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.1 to THEME: PhotoBlogger – 1.0.2

PhotoBlogger - 1.0.2

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.2
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.1&new_path=photoblogger/1.0.2

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.2/screenshot.png

#9 @HannibalBector
17 months ago

Hi @thelukemcdonald,

I've uploaded a new version and I've fixed all of the required items (except the Flickity url in the readme file, since the url was correct; and instead of removing the minified version of Flickity I've added a un-minified version to the theme) and most of the recommended items.

#10 @thelukemcdonald
17 months ago

  • Keywords changed from theme-photoblogger, accessibility-ready to theme-photoblogger accessibility-ready

Required

Code

The esc_textarea() on L33 template-parts/author-bio.php is intended to be used to escape text inside a <textarea> element. A more accurate function to use here might be wp_kses(). Here is an example of what that escaping may look like (untested):

<?php 
echo wp_kses( wpautop( get_the_author_meta( 'description' ) ), array(
	'a'    => array( 'class' => true, 'href' => true ),
	'p'    => array(),
	'span' => array( 'class' => true ),
) ); 

Escaping

It looks like there are a few more translated strings and or content that need to be escaped. E.g. __() would become esc_html__().

  • footer.php L27
  • header.php L30
  • single.php L25-26
  • inc/customizer.php L21-22, 27, 30, 35, 38, 43, 46, 56, 61-63, 73, 86
  • inc/plugin-enhancements.php L106, 115, 124, 133, 142, 151, 160
  • template-parts/author-bio.php L12, 37
  • template-parts/header-featured.php L25, 28 ('Read More')
  • There can only be one footer credit link (link to WordPress does not count); there are currently two. Maybe reconsider adding support for the Footer Credits plugin to allow users maximum control over this content.

Design

Site Logo

  • Many users don't size their logos before uploading, often resulting in large image. In this case, the site title can take over the header and featured images. You'll probably want to set some sane width and/or height defaults. Maybe consider limiting both to 300px or something.

Site Title

  • The Site title tends to wrap on smaller screens when displaying relatively short, not to mention longer, site titles. When this happens, the "Menu" label sits on top of the menu icon. If kept, the menu label would likely need some bottom margin.


Recommended

Code

  • Remove minified version of Flickity. Unless there is a purpose to keep this around, it might be best to remove this script and enqueue it original version. A plugin can handle the minification of scripts and styles if desired.

Options and Settings

  • Consider a Customizer setting to enable mobile search functionality.

Design

  • The social navigation doesn't show in the header on smaller screens, it does show in the footer though. Maybe consider hiding the social navigation on larger screens where navigation also shows in the header.
  • The header can contain a site logo, site title, site navigation, and social navigation all on one line. This tends to cause some visual issues. I understand this is difficult to manage and design around, so it's not required, however it might be worth looking into to see how creative you can get.


Notes

  • You might consider removing the accessibility-ready initially. Adding this tag requires a separate accessibility review and may a specialized theme team member. Removing the tag initially will help speed up the themes launch process, in which you can add it after launch to then go through the review process. That's just food for thought.

#11 @thelukemcdonald
17 months ago

Hi @HannibalBector,

There were a few other strings that needed escaped, otherwise, things look really good! Once the required items are updated, I'll take another quick look and most likely move it the next stage in the game. Let me know if you have any questions.

#12 @themetracbot
17 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.2 to THEME: PhotoBlogger – 1.0.3

PhotoBlogger - 1.0.3

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.3
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.2&new_path=photoblogger/1.0.3

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.3/screenshot.png

#13 @HannibalBector
17 months ago

Hi @thelukemcdonald,

I've updated the theme and fixed all the required stuff. As you've probably noticed from my code and design: I'm not a web designer (my day job doesn't require me to code or design at all; entirely different field), but I'm learning and thanks to you I'm finally beginning to see that I misunderstood the concept of escaping. Thanks! :D

I will look at the recommended stuff wednesday when I have more time (and I think I will support Footer Credits).

Just one question about the minified version of Flickity: Why is it better to replace the minified version with a non-minified version? I would expect that a user who isn't using a plugin for minification would have much to gain if the theme uses a minified script (about 90kb difference).

#14 @thelukemcdonald
17 months ago

It's interesting to hear you're not in the web design or development field considering the quality of the themes design and code, which I thought was done well.

As far as the magnification of scripts, it's a requirement that these not be used I'm guessing for security and reviewing purposes. The escaping of translations falls into the security boat as well.

I believe the next step is for a Theme Team member to take a look at the theme. From there, it will most likely be put in line for an accessibility review, though I'm not entirely sure at this point. Stay posted.

#15 @thelukemcdonald
17 months ago

  • Status changed from reviewing to approved

#16 @joedolson
17 months ago

  • Status changed from approved to reopened

Reopening for accessibility-ready review.

@thelukemcdonald Please remember to ping either myself or @davidakennedy when a theme has the accessibility-ready tag, so that we know that it's ready for a review. Thanks!

#17 @grapplerulrich
16 months ago

  • Cc joedolson added
  • Status changed from reopened to reviewing

#18 @davidakennedy
16 months ago

Hi there!

Thanks for creating a WordPress theme and submitting it to the WordPress.org directory!

Since your theme also includes the accessibility-ready tag, I've also reviewed it according to those requirements, which you can find here: https://make.wordpress.org/themes/handbook/review/accessibility/

Anything in marked required will need to be fixed before the theme can be approved. Anything marked recommended is optional for you to consider and/or fix.

Nice job overall! There are only a few minor fixes needed to pass the review.

Keyboard Navigation

Required: Form inputs and the menu toggle should have some focus styles beyond color change alone. Like changing the border or box shadow.

Controls

Pass.

Skip Links

Pass.

Forms

Pass.

Headings

Pass.

Recommended: I would make the <h1> for the main menu a <h2> since it's not the most important item on the page. That way, every page as one top level heading.

ARIA Landmark Roles

Pass.

Recommended: It looks like the mobile menu toggle's aria-controls match up to the wrong id. It should match the menu it expands. That's an easy fix.

Link Text

Pass.

Contrasts

Pass.

Images

Pass.

Media

Pass.

Screen Reader Text

Pass.

Not Allowed

  • Any positive tabindex attribute: Pass.
  • The inclusion of the accesskey attribute: Pass.
  • Spawning new windows or tabs without warning the user: Pass.

Recommended

  • Zoomable text: Good. Menu links could be sized in relative units, but most of the theme flexes well when the font size increases.
  • Removal of title attributes: There are a few title attributes in the footer, featured header and search form that could be removed.

Notes

These are just a collection of thoughts and miscellaneous things I found while reviewing your theme.

  • If you have a long menu, on mobile the toggle button moves way down, which means you have to scroll a lot to close it. It might be a big improvement to position that absolutely or fix it to the top.
  • It's worth noting that I didn't include the featured content slider in my testing since it requires a plugin. However, I did take a quick look at it. The buttons need accessible text or labels with aria-label. The read more links should include the post title for better link text. The slider should be enhanced with ARIA so users no what's happening when a slide changes. Also, the buttons did not work in my screen reader (Voiceover) when I pressed control + option + spacebar. They only worked when I pressed enter.

Thanks again for creating with WordPress and sharing your work! If you have any questions about your review, don't hesitate to ask!

Cheers,
Dave

#19 @HannibalBector
16 months ago

Hi @davidakennedy,

Thanks for the review!

I've fixed the required stuff (the focus styles for inputs and the menu-toggle) and most of the recommended stuff.

There is however one thing that's not entirely clear to me: in the recommended section you suggest that I remove the title attribute in the featured header (the only title attribute is on the read more link), but in the notes you say that I should include the post title in the read more link for better link text. So my guess is that I can fix this by removing the title attritute and adding the post title as screen reader text. Is this correct?

I will upload the fixed version tomorrow (or if I need more time fixing the slider the day after tomorrow).

Thanks again!

Best regards,

Michael

#20 @HannibalBector
16 months ago

@davidakennedy

Never mind the question. I think I've already found the answer:
https://silktide.com/i-thought-title-text-improved-accessibility-i-was-wrong/

Sorry about that. Should have Googled first. :)

#21 @davidakennedy
16 months ago

@HannibalBector Hey! No worries – I should have been more specific.

I'm talking about removing these:

Footer: title="<?php bloginfo( 'name' ); ?>"
Search form: title="<?php esc_attr_e( 'Search for:', 'photoblogger' ); ?>"
Featured header (twice): title="<?php echo esc_attr( sprintf( __( 'Permalink to %s', 'photoblogger' ), the_title_attribute( 'echo=0' ) ) ); ?>"

And yes, title attributes are mostly useless. Not just because of accessibility, but also, they're limited to mouse-enabled computers, but many users use touch devices these days. This is why we recommend removing them. Any essential content should use real text or something like aria-label, if need be.

Looking forward to your fixes! Let me know if you have more questions. :)

#22 @themetracbot
16 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.3 to THEME: PhotoBlogger – 1.0.4

PhotoBlogger - 1.0.4

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.4
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.3&new_path=photoblogger/1.0.4

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.4/screenshot.png

#23 @HannibalBector
16 months ago

Hi @davidakennedy,

I've fixed the required stuff and I've followed most of you recommendations, except this part:
The slider should be enhanced with ARIA so users no what's happening when a slide changes. Also, the buttons did not work in my screen reader (Voiceover) when I pressed control + option + spacebar. They only worked when I pressed enter.

I need to think about this one. I'll try to fix this tomorrow.

I'm thinking about adding aria-hidden, and disabling autoplay when the user puts focus on the skip-to-content link (which almost all screenreader users do, right?). I might even hide the prev/next buttons in that case, because the slider will move to the next slide when the focus is on the title of that slide, so there is no need for those buttons.

Last edited 16 months ago by HannibalBector (previous) (diff)

#24 @themetracbot
16 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.4 to THEME: PhotoBlogger – 1.0.5

PhotoBlogger - 1.0.5

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.5
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.4&new_path=photoblogger/1.0.5

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.5/screenshot.png

#25 @HannibalBector
16 months ago

I think everything is fixed now, except for this: "The slider should be enhanced with ARIA so users no what's happening when a slide changes." I think I will add a default aria-hidden = true and change this when a slide gets a is-selected tag.

Will do this tomorrow. :)

#26 @HannibalBector
16 months ago

@davidakennedy

There seems to be a problem with uploading theme updates to the repository.

I'm getting an error and no new ticket is created.

But the theme has uploaded just fine and can be found here:
https://themes.svn.wordpress.org/photoblogger/1.0.7/


This theme should be ready for a new accessibility review. :)

#27 @HannibalBector
16 months ago

Just made a small update and this ticket still isn't being updated:
https://themes.svn.wordpress.org/photoblogger/

#28 @grapplerulrich
16 months ago

There is an issue with trac it will be fixed in a few days.

#29 @davidakennedy
16 months ago

Hey there,

Thanks for the updates. If it's not mentioned below, consider it fixed. I downloaded 1.0.8 and tested with it.

  • There is an error in the console on line 97: photoblogger.js?ver=20150115:97 Uncaught TypeError: $(...).flickity is not a function.

Keyboard Navigation

  • Form inputs still need a visible focus style, like a border, box shadow, etc. The mobile toggle looks good.

Let me know if you have any questions. Thanks for your hard work!

#30 @HannibalBector
16 months ago

Hi there,

Thanks for the review! I still can't upload an update, but you can find version 1.0.9 on GitHub:
https://github.com/MichaelVanDenBerg/PhotoBlogger

I've fixed the TypeError and added an extra box shadow to form inputs (though it already had an outline, but it might not have been very noticeable since both the border and the outline had the same color; and I've removed overflow hidden on the search form because that was hiding the outline). I hope everything is fixed now! :)

I will upload the update here when the issue with trac has been fixed.

Thanks again for your review! :)

#31 @themetracbot
16 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.5 to THEME: PhotoBlogger – 1.0.9

PhotoBlogger - 1.0.9

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? You know you want to! ;)

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.0.9
ZIP - https://wordpress.org/themes/download/photoblogger.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.5&new_path=photoblogger/1.0.9

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.0.9/screenshot.png

#32 @davidakennedy
16 months ago

Hey there,

Thanks for the updates. If it's not mentioned below, consider it fixed.

In that screenshot, I have the comment form input focused and there's no visible difference between unfocused elements. I know it's been frustrating with the upload form being broken for a few days – maybe that update got missed? I looked at version 1.0.9.

This is what I see for the focus styles:

input[type="text"]:focus,
input[type="email"]:focus,
input[type="url"]:focus,
input[type="password"]:focus,
input[type="search"]:focus,
textarea:focus {
  color: #111;
}

Thanks again for your work and updates on this theme. Almost there!

#33 @themetracbot
16 months ago

  • Summary changed from THEME: PhotoBlogger – 1.0.9 to THEME: PhotoBlogger – 1.1.0

PhotoBlogger - 1.1.0

PhotoBlogger is a theme specifically designed for photobloggers, photographers and artists wanting to showcase their art in a fullscreen slider. It’s modern, minimal and responsive, and it’s accessibility-ready. It supports several post formats (quote, link, image and aside), a full width page template, and… well, why don’t you just give it a try? Check out the demo at: http://wp.me/p8Ci4-ju

Theme URL - http://michaelvandenberg.com/portfolio/photoblogger/
Author URL - http://michaelvandenberg.com/

SVN - https://themes.svn.wordpress.org/photoblogger/1.1.0
ZIP - https://wordpress.org/themes/download/photoblogger.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=photoblogger/1.0.9&new_path=photoblogger/1.1.0

History:

Ticket Summary Status Resolution Owner
#29894 THEME: PhotoBlogger – 1.1.0 closed live thelukemcdonald

(this ticket)

#38114 THEME: PhotoBlogger – 1.1.1 closed live themetracbot
#38152 THEME: PhotoBlogger – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/photoblogger/1.1.0/screenshot.png

#34 @HannibalBector
16 months ago

Howdie!

It should be fixed now. I didn't notice it because the browser was applying default styling (a blue outline, both in Safari and Chrome). Sorry for that, should have noticed it. :)

#35 @davidakennedy
16 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good! Thanks for sticking with it, and making the changes. Congrats on PhotoBlogger!

#36 @HannibalBector
16 months ago

Thank you @davidakennedy and @thelukemcdonald for reviewing my theme! I've learned a lot because of guys like you help guys like me become better themers! Thanks again, much appreciated! :)

#37 @thelukemcdonald
16 months ago

You're welcome! Thanks for being responsive and open to feedback. Congrats on the launch!

Note: See TracTickets for help on using tickets.