WordPress.org

Make WordPress Themes

#30155 closed theme (not-approved)

THEME: Plumeria – 1.0.1

Reported by: plumeriatech Owned by: metallicarosetail
Priority: new theme Keywords: theme-plumeria
Cc: abhijeet@…

Description

Plumeria - 1.0.0

Plumeria blog theme is clean, paper background specially designed for the personal bloggers.

Theme URL -
Author URL - http://www.plumeriatech.com/

SVN - https://themes.svn.wordpress.org/plumeria/1.0.0
ZIP - https://wordpress.org/themes/download/plumeria.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#30155 THEME: Plumeria – 1.0.1 closed not-approved metallicarosetail

(this ticket)


https://themes.svn.wordpress.org/plumeria/1.0.0/screenshot.png

Change History (16)

#1 @plumeriatech
19 months ago

Hello Reviewer,

Could you please check my theme ?

Thanks,

#2 @themetracbot
18 months ago

  • Owner set to yekoone
  • Status changed from new to reviewing

#3 @yekoone
18 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Following tags has been deprecated, please remove it from your style.css header:

black
blue
brown
gray
green
orange
pink
purple
red
silver
tan
white
yellow
dark
light
responsive-layout
fixed-layout
fluid-layout
blavatar
photoblogging
seasonal

Also you can add these new tags:

grid-layout
footer-widgets
blog
e-commerce
education
entertainment
food-and-drink
holiday
news
photography
portfolio

Thanks for your patience, please fix the issues and write a comment here to reopen the ticket

#4 @grapplerulrich
18 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Reopening as a proper review was not done.

#5 @grapplerulrich
18 months ago

Removing theme reviewer as they have another theme to review.

#6 @grapplerulrich
18 months ago

  • Owner yekoone deleted
  • Status changed from reopened to reviewing

#7 @themetracbot
18 months ago

  • Owner set to asidethemes

#8 @asidethemes
18 months ago

  • Status changed from reviewing to approved

#9 @Otto42
18 months ago

  • Status changed from approved to reopened

#10 @Otto42
18 months ago

  • Owner asidethemes deleted
  • Status changed from reopened to reviewing

#11 @themetracbot
18 months ago

  • Summary changed from THEME: Plumeria – 1.0.0 to THEME: Plumeria – 1.0.1

Plumeria - 1.0.1

Plumeria blog theme is clean, paper background specially designed for the personal bloggers.

Theme URL -
Author URL - http://www.plumeriatech.com/

SVN - https://themes.svn.wordpress.org/plumeria/1.0.1
ZIP - https://wordpress.org/themes/download/plumeria.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumeria/1.0.0&new_path=plumeria/1.0.1

History:

Ticket Summary Status Resolution Owner
#30155 THEME: Plumeria – 1.0.1 closed not-approved metallicarosetail

(this ticket)


https://themes.svn.wordpress.org/plumeria/1.0.1/screenshot.png

#12 @plumeriatech
18 months ago

Hello,
I have removed the deprecated tags and added new tags.

Thank you!

#13 @themetracbot
17 months ago

  • Owner set to metallicarosetail

#14 @metallicarosetail
17 months ago

REQUIRED: Trying to get property of non-object on line 23 of /wp-content/themes/plumeria/footer.php
REQUIRED: On style.css. License should be below version. See the format of style.css on twentysixteen theme for reference

REQUIRED: What is the use of style.less and layout.css? If there is any unwanted file then remove it. Don't backup/ add on theme.
REQUIRED: Provide all the license of image which is inside image folder. If it is all your's own creating then then release/mention your license under GPLV3 or later (license required: mrec.jpg, 404.jpg).
REQUIRED: Remove all css and javascript from head. It must be enqueued from somewhere basically enqueue it from functions.php
<link href='https://fonts.googleapis.com/css?family=Roboto:400,400italic,500,700' rel='stylesheet' type='text/css'>
<link href='https://fonts.googleapis.com/css?family=Montserrat:400,700' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="<?php echo get_template_directory_uri();?>/css/font-awesome.css"/>
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/owl.transitions.css">
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/owl.theme.css">
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/owl.carousel.css">
link rel="stylesheet" type="text/css" href="<?php echo get_template_directory_uri(); ?>/css/prettyPhoto.css" media="screen" />
<script src="<?php echo get_template_directory_uri(); ?>/js/jquery-1.11.3.min.js" type="text/javascript"></script>
<script type="text/javascript" src="<?php echo get_template_directory_uri(); ?>/js/jquery.prettyPhoto.js"></script>
<script src="<?php echo get_template_directory_uri(); ?>/js/main.js" type="text/javascript"></script>
<script src="<?php echo get_template_directory_uri(); ?>/js/owl.carousel.js" type="text/javascript"></script>
REQUIRED: Don't enqueue jquery-1.11.3.min.js by yourself. WordPress comes with its own jquery and remove from folder too
REQUIRED: If you are using minified version of jquery then provide unminified version jquery too. Provide unminified version of jquery.prettyPhoto.js
REQUIRED: main.js remove this code if not used

/* $(window).on( 'scroll', function(){
    var stickyTop = $('#left-sidebar').offset().top;
    if ($(window).scrollTop() >= stickyTop) {
        $('#left-sidebar').addClass('fixed');
    } else {
        $('#left-sidebar').removeClass('fixed');
    }
});*/

REQUIRED: content.php on line no 15 remove this code <?php /*if($url == ){ $url = get_template_directory_uri()."/images/default-thumbnail.jpg"; } */?>
REQUIRED: footer.php on line no 19 <!--<img src="<?php /*echo get_template_directory_uri(); */?>/images/logo-plumeria.png" alt="" class="logo-footer"/>--> and also found on header.php. check it on other place too . Is this line required ? <?php $url = wp_get_attachment_url(get_post_thumbnail_id($post->ID, 'thumbnail')); ?>
REQUIRED: Translation not ready. Translate text MENU, Gallery, Categories, Copyright, All Rights Reserved, Latest News, earch Site. Check it on other place too.
REQUIRED: I am not sure on it so i posted it on slack and then told that it need to be escaped. So escape wp_get_attachment_url() and get_template_directory_uri() from 404.php. So escape $url
REQUIRED: index.php on line no 181 escape this value <?php echo $cat->name; ?> . Remove unwanted code on line no 149

/*'meta_query' => array(
array(
	'key' => '_thumbnail_id'
),
)*/

Theme Check Plugin:
RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is plumeria
INFO: At least one hard coded date was found in the file template-parts/content.php. Consider get_option( 'date_format' ) instead.
INFO: At least one hard coded date was found in the file template-parts/content-search.php. Consider get_option( 'date_format' ) instead.
INFO: At least one hard coded date was found in the file index.php. Consider get_option( 'date_format' ) instead.

Note:
This is my initial review. After submitting a new version i will review deeply on this theme.
REQUIRED points should be resolved for theme approved. RECOMMENDED points are optional but its a best practices. Theme will not be rejected on the base of RECOMMENDED points.
Please response within 7 days. Otherwise your theme will marked as not approved.
Please follow the theme development guideline for making theme. https://make.wordpress.org/themes/handbook/review/
After solving this review, please submit your theme on https://wordpress.org/themes/upload/
If you have any confusion please ask your query on #themereview channel on WordPress slack or ping me on @metallicarosetail

Thank you!
Metallica RoseTail

#15 @metallicarosetail
17 months ago

@plumeriatech

Its already 7 days and you are not responding with any message. Respond it within 24 hours otherwise this ticket will be resolve as not approved.

Thank you!

#16 @metallicarosetail
17 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing as not-approved as there has been no communication with theme author in over 7 days.

Thank you!

Note: See TracTickets for help on using tickets.