WordPress.org

Make WordPress Themes

Opened 21 months ago

Closed 13 months ago

Last modified 13 months ago

#30243 closed theme (live)

THEME: Vicem – 1.0.5

Reported by: monikarao Owned by: edmund.turbin
Priority: previously reviewed Keywords: theme-vicem
Cc: monika@…, djrmom

Description

Vicem - 1.0.2

Vicem is a new theme that allows you to create blogs and websites.The theme is well designed and does not require any other hard work to get it up and running right away. All the hard work has been done in this theme, it is clean and efficient.

Theme URL -
Author URL - https://github.com/monika-12

SVN - https://themes.svn.wordpress.org/vicem/1.0.2
ZIP - https://wordpress.org/themes/download/vicem.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=vicem/1.0.1&new_path=vicem/1.0.2

History:

Ticket Summary Status Resolution Owner
#29965 THEME: Vicem – 1.0.1 closed not-approved karmatosed
#30243 THEME: Vicem – 1.0.5 closed live edmund.turbin

(this ticket)


https://themes.svn.wordpress.org/vicem/1.0.2/screenshot.png

Change History (25)

#1 @themetracbot
20 months ago

  • Summary changed from THEME: Vicem – 1.0.2 to THEME: Vicem – 1.0.3

Vicem - 1.0.3

Vicem is a new theme that allows you to create blogs and websites.The theme is well designed and does not require any other hard work to get it up and running right away. All the hard work has been done in this theme, it is clean and efficient.

Theme URL -
Author URL - https://github.com/monika-12

SVN - https://themes.svn.wordpress.org/vicem/1.0.3
ZIP - https://wordpress.org/themes/download/vicem.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=vicem/1.0.2&new_path=vicem/1.0.3

History:

Ticket Summary Status Resolution Owner
#29965 THEME: Vicem – 1.0.1 closed not-approved karmatosed
#30243 THEME: Vicem – 1.0.5 closed live edmund.turbin

(this ticket)


https://themes.svn.wordpress.org/vicem/1.0.3/screenshot.png

#2 @themetracbot
17 months ago

  • Owner set to yekoone
  • Status changed from new to reviewing

#3 @yekoone
17 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Following tags has been deprecated, please remove it from your style.css header:

black
blue
brown
gray
green
orange
pink
purple
red
silver
tan
white
yellow
dark
light
responsive-layout
fixed-layout
fluid-layout
blavatar
photoblogging
seasonal

Also you can add these new tags:

grid-layout
footer-widgets
blog
e-commerce
education
entertainment
food-and-drink
holiday
news
photography
portfolio

Thanks for your patience, please fix the issues and write a comment here to reopen the ticket

#4 @grapplerulrich
17 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Reopening as a proper review was not done.

#5 @grapplerulrich
17 months ago

Removing theme reviewer as they have another theme to review.

#6 @grapplerulrich
17 months ago

  • Owner yekoone deleted
  • Status changed from reopened to reviewing

#7 @themetracbot
16 months ago

  • Owner set to edmund.turbin

#8 @edmund.turbin
16 months ago

Theme Check Results

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.

The domains found are vicem, text-domain

Please check vicem/inc/customizer.php for text-domain


  • WARNING: The tag light has been deprecated, please remove it from your style.css header.


  • RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • RECOMMENDED: Screenshot is wrong size! Detected: 1902x1283px. Maximum allowed size is 1200x900px.
  • RECOMMENDED: Screenshot dimensions are wrong! Ratio of width to height should be 4:3.

Required
header.php
Change Viewport tag content value (misspelled) from content="width=devicem-width, to content="width=device-width,

Recommended
Follow Theme Check recommendations and warnings above

Responsive design

  • The theme should be responsive
  • Mobile menu needs styling/positioning
  • Change .site-main and .wrap classes to uses max-width rather than width in style.css

Documentation

  • Provide some info in the readme on what can with customizer social media options
  • Readme version numbers to be bumped up to current

Customizer

  • Header Image does not display if added via the customizer

Consider adding descriptions in the customizer social media options so that users are clear on what they need to do.

#9 @edmund.turbin
16 months ago

Hello @monikarao

I wanted to let you know that I spent some time reviewing your theme yesterday. Some small changes are needed, but quality is good overall. I'd urge you to improve your theme's responsiveness as it does not display well for small screens. I've left some required changes and recommendations in the above comment 8. Please do not hesitate to reach out if you have any questions and happy theming!

#10 @monikarao
16 months ago

Hello @edmund.turbin

Thanks for your review. I'll submit the updated version of the theme by this weekend.

#11 @monikarao
16 months ago

Hello @edmund.turbin

I've updated changes and will upload it today.I've not worked on responsive part of theme.So Let me know is it required to make responsive theme?

Thanks

#12 @edmund.turbin
16 months ago

Hi @monikarao

Looking forward to the updates. The theme is not required to be responsive, but it would make sense as underscores already gives you some of the tools you need. Lots of mobile users on the web today, and would be great for your theme to support them.

Cheers,
Edmund

#13 @themetracbot
16 months ago

  • Summary changed from THEME: Vicem – 1.0.3 to THEME: Vicem – 1.0.4

Vicem - 1.0.4

Vicem is a new theme that allows you to create blogs and websites.The theme is well designed and does not require any other hard work to get it up and running right away. All the hard work has been done in this theme, it is clean and efficient.

Theme URL -
Author URL - https://github.com/monika-12

SVN - https://themes.svn.wordpress.org/vicem/1.0.4
ZIP - https://wordpress.org/themes/download/vicem.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=vicem/1.0.3&new_path=vicem/1.0.4

History:

Ticket Summary Status Resolution Owner
#29965 THEME: Vicem – 1.0.1 closed not-approved karmatosed
#30243 THEME: Vicem – 1.0.5 closed live edmund.turbin

(this ticket)


https://themes.svn.wordpress.org/vicem/1.0.4/screenshot.png

#14 @grapplerulrich
15 months ago

@edmund.turbin Have you seen the update?

#15 @edmund.turbin
15 months ago

  • Status changed from reviewing to approved

Great work Monika! I'll get this approved.

#16 @monikarao
15 months ago

Thanks @edmund.turbin

#17 @djrmom
14 months ago

  • Cc djrmom added
  • Status changed from approved to reopened

#18 follow-ups: @djrmom
13 months ago

  • Owner changed from edmund.turbin to monikarao
  • Status changed from reopened to reviewing

Hi @edmund.turbin,

Your theme has just a few required issues before it can be made live. You will not need to wait in the queue again once fixed but please make sure to update or comment within 7 days to keep your ticket open. Please let me know if you have any questions.

Options

  • header image, header text color, and display site title options are not working, if you don't want to support these, just don't add_theme_support for theme
  • disable social icons until the user has added their info

Internationalization

  • this should be __( instead of _( 'description' => _('This is the Social Media Section.Add URL to display Social Icons in footer.')
  • content.php Read More text needs to be translation ready
  • update vicem.pot for your theme or remove it as it is not required

Scripts/Styles

  • Unnmodified third party bundled scripts/styles should not be prefixed. Use wp_enqueue_style('font-awesome' instead of wp_enqueue_style('vicem-fontawesome'
  • google font enqueues should be prefixed, please add prefix to wp_enqueue_style('font-name'

Security

  • content.php get_permalink needs esc_url

Code

  • Use the_excerpt and its filters instead of vicem_limit_content
  • remove layouts folder if unused

Licensing

  • if this is your image "https://s3.amazonaws.com/uifaces/faces/twitter/k/128.jpg" please include a statement that it is created by you in readme.txt, if not, there needs to be a source link to verify the license
  • You need to include your own copyright statement, ex. Fred WordPress Theme, Copyright 2012 Joe Smith

@monikarao, please continue the review and re-approve when ready.

Thanks,
Jenny

#19 in reply to: ↑ 18 @edmund.turbin
13 months ago

Hi @djrmom.

Apologies for the confusion. Sounds like @monikarao needs to update her theme with your recommended fixes. Once this is done I'm happy to approve.

Cheers,
Edmund

Replying to djrmom:

Hi @edmund.turbin,

Your theme has just a few required issues before it can be made live. You will not need to wait in the queue again once fixed but please make sure to update or comment within 7 days to keep your ticket open. Please let me know if you have any questions.

Options

  • header image, header text color, and display site title options are not working, if you don't want to support these, just don't add_theme_support for theme
  • disable social icons until the user has added their info

Internationalization

  • this should be __( instead of _( 'description' => _('This is the Social Media Section.Add URL to display Social Icons in footer.')
  • content.php Read More text needs to be translation ready
  • update vicem.pot for your theme or remove it as it is not required

Scripts/Styles

  • Unnmodified third party bundled scripts/styles should not be prefixed. Use wp_enqueue_style('font-awesome' instead of wp_enqueue_style('vicem-fontawesome'
  • google font enqueues should be prefixed, please add prefix to wp_enqueue_style('font-name'

Security

  • content.php get_permalink needs esc_url

Code

  • Use the_excerpt and its filters instead of vicem_limit_content
  • remove layouts folder if unused

Licensing

  • if this is your image "https://s3.amazonaws.com/uifaces/faces/twitter/k/128.jpg" please include a statement that it is created by you in readme.txt, if not, there needs to be a source link to verify the license
  • You need to include your own copyright statement, ex. Fred WordPress Theme, Copyright 2012 Joe Smith

@monikarao, please continue the review and re-approve when ready.

Thanks,
Jenny

#20 @djrmom
13 months ago

  • Owner changed from monikarao to edmund.turbin

Sorry, got the names backwards. Thanks.

#21 @monikarao
13 months ago

Thanks @djrmom

I will update the theme with required fixes.

#22 @themetracbot
13 months ago

  • Summary changed from THEME: Vicem – 1.0.4 to THEME: Vicem – 1.0.5

Vicem - 1.0.5

Vicem is a new theme that allows you to create blogs and websites.The theme is well designed and does not require any other hard work to get it up and running right away. All the hard work has been done in this theme, it is clean and efficient.

Theme URL -
Author URL - https://github.com/monika-12

SVN - https://themes.svn.wordpress.org/vicem/1.0.5
ZIP - https://wordpress.org/themes/download/vicem.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=vicem/1.0.4&new_path=vicem/1.0.5

History:

Ticket Summary Status Resolution Owner
#29965 THEME: Vicem – 1.0.1 closed not-approved karmatosed
#30243 THEME: Vicem – 1.0.5 closed live edmund.turbin

(this ticket)


https://themes.svn.wordpress.org/vicem/1.0.5/screenshot.png

#23 in reply to: ↑ 18 @monikarao
13 months ago

Hello @djrmom

I've updated the theme with all required fixed. Please let me know if any problems I missed.

Thanks

#24 @djrmom
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @monikarao,

Please fix on update:

  • Use wp_enqueue_style('font-awesome' instead of wp_enqueue_style('fontawesome'

Congrats your theme is now live.

#25 @monikarao
13 months ago

Thanks @djrmom

I'll update this in next release.

Note: See TracTickets for help on using tickets.