WordPress.org

Make WordPress Themes

Opened 23 months ago

Closed 15 months ago

Last modified 15 months ago

#30331 closed theme (live)

THEME: Purus – 1.1.5

Reported by: Prelc Owned by: ThemeZee
Priority: new theme Keywords: theme-purus
Cc: mareprelc@…

Description

Purus - 1.0.0

Clean and simple WordPress blog theme focused on readability.

Theme URL - http://www.prelc.si/purus
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/purus/1.0.0
ZIP - https://wordpress.org/themes/download/purus.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#30331 THEME: Purus – 1.1.5 closed live ThemeZee

(this ticket)

#37871 THEME: Purus – 1.2.0 closed live themetracbot
#38494 THEME: Purus – 1.2.1 closed live themetracbot
#41367 THEME: Purus – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/purus/1.0.0/screenshot.jpg

Attachments (1)

purus.zip (332.1 KB) - added by Prelc 18 months ago.
Purus v1.1.0

Download all attachments as: .zip

Change History (21)

#1 @ThemeZee
18 months ago

  • Owner set to ThemeZee
  • Status changed from new to reviewing

#2 @ThemeZee
18 months ago

Great theme! I really like the minimalistic design :)

Required Issues

There are some issues which are required by the theme review guidelines and have to be fixed before the theme can be approved.

Theme Logo
Please use the new custom logo feature of WordPress 4.5 instead of your own header logo setting. You can learn more about it on https://codex.wordpress.org/Theme_Logo

I know WordPress 4.5 was not available 5 months ago, but it is required by the Theme Review Guidelines to use WordPress core methods if available.

Custom JS
Please remove the settings for adding custom JS code to head and footer of the theme. This is considered plugin territory and not allowed in themes hosted on wordpress.org

Functions.php
You are registering requirejs for bower but the file does not exist.

Prefixing
You need to prefix every single function with the theme slug = purus_

For example:

function new_excerpt_more()
function custom_oembed_filter()
function google_fonts()
class Color

Unprefixed functions can easily lead to fatal errors if the same function names are used in plugins or child themes.


I will leave the ticket open for 7 days so you have time to fix these issues. Please let me know if you have any questions.

#3 @Prelc
18 months ago

Thanks a lot for the nice words and the review. I will try my best to fix all the issues in 7 days.

@Prelc
18 months ago

Purus v1.1.0

#4 @Prelc
18 months ago

I don't know if this is the right way, but i uploaded fixed theme as the attachment.

Please let me know if i need to upload it somwhere else.

#5 @themetracbot
18 months ago

  • Summary changed from THEME: Purus – 1.0.0 to THEME: Purus – 1.1.0

Purus - 1.1.0

Clean and simple WordPress blog theme focused on readability.

Theme URL - http://www.prelc.si/purus
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/purus/1.1.0
ZIP - https://wordpress.org/themes/download/purus.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=purus/1.0.0&new_path=purus/1.1.0

History:

Ticket Summary Status Resolution Owner
#30331 THEME: Purus – 1.1.5 closed live ThemeZee

(this ticket)

#37871 THEME: Purus – 1.2.0 closed live themetracbot
#38494 THEME: Purus – 1.2.1 closed live themetracbot
#41367 THEME: Purus – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/purus/1.1.0/screenshot.jpg

#6 @ThemeZee
18 months ago

Thanks for the update.

Required

I took some closer look at the settings which is important due to security reasons.

Custom CSS
Please use the wp_filter_nohtml_kses() function in /inc/theme-customizer.php to sanitize the input of the Custom CSS setting.

You can find more details on https://make.wordpress.org/themes/2015/02/10/custom-css-boxes-in-themes/

Sanitization of Select fields
Please use a proper function to sanitize select fields. sanitize_text_field is for text fields.

You can find an example of a good sanitize_select function on https://github.com/WPTRT/code-examples/blob/master/customizer/sanitization-callbacks.php#L262

Licensing
Please include a readme.txt file with proper copyright attribution. You also need to list the license of all included third-party ressources and license information about images in the screenshot.

Since WordPress themes have to be GPL all included ressources must have a GPL compatible license.

You can find an example of a readme file on https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/


I will leave the ticket open for 7 days so you have time to fix these issues. Please let me know if you have any questions.

#7 @Prelc
18 months ago

I was trying to upload the theme for last two days but it looks like track is still down? Problem is that i'am going on holidays tomorrow and i will be away until 15. July. If it's possible i would be really glad if ticket stays open meanwhile and i will try to upload everything first moment when i get back or maybe even in between. I already made all the fixes, so i just need to wait for system to starts working again.

Take care!

#8 @ThemeZee
18 months ago

No problem, we can keep the ticket open and continue the review in July.

Enjoy your holiday :)

#9 @themetracbot
17 months ago

  • Summary changed from THEME: Purus – 1.1.0 to THEME: Purus – 1.1.3

Purus - 1.1.3

Clean and simple WordPress blog theme focused on readability.

Theme URL - http://www.prelc.si/purus
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/purus/1.1.3
ZIP - https://wordpress.org/themes/download/purus.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=purus/1.1.0&new_path=purus/1.1.3

History:

Ticket Summary Status Resolution Owner
#30331 THEME: Purus – 1.1.5 closed live ThemeZee

(this ticket)

#37871 THEME: Purus – 1.2.0 closed live themetracbot
#38494 THEME: Purus – 1.2.1 closed live themetracbot
#41367 THEME: Purus – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/purus/1.1.3/screenshot.jpg

#10 @ThemeZee
17 months ago

  • Status changed from reviewing to approved

This looks all good now and I'm approving the theme.

The theme goes in the admin queue and will get a final review before it is set live by an admin.

#11 @Prelc
17 months ago

Great to hear that! :) Thanks for your time and review.

#12 @greenshady
16 months ago

  • Status changed from approved to reopened

I'm taking over the admin review.

#13 @greenshady
16 months ago

  • Status changed from reopened to reviewing

There's just a few things that we need to get squared away before your theme can go live.

Theme URI

The Theme URI (if used) must link to a page with information about your theme. It cannot merely be a demo.

Comments on pages

Pages must display the comment form and comment list.

Proper ellipsis (recommended)

Your filter on excerpt more should use a proper ellipsis. Three periods do make an ellipsis.

return ' ...';

… gives you the correct character.

Default footer customizer settings

You need to make sure to internationalize the default footer text in the customizer so that it can be translated:

$wp_customize->add_setting(
	'footer_left',
	array(
		'default' => 'Purus - WordPress theme made by <a href="https://twitter.com/prelc">Prelc</a>.',
		'sanitize_callback' => 'wp_kses',
	)
);
$wp_customize->add_setting(
	'footer_right',
	array(
		'default' => '© 2016. All rights reserved.',
		'sanitize_callback' => 'wp_kses',
	)
);

Also, use &copy; so that you have a correct copyright symbol.

Storing theme options

You have two choices for storing your theme options:

  • Use the default method of theme mods (strongly recommended).
  • Save everything as a single option (array of settings).

You're not allowed to store everything as multiple DB options.

#14 @Prelc
16 months ago

Thanks for the review. I will fix everything as soon as possible.

#15 @themetracbot
16 months ago

  • Summary changed from THEME: Purus – 1.1.3 to THEME: Purus – 1.1.4

Purus - 1.1.4

Clean and simple WordPress blog theme focused on readability.

Theme URL -
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/purus/1.1.4
ZIP - https://wordpress.org/themes/download/purus.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=purus/1.1.3&new_path=purus/1.1.4

History:

Ticket Summary Status Resolution Owner
#30331 THEME: Purus – 1.1.5 closed live ThemeZee

(this ticket)

#37871 THEME: Purus – 1.2.0 closed live themetracbot
#38494 THEME: Purus – 1.2.1 closed live themetracbot
#41367 THEME: Purus – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/purus/1.1.4/screenshot.jpg

#16 @grapplerulrich
15 months ago

Doing a final review.

  • Please prefix the fonts enqueue handle wp_enqueue_style( 'google_fonts'
  • Please remove global $post; from purus_new_excerpt_more
  • The text "Purus - WordPress theme made by" is not internatuionalized
  • Please escape the Custom CSS on output get_theme_mod( 'custom_css' )
  • Please can you explain what you are doing in assets/js/fix.jquery.js
  • Please remove the default favicon and logo files.

#17 @Prelc
15 months ago

Hi,

Thanks for the review.

I would just ask for a few more days so I can finish everything.

#18 @themetracbot
15 months ago

  • Summary changed from THEME: Purus – 1.1.4 to THEME: Purus – 1.1.5

Purus - 1.1.5

Clean and simple WordPress blog theme focused on readability.

Theme URL -
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/purus/1.1.5
ZIP - https://wordpress.org/themes/download/purus.1.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=purus/1.1.4&new_path=purus/1.1.5

History:

Ticket Summary Status Resolution Owner
#30331 THEME: Purus – 1.1.5 closed live ThemeZee

(this ticket)

#37871 THEME: Purus – 1.2.0 closed live themetracbot
#38494 THEME: Purus – 1.2.1 closed live themetracbot
#41367 THEME: Purus – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/purus/1.1.5/screenshot.jpg

#19 @grapplerulrich
15 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Setting live.

#20 @Prelc
15 months ago

Thanks for your reviews and patience. :)

Note: See TracTickets for help on using tickets.