WordPress.org

Make WordPress Themes

Opened 17 months ago

Closed 6 days ago

#30498 closed theme (live)

THEME: Total – 1.0.8

Reported by: hashthemes Owned by: greenshady
Priority: new theme Keywords: theme-total
Cc: hashthemes@…, kevinhaig

Description

Total - 1.0.2

Total is a beautiful WordPress theme with lots of featured packed option to configure a complete website.

Theme URL -
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.2
ZIP - https://wordpress.org/themes/download/total.1.0.2.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.2/screenshot.png

Attachments (2)

progressbar-1.png (6.0 KB) - added by poena 10 months ago.
prev-and-next.png (49.5 KB) - added by poena 10 months ago.

Download all attachments as: .zip

Change History (46)

#1 @rohitink
13 months ago

  • Owner set to rohitink
  • Status changed from new to reviewing

#2 @rohitink
13 months ago

  • IN 404.php, the text 404 also needs to be translated.
  • Footer Link should open in a New Window.
  • isotope is not allowed. Its license is not GPL friendly. Use Masonry instead.
  • Do not prefix hooks for third party resources, while enqueing them. total-bx-slider should be bx-slider

I am allowing the slider as it consists of 3 slides only.
But however, you may be asked to remove it or use it with a plugin.

Everything else looks good.

Last edited 13 months ago by rohitink (previous) (diff)

#3 @hashthemes
13 months ago

Thank you for the review.

I can not upload the corrected theme as the option to upload the theme has been disabled.

It's showing the message
"Theme uploading is currently disabled. Please come back and try again later."

#4 @rohitink
13 months ago

No Problem
Let's wait until this issue is fixed :)

#5 @themetracbot
13 months ago

  • Summary changed from THEME: Total – 1.0.2 to THEME: Total – 1.0.3

Total - 1.0.3

Total is a beautiful WordPress theme with lots of featured packed option to configure a complete website.

Theme URL -
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.3
ZIP - https://wordpress.org/themes/download/total.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.2&new_path=total/1.0.3

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.3/screenshot.png

#6 @hashthemes
13 months ago

@rohitink isotope is licesed under GPLv3 for personal and freely distributed Projects. Please check this link http://isotope.metafizzy.co/license.html

I have fixed all other mentioned issues.

#7 @rohitink
13 months ago

@hashthemes I am not sure if isotope is really GPL Compatible. The Question is, can someone create a commercial version of your theme with Isotope under the GPL license? TBH, I am myself confused about this whole thing. Because, Isoptope is Dual Licensed, GPL and a Paid Commercial License.

Last time I checked, Isotope was not allowed for WordPress themes.

I think @poena can help both of us out here, regarding the license.

#8 @rohitink
12 months ago

I Guess @poena is not available. @grapplerulrich,

Could you help us here? :)

#9 @poena
12 months ago

I'm not sure. It's tricky. I'm not sure if the GPL allows you to sell the same code as non GPL.

#10 @grapplerulrich
12 months ago

It is fine. The author is offering another version for those poeple who do not want to licence their projects under GPL which is not the case here.

#11 @rohitink
12 months ago

@hashthemes

The theme is ready to be approved. But since u messaged me on slack, to wait till you submit an update, I will approve this theme once you submit the update :)

#12 @themetracbot
12 months ago

  • Summary changed from THEME: Total – 1.0.3 to THEME: Total – 1.0.4

Total - 1.0.4

Total is a beautiful WordPress theme with lots of featured packed option to configure a complete website.

Theme URL -
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.4
ZIP - https://wordpress.org/themes/download/total.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.3&new_path=total/1.0.4

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.4/screenshot.png

#13 @themetracbot
12 months ago

  • Summary changed from THEME: Total – 1.0.4 to THEME: Total – 1.0.5

Total - 1.0.5

Total is a clean and beautiful WordPress theme with lots of features to make a complete website. The theme is perfect for business, photography, education, creative websites. The powerful customizer panel allows to configure the theme with live preview. The theme is SEO friendly, browser compatible, fully translation ready.

Theme URL -
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.5
ZIP - https://wordpress.org/themes/download/total.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.4&new_path=total/1.0.5

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.5/screenshot.png

#14 @rohitink
12 months ago

  • Status changed from reviewing to approved

Looks Good to me.

But admins may object to some of the custom content generation used in this theme.

#15 @poena
10 months ago

  • Status changed from approved to reopened

#16 @poena
10 months ago

  • Cc kevinhaig added
  • Status changed from reopened to reviewing

Hi
Let's do the "fun stuff" first shall we?

Required

Please reduce the amount of content creation. The slider could easily be constructed by using existing content such as pages or posts. -You are already using this technique for some of the other options, and using existing content would also mean that you would not need the demo content. See https://make.wordpress.org/themes/2016/03/31/what-is-demo-content/

I see no problem with combining posts or pages with section background images or icons.
@kevinhaig Do you have anything to add regarding these options?

Posts without titles can't be reached from the archive and search result pages if comments are turned off.
The only link to the post besides the title is the comment link; the read more link is not used on these pages.

Code review:
functions.php:
images-loaded is now included in WordPress as a seperate file, so you need to enqueue this version instead of including your own.
See https://make.wordpress.org/core/2016/07/18/external-library-updates-in-4-6/

The readme file needs to be updated, it refers to a theme called "Hash One"
Make sure your theme has been tested with 4.6, not only 4.4.2.

I was unable to find a copyright statement for the theme itself.
See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

style.css
You can only use 3 subject tags, you are now using 4. See https://make.wordpress.org/themes/2016/09/06/meeting-summary-2016-09-06/

customizer.php
Missing translation functions:
Lines 292, 521, 605, 920, 1197, 1503, 1506, 1582, 1583, 1584 ( the alt texts), 1673, 1674, 1675,
Translated text inside attributes also needs to be escaped with esc_attr().


Notes

(Notes are not required to pass the review)

Home page template:
I do feel that the sections and divs should not be printed if they are empty, -if the options are not used. This causes empty rows of different colors to show on the page.

If the progressbar title is longer than the length of the %, the text overlaps, see screenshot.
The post date is presented differently on the search result page. It could use some spacing.


What happens next

Please update the theme. You will need to reply within 7 days, or your ticket may be closed as not approved.

I will assign the theme back to the original reviewer @rohitink, who will check your update and approve the theme again once everything has been fixed.

I will then do a final check to see if we can set your theme live.

@poena
10 months ago

#17 @kevinhaig
10 months ago

Content Creation

This theme is creating a lot of content. Many of the sections for the static home page, by themselves are borderline, but collectively amount to significant content.

It's always a very difficult decision when this kind of thing happens.

slider section : uses pseudo CPT's, not allowed. Please use something like features posts to include the image and the title/content areas.

I really think the content creation is too much, and I ask the author to put all this static page content stuff into a plugin.

@greenshady, sorry for pinging you :( If you can spare a few moments can you look at the options for this theme as well? It is a tough one.

Other

Please include custom-logo in your style.css as you sre supporting this feature.

#18 follow-up: @hashthemes
10 months ago

@poena @kevinhaig

Thank you for your reviews.

I think apart from the slider, almost all the sections are using posts and pages for the content along with it some icons and background images(i suppose images are not content creation). And i think a section like static counter and call to action is allowed as trival contents.

For Slider, i would be replacing it with the Pages in next update.

#19 in reply to: ↑ 18 @kevinhaig
10 months ago

Replying to hashthemes:

@poena @kevinhaig

Thank you for your reviews.

I think apart from the slider, almost all the sections are using posts and pages for the content along with it some icons and background images(i suppose images are not content creation). And i think a section like static counter and call to action is allowed as trival contents.

For Slider, i would be replacing it with the Pages in next update.

I don't really disagree with you, but I ask myself is significant content lost if the user switches themes, and because you are collectively creating so much content in each section, that the answer to that question is yes.

#20 @themetracbot
10 months ago

  • Summary changed from THEME: Total – 1.0.5 to THEME: Total – 1.0.6

Total - 1.0.6

Total is a clean and beautiful WordPress theme with lots of features to make a complete website. The theme is perfect for business, photography, education, creative websites. The powerful customizer panel allows to configure the theme with live preview. The theme is SEO friendly, browser compatible, fully translation ready.

Theme URL - http://hashthemes.com/wordpress-theme/total/
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.6
ZIP - https://wordpress.org/themes/download/total.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.5&new_path=total/1.0.6

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.6/screenshot.png

#21 @hashthemes
10 months ago

Uploaded a new version by fixing all the issues mentioned by @poena

Posts without titles can't be reached from the archive and search result pages if comments are turned off.
The only link to the post besides the title is the comment link; the read more link is not used on these pages.

I think post without title should be exceptional case. The archive pages are designed to show the full post content unless it is striped by "Continue Reading" default feature of WordPress

So far i feel like there should not be any content creation issue. The content are either from post or page. Some generated content should fall under trival content. And slider is also replace by page in the updated version.

#22 @poena
10 months ago

Perhaps your intention was to show the entire content, but what if the user wants to open the post in a different window? What if they want to be able to link to the post they just saw? To share it or bookmark it? We shouldn't make it more difficult for the user to reach the content.
The Continue reading link only shows if the more tag is manually added to the post.
-You can for example check if the post has a title, and add a link if it doesn't. You don't need to add an extra link to posts that already has one or two links.
I found the same problem with pages that show up in the search result.

Even without the slides, I counted over 60(!) things that the user would loose if they switch themes so no the total amount is not minor/trivial (And then I didn't count the uploaded images). So if you could think of anything else that you feel that you can edit, please do so.

This prompted me to test the sections further:
-When the posts in the portfolio section doesn't have a featured image, the post title is white over a white background, until the little (invisible)"box" is hovered.
The link associated with the search icon and the chain link icon is empty, so the post can't be reached.
Example source code from my install:

<div class="ht-portfolio-wrap" style="background-image: url();">
	<div class="ht-portfolio-caption">
		<h5>Hello world!</h5>
		<a class="ht-portfolio-link" href=""><i class="fa fa-link"></i></a>
		<a class="ht-portfolio-image" data-lightbox-gallery="gallery1" href=""><i class="fa fa-search"></i></a>
	</div>
</div>


I was able to make the Team section title and sub title work, but not the pages, the text or social links settings.
The ht-team-member divs are empty.
@rohitink -Please check if you can reproduce this in the new version.


Please avoid adding large unrelated updates during review, it means that we need to review the theme twice.

#23 @hashthemes
10 months ago

@poena

The portion like progress bar, static counter, and the social icon for the team member increases the count. But i saw that this sort of content are allowed in the past as they are not the important part of the website. These sort of content only supports the main content which i have derived from post, page and category.

I have no idea what to do as all the sections are important for the website. If you can point me precisely, it would help me to move forward. or @grapplerulrich greenshady would like to share their views.

And sorry for some more updates. The updates were woo commerce compatibility, addition of few jquery library and customizer section management.


#24 @themetracbot
10 months ago

  • Summary changed from THEME: Total – 1.0.6 to THEME: Total – 1.0.7

Total - 1.0.7

Total is a clean and beautiful WordPress theme with lots of features to make a complete website. The theme is perfect for business, photography, education, creative websites. The powerful customizer panel allows to configure the theme with live preview. The theme is SEO friendly, browser compatible, fully translation ready.

Theme URL - http://hashthemes.com/wordpress-theme/total/
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.7
ZIP - https://wordpress.org/themes/download/total.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.6&new_path=total/1.0.7

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.7/screenshot.png

#25 @poena
10 months ago

@rohitink Do you have time to do the follow up review? We haven't heard from you the past week.

#26 @rohitink
10 months ago

@poena I will review the version 1.0.7 and update this ticket by tonight. Didn't realize I was mentioned in the ticket earlier.

#27 @poena
10 months ago

Great.
I think we can leave the content creation as it is for now -there has been no feedback from the other key reviewers. But please double check that the portfolio and team sections are working.

#28 @rohitink
10 months ago

  • Status changed from reviewing to approved

@poena I have checked on my end. I am able to create portfolio and team sections properly in version 1.0.7
It looks alright to me.

#29 @poena
10 months ago

Hi
I'm sorry I had some older reviews that took much longer than expected, I will look at the theme on saturday at the very latest.

#30 @hashthemes
10 months ago

No Problem. Its fine. I know every one here is a volunteer and they have their own works as well.

#31 @poena
10 months ago

  • Status changed from approved to reopened

Hi
The team and portfolio are working well but now I can't get the slider to work.
I can't see the page content, but the next and prev arrows are sitting between the about section and the top menu part,
regardless if there are any selected pages for the slider or not.

I got the following js error on local host, but not on the live server so I 'm not sure if it is related:
Failed to load resource: the server responded with a status of 404 (Not Found) on "localhost/wordpress/undefined"

I was unable to find a copyright statement for the theme itself.
Example: Total WordPress theme copyright Hash Themes 2016

In total-functions.php, total_excerpt
Use WordPress functionality to adjust the length, for example the wp_trim_excerpt, see
https://developer.wordpress.org/reference/functions/wp_trim_excerpt/#source
https://developer.wordpress.org/reference/hooks/excerpt_length/

@poena
10 months ago

#32 @poena
10 months ago

OK I've tested 1.0.7 on a fresh install and the javascript error is gone so you can just ignore that.

-The next and prev arrows for the slider are still displaying even if no pages are selected.

I am able to get the slider to work if there is a featured image -perhaps this is how you intended it?
Perhaps the code can be adjusted to only display pages with featured images in the drop down, but I don't currently have a working example of that.
But you either need to make it work without the images, or notify the user that they need to select pages with featured images. If not they will probably think it is broken, as I did. I hope that makes sense.
(Limitations can also be documented in the readme file)

#33 @themetracbot
10 months ago

  • Summary changed from THEME: Total – 1.0.7 to THEME: Total – 1.0.8

Total - 1.0.8

Total is a clean and beautiful WordPress theme with lots of features to make a complete website. The theme is perfect for business, photography, education, creative websites. The powerful customizer panel allows to configure the theme with live preview. The theme is SEO friendly, browser compatible, fully translation ready.

Theme URL - http://hashthemes.com/wordpress-theme/total/
Author URL - http://hashthemes.com

SVN - https://themes.svn.wordpress.org/total/1.0.8
ZIP - https://wordpress.org/themes/download/total.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=total/1.0.7&new_path=total/1.0.8

History:

Ticket Summary Status Resolution Owner
#2421 THEME: Totally Smells like Facebook - 1.0 closed closed-newer-version-uploaded
#2422 THEME: Totally Smells like Facebook - 1.0.1 closed not-approved greenshady
#6086 THEME: Total Bounty WordPress Business Theme - 1.2 closed not-approved
#6092 THEME: Total Bounty WP Business - 1.2 closed not-approved kwight
#6607 THEME: Total Bounty WP Business - 1.3 closed closed-newer-version-uploaded
#6608 THEME: Total Bounty WP Business - 1.4 closed not-approved kobenland
#7021 THEME: Total Bounty WP Business - 1.6 closed closed-newer-version-uploaded sixhours
#7064 THEME: Total Bounty WP Business - 1.6.1 closed not-approved sixhours
#7707 THEME: Total Bounty WP Business - 1.6.4 closed not-approved kobenland
#30498 THEME: Total – 1.0.8 closed live greenshady

(this ticket)

#36995 THEME: Total – 1.0.9 closed live themetracbot
#37021 THEME: Total – 1.1.0 closed live themetracbot
#37141 THEME: Total – 1.1.1 closed live themetracbot
#37581 THEME: Total – 1.1.2 closed live themetracbot
#38889 THEME: Total – 1.1.3 closed live themetracbot
#38893 THEME: Total – 1.1.4 closed live themetracbot
#38919 THEME: Total – 1.1.5 closed live themetracbot
#39460 THEME: Total – 1.1.6 closed live themetracbot
#39569 THEME: Total – 1.1.6.1 closed live themetracbot
#40582 THEME: Total – 1.1.6.2 closed live themetracbot
#42362 THEME: Total – 1.1.6.3 closed live themetracbot
#42364 THEME: Total – 1.1.6.4 closed live themetracbot
#42536 THEME: totaloneone – 1.1.7.1 closed not-approved rabmalin
#42820 THEME: Total – 1.1.6.5 closed live themetracbot
#43172 THEME: Totalw – 1.1.6.9 closed not-approved rabmalin
#44260 THEME: Total – 1.1.6.6 closed live themetracbot


https://themes.svn.wordpress.org/total/1.0.8/screenshot.png

#34 @hashthemes
10 months ago

@poena

The team and portfolio are working well but now I can't get the slider to work.
I can't see the page content, but the next and prev arrows are sitting between the about section and the top menu part,
regardless if there are any selected pages for the slider or not.

Fixed this issue

I was unable to find a copyright statement for the theme itself.
Example: Total WordPress theme copyright Hash Themes 2016

Added copyright text in readme.txt

In total-functions.php, total_excerpt
Use WordPress functionality to adjust the length, for example the wp_trim_excerpt, see
https://developer.wordpress.org/reference/functions/wp_trim_excerpt/#source
https://developer.wordpress.org/reference/hooks/excerpt_length/

Replaced the funtion total_excerpt with WordPress core function wp_trim_words() where ever possible. But in some places i need to limit the content by the letter count because a long word can distort the design.

I am able to get the slider to work if there is a featured image -perhaps this is how you intended it?
Perhaps the code can be adjusted to only display pages with featured images in the drop down, but I don't currently have a working example of that.
But you either need to make it work without the images, or notify the user that they need to select pages with featured images. If not they will probably think it is broken, as I did. I hope that makes sense.
(Limitations can also be documented in the readme file)

Yes, the featured image works as a slider banner and the title and content works as a slider caption. I have added a small note informing the detail about it in the customzer just below the slider page selection drop down so that they don't get confused.

#35 @poena
10 months ago

  • Status changed from reopened to reviewing

#36 @poena
10 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thank you for fixing these issues, your theme should be live shortly.

Recommended:
Don't escape post or page titles, then users can't use html to make their titles bold etc.
See home-template.php line 35

#37 @grapplerulrich
10 months ago

I have taken the theme temporarily offline as we check potential conflicts with a theme with the same name. https://themeforest.net/item/total-responsive-multipurpose-wordpress-theme/6339019

This ticket was mentioned in Slack in #themereview by rinkuyadav999. View the logs.


10 months ago

#39 @hashthemes
10 months ago

@grapplerulrich

I am really very shocked to see my theme taken down which was only live yesterday for just a reason of having similar name with that on the ThemeForest. I have used a name "Total" is a sense that the theme is a complete (Total Package) theme for anyone who want to use it.

I saw some people taking in the slack regarding the technique to come on the popular list. But i must say that the theme was submitted 8 months ago when the popular list was based on total download from wordpress.org rather that active installs.

Also there are thousands of marketplace in the web. ThemeForest, Mojo Market, Elegant Themes being popular one gets noticed by many for the duplicate name but as you know there are many other marketplace that are unnoticed. So any generic name used for the theme submitted in wordpress.org will definitely have duplicate theme some where around the web. So should we keep taking down all the theme that has duplicate name?

And it would have been better if you had given me the solution for this problem instead of taking down the theme.

Waiting for your response.

Thank You

#40 @grapplerulrich
10 months ago

@hashthemes The theme is back up after discussing it with the other key reviewers. The reason was to take the theme offline was to place the issue on ice. If it were to be a problem then the solution would have been to rename the theme.

#41 @hashthemes
10 months ago

Thank you @grapplerulrich

I can see the theme in the list now.

#42 @ilovewpcom
6 days ago

  • Resolution live deleted
  • Status changed from closed to reopened

Hi,

In light of this ticket: https://themes.trac.wordpress.org/ticket/43517#comment:30

I request that this theme be urgently suspended from the repository and/or be renamed to something else.

Thank you.

cc @grapplerulrich, @greenshady, @poena

#43 @greenshady
6 days ago

  • Owner changed from rohitink to greenshady
  • Status changed from reopened to reviewing

#44 @greenshady
6 days ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.