WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 12 months ago

Last modified 11 months ago

#30684 closed theme (not-approved)

THEME: Kutub – 1.4

Reported by: tallythemes Owned by: rajanamaharjan45
Priority: new theme Keywords: theme-kutub
Cc: admin@…

Description

Kutub - 1.0

Kutub is a multipurpose WordPress theme. It is best for any of business website. The theme is fully responsive. It have video background and parallax effect.

Theme URL - http://tallythemes.com/product/kutub-pro-responsive-multi-purpose-wordpress-theme/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/kutub/1.0
ZIP - https://wordpress.org/themes/download/kutub.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#30684 THEME: Kutub – 1.4 closed not-approved rajanamaharjan45

(this ticket)


https://themes.svn.wordpress.org/kutub/1.0/screenshot.jpg

Change History (26)

#1 @themetracbot
20 months ago

  • Summary changed from THEME: Kutub – 1.0 to THEME: Kutub – 1.1

Kutub - 1.1

Kutub is a multipurpose WordPress theme. It is best for any of business website. The theme is fully responsive. It have video background and parallax effect.

Theme URL - http://tallythemes.com/product/kutub-pro-responsive-multi-purpose-wordpress-theme/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/kutub/1.1
ZIP - https://wordpress.org/themes/download/kutub.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kutub/1.0&new_path=kutub/1.1

History:

Ticket Summary Status Resolution Owner
#30684 THEME: Kutub – 1.4 closed not-approved rajanamaharjan45

(this ticket)


https://themes.svn.wordpress.org/kutub/1.1/screenshot.jpg

#2 @tallythemes
20 months ago

Hello @karmatosed,

I have added "accessibility-ready" tag by mistake. I have removed the tag in version 1.1
But it still show "accessibility-ready" tag in the ticket. Can you please remove that "accessibility-ready" so theme will not face "accessibility-ready" review.

Thanks

#3 @themetracbot
15 months ago

  • Owner set to picocodes
  • Status changed from new to reviewing

#4 @grapplerulrich
15 months ago

  • Keywords changed from theme-kutub, accessibility-ready to theme-kutub accessibility-ready
  • Owner picocodes deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#5 @themetracbot
15 months ago

  • Owner set to zhangrongfeng

#6 @grapplerulrich
15 months ago

  • Owner zhangrongfeng deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#7 @themetracbot
15 months ago

  • Owner set to rajanamaharjan45

#8 @rajanamaharjan45
14 months ago

Hi @tallythemes ,
This is not a complete review. I found that you had prefix theme with your name. So, this wrong way to prefix theme. Prefixing Should be done with theme slug because it makes theme function unique. If theme function is same than if will have problem. While you create themes using your name, there may be conflict in function. So please fix this problem.
Some of the functions that you had left to prefix are given below:
-tgm-config.php L2 and L3

Your theme have lots of securities issues. for eg esc_attr(), esc_url(), esc_html(), esc_textarea(), etc function should be used to clean and escape output in html.
So please visit this link https://developer.wordpress.org/themes/advanced-topics/theme-security/ to solve security issues.

This is not an complete review. So, Please check your theme carefully and update it so that I can continue my next step of theme reviewing.

Thanks!!

#9 @tallythemes
14 months ago

Hello @rajanamaharjan45

I will check and fix the securities issues. But I am not sure about the prefixing issue you have pointed. I use a stater theme to create my theme and the prefix of that theme is "tally_" I don't think it will create conflict with other theme as a WordPress site only run a single theme not many like plugins. So I think the prefix idea is best but not require. What is think?

Last edited 14 months ago by tallythemes (previous) (diff)

#10 @grapplerulrich
14 months ago

Prefixing functions is required. You can find it in the requirements. https://make.wordpress.org/themes/handbook/review/required/#code

Also the Theme URL should be about the free theme not the pro version.

#11 @tallythemes
14 months ago

Hello @grapplerulrich ,

I will change the theme URL

I have used prefix to all function, variable to "tally_" is it ok? Or Will I have to change that Prefix to the theme slug?

I use this "tally_" prefix to my theme only not any plugin. And I think this prefix will not conflict with any other plugins what you think?

#12 @rajanamaharjan45
14 months ago

Hi @tallythemes ,
No, you should change to your own theme slug. If theme with slug name tally is created, He/She will use tally as prefix. So, you better change your prefix.

#13 @tallythemes
14 months ago

Ok, I will change the prefix. Please allow me another 2 days to fix all the issue and change the prefix of all functions and variables.

#14 @themetracbot
14 months ago

  • Summary changed from THEME: Kutub – 1.1 to THEME: Kutub – 1.2

Kutub - 1.2

Kutub is a multipurpose WordPress theme. It is best for any of business website. The theme is fully responsive. It have video background and parallax effect.

Theme URL - http://tallythemes.com/product/free-responsive-multi-purpose-wordpress-theme-kutub-lite/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/kutub/1.2
ZIP - https://wordpress.org/themes/download/kutub.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kutub/1.1&new_path=kutub/1.2

History:

Ticket Summary Status Resolution Owner
#30684 THEME: Kutub – 1.4 closed not-approved rajanamaharjan45

(this ticket)


https://themes.svn.wordpress.org/kutub/1.2/screenshot.jpg

#15 @tallythemes
14 months ago

Hello @rajanamaharjan45,

I have updated the theme with the changes you pointed.

I have changed the prefix of the theme to theme slug also I have added escape functions to filter the output and input of the theme data.

Thanks

#16 @rajanamaharjan45
14 months ago

Hi @tallythemes ,
Please update your theme carefully. You have still left to prefix the functions, style and script. Here, the list I have found.

  • functions.php
    1. L32->add_filter('tallythemesetup_plugin_list', 'kutub_tallythemesetup_plugin_list');
  • tallybuilder-connet.php
    1. you didn't prefix hook and functions in add_filter function.
  • text-metabox.php
    1. all the funtions
  • script-loader.php
    1. all the styles and script
    2. don't prefix 3rd party styles and scripts

This time please check your theme carefully and update.

Thank you.

Last edited 14 months ago by rajanamaharjan45 (previous) (diff)

#17 @tallythemes
14 months ago

Hi

Thanks for the review. There are some code in the theme for a plugin. The plugin is "TallyBuilder" That's why I can not add theme prefix on that functions and filters. The filter you pointed on functions.php tallythemesetup_plugin_list is a filter name of the plugin. In tallybuilder-connet.php there are some filter which are plugin's filter.

Another thing is text-metabox.php is file is for the plugin. This file will used by the "TallyBuilder" plugin and the functions that are using in that file is for that plugin. This file will not load with the theme.

So I think the first 3 issue you pointed is not a problem at all.

I will fix the script-loader.php and I will update the theme.

#18 @themetracbot
14 months ago

  • Summary changed from THEME: Kutub – 1.2 to THEME: Kutub – 1.3

Kutub - 1.3

Kutub is a multipurpose WordPress theme. It is best for any of business website. The theme is fully responsive. It have video background and parallax effect.

Theme URL - http://tallythemes.com/product/free-responsive-multi-purpose-wordpress-theme-kutub-lite/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/kutub/1.3
ZIP - https://wordpress.org/themes/download/kutub.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kutub/1.2&new_path=kutub/1.3

History:

Ticket Summary Status Resolution Owner
#30684 THEME: Kutub – 1.4 closed not-approved rajanamaharjan45

(this ticket)


https://themes.svn.wordpress.org/kutub/1.3/screenshot.jpg

#19 @rajanamaharjan45
14 months ago

Hi @tallythemes

  1. Remove all depreciated tags from readme.txt
  2. You are to keep one upsell. You have keot many pro version ads. And controls and setting should not be blank in section.

Please solve these problems and reply.
Thank you..

#20 @themetracbot
14 months ago

  • Summary changed from THEME: Kutub – 1.3 to THEME: Kutub – 1.4

Kutub - 1.4

Kutub is a multipurpose WordPress theme. It is best for any of business website. The theme is fully responsive. It have video background and parallax effect.

Theme URL - http://tallythemes.com/product/free-responsive-multi-purpose-wordpress-theme-kutub-lite/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/kutub/1.4
ZIP - https://wordpress.org/themes/download/kutub.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kutub/1.3&new_path=kutub/1.4

History:

Ticket Summary Status Resolution Owner
#30684 THEME: Kutub – 1.4 closed not-approved rajanamaharjan45

(this ticket)


https://themes.svn.wordpress.org/kutub/1.4/screenshot.jpg

#21 @rajanamaharjan45
14 months ago

  • Status changed from reviewing to approved

Hi @tallythemes
Your theme is approved. Next step of review is done by Admin before. It may take about 1 month.

#22 @joedolson
13 months ago

  • Keywords accessibility-ready removed

#23 @kevinhaig
12 months ago

I will do this final

#24 @kevinhaig
12 months ago

  • Status changed from approved to reopened

#25 @kevinhaig
12 months ago

  • Resolution set to not-approved
  • Status changed from reopened to closed

Theme Review - Kutub Version 1.4

  • Hi I am @kevinhaig and I have completed the second (final) review of your theme.
  • Sorry but the ticket has been reopened because there are requirements not met.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Ticket Closed

  • Sorry but the ticket for this theme has been closed.
  • As part of the new theme directory guidelines, reviewers are now allowed to close tickets if a theme has 5 or more distinct issues.
  • Try not get discouraged because a closed ticket is not the end.
  • We want you to resubmit your theme.
  • We do ask that you spend a bit more time making sure that your theme meets all the requirements before we make it live.
  • If you need help with anything or want me to explain further, please post here in this ticket.
  • Note that when you do upload a new version you will enter as a new ticket at the bottom of the new queue.
  • Authors with tickets already in the review queues must wait to upload a new version until those themes are closed or set live.
  • Also feel free to post on slack.
  • slack : https://make.wordpress.org/chat/Slack
  • Theme Review Team slack : https://wordpress.slack.com/messages/themereview channel

Required Items

Code

All untrusted data should be escaped before output.
  • Check and fix escaping problem. , file: kutub\inc\custom-functions.php, line: 31
  • Check and fix escaping problem. , file: kutub\inc\custom-functions.php, line: 38
  • Check and fix escaping problem. , file: kutub\inc\custom-functions.php, line: 80
  • it does not look to me like any of the metadata in text-css.php or text-html.php is being sanitized before output?
  • there are options in script-loader.php that are not being escaped.
  • it looks like you are displaying options in this theme that are setup by one of your plugins?
  • the option/escaping system is very frustrating and difficult to check. Let me go through your footer section in detail
    • there are options in footer-css.php that are not properly being escaped.
      • kutub_css_style('.site-footer h3', kutub_option('footer_widgets_title_color'), 'color: %s%;');
        • the kutb_option() returns an option, not even setup that I can see. It returns the option escaped using wp_kses() which is the wrong function. esc_html() should be used in this case.
    • in footer-html.php
      • why are you escaping a hardcoded url?. By the way url's should be escaped with esc_url() not esc_url_raw(), which is for sanitizing.
      • <div class="col-md-<?php echo $widget_layout[0]; ?>"> needs escaping
      • <?php echo kutub_option('credit_text', … needs escaping.
        • Upon further inspection and frustration, I realized that your kutub_options() function returned a correct escaping for the text.
  • also kutub_options() escapes all options with wp_kses() which is not consistent with how some of your options are saves, and not correct for url's.
    • options should be escaped as late as possible, and it should be evident that the option is being escaped with the correct function.
      • for example esc_html( get_option( 'tt_footer_widgets_title_color', '#ffffff' ) ); is much more readable and better then the one you have above.
  • Please look at your entire option system for proper escaping.

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • Could not find support for custom-logo. You are using logo images so you must use the core feature add_theme_support('custom-logo') and not a custom function or setup.
The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
  • custom-background exists in the style.css tags list but it appears this feature is not supported. , file: kutub\style.css, line: 10
  • custom-header exists in the style.css tags list but it appears this feature is not supported. , file: kutub\style.css, line: 10
  • editor-style was found but add_editor_style() is missing. , file: kutub\style.css, line: 10
  • No subject tags were found. Please select no more then 3 subject tags that reflect your theme. , file: kutub\style.css, line: 10
  • ref: https://make.wordpress.org/themes/handbook/review/required/theme-tags/
Post Formats
  • You have added theme support for Post Formats but I am not seeing them being supported. Post formats are about displaying the post in a distinctly different way from a standard post.
  • if you want to continue to support post formats, make them distinctive, otherwise remove the add_theme_support() statement and ensure the tag is not in the style.css taglist

Language

All theme text strings are to be translatable.
  • Strings should have translatable content , file: kutub\inc\content\incontent\incontent-html-author.php, line: 5
  • you have untranslated strings in text-metabox.php,kutub-home-page.php

Licensing

Declare licenses of any resources included such as fonts or images, including screenshot images
  • For resources please include: declaration (ex Copyright 2015, by John Smith), resource download link, license type, and license download
  • You have not declared magnific popup
  • You have not declared TGMPA
  • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      
  • please provide download links and licensing for all images bundled with the theme and for the ywo images included in the screenshot.
Licensing References

Options and Settings

  • It looks like you have many options set up in this theme that are actually not there? Are you setting these up in the Pro version of the theme?
Use sane defaults and don’t write default setting values to the database.

Themeshop Uses GPL

If you are a themeshop you should be selling under GPL to be in the WordPress.org repo.
  • The statement below on your website does not observe the GPL freedoms. Any WordPress products available on your site whether free or for sale must observe these freedoms or you can't host the theme on the .org repo.

You may download a single copy of any content contained on the Sites, solely for your personal, non-commercial use, consistent with these terms of use, provided that you maintain the copyright and other notices contained in that content. This excludes products available for sale/licensing on the Sites.

Other Selling Problems

  • Upselling is too extensive
    • Please limit your Upsell to one link in the main customizer panel.
    • Having a separate theme upsell page under Appearance is fine, but it must only provide information about the theme. You can not upsell other themes in this page.

Stylesheets and Scripts

Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
No minification of scripts or files unless provide original files.
  • In the spirit of GPL software, users must be given the source code in a format they can understand and edit if they so choose. Minified code is very difficult to read and edit so if you are going to use the minified code in your theme you must also provide a non minified version for users to read and edit, if they wish to do that. This applies to all code, but in particular css and js files
  • please go through your theme and provide un-minified versions of all css and js files in the same folder as the minified ones.
  • you have minified scripts without unminified copies all over the place.

Other Required Items

Other Required Items
  • No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them. , file: kutub\inc\content\hero\hero.php, line: 1

Recommended Items

It is not required to complete recommended items, but considered good practice

  • This comment is 67% valid code; is this commented out code? , file: kutub\inc\content\hero\hero-customize.php, line: 8
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content\incontent\incontent-html-archive.php, line: 3
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content\incontent\incontent-html-author.php, line: 15
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content\incontent\incontent-html-single.php, line: 3
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content\incontent\incontent-post.php, line: 40
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content-loader.php, line: 12
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\content-loader.php, line: 18
  • This comment is 60% valid code; is this commented out code? , file: kutub\inc\custom-functions.php, line: 63
  • This comment is 75% valid code; is this commented out code? , file: kutub\inc\custom-functions.php, line: 138
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 143
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 148
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 153
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 158
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 165
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 172
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 177
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 182
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 187
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 192
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 197
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 202
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\custom-functions.php, line: 207
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 19
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 24
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 29
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 34
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 39
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize-actions.php, line: 44
  • This comment is 50% valid code; is this commented out code? , file: kutub\inc\customize\tt-customize.php, line: 63
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize.php, line: 68
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize.php, line: 73
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize.php, line: 78
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\customize\tt-customize.php, line: 83
  • include() found. Please check if get_template_part() should be used instead. , file: kutub\inc\inc.php, line: 10
  • This comment is 80% valid code; is this commented out code? , file: kutub\inc\tallybuilder\sections\text\text-metabox.php, line: 17

#26 @jrf
11 months ago

Also, when you resubmit: please upgrade the included version of the TGM plugin activation class to the latest version (2.6.1).

Pro-tip: If you download a fresh copy of TGMPA using the Custom TGMPA Generator, it will serve you with a customized download of TGMPA which will pass the Theme Check rules (text-domain and such).

Note: See TracTickets for help on using tickets.