WordPress.org

Make WordPress Themes

Opened 21 months ago

Closed 15 months ago

Last modified 15 months ago

#30782 closed theme (live)

THEME: Gridbox – 1.0.4

Reported by: ThemeZee Owned by: rinkuyadav999
Priority: new theme Keywords: theme-gridbox
Cc: contact@…

Description

Gridbox - 1.0

Gridbox is a clean and solid WordPress theme featuring a three-column grid-layout for posts. The theme works out of the box and does not require any complicated setup. It is perfectly suited for a simple magazine, blog or portfolio website.

Theme URL - https://themezee.com/themes/gridbox/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gridbox/1.0
ZIP - https://wordpress.org/themes/download/gridbox.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#30782 THEME: Gridbox – 1.0.4 closed live rinkuyadav999

(this ticket)

#36429 THEME: Gridbox – 1.0.5 closed live themetracbot
#37304 THEME: Gridbox01 – 1.1.5 closed not-approved djrmom
#37474 THEME: Gridbox – 1.0.6 closed live themetracbot
#37484 THEME: Gridbox – 1.0.7 closed live themetracbot
#38723 THEME: Gridbox – 1.0.8 closed live themetracbot
#39954 THEME: Gridbox – 1.0.9 closed live themetracbot
#41180 THEME: Gridbox – 1.2 closed live themetracbot
#41265 THEME: Gridbox – 1.2.1 closed live themetracbot
#41851 THEME: Gridbox – 1.2.2 closed live themetracbot
#42872 THEME: Gridbox – 1.2.3 closed live themetracbot
#44509 THEME: Gridbox – 1.3 closed live themetracbot
#45535 THEME: Gridbox – 1.4 closed live themetracbot
#46141 THEME: Gridbox – 1.4.1 closed live themetracbot
#47728 THEME: Gridbox – 1.4.2 closed live themetracbot


https://themes.svn.wordpress.org/gridbox/1.0/screenshot.jpg

Change History (15)

#1 @themetracbot
19 months ago

  • Summary changed from THEME: Gridbox – 1.0 to THEME: Gridbox – 1.0.1

Gridbox - 1.0.1

Gridbox is a clean and solid WordPress theme featuring a three-column grid-layout for posts. The theme works out of the box and does not require any complicated setup. It is perfectly suited for a simple magazine, blog or portfolio website.

Theme URL - https://themezee.com/themes/gridbox/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gridbox/1.0.1
ZIP - https://wordpress.org/themes/download/gridbox.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gridbox/1.0&new_path=gridbox/1.0.1

History:

Ticket Summary Status Resolution Owner
#30782 THEME: Gridbox – 1.0.4 closed live rinkuyadav999

(this ticket)

#36429 THEME: Gridbox – 1.0.5 closed live themetracbot
#37304 THEME: Gridbox01 – 1.1.5 closed not-approved djrmom
#37474 THEME: Gridbox – 1.0.6 closed live themetracbot
#37484 THEME: Gridbox – 1.0.7 closed live themetracbot
#38723 THEME: Gridbox – 1.0.8 closed live themetracbot
#39954 THEME: Gridbox – 1.0.9 closed live themetracbot
#41180 THEME: Gridbox – 1.2 closed live themetracbot
#41265 THEME: Gridbox – 1.2.1 closed live themetracbot
#41851 THEME: Gridbox – 1.2.2 closed live themetracbot
#42872 THEME: Gridbox – 1.2.3 closed live themetracbot
#44509 THEME: Gridbox – 1.3 closed live themetracbot
#45535 THEME: Gridbox – 1.4 closed live themetracbot
#46141 THEME: Gridbox – 1.4.1 closed live themetracbot
#47728 THEME: Gridbox – 1.4.2 closed live themetracbot


https://themes.svn.wordpress.org/gridbox/1.0.1/screenshot.jpg

#2 @themetracbot
19 months ago

  • Summary changed from THEME: Gridbox – 1.0.1 to THEME: Gridbox – 1.0.2

Gridbox - 1.0.2

Gridbox is a clean and solid WordPress theme featuring a three-column grid-layout for posts. The theme works out of the box and does not require any complicated setup. It is perfectly suited for a simple magazine, blog or portfolio website.

Theme URL - https://themezee.com/themes/gridbox/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gridbox/1.0.2
ZIP - https://wordpress.org/themes/download/gridbox.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gridbox/1.0.1&new_path=gridbox/1.0.2

History:

Ticket Summary Status Resolution Owner
#30782 THEME: Gridbox – 1.0.4 closed live rinkuyadav999

(this ticket)

#36429 THEME: Gridbox – 1.0.5 closed live themetracbot
#37304 THEME: Gridbox01 – 1.1.5 closed not-approved djrmom
#37474 THEME: Gridbox – 1.0.6 closed live themetracbot
#37484 THEME: Gridbox – 1.0.7 closed live themetracbot
#38723 THEME: Gridbox – 1.0.8 closed live themetracbot
#39954 THEME: Gridbox – 1.0.9 closed live themetracbot
#41180 THEME: Gridbox – 1.2 closed live themetracbot
#41265 THEME: Gridbox – 1.2.1 closed live themetracbot
#41851 THEME: Gridbox – 1.2.2 closed live themetracbot
#42872 THEME: Gridbox – 1.2.3 closed live themetracbot
#44509 THEME: Gridbox – 1.3 closed live themetracbot
#45535 THEME: Gridbox – 1.4 closed live themetracbot
#46141 THEME: Gridbox – 1.4.1 closed live themetracbot
#47728 THEME: Gridbox – 1.4.2 closed live themetracbot


https://themes.svn.wordpress.org/gridbox/1.0.2/screenshot.jpg

#3 @themetracbot
17 months ago

  • Summary changed from THEME: Gridbox – 1.0.2 to THEME: Gridbox – 1.0.3

Gridbox - 1.0.3

Gridbox is a clean and solid WordPress theme featuring a three-column grid-layout for posts. The theme works out of the box and does not require any complicated setup. It is perfectly suited for a simple magazine, blog or portfolio website.

Theme URL - https://themezee.com/themes/gridbox/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gridbox/1.0.3
ZIP - https://wordpress.org/themes/download/gridbox.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gridbox/1.0.2&new_path=gridbox/1.0.3

History:

Ticket Summary Status Resolution Owner
#30782 THEME: Gridbox – 1.0.4 closed live rinkuyadav999

(this ticket)

#36429 THEME: Gridbox – 1.0.5 closed live themetracbot
#37304 THEME: Gridbox01 – 1.1.5 closed not-approved djrmom
#37474 THEME: Gridbox – 1.0.6 closed live themetracbot
#37484 THEME: Gridbox – 1.0.7 closed live themetracbot
#38723 THEME: Gridbox – 1.0.8 closed live themetracbot
#39954 THEME: Gridbox – 1.0.9 closed live themetracbot
#41180 THEME: Gridbox – 1.2 closed live themetracbot
#41265 THEME: Gridbox – 1.2.1 closed live themetracbot
#41851 THEME: Gridbox – 1.2.2 closed live themetracbot
#42872 THEME: Gridbox – 1.2.3 closed live themetracbot
#44509 THEME: Gridbox – 1.3 closed live themetracbot
#45535 THEME: Gridbox – 1.4 closed live themetracbot
#46141 THEME: Gridbox – 1.4.1 closed live themetracbot
#47728 THEME: Gridbox – 1.4.2 closed live themetracbot


https://themes.svn.wordpress.org/gridbox/1.0.3/screenshot.jpg

#4 @rinkuyadav999
16 months ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

Hi @ThemeZee

I am reviewing your theme and upload issues if found.

Thanks
Rinku Y

#5 @rinkuyadav999
16 months ago

Hi @ThemeZee

I have taken a quick review and found some issues.


NOTE: remove deprecated tags in style.css and also make sure all tags are base on theme features.

WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag silver has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag red has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag green has been deprecated, please remove it from your style.css header.
WARNING: The tag gray has been deprecated, please remove it from your style.css header.
WARNING: The tag fluid-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag blue has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.


Provide un-minify version of all js and css files like: html5shiv.min.js


remove all unused files


Some text are not translation-ready like Gridbox Review in theme-info.php


I do not find "/images/" directory and default-featured-image.png image. may be you forgot.


NOTE: Please reply within 7 days otherwise this ticket will be close.

Thanks
Rinku Y

#6 @themetracbot
16 months ago

  • Summary changed from THEME: Gridbox – 1.0.3 to THEME: Gridbox – 1.0.4

Gridbox - 1.0.4

Gridbox is a clean and solid WordPress theme featuring a three-column grid-layout for posts. The theme works out of the box and does not require any complicated setup. It is perfectly suited for a simple magazine, blog or portfolio website.

Theme URL - https://themezee.com/themes/gridbox/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gridbox/1.0.4
ZIP - https://wordpress.org/themes/download/gridbox.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gridbox/1.0.3&new_path=gridbox/1.0.4

History:

Ticket Summary Status Resolution Owner
#30782 THEME: Gridbox – 1.0.4 closed live rinkuyadav999

(this ticket)

#36429 THEME: Gridbox – 1.0.5 closed live themetracbot
#37304 THEME: Gridbox01 – 1.1.5 closed not-approved djrmom
#37474 THEME: Gridbox – 1.0.6 closed live themetracbot
#37484 THEME: Gridbox – 1.0.7 closed live themetracbot
#38723 THEME: Gridbox – 1.0.8 closed live themetracbot
#39954 THEME: Gridbox – 1.0.9 closed live themetracbot
#41180 THEME: Gridbox – 1.2 closed live themetracbot
#41265 THEME: Gridbox – 1.2.1 closed live themetracbot
#41851 THEME: Gridbox – 1.2.2 closed live themetracbot
#42872 THEME: Gridbox – 1.2.3 closed live themetracbot
#44509 THEME: Gridbox – 1.3 closed live themetracbot
#45535 THEME: Gridbox – 1.4 closed live themetracbot
#46141 THEME: Gridbox – 1.4.1 closed live themetracbot
#47728 THEME: Gridbox – 1.4.2 closed live themetracbot


https://themes.svn.wordpress.org/gridbox/1.0.4/screenshot.jpg

#7 @ThemeZee
16 months ago

Hello Rinku Y,

Thank you so much for taking the time to review my theme, I highly appreciate it :)

  • I have updated the tags, removed the untranslated texts and added the missing placeholder image.
  • The theme already included the unminified html5shiv.js, maybe you did not see that
  • I went through all files but did not find any unused files. All files only used for development should be removed. Please let me know which files you mean if you still think there are some files which should be removed.

Cheers,
Thomas

#8 @rinkuyadav999
16 months ago

  • Status changed from reviewing to approved

Hi @ThemeZee

I do not find any issue so I am approving your theme and a key reviewer will take final review.

Thanks
Rinku Y

#9 @ThemeZee
16 months ago

Great :) Thanks for approving the theme!

#10 @poena
15 months ago

  • Status changed from approved to reopened

#11 @poena
15 months ago

Hi
You might already have read or participated in the recent Slack discussions regarding adding content to the customizer with (non-api)javascript.
This is not allowed, and falls under the "Use WordPress functionality and features first, if available." requirement. (It is also not future proof and may cause problems with the customizer later on.)
The Theme Links below the Theme Options will need to be added with the customizer api.
I do believe that the way you have added your links in the "More Features"section is sufficient.

Any collection of user data should be “opt-in” only, so you will need to adjust to this or remove the utm links.
We had a brief discussion about if we could allow this kind of tracking or perhaps if we could allow parts of it but the general consensus was that, as the requirement states, any collection of user data needs to be opt-in.
https://wordpress.slack.com/archives/themereview/p1473560478001426

If you still feel strongly that this is not correct you are of course welcome to bring it up with they key reviewers that were not present or perhaps during a Tuesday meeting.


Other than this, the theme should be ready to go live.


I did not check your live themes, but if you know that you have the same codes or links in any other theme, please fix them aswell.
I did find it in:
https://themes.trac.wordpress.org/ticket/31188
https://themes.trac.wordpress.org/ticket/31455

#12 @poena
15 months ago

  • Status changed from reopened to reviewing

Hi.
Since it seems that there are some difference in opinion regarding the umt links, it is not really fair to hold your theme back because of it.

Since there is only one remaining issue, please fix the links in the customizer with your next update.

#13 @poena
15 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

#14 @ThemeZee
15 months ago

@poena Thanks for making the theme live.

Yes, I did follow the recent Slack conversations that adding content to the Customizer with JavaScript is not future proof. I was not aware that my implementation is against best practices and therefore this was a bit of a surprise. I did not try to bypass the guidelines, it just seemed more user-friendly to add these links to the whole panel and not in an extra section.

I'm currently playing around with the Customizer API to add these links properly on the same location or moving them to a section if that is not possible. I will update all my themes when I have a working solution.

This ticket was mentioned in Slack in #themereview by themezee. View the logs.


15 months ago

Note: See TracTickets for help on using tickets.