WordPress.org

Make WordPress Themes

#31070 closed theme (live)

THEME: Steed – 1.3

Reported by: tallythemes Owned by: kevinhaig
Priority: new theme Keywords: theme-steed
Cc: admin@…

Description

Steed - 1.0

Blog magazine WordPress theme Steed has a clean, stylish, modern and minimal design that’s ideal for any type of online magazine websites, news sites & blogs. It would be perfect for making any kind of magazine, news, technology and gadget blogs, food blogs, travel websites,review sites, photography, fashion and lifestyle or anything else. It is Retina ready and Responsive. Also, it has Customizer support, multimedia styling (for photos, galleries, videos, audio etc), a very flexible dashboard. Also, Blog magazine WordPress theme Steed is well optimized for better pageviews and SEO score. Theme Demo:: http://tallythemes.com/preview/steed-wordpress-theme-preview/

Theme URL - http://tallythemes.com/product/steed-pro-blog-wordpress-theme/
Author URL - http://tallythemes.com/

SVN - https://themes.svn.wordpress.org/steed/1.0
ZIP - https://wordpress.org/themes/download/steed.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#31070 THEME: Steed – 1.3 closed live kevinhaig

(this ticket)

#37944 THEME: Steed – 2.0 closed live themetracbot
#38373 THEME: Steed – 2.1 closed live themetracbot
#38843 THEME: Steed – 2.2 closed live themetracbot
#39077 THEME: Steed – 2.3 closed live themetracbot
#45303 THEME: Steed – 3.0 closed live themetracbot
#45304 THEME: Steed – 3.0.1 closed live themetracbot
#46382 THEME: Steed – 3.2 closed live themetracbot
#46640 THEME: Steed – 3.3 closed live themetracbot
#47027 THEME: Steed – 3.4 closed live themetracbot
#47030 THEME: Steed – 3.4.1 closed live themetracbot


https://themes.svn.wordpress.org/steed/1.0/screenshot.png

Change History (29)

#1 @trkr
15 months ago

Hi @tallythemes

This is just a notice.

Reviewers are now allowed to close the ticket if 3 or more security or
prefixing issues are found. https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/

Also you should follow these requirements:
https://make.wordpress.org/themes/handbook/review/required/

Please make proper changes before your theme gets reviewed.

Thanks,
Turker.

#2 @themetracbot
14 months ago

  • Owner set to wptech
  • Status changed from new to reviewing

#3 @wptech
14 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

1) Sticky post styling issue https://nimbus.everhelper.me/client/notes/share/551675/2068uygpwwu5zmxz04ap

2) Styling issues https://nimbus.everhelper.me/client/notes/share/551694/dz4kl8f9cof8e97ixm5t https://nimbus.everhelper.me/client/notes/share/551697/bxd6w0wt0ynivgga920a

3) No pagination https://nimbus.everhelper.me/client/notes/share/551726/9u17m5qih35fgu4ebkw5

4) Theme check issues https://nimbus.everhelper.me/client/notes/share/551734/ywyqsq59kcskok7lcb05
https://nimbus.everhelper.me/client/notes/share/551736/9q34qx1t1ux3ewr9e50c

5) Data Validation issues have been found in your theme. All dynamic data must be correctly escaped for the context where it is rendered. - All dynamic data must be escaped with esc_attr() before rendered in an html attribute. - Whenever you are rendering a url to the screen its value must be passed through esc_url() first. - If dynamic data is rendered inside an attribute that triggers a JavaScript event, it must be escaped with esc_js(). Please make sure you read these articles: https://make.wordpress.org/themes/tags/writing-secure-themes/ http://codex.wordpress.org/Data_Validation http://developer.wordpress.com/themes/escaping/ http://code.tutsplus.com/articles/data-sanitization-and-validation-with-wordpress--wp-25536 https://vip.wordpress.com/documentation/best-practices/security/validating-sanitizing-escaping/ For examples and there are more: https://nimbus.everhelper.me/client/notes/share/551754/uzbpac3rzdylstdxdd38

6) Please use a unique prefix for all function names, custom images sizes, classes, CONSTANTS, hooks, public/global variables, and database entries to avoid conflict issues with plugins and other themes. For example, themename_ OR frameworkname_ - Read more at http://themereview.co/prefix-all-the-things/ - You can have frameworkname_ if you are using a framework while using themename_ for your themes

7) Globals should always be within a function or a class and should be used restrictively & only if theme really needs to. It's highly recommended not to use them at all just to keep things out of the global namespace, they're poor coding practice.

8) Hard coded footer https://nimbus.everhelper.me/client/notes/share/551764/0uyg2xs4rvbkbthen9qe

9) All theme text strings are to be translatable and properly escaped. https://gist.github.com/kailoon/01fa8e95d2e910e666c6

10) The localization file should be in English and delivered as .POT file. .POT will contain all translation strings. .POT file name should match the themes-slug. Theme can include an actual translation files, but it should not add the en_US.mo or en_US.po because English already implies.

11) Please update the TGM Plugin Activation to the latest version, which fixes the security flaw - https://github.com/TGMPA/TGM-Plugin-Activation/releases

#4 @jrf
14 months ago

Please update the TGM Plugin Activation to the latest version, which fixes the security flaw - https://github.com/TGMPA/TGM-Plugin-Activation/releases

Pro-tip: If you download a fresh copy of TGMPA using the Custom TGMPA Generator, it will serve you with a customized download of TGMPA which will pass the Theme Check rules (text-domain and such).

#5 @tallythemes
14 months ago

What a joke, after waiting 5 months the theme was reviewed and not-approved in the first review. If it is the rule why I had to wait 5 months. I also do review but I always try to cooperate with the theme author to make his/her theme approved.

The reviewer should give me time to fix the issue and review the theme again.

Now I will upload the theme again with the fixes and after 5 months it will review.

Last edited 14 months ago by tallythemes (previous) (diff)

#6 @trkr
14 months ago

@tallythemes,

I havent made a full review of your theme but as i pointed my previous reply 3 weeks ago, your theme has prefixing/security issues.

If you ignored that notice and didnt make any update about issues then there is no problem to close this ticket in my opinion.

Again, i havent make a full review so i could have missed something and ofcourse i'm not an admin. If you think there is a misunderstanding or a mistake feel free to ask an admin opinion.

Thanks,
Turker.

#7 @wptech
14 months ago

@tallythemes I am sorry, I mistakenly closed the ticket.

@trkr @jrf If someone has the authority to reopen it, then please do.

#8 @jrf
14 months ago

You can ask in the Team Review Slack for an admin to reopen it.

This ticket was mentioned in Slack in #themereview by ahmed00. View the logs.


14 months ago

#10 @djrmom
14 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#11 @djrmom
14 months ago

  • Status changed from reopened to reviewing

Reopening this per @wptech's request.

Please keep our new review baseline in mind as noted above https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/ "Themes that do not fullfill the review baseline will be closed. The ticket will be closed if the theme has more then 3 prefixing or security issues. This also applies to the admin review queue."

Thanks.

#12 @tallythemes
14 months ago

Hello @wptech,

Thank you for your effort to reopen the review again.

Please allow me 16 hours to fix the issue and update the theme for your 2nd review.

Thanks

#13 @wptech
14 months ago

@djrmom Thanks to reopen the ticket.

I have read that meeting note. Will take care of the things.

#14 @wptech
14 months ago

@tallythemes waiting for re submission

#15 @themetracbot
14 months ago

  • Summary changed from THEME: Steed – 1.0 to THEME: Steed – 1.1

Steed - 1.1

Steed is a very basic and standard wordpress theme. It is very easy to customize and very fast loaded.

Theme URL - http://tallyThemes.com/steed
Author URL - http://tallyThemes.com

SVN - https://themes.svn.wordpress.org/steed/1.1
ZIP - https://wordpress.org/themes/download/steed.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=steed/1.0&new_path=steed/1.1

History:

Ticket Summary Status Resolution Owner
#31070 THEME: Steed – 1.3 closed live kevinhaig

(this ticket)

#37944 THEME: Steed – 2.0 closed live themetracbot
#38373 THEME: Steed – 2.1 closed live themetracbot
#38843 THEME: Steed – 2.2 closed live themetracbot
#39077 THEME: Steed – 2.3 closed live themetracbot
#45303 THEME: Steed – 3.0 closed live themetracbot
#45304 THEME: Steed – 3.0.1 closed live themetracbot
#46382 THEME: Steed – 3.2 closed live themetracbot
#46640 THEME: Steed – 3.3 closed live themetracbot
#47027 THEME: Steed – 3.4 closed live themetracbot
#47030 THEME: Steed – 3.4.1 closed live themetracbot


https://themes.svn.wordpress.org/steed/1.1/screenshot.jpg

#16 @tallythemes
14 months ago

Hello @wptech

Sorry for the delay. I have to fix many issue as it was 5 months old and a lot of new rule and changes on the theme review guide.

Please review the theme.

Thank you very much

#17 @wptech
14 months ago

1) Still data validation issues are exits. http://nimb.ws/tLTo4a

2) You have added languages support in the theme but no language directory and files are exists

3) User the proper screenshot. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred. See in the theme check.

#18 @tallythemes
14 months ago

For the first issue what validation function I should use?

#19 @themetracbot
14 months ago

  • Summary changed from THEME: Steed – 1.1 to THEME: Steed – 1.2

Steed - 1.2

Steed is a very basic and standard wordpress theme. It is very easy to customize and very fast loaded.

Theme URL - http://tallyThemes.com/steed
Author URL - http://tallyThemes.com

SVN - https://themes.svn.wordpress.org/steed/1.2
ZIP - https://wordpress.org/themes/download/steed.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=steed/1.1&new_path=steed/1.2

History:

Ticket Summary Status Resolution Owner
#31070 THEME: Steed – 1.3 closed live kevinhaig

(this ticket)

#37944 THEME: Steed – 2.0 closed live themetracbot
#38373 THEME: Steed – 2.1 closed live themetracbot
#38843 THEME: Steed – 2.2 closed live themetracbot
#39077 THEME: Steed – 2.3 closed live themetracbot
#45303 THEME: Steed – 3.0 closed live themetracbot
#45304 THEME: Steed – 3.0.1 closed live themetracbot
#46382 THEME: Steed – 3.2 closed live themetracbot
#46640 THEME: Steed – 3.3 closed live themetracbot
#47027 THEME: Steed – 3.4 closed live themetracbot
#47030 THEME: Steed – 3.4.1 closed live themetracbot


https://themes.svn.wordpress.org/steed/1.2/screenshot.png

#20 @tallythemes
14 months ago

I have fixed the data validation issue that you have pointed.
I have added a language directory with language files
I have updated the Screenshot in PNG version and the size is 1200x900

#21 @wptech
14 months ago

  • Status changed from reviewing to approved

All is fixed ..

#22 @tallythemes
14 months ago

Hello @wptech
Thank you

#23 @kevinhaig
12 months ago

I will do this final.

#24 @kevinhaig
12 months ago

  • Status changed from approved to reopened

#25 @kevinhaig
12 months ago

Theme Review - Steed Version 1.2

  • Hi I am @kevinhaig and I have completed the second (final) review of your theme.
  • Sorry but the ticket has been reopened because there are requirements not met.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for custom-logo used but not found in tags list in style.css file: steed\functions.php, line: 84
The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
Post Formats
  • You have added theme support for Post Formats but I am not seeing them being supported. Post formats are about displaying the post in a distinctly different way from a standard post.
  • if you want to continue to support post formats, make them distinctive, otherwise remove the add_theme_support() statement and ensure the tag is not in the style.css taglist

Licensing

Declare copyright and license explicitly. Use the license and license uri header slugs to style.css.
  • You have not properly declared the copyright. As a minimum, either in style.css or in the readme.txt file you need to have :
       theme name WordPress Theme, Copyright (C) 2015, theme author
       theme name is distributed under the terms of the GNU GPL
    
Declare licenses of any resources included such as fonts or images, including screenshot images
  • For resources please include: declaration (ex Copyright 2015, by John Smith), resource download link, license type, and license download
  • TGMPA needs to be declared
  • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      
  • please declare the image used in the screenshot
Licensing References

Themeshop Uses GPL

If you are a themeshop you should be selling under GPL to be in the WordPress.org repo.
  • The statement below on your website does not observe the GPL freedoms. Any WordPress products available on your site whether free or for sale must observe these freedoms or you can't host the theme on the .org repo.

You may download a single copy of any content contained on the Sites, solely for your personal, non-commercial use, consistent with these terms of use, provided that you maintain the copyright and other notices contained in that content. This excludes products available for sale/licensing on the Sites.

Other Selling Problems

  • Upselling is too extensive
    • Please limit your Upsell to one link in the main customizer panel.

Stylesheets and Scripts

No minification of scripts or files unless provide original files.
  • In the spirit of GPL software, users must be given the source code in a format they can understand and edit if they so choose. Minified code is very difficult to read and edit so if you are going to use the minified code in your theme you must also provide a non minified version for users to read and edit, if they wish to do that. This applies to all code, but in particular css and js files
  • please provide a unminified version of font-awesome.min.css

#26 @themetracbot
12 months ago

  • Summary changed from THEME: Steed – 1.2 to THEME: Steed – 1.3

Steed - 1.3

Steed is a very basic and standard wordpress theme. It is very easy to customize and very fast loaded.

Theme URL - http://tallyThemes.com/steed
Author URL - http://tallyThemes.com

SVN - https://themes.svn.wordpress.org/steed/1.3
ZIP - https://wordpress.org/themes/download/steed.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=steed/1.2&new_path=steed/1.3

History:

Ticket Summary Status Resolution Owner
#31070 THEME: Steed – 1.3 closed live kevinhaig

(this ticket)

#37944 THEME: Steed – 2.0 closed live themetracbot
#38373 THEME: Steed – 2.1 closed live themetracbot
#38843 THEME: Steed – 2.2 closed live themetracbot
#39077 THEME: Steed – 2.3 closed live themetracbot
#45303 THEME: Steed – 3.0 closed live themetracbot
#45304 THEME: Steed – 3.0.1 closed live themetracbot
#46382 THEME: Steed – 3.2 closed live themetracbot
#46640 THEME: Steed – 3.3 closed live themetracbot
#47027 THEME: Steed – 3.4 closed live themetracbot
#47030 THEME: Steed – 3.4.1 closed live themetracbot


https://themes.svn.wordpress.org/steed/1.3/screenshot.png

#27 @tallythemes
12 months ago

Hello @kevinhaig,

I have fixed all listed issue.

#28 @kevinhaig
11 months ago

  • Owner changed from wptech to kevinhaig
  • Status changed from reopened to reviewing

looks fine

#29 @kevinhaig
11 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.