WordPress.org

Make WordPress Themes

#31122 closed theme (live)

THEME: Numinous – 1.0.7

Reported by: raratheme Owned by: smarica
Priority: new theme Keywords: theme-numinous
Cc: raushan@…

Description

Numinous - 1.0.0

Numinous is a clean and elegant WordPress theme that can be used for blogging. It is built with HTML5, CSS3 and JQuery and is fully responsive and easy to navigate on various types of displays from desktops to mobile. The theme is translation ready.

Theme URL - http://raratheme.com/theme/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.0
ZIP - https://wordpress.org/themes/download/numinous.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.0/screenshot.png

Change History (37)

#1 @themetracbot
16 months ago

  • Owner set to chronmods
  • Status changed from new to reviewing

#2 @raratheme
16 months ago

Hello @chronmods,

We are going to upload latest version of Numinous in a few hours. Kindly review the latest version of the theme.

Thank you.

#3 @themetracbot
16 months ago

  • Summary changed from THEME: Numinous – 1.0.0 to THEME: Numinous – 1.0.1

Numinous - 1.0.1

Numinous is a clean and elegant WordPress theme that can be used for blogging. It is built with HTML5, CSS3 and JQuery and is fully responsive and easy to navigate on various types of displays from desktops to mobile. The theme is translation ready.

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.1
ZIP - https://wordpress.org/themes/download/numinous.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.0&new_path=numinous/1.0.1

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.1/screenshot.png

#4 @raratheme
16 months ago

Hello @chronmods,

We have uploaded the latest version of Numinous. Kindly review the latest version.

Thank you.

#5 @grapplerulrich
16 months ago

  • Owner chronmods deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#6 @themetracbot
16 months ago

  • Owner set to smarica

#7 @smarica
16 months ago

WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag green has been deprecated, please remove it from your style.css header.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Escaping is missing in :

numinous-custom-functions.php in lines 181, 222, 225, 229, 231 and 232
numinous-metabox.php in lines 46, 58 and 61
widget-popular-post.php in lines 53, 54, 71, 83, 106, 107, 111, 112, 116, 117, 121 and 122
widget-recent-post.php in lines 52, 53, 72, 84, 106, 107, 111, 112, 116, 117, 121 and 122
content-search.php in line 24
content.php in line 52
footer.php in lines 45, 46 and 48

#8 @raratheme
16 months ago

Hello @smarica,

Could you kindly confirm that you have reviewed the latest version of the theme?

Thank you.

Best regards,
Raushan

#9 @smarica
16 months ago

I am so sorry for reviewing the old version. Here's the review of the latest version of the theme.

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
Escaping is missing in :

custom-functions.php in line 227
numinous-metabox.php in lines 46, 58 and 61
widget-popular-post.php in lines 53, 54, 77, 99, 100, 104, 105, 110, 114 and 115
widget-recent-post.php in lines 52, 53, 76, 98, 99, 103, 104, 108, 109, 113 and 114

#10 @themetracbot
16 months ago

  • Summary changed from THEME: Numinous – 1.0.1 to THEME: Numinous – 1.0.3

Numinous - 1.0.3

Numinous is a clean and elegant WordPress theme that can be used for blogging. It is built with HTML5, CSS3 and JQuery and is fully responsive and easy to navigate on various types of displays from desktops to mobile. The theme is translation ready.

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.3
ZIP - https://wordpress.org/themes/download/numinous.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.1&new_path=numinous/1.0.3

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.3/screenshot.png

#11 @raratheme
16 months ago

Hello @smarica,

We have fixed the issues and uploaded the latest version of the theme. Please find my feedback below.

custom-functions.php in line 227

It's already escaped. You can see here: https://make.wordpress.org/themes/2015/02/10/custom-css-boxes-in-themes/

numinous-metabox.php in lines 46, 58 and 61

There is no file named "numinous-metabox.php".

widget-popular-post.php in lines 53, 54, 77, 99, 100, 104, 105, 110, 114 and 115

Fixed

widget-recent-post.php in lines 52, 53, 76, 98, 99, 103, 104, 108, 109, 113 and 114

Fixed

Thank you.

Best regards,
Raushan

#12 @smarica
16 months ago

  • Status changed from reviewing to approved

Seems like the theme is ready to go !

All the best

Smarika

#13 @raratheme
16 months ago

Thank you @smarica.

Have a nice evening!

Best regards,
Raushan Jaiswal

#14 @greenshady
14 months ago

I'm taking the admin review for this theme.

#15 @greenshady
14 months ago

  • Status changed from approved to reopened

#16 @greenshady
14 months ago

  • Status changed from reopened to reviewing

Overall, everything looks pretty solid. There's just a few issues that need correcting before I can set this live.

Front Page

The "Home Page Settings" should not be shown on the front page if the user has chosen for the blog posts to appear on their front page. These should only show for your custom template.

Copyright / License

Missing copyright and license statements in readme file for the third-part JS and Font Awesome CSS and font.

Your post type archive links are broken. You also show an archive link when a post type doesn't have an archive link.

Make sure to internationalize the date/time when outputting it.

#17 @themetracbot
13 months ago

  • Summary changed from THEME: Numinous – 1.0.3 to THEME: Numinous – 1.0.4

Numinous - 1.0.4

Numinous is a clean and elegant WordPress theme that can be used for blogging. It is built with HTML5, CSS3 and JQuery and is fully responsive and easy to navigate on various types of displays from desktops to mobile. The theme is translation ready.

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.4
ZIP - https://wordpress.org/themes/download/numinous.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.3&new_path=numinous/1.0.4

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.4/screenshot.png

#18 @themetracbot
13 months ago

  • Summary changed from THEME: Numinous – 1.0.4 to THEME: Numinous – 1.0.5

Numinous - 1.0.5

Numinous is a clean and elegant Magazine WordPress theme. It is aresponsive magazine style WordPress theme suitable for news, newspaper, magazine, food, technology, viral content websites. The theme is easily customisable using the options available on the customizer. Designed with visitor engagement in mind, the theme has a clean layout and great typography to create a beautiful looking website and adds up to a great user experience. The theme is developed using SEO in mind, so that you can easily climb the Google ranking. The theme comes with several custom widgets that can be placed on various widget areas in the theme. It also had colour options for the category. The theme is also translation ready. Check the demo at http://raratheme.com/preview/numinous, documentation at http://raratheme.com/documentation/numinous and get support at https://raratheme.com/support-ticket

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.5
ZIP - https://wordpress.org/themes/download/numinous.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.4&new_path=numinous/1.0.5

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.5/screenshot.png

#19 @raratheme
13 months ago

Hello @greenshady,

We have fixed all the issues that you have mentioned. Please check.

We have also made 2 small changes.

  1. We have changed images in the screenshot. We have also included the image license in the readme file.
  2. We have updated theme description.

Thank you.

#20 @greenshady
13 months ago

You still didn't fix two of the four issues I posted.

Front Page

The custom home page settings should not be shown on the front page of the site when the user has chosen to show blog posts there.

Just because you've hidden those settings in the customizer and are only showing them when the template-home.php is used doesn't change how this works. Suppose I add that template to my "About" page at localhost/about. Then, I save the settings. Well, those things still appear on my front page, even though my front page is set to show the latest posts.

The post type archive link in your breadcrumbs is still broken. Use: https://developer.wordpress.org/reference/functions/get_post_type_archive_link/

#21 @raratheme
13 months ago

Hello @greenshady,

  1. Will this be good, if we check for show_on_front as well like this?
( get_option( 'show_on_front' ) == 'page' ) && is_page_template( 'template-home.php' )

  1. For Breadcrumb, is this the right way?
$post_type = get_post_type_object(get_post_type());
                if ( get_query_var('paged') ) {
        echo '<a href="' . esc_url( get_post_type_archive_link( $post_type->name ) ) . '">' . esc_html( $post_type->label ) . '</a>';
                    if( $showCurrent == 1 ) echo ' <span class="separator">' . esc_html( $delimiter ) . '</span> ' . $before . sprintf( __('Page %s','numinous'), get_query_var('paged') ) . $after;
       } else {
        if ( $showCurrent == 1 ) echo $before . esc_html( $post_type->label ) . $after;
       }

Thank you.

#22 @greenshady
12 months ago

Sorry for the late reply. I remember writing an answer to this when you first asked. I think I just forgot to post it here.

With the page template, you only need to check:

if ( is_page_template( 'template-home.php' ) )

The post type archive link looks good.

#23 @raratheme
12 months ago

@greenshady, thank you.

We have checked the following in the uploaded theme above.

if ( is_page_template( 'template-home.php' ) )

Could you kindly tell us what is missing or wrong, so that we can fix?

We have corrected post type archive. We will upload a new version after correcting the above issue as well.

Thank you.

#24 @greenshady
12 months ago

Suppose I add template-home.php to my "About" page at localhost/about. Then, I save the settings for that template. Those things show on the front page of my site, even though my front page is set to show the latest posts or another page.

Last edited 12 months ago by greenshady (previous) (diff)

#25 @raratheme
12 months ago

@greenshady

( get_option( 'show_on_front' ) == 'page' ) && is_page_template( 'template-home.php' )

Is the above code fine, which will show the home page setting only when the template is assigned and make it as front page?

If not, could you please tell us the solutions?

Thank you.

#26 @greenshady
12 months ago

Like I said above, the conditional check you need is this:

if ( is_page_template( 'template-home.php' ) )

#27 @raratheme
12 months ago

@greenshady We have already checked that condition in customizer.php at line 15. Is there somewhere else that needs to be checked?

#28 @raratheme
12 months ago

@greenshady I hope you had good times during the holidays.

Any feedback on above? :)

Thank you.

#29 @greenshady
12 months ago

Follow these steps that I've already described exactly.

Suppose I add template-home.php to my "About" page at localhost/about. Then, I save the settings for that template. Those things show on the front page of my site, even though my front page is set to show the latest posts or another page.

Just follow those directions and see what happens. Then, fix it. You know where all the code is in your theme, not me.

#30 @themetracbot
11 months ago

  • Summary changed from THEME: Numinous – 1.0.5 to THEME: Numinous – 1.0.6

Numinous - 1.0.6

Numinous is a clean and elegant Magazine WordPress theme. It is a responsive magazine style WordPress theme suitable for news, newspaper, magazine, food, technology, viral content websites. The theme is easily customisable using the options available on the customizer. Designed with visitor engagement in mind, the theme has a clean layout and great typography to create a beautiful looking website and adds up to a great user experience. The theme is developed using SEO in mind, so that you can easily climb the Google ranking. The theme comes with several custom widgets that can be placed on various widget areas in the theme. It also had colour options for the category. The theme is also translation ready. Check the demo at http://raratheme.com/preview/numinous, documentation at http://raratheme.com/documentation/numinous and get support at https://raratheme.com/support-ticket

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.6
ZIP - https://wordpress.org/themes/download/numinous.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.5&new_path=numinous/1.0.6

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#31 @raratheme
11 months ago

@greenshady We have made changes as you have recommended. Please take a look and let us know your feedback.

Thank you.

#32 @greenshady
11 months ago

You fixed the front page issue. However, in your changeset, you created some new issues that I couldn't ignore.

===Security===

You need to wrap get_query_var( 'paged' ) with absint() or intval() here in inc/template-functions.php on line 590:

if( $showCurrent == 1 ) echo ' <span class="separator">' . esc_html( $delimiter ) . '</span> ' . $before . sprintf( __('Page %s','numinous'), get_query_var('paged') ) . $after;

===Admin Scripts===

You added this code that loads scripts on every admin page in inc/custom-functions.php.

if ( is_admin() ) : // Load only if we are viewing an admin page
function numinous_admin_scripts() {
	wp_enqueue_style( 'numinous-admin-style',get_template_directory_uri().'/inc/css/admin.css', '1.0', 'screen' );    
    wp_enqueue_script( 'numinous-admin-js', get_template_directory_uri().'/inc/js/admin.js', array( 'jquery' ), '', true );
}
add_action( 'admin_enqueue_scripts', 'numinous_admin_scripts' );
endif;

First, you don't need the if ( is_admin() ) check. admin_enqueue_scripts only runs in the admin.

Second, you need to use the $hook parameter to check if you're loading this on the necessary admin screen. See: https://codex.wordpress.org/Plugin_API/Action_Reference/admin_enqueue_scripts#Example:_Load_CSS_File_from_a_plugin_on_specific_Admin_Page

To me, this looks like customizer CSS and JS. If so, the appropriate hook for that would be customize_controls_enqueue_scripts.

Last edited 11 months ago by greenshady (previous) (diff)

#33 @themetracbot
11 months ago

  • Summary changed from THEME: Numinous – 1.0.6 to THEME: Numinous – 1.0.7

Numinous - 1.0.7

Numinous is a clean and elegant Magazine WordPress theme. It is a responsive magazine style WordPress theme suitable for news, newspaper, magazine, food, technology, viral content websites. The theme is easily customisable using the options available on the customizer. Designed with visitor engagement in mind, the theme has a clean layout and great typography to create a beautiful looking website and adds up to a great user experience. The theme is developed using SEO in mind, so that you can easily climb the Google ranking. The theme comes with several custom widgets that can be placed on various widget areas in the theme. It also had colour options for the category. The theme is also translation ready. Check the demo at http://raratheme.com/preview/numinous, documentation at http://raratheme.com/documentation/numinous and get support at https://raratheme.com/support-ticket

Theme URL - http://raratheme.com/wordpress-themes/numinous/
Author URL - http://raratheme.com/

SVN - https://themes.svn.wordpress.org/numinous/1.0.7
ZIP - https://wordpress.org/themes/download/numinous.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=numinous/1.0.6&new_path=numinous/1.0.7

History:

Ticket Summary Status Resolution Owner
#31122 THEME: Numinous – 1.0.7 closed live smarica

(this ticket)

#40050 THEME: Numinous – 1.0.8 closed live themetracbot
#40354 THEME: Numinous – 1.0.9 closed live themetracbot
#42748 THEME: Numinous – 1.1.0 closed live themetracbot
#43124 THEME: Numinous – 1.1.1 closed live themetracbot
#44916 THEME: Numinous – 1.1.2 closed live themetracbot
#46628 THEME: Numinous – 1.1.3 closed live themetracbot
#47634 THEME: Numinous – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/numinous/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#34 @raratheme
11 months ago

Hi @greenshady, Thank you for the review. We have fixed the issues that you have mentioned and uploaded a new version.

Please take a look. Thank you.

#35 @raratheme
11 months ago

Hi @greenshady, just a kind reminder that it has been 9 days :)

#36 @raratheme
11 months ago

Hi @greenshady, another kind reminder. It has been more than 3 weeks that the ticket is not reviewed :)

#37 @greenshady
11 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.