WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 13 months ago

Last modified 13 months ago

#31170 closed theme (live)

THEME: Micro – 1.2.8

Reported by: xavortm Owned by: poena
Priority: new theme Keywords: theme-micro
Cc: xavortm@…

Description

Micro - 1.0

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.0
ZIP - https://wordpress.org/themes/download/micro.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.0/screenshot.png

Attachments (1)

GIF.gif (68.7 KB) - added by poena 14 months ago.

Download all attachments as: .zip

Change History (29)

#1 @themetracbot
20 months ago

  • Summary changed from THEME: Micro – 1.0 to THEME: Micro – 1.1

Micro - 1.1

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.1
ZIP - https://wordpress.org/themes/download/micro.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.0&new_path=micro/1.1

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.1/screenshot.png

#2 @themetracbot
20 months ago

  • Summary changed from THEME: Micro – 1.1 to THEME: Micro – 1.2.2

Micro - 1.2.2

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.2
ZIP - https://wordpress.org/themes/download/micro.1.2.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.1&new_path=micro/1.2.2

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.2/screenshot.png

#3 @themetracbot
20 months ago

  • Summary changed from THEME: Micro – 1.2.2 to THEME: Micro – 1.2.3

Micro - 1.2.3

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.3
ZIP - https://wordpress.org/themes/download/micro.1.2.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.2&new_path=micro/1.2.3

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.3/screenshot.png

#4 @poena
14 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#5 @poena
14 months ago

Hi
Before I start the review I have some questions about licensing.
All authors who wants to include their themes in the WordPress.org theme directory needs to sell their WordPress related products under a GPL compatible license.

If I understand correctly, you do not sell premade plugins or themes. But I was unable to find any license information
for the finished products that you do sell?

Last edited 14 months ago by poena (previous) (diff)

#6 @xavortm
14 months ago

@poena can you please link me to what you've read? I am not 100% what are you referring to :)

#7 @poena
14 months ago

I meant the author link that leads to the company website. (It's a rather large site so no, I can't tell you exactly what pages I've read).
I was not able to find any license information.

Perhaps if I use this phrase from the requirements it becomes clearer:
"If you are a theme shop you should be selling under GPL to be in the WordPress.org repo."

https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

The requirement is not exclusive to "themeshops". I believe that you understand the WordPress philosophy regarding GPL, I don't think this is going to be an issue? But as a revier I need to make sure.

#8 @xavortm
14 months ago

All themes and plugins are GPL compatible. You can see it here:

https://profiles.wordpress.org/devrix#content-plugins
https://profiles.wordpress.org/devrix#content-themes

All products are 100% GPL compatible.

#9 @poena
14 months ago

Hi
I still feel like we are not fully understanding each other.
If you want to change the author uri to the .org link that is acceptable.

But your commercial products needs to be under a GPL compatible license too.
Even if you dont release them to the public. If your products cant be gpl then your theme cannot be allowed in the directory.

Version 0, edited 14 months ago by poena (next)

#10 @poena
14 months ago

Meanwhile I have completed the review.
I found some issues with the theme that needs to be fixed before it can go live:

Required

The tags used in style.css has been updated, please see https://make.wordpress.org/themes/2016/05/24/new-theme-tags-have-arrived/

WARNING: The tag green has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.

When I open the customizer, these options are not working:
Display Site Title and Tagline: -When the checkbox is unchecked, the site title and description is ment to be hidden.
Header Text Color -This option is not working.
The Micro colors Global text color is working, but the Micro colors Global background color is not working.
It does not change the background, but it changes the post title color and the background color of for example the pre tag.

You can also disable these default options by adding the following arguments to add_theme_support( 'custom-header' ... in functions.php line 107 and forward:

 'default-text-color' => false,
 'header-text' => false,

I was unable to find a copyright statement for the theme itself.
See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

There are several empty files and folders -please remove any and all code, files, folders that are not used.
(It's a big plus that you have added a little bit of documentation regarding the gruntfile, as many users would not understand what this file is for).

While we do not have any design requirements, the default text color of the menu is the same as the default background color and this makes the menu practically unusable. It is only visible on hover.
When I tested the theme in Chrome (on pc) the menu also "flickered" (spelling), and I couldn't click the submenu items because as soon as the mouse was no longer hovering over the parent item, the sub menu items turned invisible.

custom-header.php
All the color options in the css needs to be escaped, not only echoed. I suggest using esc_attr().

Language:
The pot file in the languages folder refers to _s and needs to be updated.

Recommended:

I recommend updating the readme file header, and make sure that the theme has been tested with 4.6.
I also recommend that you work towards making the theme responsive.

I asked my fellow reviewers about the micro_remove_html_margin() function, and they suggested using the following instead:

add_theme_support( 'admin-bar', array( 'callback' => '__return_false') );

You can see the conversation here in the Slack archive:
https://wordpress.slack.com/archives/themereview/p1472052717004303


To submit your update, make your changes and update the version number, and upload the theme here: https://wordpress.org/themes/getting-started/

You need to reply within 7 days, or your ticket may be closed as not approved.


It is also important to note that reviewers may now close themes as not approved if 5 or more errors are found in the theme.
We would like to encourage all authors to test their theme carefully before submitting, to help us reduce the waiting time.
See https://make.wordpress.org/themes/2016/08/23/meeting-summary-2016-23-08/

#11 @xavortm
14 months ago

Thank you for the rich review! I will focus on the outlined issues in the next week or two. I will also see what needs to be updated regarding the licensing.

#12 @poena
14 months ago

Any update?

#13 @themetracbot
14 months ago

  • Summary changed from THEME: Micro – 1.2.3 to THEME: Micro – 1.2.4

Micro - 1.2.4

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.4
ZIP - https://wordpress.org/themes/download/micro.1.2.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.3&new_path=micro/1.2.4

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.4/screenshot.png

#14 @xavortm
14 months ago

Sorry for the delay. I think the issues you outlined are fixed including the responsiveness.

#15 @poena
14 months ago

Hi
These issues remain:

Elements background color -this still changes the color of the post titles.

The copyright statement refers to Twenty Fifteen and not to this theme.

I'm still experiencing the problems with the drop down menu.
I will add a gif that shows what it looks like on my install.

@poena
14 months ago

#16 @grapplerulrich
14 months ago

@xavortm Please upload an update or the ticket will be closed.

#17 @themetracbot
14 months ago

  • Summary changed from THEME: Micro – 1.2.4 to THEME: Micro – 1.2.5

Micro - 1.2.5

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.5
ZIP - https://wordpress.org/themes/download/micro.1.2.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.4&new_path=micro/1.2.5

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.5/screenshot.png

#18 @xavortm
14 months ago

Here is the update - I changed the strings in the readme file + fixed the css issues on hover and added support for more elements to change the colors. Also I changed the string from Text Color to Primary Color (same as background) so that such issues like @poena mentioned won't be confusing.

#19 @poena
13 months ago

Hi
Now you removed the copyright statement for the theme. What I meant was that you need to change the information from Twenty Fifteen to your own theme name, and your information.
Example: Theme name Copyright Author name Year.

-The submenu items are now visible, but I still can't click them.
(I'm on a pc)

I noticed that the fallback, -the menu shown when no menu has been selected, is styled slightly different and actually works better. Here the sub menu items are clickable.

Please remove the MACOSX folder.

#20 @poena
13 months ago

Hi
Do you plan to post an update or can I close this ticket?

#21 @themetracbot
13 months ago

  • Summary changed from THEME: Micro – 1.2.5 to THEME: Micro – 1.2.6

Micro - 1.2.6

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.6
ZIP - https://wordpress.org/themes/download/micro.1.2.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.5&new_path=micro/1.2.6

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.6/screenshot.png

#22 @xavortm
13 months ago

Sorry, I did fix it on the same day, but It seems the upload didn't went through. Here now I think it should be better. Thank you for your patience.

#23 @poena
13 months ago

Hi
You did not fix all the problems.
I also asked a second reviewer to verify the menu problem, and they experienced the same thing.
I have re-uploaded the latest version to a live server here:
http://www.plushie.se/

#24 @themetracbot
13 months ago

  • Summary changed from THEME: Micro – 1.2.6 to THEME: Micro – 1.2.7

Micro - 1.2.7

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.7
ZIP - https://wordpress.org/themes/download/micro.1.2.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.6&new_path=micro/1.2.7

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.7/screenshot.png

#25 @poena
13 months ago

Hi
The menu is working, but the MACOSX folder still needs to be removed.
Again I'm on a PC, but I think you need to remove it form the zip after the zip has been created.

Last edited 13 months ago by poena (previous) (diff)

#26 @themetracbot
13 months ago

  • Summary changed from THEME: Micro – 1.2.7 to THEME: Micro – 1.2.8

Micro - 1.2.8

Very small dark WordPress theme with code-like styling based on underscores starter theme

Theme URL - https://github.com/xavortm/wp-theme-micro
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/micro/1.2.8
ZIP - https://wordpress.org/themes/download/micro.1.2.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=micro/1.2.7&new_path=micro/1.2.8

History:

Ticket Summary Status Resolution Owner
#20006 THEME: Microfusion - 1.3 closed live sakinshrestha
#24060 THEME: Microblog – 1.0 closed not-approved webulous
#25598 THEME: Microblog – 1.2 closed live catchthemes
#31170 THEME: Micro – 1.2.8 closed live poena

(this ticket)

#31979 THEME: microformats – 2.0.0 closed live metallicarosetail
#36059 THEME: Microblog – 1.3 closed live themetracbot
#37941 THEME: Micro – 1.3.0 closed live themetracbot
#37983 THEME: Micro – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/micro/1.2.8/screenshot.png

#27 @poena
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thank you, your theme should be live shortly.

#28 @xavortm
13 months ago

Thank you for your patience with the delays and fixing. I will keep in mind the process to make it faster and easier for you reviewers next time. Keep up your good work, it's very appreciated!

Note: See TracTickets for help on using tickets.