WordPress.org

Make WordPress Themes

#31420 closed theme (live)

THEME: Optics – 1.0.1.1

Reported by: endortrails Owned by: rabmalin
Priority: new theme Keywords: theme-optics
Cc: thadallender@…

Description

Change History (16)

#1 @themetracbot
16 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 @rabmalin
16 months ago

Hello,

Thanks for uploading theme. I wil be reviewing your theme. Please fix following issues and reupload your theme.

Theme Tags

Prefixing

  • REQUIRED: Please prefix custom image handle. See functions.php - portfolio-landscape, etc.
  • REQUIRED: Please do not prefix handle of third party styles and scripts. optics-genericons should be genericons. `functions.php

Updater

  • REQUIRED: Please remove custom updater. It is not allowed. See GPP_Updater.

Code

  • REQUIRED: What does 'depth' => -1 in footer.php? Negative value is not accepted here I believe.

Files

  • REQUIRED: Remove rtl.css is you are not planning to use.
  • REQUIRED: Is layouts folder used?

License

  • REQUIRED: readme.txt - Please add full image URL of images used in the screenshot. All resources should be GPL compatible.

Upsell

  • REQUIRED: Non functional theme options are not allowed. Please remove them.
  • REQUIRED: You can have one upsell link in the customizer. But please make sure you are properly using Customizer API for that. No custom JS hack for upsell.

Plugin Territory

  • REQUIRED: Remove optics_media_setting().

Language / Translation

  • REQUIRED: Please regenerate optics.pot file. Or you can omit it if you want to use WordPress Language Pack.

Important

  • Please respond within 7 days. If there is no reply for 7 days then ticket will be closed as not-approved.

#3 @endortrails
16 months ago

Hi @rabmalin,

Thanks for the review. We will be making changes and update. I hope it won't be closed till then.

#4 @rabmalin
16 months ago

@endortrails ok sure. But make sure you respond within 7 days. If there is no reply for 7 days then ticket will be closed as not-approved.

#5 @endortrails
16 months ago

Is there a proper way to add the link in the customizer? The Make theme uses JS for their upsell link. We are doing the same. Let me know a better way.

REQUIRED: You can have one upsell link in the customizer. But please make sure you are properly using Customizer API for that. No custom JS hack for upsell.

#6 @endortrails
16 months ago

Also, where is the depth => -1 that you are referring to? I cannot seem to find that.

#7 @themetracbot
16 months ago

  • Summary changed from THEME: Optics – 1.0 to THEME: Optics – 1.0.1

#8 @endortrails
16 months ago

Ok, I have done other changes except for the Custom JS until we find a better way of doing that. Let me know what further edits needs to be done. Thanks.

#9 @rabmalin
16 months ago

One approach would be creating section and making custom Control for upsell info.

#10 @rabmalin
16 months ago

I talked with admin regarding upsell issue. He told me to allow such upsell for now.
I will check updated theme and post comment later.

#11 @rabmalin
15 months ago

Only few issues left.

Issues

#12 @themetracbot
15 months ago

  • Summary changed from THEME: Optics – 1.0.1 to THEME: Optics – 1.0.1.1

#13 @endortrails
15 months ago

I have added Justin's code. Other pointers are fixed as well. Thanks.

#14 @rabmalin
15 months ago

  • Status changed from reviewing to approved

Marking as approved. Stay tuned to admin queue to check position of the theme. Only after admin approval, your theme will be live. Good luck.

#15 @endortrails
15 months ago

Thanks a lot for your time and review.

#16 @karmatosed
14 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.