WordPress.org

Make WordPress Themes

Opened 19 months ago

Closed 14 months ago

Last modified 14 months ago

#31421 closed theme (live)

THEME: Photolog – 1.0.2.2

Reported by: endortrails Owned by: poena
Priority: new theme Keywords: theme-photolog
Cc: thadallender@…

Description

Photolog - 1.0.1

A photo blog theme for bloggers and photographers

Theme URL - https://graphpaperpress.com/themes/photolog/
Author URL - https://graphpaperpress.com

SVN - https://themes.svn.wordpress.org/photolog/1.0.1
ZIP - https://wordpress.org/themes/download/photolog.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#9952 THEME: Photologger - 1.0 closed not-approved Sanjiv Saha
#10340 THEME: Photologger - 1.01 closed live Fingli
#11131 THEME: Photologger - 1.02 closed live johnheimkes
#31421 THEME: Photolog – 1.0.2.2 closed live poena

(this ticket)


https://themes.svn.wordpress.org/photolog/1.0.1/screenshot.png

Change History (15)

#1 @poena
14 months ago

  • Owner set to poena
  • Status changed from new to reviewing

Hi
Since your theme has not been updated in 5 months please make sure that it is ready for review and upload your latest version.

#2 @poena
14 months ago

Hi
Since you did not reply, I went ahead with the review of the current version. Your theme has been reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

If you had planned to do any major changes, I would appreciate if you waited until the theme is live.
Please reply within 7 days, or your ticket will be closed as not approved.

Overall the code looks good. There are a couple of things that needs to be solved before your theme can go live:

Copyright and license
The entire theme needs to be GPL compatible, this includes the images used in the screenshot.
Besides the image licence and copyright information, I am also missing a copyright statement for the theme itself. This is required by the GPL.
You can read more in the license itself, or here: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

-You have two readme files, please only keep one. Since not all users understands what the .md file ending is, I do recommend that you keep the .txt version.
Please update the readme file and make sure that you have tested the theme with version 4.6, not only 4.4.

The tags that can be used in style.css has been updated, see
https://make.wordpress.org/themes/handbook/review/required/theme-tags/
https://make.wordpress.org/themes/2016/05/24/new-theme-tags-have-arrived/
These needs to be removed:
WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag photoblogging has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag gray has been deprecated, please remove it from your style.css header.
WARNING: The tag fluid-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.

extras.php
This function needs to be removed, it is not allowed in themes: photolog_media_setting().
If you need multiple, specific image sizes in the theme, please use add_image_size().
Don't forget that the name of the new image size needs to be prefixed with the theme slug.

Upsell
There are two issues here:
You are not allowed to have options in the customzier that are not working.
For reference please read these meeting notes: https://make.wordpress.org/themes/2016/05/03/may-3rd-meeting-notes/
-You are allowed to add a couple of pro links in the sections, but only for actual, working options.
This text is somewhat misleading: "Upgrade to Optics Pro to enable galleries option for your website", because you are making it sound like you can't have any galleries without the pro theme.

The second issue is the Upgrade to pro button at the top of the customizer.
While it was agreed that authors are allowed to have an upsell button, it has come to our attention that this way of adding the button with javascript will cause problems with for example the new theme install feature that is planned for 4.7. It is not future proof -we kindly ask that you use the customizer api to add your upsell link.

(Note: you are also allowed to have a full page in the admin under the appearance menu, you are not taking advantage of this.)

Also, while I expect most of these settings to be removed from the customizer, you should not be using esc_html as a sanitizing callback. It is used to escape content on output, not before saving content to the database.

Last edited 14 months ago by poena (previous) (diff)

#3 @poena
14 months ago

Hi
How are you coming along with your changes?

#4 @endortrails
14 months ago

Hi @poena,

Thanks for the review. We will be making changes and update. I hope it won't be closed till then.

#5 @endortrails
14 months ago

@poena We based those 'pro' links as done with the popular Make theme. Is that not allowed now?

What does: One top-level link in the customizer (other unobtrusive links in sections allowed). mean? ref: https://make.wordpress.org/themes/2016/05/03/may-3rd-meeting-notes/

#6 @themetracbot
14 months ago

  • Summary changed from THEME: Photolog – 1.0.1 to THEME: Photolog – 1.0.2

#7 @endortrails
14 months ago

I have fixed the issues you reported and also removed customizer option totally. I have still kept the pro link as it is as I saw Make theme is also doing the same. If this is not allowed, please recommend a better, proper way to doing it. I want to keep things simple so taking a full page in the admin approach might not be best option. Most people visit Customizer page and if they can see that there is an option to upgrade, that would be best.

Let us know what else needs to be fixed. Thanks.

Last edited 14 months ago by endortrails (previous) (diff)

#8 @poena
14 months ago

Hi
I will look at your update this evening.

This trac ticket can explain the problem better:
https://core.trac.wordpress.org/ticket/37335

There will be a blog post with examples but I'm not sure when exactly it will be ready. You are still allowed a link.

I will make sure to take another look at the make theme and see if we need to require any changes.

#10 @poena
14 months ago

Hi
The discussion about the upsell link is ongoing. You can read last nights discussions on slack here:
https://wordpress.slack.com/archives/themereview/p1473259931000989

"We can't accept themes injecting advertising into the customizer because that would mean that the theme is bypassing core functionality. The tools are available in core and have been since the customizer was added.
We have a very clear rule on using core WP functions and features if they're available: https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features"

This example code was posted. I have not tried it, and it's not perfect yet, but you can possibly build from it to fit your needs.
https://github.com/justintadlock/trt-customizer-pro

if this is not working for you perhaps you can just use a section.

From the previous review:

Copyright and license -not fixed
The entire theme needs to be GPL compatible, this includes the images used in the screenshot.
Besides the image licence and copyright information, I am also missing a copyright statement for the theme itself. This is required by the GPL.
You can read more in the license itself, or here: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Please update the readme file and make sure that you have tested the theme with version 4.6, not only 4.4.

tags -almost fixed.
Please remove "featured-image-header". I could not find this option in the theme.

#11 @themetracbot
14 months ago

  • Summary changed from THEME: Photolog – 1.0.2 to THEME: Photolog – 1.0.2.1

#12 @themetracbot
14 months ago

  • Summary changed from THEME: Photolog – 1.0.2.1 to THEME: Photolog – 1.0.2.2

#13 @endortrails
14 months ago

@poena, I am sorry about the license text. I thought I added it but looks like it didn't get saved. I have added them again in readme.txt file. I have also removed the js pro link and included the recommended folder from Justin. The theme has been tested with 4.6 as well. This is a very popular theme at Graph Paper Press. I have also fixed the tag you mentioned.

#14 @poena
14 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi
The problems have been fixed -the theme should be live shortly.

#15 @endortrails
14 months ago

Thanks a lot for your time and review. :)

Note: See TracTickets for help on using tickets.