WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 8 months ago

#31556 closed theme (live)

THEME: Progeny MMXV – 1.2.4

Reported by: audiotheme Owned by: rabmalin
Priority: previously reviewed Keywords: theme-progeny-mmxv child-theme parent-twentyfifteen
Cc: notify@…

Description

Progeny MMXV - 1.1.0

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.1.0
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.0.0.1&new_path=progeny-mmxv/1.1.0

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.1.0/screenshot.png

Change History (23)

#1 @themetracbot
10 months ago

  • Summary changed from THEME: Progeny MMXV – 1.1.0 to THEME: Progeny MMXV – 1.2.0

Progeny MMXV - 1.2.0

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.2.0
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.2.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.1.0&new_path=progeny-mmxv/1.2.0

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.2.0/screenshot.png

#2 @audiotheme
10 months ago

Last edited 10 months ago by audiotheme (previous) (diff)

#3 @themetracbot
10 months ago

  • Summary changed from THEME: Progeny MMXV – 1.2.0 to THEME: Progeny MMXV – 1.2.1

Progeny MMXV - 1.2.1

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.2.1
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.2.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.2.0&new_path=progeny-mmxv/1.2.1

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.2.1/screenshot.png

#4 @rabmalin
10 months ago

  • Keywords changed from theme-progeny-mmxv, child-theme, parent-twentyfifteen, accessibility-ready to theme-progeny-mmxv child-theme parent-twentyfifteen accessibility-ready
  • Owner set to rabmalin
  • Status changed from new to reviewing

#5 @rabmalin
10 months ago

Hello,

Thanks for uploading theme. I wil be reviewing your theme. Please fix following issues and reupload your theme.

Theme Check

  • Required: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.

The domains found are twentyfifteen, progeny-mmxv

readme.txt

Prefixing

  • REQUIRED: Please prefix custom image handle. See record-thumbnail, etc.
  • REQUIRED: progeny_audiotheme_document_head() - Use enqueue method to load script rather than hooking to wp_head.
  • REQUIRED: Invalid prefix - Cedaro_PageTypes.

License

  • REQUIRED: readme.txt - Please add full image URL of images used in the screenshot. All resources should be GPL compatible.

Important

  • Please respond within 7 days. If there is no reply for 7 days then ticket will be closed as not-approved.

#6 @rabmalin
10 months ago

@audiotheme are you planning to update theme?

#7 @audiotheme
10 months ago

@rabmalin Yeah, I plan on getting an update today as we've had a busy week in the WordPress.com theme review as well.

Cheers!

@thelukemcdonald

Last edited 10 months ago by audiotheme (previous) (diff)

#8 @themetracbot
10 months ago

  • Summary changed from THEME: Progeny MMXV – 1.2.1 to THEME: Progeny MMXV – 1.2.2

Progeny MMXV - 1.2.2

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.2.2
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.2.2.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.2.1&new_path=progeny-mmxv/1.2.2

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.2.2/screenshot.png

#9 @audiotheme
10 months ago

Thanks for the review, @rabmalin. I've updated the theme with your suggestions with the exception of a few:

  • I also get the theme check notice for multiple text domains, twentyfifteen being one of them along with the themes text domain of progeny-mmxv. I searched the theme files for the twentyfifteen text domain but didn't find it. The theme does use a few prefixed Twenty Fifteen functions which may be causing a false positive in the theme check plugin?
  • The record-thumbnail image size is used in a few of the AudioTheme templates, however, the image size isn't ever added by AudioTheme. The theme is adding this image size without the prefix so that the AudioTheme plugin can use it where defined. The same goes for the video-thumbnail image size.
  • The progeny_audiotheme_document_head() function is used to output a the only single line of JS used by the theme, which really doesn't warrant enqueing a new file and adding another page request. This function is similar to how the twentyfifteen_javascript_detection() function works. We've done similar things in past themes on .org/.com, however, I can update this to load a new file if desired.
  • The theme demo was updated with current demo content and the screenshot was updated along with it. The images used in the screenshot are still images pulled from the video using the YouTube API. I added a line of credit in the readme.txt file, but I was curious if you knew of the proper way to document and credit this for .org?

Thanks again for your time!

@thelukemcdonald

Last edited 10 months ago by audiotheme (previous) (diff)

#10 @rabmalin
10 months ago

Issues

  • REQUIRED: readme.txt - Actual copyright for 2015 theme is WordPress.org & Automattic. Please fix it. You can take this as reference for readme file. https://github.com/Automattic/_s/blob/master/readme.txt
  • REQUIRED: You are adding custom image size from here. progeny_audiotheme_setup(). Size added by theme should be prefixed. However, it is ok to implement custom image size which is added by plugin.

#11 @thelukemcdonald
10 months ago

Thanks for the heads up on the Twenty Fifteen copyright info.

I'm not sure I explained myself correctly with the image sizes.

The AudioTheme plugin has default templates. Some of those templates call the_post_thumbnail( 'record-thumbnail' ), however, the record-thumbnail image size is not registered using add_image_size() within the plugin.

The theme then can add the record-thumbnail image size so that the image used will better fit the themes layout. Anytime the_post_thumbnail( 'record-thumbnail' ) is called within the plugin's default templates, the image size defined by the theme will be used.

Additionally, the record-thumbnail image size is only added if the AudioTheme plugin is activated. That particular image size is also only used within the few AudioTheme templates that have been overridden.

That said, I don't want this to hold up the review and if needed, I'll make the change. I'd prefer to register a record-thumbnail image size for the plugin to use in its default templates for best display within the themes layout and design.

Last edited 10 months ago by thelukemcdonald (previous) (diff)

#12 @rabmalin
10 months ago

The AudioTheme plugin has default templates. Some of those templates call the_post_thumbnail( 'record-thumbnail' ), however, the record-thumbnail image size is not registered using add_image_size() within the plugin.

Exactly. Image size required for plugin should be registered in plugin, not in theme.

#13 @thelukemcdonald
10 months ago

Not exactly. Image sizes defined by the plugin are not required but only provide a suggested size. The image size argument of the_post_thumbnail() is optional, and if the size defined does not exist, the default post-thumbnail size will be used.

The plugin works fine without the record-thumbnail being defined. What the plugin does do is offers theme developers flexibility to define a proper image size for the theme. Would a theme not have a better idea of the an image size best suited for its layout? This is actually a great way to provide flexibility to themes when possible.

Regardless, I'll make the change so we can move forward.

Last edited 10 months ago by thelukemcdonald (previous) (diff)

#14 @themetracbot
10 months ago

  • Summary changed from THEME: Progeny MMXV – 1.2.2 to THEME: Progeny MMXV – 1.2.3

Progeny MMXV - 1.2.3

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.2.3
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.2.3.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.2.2&new_path=progeny-mmxv/1.2.3

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.2.3/screenshot.png

#15 @rabmalin
10 months ago

Issues

  • REQUIRED: readme.txt - You have not still kept FULL image url of those used in the screenshot. Please confirm that those are under GPL compatible license.
  • REQUIRED: I just noticed that screenshot size in not correct. Screenshot is wrong size! Detected: 1280x960px. Maximum allowed size is 1200x900px. Any 4:3 image size is acceptable, but 1200x900 is preferred.

#16 @rabmalin
10 months ago

@joedolson Pinging you for a11y review.

#17 @rabmalin
10 months ago

  • Keywords accessibility-ready removed

accessibility-ready tag seems to be removed. So, no need of a11y review.

#18 @rabmalin
9 months ago

@audiotheme Please respond within 2 days. Otherwise ticket will be closed.

#19 @themetracbot
9 months ago

  • Summary changed from THEME: Progeny MMXV – 1.2.3 to THEME: Progeny MMXV – 1.2.4

Progeny MMXV - 1.2.4

Twenty Fifteen child theme with unique grid and list page template layouts. Display page children in a unique grid or list view. With AudioTheme support included, you can nicely display display your music, videos, and gigs.

Theme URL - https://audiotheme.com/view/progeny-mmxv/
Author URL - https://audiotheme.com/

SVN - https://themes.svn.wordpress.org/progeny-mmxv/1.2.4
ZIP - https://wordpress.org/themes/download/progeny-mmxv.1.2.4.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyfifteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progeny-mmxv/1.2.3&new_path=progeny-mmxv/1.2.4

History:

Ticket Summary Status Resolution Owner
#22204 THEME: Progeny MMXV - 1.0.0.1 closed not-approved alex27
#31556 THEME: Progeny MMXV – 1.2.4 closed live rabmalin

(this ticket)

#41723 THEME: Progeny MMXV – 1.3.0 closed live themetracbot


https://themes.svn.wordpress.org/progeny-mmxv/1.2.4/screenshot.png

#20 @grapplerulrich
9 months ago

@rabmalin The update has been uploaded.

#21 @rabmalin
9 months ago

will check today. Thanks.

Last edited 9 months ago by rabmalin (previous) (diff)

#22 @rabmalin
9 months ago

  • Status changed from reviewing to approved

All issues fixed. Marking as approved.

#23 @karmatosed
8 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.