WordPress.org

Make WordPress Themes

#31897 closed theme (live)

THEME: Gambit – 1.0.6

Reported by: ThemeZee Owned by: acosmin
Priority: new theme Keywords: theme-gambit
Cc: contact@…

Description

Gambit - 1.0

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0
ZIP - https://wordpress.org/themes/download/gambit.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0/screenshot.jpg

Change History (15)

#1 @themetracbot
18 months ago

  • Summary changed from THEME: Gambit – 1.0 to THEME: Gambit – 1.0.1

Gambit - 1.0.1

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0.1
ZIP - https://wordpress.org/themes/download/gambit.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gambit/1.0&new_path=gambit/1.0.1

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0.1/screenshot.jpg

#2 @themetracbot
16 months ago

  • Summary changed from THEME: Gambit – 1.0.1 to THEME: Gambit – 1.0.2

Gambit - 1.0.2

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0.2
ZIP - https://wordpress.org/themes/download/gambit.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gambit/1.0.1&new_path=gambit/1.0.2

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0.2/screenshot.jpg

#3 @themetracbot
15 months ago

  • Summary changed from THEME: Gambit – 1.0.2 to THEME: Gambit – 1.0.4

Gambit - 1.0.4

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0.4
ZIP - https://wordpress.org/themes/download/gambit.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gambit/1.0.2&new_path=gambit/1.0.4

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0.4/screenshot.jpg

#4 @rabmalin
15 months ago

Hello,

Thanks for uploading theme. When your theme reaches to the top of this Review Queue ( https://themes.trac.wordpress.org/report/2 ), reviewer will be assigned and review process will follow procedures found in the Theme Handbook - https://make.wordpress.org/themes/handbook/review/required/ . Ticket will be closed as not-approved if theme has more than 5 distinct issues. So, please check your theme against Theme Review Guidelines to avoid closing of ticket.

Note: This is not a review.

#5 @themetracbot
15 months ago

  • Summary changed from THEME: Gambit – 1.0.4 to THEME: Gambit – 1.0.5

Gambit - 1.0.5

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0.5
ZIP - https://wordpress.org/themes/download/gambit.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gambit/1.0.4&new_path=gambit/1.0.5

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0.5/screenshot.jpg

#6 @acosmin
15 months ago

@grapplerulrich I would like to review this theme. Thank you!

#7 @grapplerulrich
15 months ago

Thanks @acosmin

#8 @grapplerulrich
15 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#9 @ThemeZee
15 months ago

@acosmin Thanks for taking the time to review my theme :) Let me know if you have any questions about the code!

#10 @acosmin
15 months ago

No problem :)

Theme check - ok

Required

  • It looks like you are injecting html (js/customizer-controls.js) in the Customizer (Theme Options). Those should be moved in a section and must use the Customizer API. Here is a nice example: https://github.com/justintadlock/trt-customizer-pro
  • You are using searchform.php and also adding support for it in functions.php, line 46. You should choose one or the other.
  • Functions.php, line 195, seeing as you only have one font family, you don't need implode()
  • inc/theme-info.php, I may be wrong but I don't think translating and escaping your url, themezee.com, is needed. In the same file, http://wordpress.org/support/view/theme-reviews/gambit?filter=5 doesn't need escaping because it's not translatable. If you translate it then it would need escaping.
  • inc/theme-info.php Gambit Review needs esc_attr__()
  • inc/template-tags.php, lines 416 and 417:
    • wordpress.org needs escaping and translation, the title attribute esc_attr__() and text needs _e(). The href needs both so that locales can link to their respective localized version of wordpress.org.
    • the title attribute and text need translation.
    • you can use something like "' . esc_attr__( "Gambit WordPress Theme", "gambit" ) . '"
  • widgets/widget-magazine-posts-columns.php, line 302, use esc_attr__ instead of esc_html__
    • value="<?php echo $settings['category_ needs escaping, esc_attr()
    • the same issues apply to widgets/widget-magazine-posts-* files.

Everything else looks ok, nicely coded. I don't see any problem in approving this theme after you fix the above issues.

#11 @ThemeZee
15 months ago

Thanks for the fast review, I will fix these issues immediately.

Translating the themezee.com URL makes sense because we have a German & English version of our website. I will add translation to the wordpress.org URL in theme-info.php as well, since there are also different language sites for wordpress.org

Nice catch with all the escaping issues. I certainly know how this should be done and test carefully but it seems I missed a few with this theme. Always good to have a second eye on your code, thank you :)

#12 @themetracbot
15 months ago

  • Summary changed from THEME: Gambit – 1.0.5 to THEME: Gambit – 1.0.6

Gambit - 1.0.6

Gambit is a complex and highly flexible WordPress theme perfectly suited for any news, magazine or blog website. It features several different layout options, two sidebars and a stunning featured post slider. The easy to use Magazine Homepage template allows you to create a powerful online magazine in just a few minutes.

Theme URL - https://themezee.com/themes/gambit/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/gambit/1.0.6
ZIP - https://wordpress.org/themes/download/gambit.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gambit/1.0.5&new_path=gambit/1.0.6

History:

Ticket Summary Status Resolution Owner
#31897 THEME: Gambit – 1.0.6 closed live acosmin

(this ticket)

#37739 THEME: Gambit – 1.0.7 closed live themetracbot
#38721 THEME: Gambit – 1.0.8 closed live themetracbot
#39953 THEME: Gambit – 1.0.9 closed live themetracbot
#41179 THEME: Gambit – 1.2 closed live themetracbot
#41237 THEME: Gambit – 1.2.1 closed live themetracbot
#41264 THEME: Gambit – 1.2.2 closed live themetracbot
#41850 THEME: Gambit – 1.2.3 closed live themetracbot
#42338 THEME: Gambit – 1.2.4 closed live themetracbot
#42871 THEME: Gambit – 1.2.5 closed live themetracbot
#44507 THEME: Gambit – 1.3 closed live themetracbot
#45417 THEME: Gambit – 1.3.1 closed live themetracbot
#47726 THEME: Gambit – 1.3.2 closed live themetracbot


https://themes.svn.wordpress.org/gambit/1.0.6/screenshot.jpg

#13 @acosmin
15 months ago

  • Status changed from reviewing to approved

Marking this as approved based on diff.

Just a little note, it's not required to use esc_*__ all over the place. You can use __() or _e() without it being a security issue.

Anyway, good luck in the next stage ;) you have a few weeks ahead of you!

#14 @ThemeZee
15 months ago

Thanks for approving the theme, I highly appreciate it.

I know that escaping all translation functions is not required on wordpress.org, only for HTML attributes.

However, Automattic requires it for themes on wordpress.com and I'd like to stay consistent between all my code. I believe Underscores escapes everything, too.

#15 @karmatosed
13 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.