WordPress.org

Make WordPress Themes

#31979 closed theme (live)

THEME: microformats – 2.0.0

Reported by: Dejan Batanjac Owned by: metallicarosetail
Priority: new theme Keywords: theme-microformats
Cc: dejan.batanjac@…

Description

Change History (11)

#1 @themetracbot
19 months ago

  • Summary changed from THEME: microformats – 1.0.0 to THEME: microformats – 1.0.1

#2 @themetracbot
16 months ago

  • Summary changed from THEME: microformats – 1.0.1 to THEME: microformats – 1.0.2

#3 @rabmalin
14 months ago

Hello,

Thanks for uploading theme. When your theme reaches to the top of the Review Queue, reviewer will be assigned and review process will follow procedures found in the Theme Handbook. Ticket will be closed as not-approved if theme has more than 5 distinct issues. So, please check your theme against Theme Review Guidelines to avoid closing of ticket.

Note: This is not a review.

#4 @metallicarosetail
13 months ago

  • Owner set to metallicarosetail
  • Status changed from new to reviewing

#5 @metallicarosetail
13 months ago

Required: Under Customize-> Site Identity -> Display Site Title and Tagline
Check box not working. Please fix it.
Required: Inside readme.txt there is a changelog. You latest version should be at top not at below the previous version. I would recommeded you to create a seperate changelog.txt file.
Similar to this:

Format E.g:- 
= 1.0.2 - Jun 28 2016 =
* Fixed tags

= 1.0.1 - Apr 7 2016 =
* Update of the screenshot

= 1.0.0 - Apr 7 2016 =
* Initial release

Required: I am not able to fine the license of screenshot and javascript file that you have used. Please specify
Required: Don't keep unwanted text which you have added with making comment on functions.php file. Check on other place also.
Required: escape required in template tag on line no 66

Like to confirm are you displaying site title only on home page/ frontpage? Is this your design? Site title is not dispalyed on inner page. Design issues is only recommended
Required: escape required on L66 , L72, 93, 95, 96 on template-tags.php

Note:
This is my initial review. After submitting a new version i will review deeply on this theme.
REQUIRED points should be resolved for theme approved.
RECOMMENDED points are optional but its a best practices. Theme will not be rejected on the base of RECOMMENDED points.
Please response within 7 days. Otherwise theme will marked as not approved.
Please follow the theme development guideline for making theme. https://make.wordpress.org/themes/handbook/review/
After solving this review, please submit your theme on https://wordpress.org/themes/upload/
If you have any confusion please ask your query on #themereview channel on WordPress slack or ping me on @metallicarosetail

Thank you
Metallica RoseTail

#6 @Dejan Batanjac
13 months ago

Hi, thanks for the review. I will try to update this thread tomorrow.

#7 @themetracbot
13 months ago

  • Summary changed from THEME: microformats – 1.0.2 to THEME: microformats – 1.1.0

#8 @metallicarosetail
13 months ago

Issues :
Required: You cannot add metabox from post/page. Remove it. It falls under plugin territory so leave it for plugins. Found at functions.php Line no 241 onwards

Required: On footer.php line no 18 translation and escape issue. Better use

esc_html_e('Dejan Batanjac','microformats')

Required: On template-tags.php line no 330 escape missing. Use esc_html_e() instead of using _e()

Required: Is it necessary?

// Adds a class of hfeed to non-singular pages.
	if ( ! is_singular() ) {
		$classes[] = 'hfeed';
	}

I could not find any css for it on your style.css. Does it have any design related so you have added it to body section with not singular?

Required: why you have added a blank custom_style.css? If no css then don't add unwanted files. I have told you before also on slack about rtl.css page. If no use then don't add on your theme.

Thank you

#9 @themetracbot
13 months ago

  • Summary changed from THEME: microformats – 1.1.0 to THEME: microformats – 2.0.0

#10 @metallicarosetail
13 months ago

  • Status changed from reviewing to approved

@Dejan Batanjac

Congratulation! Now I have marked your theme as approve and i did not see any major issues. Now admin will do a final review on your theme. Wait in an admin queue. Once they review and approve it then it goes to live.
You can check your theme on below link
https://themes.trac.wordpress.org/query?status=approved&group=priority&page=2&col=id&col=summary&col=reporter&col=owner&col=priority&col=changetime&col=keywords&report=24&order=changetime
Thank you

#11 @karmatosed
12 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.