WordPress.org

Make WordPress Themes

#32029 closed theme (not-approved)

THEME: Magnificient – 1.3.8

Reported by: krazzeniru20 Owned by: yudleethemes
Priority: previously reviewed Keywords: theme-magnificient
Cc: nirmalya.email@…

Description

Magnificient - 1.3.5

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB’s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://www.infismash.com/magnificient-wordpress-theme/
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.5
ZIP - https://wordpress.org/themes/download/magnificient.1.3.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.4&new_path=magnificient/1.3.5

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar
#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes

(this ticket)


https://themes.svn.wordpress.org/magnificient/1.3.5/screenshot.png

Change History (20)

#1 @themetracbot
21 months ago

  • Summary changed from THEME: Magnificient – 1.3.5 to THEME: Magnificient – 1.3.6

Magnificient - 1.3.6

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB’s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://www.infismash.com/magnificient-wordpress-theme/
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.6
ZIP - https://wordpress.org/themes/download/magnificient.1.3.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.5&new_path=magnificient/1.3.6

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar
#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes

(this ticket)


https://themes.svn.wordpress.org/magnificient/1.3.6/screenshot.png

#2 @rinkuyadav999
16 months ago

Hi

Your theme will be start reviewing soon. so please make sure, you theme follow latest guideline:- https://make.wordpress.org/themes/handbook/review/required/

Note: Reviewers are allow to close ticket (theme), if more than 5 unique issues found. so please review your theme yourself and fix all "require" issues.

Thanks

#3 @themetracbot
15 months ago

  • Owner set to lovinglyyours
  • Status changed from new to reviewing

#4 @grapplerulrich
15 months ago

  • Owner lovinglyyours deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#5 @themetracbot
15 months ago

  • Owner set to yudleethemes

#6 @yudleethemes
15 months ago

Please fix the issues mentioned in the theme below:

WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag fluid-layout has been deprecated, please remove it from your style.css header.
REQUIRED: You are not allowed to hide the admin bar.
RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#7 @themetracbot
15 months ago

  • Summary changed from THEME: Magnificient – 1.3.6 to THEME: Magnificient – 1.3.7

Magnificient - 1.3.7

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB’s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://www.infismash.com/magnificient-wordpress-theme/
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.7
ZIP - https://wordpress.org/themes/download/magnificient.1.3.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.6&new_path=magnificient/1.3.7

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar
#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes

(this ticket)


https://themes.svn.wordpress.org/magnificient/1.3.7/screenshot.png

#8 @yudleethemes
15 months ago

  • Status changed from reviewing to approved

Thanks for the fixes. Looks good. Approving this.

#9 @rabmalin
13 months ago

I will do final review.

#10 @rabmalin
13 months ago

Hello,

Reviewers are now allowed to close ticket if 5 or more distinct issues are found. But I am giving you a chance now since you are waiting for more than a year to submit theme. Please fix following issues and reupload your theme.

Very Important: These are only few issues found in 15 minutes review. Then I stopped reviewing. It seems lot more issues exist in the theme. Please go through guideline very very carefully and fix your theme. I will have to close theme if 5 or more distinct issues are found in the next update.

Guideline: https://make.wordpress.org/themes/handbook/review/required/

Issues

WordPress Features first

  • REQUIRED: Remove favicon feature from theme.
  • REQUIRED: Remove magnificient_logo from theme and use Custom Logo. https://make.wordpress.org/core/2016/03/10/custom-logo/
  • REQUIRED: Use the_archive_title() to display archive title.
  • REQUIRED: Remove magnificient_pagination() and use `the_posts_pagination().
  • REQUIRED: Remove post-navigation.php and use `the_post_navigation().

Plugin Territory

Plugin Territory

#11 @rabmalin
13 months ago

  • Status changed from approved to reopened

#12 @rabmalin
13 months ago

  • Cc rabmalin added

#13 @krazzeniru20
13 months ago

Thank you @rabmalin. I'll update the theme in a few days.

#14 @rabmalin
13 months ago

Please respond within 24 hours. Or ticket will be closed as not-approved.

#15 @krazzeniru20
13 months ago

@rabmalin I'll update within 24 hours. Thank you.

#16 @themetracbot
13 months ago

  • Summary changed from THEME: Magnificient – 1.3.7 to THEME: Magnificient – 1.3.8

Magnificient - 1.3.8

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB’s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL -
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.8
ZIP - https://wordpress.org/themes/download/magnificient.1.3.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.7&new_path=magnificient/1.3.8

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar
#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes

(this ticket)


https://themes.svn.wordpress.org/magnificient/1.3.8/screenshot.png

#17 @krazzeniru20
13 months ago

I've updated the theme fixing some of the issues. Can you please let me know what plugin (if any) you used to get the issues related to my theme? Thank you.

#18 @rabmalin
13 months ago

I am not sure I am getting you clearly. I directly dive into codes. Only plugin I use is Theme Check.

#19 @rabmalin
13 months ago

Previous Issues Not Fixed

  • REQUIRED: functions.php - When loading PHP files which are not template files, you should be get_template_directory().
  • Eg, require_once('library/theme-support.php'); -> require_once get_template_directory() . '/library/theme-support.php';

Issues

  • REQUIRED: add_theme_support( 'magnificient_logo' ); - Can you please explain this?
  • REQUIRED: archive.php - You are not allowed to keep BC code for more than 3 major version. Please use the_posts_pagination() only. Please check in other places also.
  • REQUIRED: Please rename page template file name. File should not be prefixed like page-full.php. You can use tpl-full.php or template-full.php or similar.
  • REQUIRED: Remove definition of the_posts_pagination(). This function is already defined in WordPress core.
  • REQUIRED: Remove <link rel="alternate" type="application/rss+xml" title="<?php bloginfo('name'); ?> Feed" href="<?php echo esc_url( home_url('/') ); ?>/feed/">
  • REQUIRED: Remove archives-page.php. Custom page template for blog listing is not allowed.
  • REQUIRED: comments.php - You should not be creating comment form like that. See https://github.com/Automattic/_s/blob/master/comments.php
  • REQUIRED: Translation issue - footer.php L44;
  • REQUIRED: In dynamic_sidebar(), use sidebar ID rather than sidebar name.
  • REQUIRED: body_class('antialiased') - It should be body_class(). If you want to customize body class, use https://developer.wordpress.org/reference/hooks/body_class/
  • REQUIRED: readme.txt - You need not keep all license text here. You should only keep license URL. See https://make.wordpress.org/themes/2015/04/29/a-revised-readme/
  • REQUIRED: searchform.php - Search query is missing in value attribute. https://developer.wordpress.org/reference/functions/get_search_query/

I only checked 10 files and found this much issues. Lots of files are remaining to be reviewed. Can you please allocate more time for checking guideline? https://make.wordpress.org/themes/handbook/review/required/ I am feeling like I should have closed ticket in the first comment.

#20 @rabmalin
13 months ago

  • Cc rabmalin removed
  • Resolution set to not-approved
  • Status changed from reopened to closed

Closing due to no response for 7 days.

Note: See TracTickets for help on using tickets.