WordPress.org

Make WordPress Themes

#32604 closed theme (live)

THEME: StoreVilla – 1.1.1

Reported by: Access Keys Owned by: DannyCooper
Priority: new theme Keywords: theme-storevilla
Cc: wp@…

Description

StoreVilla - 1.0.0

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.0
ZIP - https://wordpress.org/themes/download/storevilla.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.0/screenshot.png

Change History (39)

#1 @themetracbot
16 months ago

  • Summary changed from THEME: StoreVilla – 1.0.0 to THEME: StoreVilla – 1.0.1

StoreVilla - 1.0.1

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.1
ZIP - https://wordpress.org/themes/download/storevilla.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.0&new_path=storevilla/1.0.1

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.1/screenshot.png

#2 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.1 to THEME: StoreVilla – 1.0.3

StoreVilla - 1.0.3

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.3
ZIP - https://wordpress.org/themes/download/storevilla.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.1&new_path=storevilla/1.0.3

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.3/screenshot.png

#3 @acosmin
14 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#4 @acosmin
14 months ago

Required

  1. inc\template-tags.php
    • line 232, if you don't have WC installed and you're logged in, that link doesn't do anything.
    • line 459, you don't need esc_url() there.
    • WordPress Theme : StoreVilla looks a little spammy. You can try something like StoreVilla theme by
  1. Content creation. Move the following sections in a plugin (also, any function related to them in extras.php):
    • Payment Logo Section
    • Services Section Area
    • Brands Logo Section Area
    • Header Promo Section
    • Main Banner Section Area
  1. inc\storevilla-widget.php Move the following widgets in a plugin:
    • About us information
    • Promo Widget Section
    • Quick Contact Info
    • Testimonials
    • You also have some PHP notices when you add them in a sidebar (all these widgets display the same errors):
      Notice: Undefined index: storevilla_blogs_top_title in \wp-content\themes\storevilla\inc\storevilla-widget.php on line 1716
      
      Notice: Undefined index: storevilla_blogs_title in \wp-content\themes\storevilla\inc\storevilla-widget.php on line 1717
      
      Notice: Undefined index: blogs_category_list in \wp-content\themes\storevilla\inc\storevilla-widget.php on line 1718
      
      Notice: Undefined index: blogs_posts_display_order in \wp-content\themes\storevilla\inc\storevilla-widget.php on line 1719
      
  1. inc\extras.php
    • storevilla_retina_support_create_images() is plugin territory.
    • storevilla_delete_retina_support_images() is plugin territory.
  1. inc\class-repeater.php is plugin territory and is used to create content in the above sections. Please remove it or move it in a plugin.
  1. readme.txt
    • You need to declare licenses for all 3rd party scripts/styles/images:
      • retina.js
      • modernizr.js

---

That's about it for now.

Last edited 14 months ago by acosmin (previous) (diff)

#5 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.3 to THEME: StoreVilla – 1.0.4

StoreVilla - 1.0.4

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.4
ZIP - https://wordpress.org/themes/download/storevilla.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.3&new_path=storevilla/1.0.4

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.4/screenshot.png

#6 @acosmin
14 months ago

You haven't removed any of the things I noted in my initial review.

#7 @Access Keys
14 months ago

Thanks @acosmin for the review.

Here are my opinion regarding your feed backs.

line 232, if you don't have WC installed and you're logged in, that link doesn't do anything.

Fixed

line 459, you don't need esc_url() there.

Fixed

WordPress Theme : StoreVilla looks a little spammy. You can try something like StoreVilla theme by

I think this is not a requirement although i have fixed it.

  1. Content creation. Move the following sections in a plugin (also, any function related to them in extras.php):

Payment Logo Section

There is no any content creation in this section because the uploaded image does not get lost on changing the theme.

Services Section Area

This section can be considered as a trivial content and these sort of content are allowed as per discussion between key reviewers.

Brands Logo Section Area

This section also uses the uploaded images. So i don't find any content creation here as well.

Header Promo Section

This section also used the uploaded images. The content creation here is only the title and subtitle which i have removed in the new version. And the link is again a trivial content and it is allowed.

Main Banner Section Area

I feel this section has some content creation so i have replaced it with category posts in the latest version.

  1. inc\storevilla-widget.php Move the following widgets in a plugin:

About us information

This is also a trivial content.

Promo Widget Section

Removed this widget in the latest version with assumption that it creates of consideration amount of content.

Quick Contact Info

This is also a trivial content.

Testimonials

This section uses category post to generate the content. The title, subtitle are auxiliary content.

You also have some PHP notices when you add them in a sidebar (all these widgets display the same errors):

Fixed

  1. inc\extras.php

storevilla_retina_support_create_images() is plugin territory.
storevilla_delete_retina_support_images() is plugin territory.

Removed

  1. inc\class-repeater.php is plugin territory and is used to create content in the above sections. Please remove it or move it in a plugin.

I don't think this falls under plugin territory. It is the class that extends the customizer class and is done according to the rule.

  1. readme.txt

Added necessary license.

I am pinging some key reviewer @emiluzelac @greenshady @grapplerulrich so that they can give their valuable feed backs on the content creation matter as indicated by @acosmin . I would be happy and no problem to go with the guideline if they are really not allowed.

#8 @acosmin
14 months ago

@emiluzelac @greenshady @grapplerulrich :) the author is waiting for a 2nd opinion on this. After that I can continue with my review.

Thank you!

#9 @greenshady
14 months ago

Just did a quick scan. Let me know if I missed anything.

Footer credit

Spam/SEO-seeded alt and title attribute needs to be removed:

<a href=" https://accesspressthemes.com/ " alt="Premium WordPress Themes &amp; Plugins by AccessPress Themes" title="Premium WordPress Themes &amp; Plugins by AccessPress Themes" rel="designer" target="_blank">AccessPress Themes</a>

Content creation

Customizer:

  • Services customizer section

Widgets:

  • SV: About Us Information

Repeater control

A "repeater" isn't inherently plugin territory. It just depends on what it is that you're repeating, which is typically custom content. So, just depends on what you're repeating.

#10 @acosmin
14 months ago

@greenshady the repeater is used to upload multiple client/brands logos and order them around. Each new field has an upload image button. After that they are displayed in a section, like most stores have. Allowed?

#11 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.4 to THEME: StoreVilla – 1.0.5

StoreVilla - 1.0.5

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.5
ZIP - https://wordpress.org/themes/download/storevilla.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.4&new_path=storevilla/1.0.5

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.5/screenshot.png

#12 @Access Keys
14 months ago

Footer credit
Spam/SEO-seeded alt and title attribute needs to be removed:
<a href=" https://accesspressthemes.com/ " alt="Premium WordPress Themes &amp; Plugins by AccessPress Themes" title="Premium WordPress Themes &amp; Plugins by AccessPress Themes" rel="designer" target="_blank">AccessPress Themes</a>

Title and Alt attribute removed.

Customizer:
Services customizer section

Removed

http://i.imgur.com/3Po3rtT.png
@greenshady This section is used to display the above content as in image and can't it be considered as trivial content? Also it is non repeatable as for the widget.

Widgets:
SV: About Us Information

Removed

#13 @grapplerulrich
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.5 to THEME: StoreVilla – 1.0.4

You could use the core gallery shortcode for logos repeater field.

#14 @Access Keys
14 months ago

@grapplerulrich

The Theme Checker does not allow do_shortcode() function and to use the shortcode i need to use that function. Also Shortcode is a plugin territory as indicated by other reviewer in our past themes review.

#15 @rabmalin
14 months ago

do_shortcode() call is allowed. add_shortcode() is not allowed.

#16 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.4 to THEME: StoreVilla – 1.0.6

StoreVilla - 1.0.6

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.6
ZIP - https://wordpress.org/themes/download/storevilla.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.5&new_path=storevilla/1.0.6

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.6/screenshot.png

#17 @Access Keys
14 months ago

Repeater field replaced with WordPress Default Gallery option implemented via Customizer.

I hope every thing is fine now.

#18 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.6 to THEME: StoreVilla – 1.0.7

StoreVilla - 1.0.7

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.7
ZIP - https://wordpress.org/themes/download/storevilla.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.6&new_path=storevilla/1.0.7

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.7/screenshot.png

#19 @acosmin
14 months ago

Required

  1. In multiple files you have the_time('M, d Y'); (content.php, line 35 for example). This doesn't respect the users date format (from Settings > General). Needs a fix.
  1. extras.php
    • is_woocommerce_activated() needs a prefix.
    • Needs escaping:
      • line 220, esc_attr__()
      • line 227, $category->slug & $category->name, esc_attr(), esc_html()
      • line 237, esc_attr__()
      • storevilla_payment_logo() don't leave the alt attributes empty
      • lines 491, 492, 629, 635 escaping
      • line 581, esc_html()
  1. template-tags.php
    • line 544, change wp_reset_query() with wp_reset_postdata()
    • lines 593-594, use esc_html instead of esc_attr()
    • line 604, don't leave the alt attribute empty :) add something like logo
  1. storevilla-widget.php
    • line 53, needs esc_html__()
    • lines 103-104, use esc_html instead of esc_attr() - which is used for attributes
    • line 140, change wp_reset_query() with wp_reset_postdata() - Read the notes in Interacting with WP_Query
      • the above apply to all your widgets, please fix them
    • don't use https://placeholdit.imgix.net
    • the widget's title needs to be translatable, example 'SV: Testimonial Widget Section', line 1137. Do the same if this is present anywhere else.
      • same for 1531, 1545
    • no escaping present on lines: 1130, 1136.
    • storevilla_media_scripts() loads assets all over the admin area. Load them only where they are needed.

Try and add an active_callback for the sections that require template-home.php

Last edited 14 months ago by acosmin (previous) (diff)

#20 @grapplerulrich
14 months ago

There is no need to use do_shortcode. You can use gallery_shortcode() instead. Just pass the same attributes. https://konstantin.blog/2013/dont-do_shortcode/

#21 @themetracbot
14 months ago

  • Summary changed from THEME: StoreVilla – 1.0.7 to THEME: StoreVilla – 1.0.8

StoreVilla - 1.0.8

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.8
ZIP - https://wordpress.org/themes/download/storevilla.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.7&new_path=storevilla/1.0.8

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.8/screenshot.png

#22 @Access Keys
14 months ago

Dear @acosmin

We have fixed your feedback and submitted new version.

Thanks
Access Keys

#23 @acosmin
13 months ago

  1. extras.php
    • esc_attr( __('Search entire store here','storevilla') ) this can be done with esc_attr__()
      • line 636, esc_attr_e()
    • line 227, esc_attr( $category->name ) needs esc_html()
      • the same goes for any element that isn't an attribute. when it's between tags, <a>element</a>, it's not an attribute. so esc_html() is needed. <a><?php echo esc_html(element); ?></a>
  1. storevilla-widget.php
    • line 53, needs esc_html__() needs to be translatable. you're using just esc_html()
    • $contact_number & $contact_email need to be escaped esc_html()
  1. This doesn't need to be registered, just enqueue the file as you would normally do with a handle and use it to localize the script. wp_register_script('storevilla-media-uploader', get_template_directory_uri() . '/assets/js/storevilla-init-admin.js', array( 'jquery', 'customize-controls' ), 1.0);

Please take your time and don't rush fixes.

#24 @acosmin
13 months ago

I don't want to make theme authors wait more than they need to, so @grapplerulrich please remove me from this ticket (also #32963 & #32964). I won't be able to finish these reviews.

Thank you!

#25 @grapplerulrich
13 months ago

  • Owner acosmin deleted

Removing as reuqested.

#26 @themetracbot
13 months ago

  • Summary changed from THEME: StoreVilla – 1.0.8 to THEME: StoreVilla – 1.0.9

StoreVilla - 1.0.9

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.0.9
ZIP - https://wordpress.org/themes/download/storevilla.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.8&new_path=storevilla/1.0.9

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.0.9/screenshot.png

#27 @themetracbot
13 months ago

  • Owner set to DannyCooper

#28 @DannyCooper
13 months ago

Hi @Access Keys I will be continuing this review.

@acosmin if there is anything I need to know before I begin, please let me know.

Thanks

#29 @DannyCooper
13 months ago

template-parts/content.php:16

$image = wp_get_attachment_image_src(get_post_thumbnail_id(get_the_ID()), 'storevilla-blog-image', true);

Is there any reason to use that instead of:

$image = get_the_post_thumbnail_url(get_the_ID(), 'storevilla-blog-image');

template-home.php:12 - Wrong @package listed

sidebar-right.php file is missing opening docblock

sidebar-woocommerce.php:20 + :28 Incorrect code comment

sidebar-right.php file is missing opening docblock

template-parts/content-search.php:35

http://i.imgur.com/1cqu8n8.png

I assume the number should be floating right here.

http://i.imgur.com/RbIETzg.png

Date, author and title are indistinguishable from the content and each other here.

inc/template-tags.php:159 esc_attr is used to escape email addresses, maybe sanitize_email() would be better

inc/template-tags.php:451 use date i18n

inc/template-tags.php:577 typo in function name

inc/storevilla-widget.php It's not required. However, this file would benefit from more comments
inc/storevilla-widget.php:970 esc_attr has been used a lot in this file where esc_html or wp_kses_post may be better
inc/storevilla-widget.php:1135 esc_html has been used to escape an email address

inc/custom-header.php:49 HEADER_TEXTCOLOR is deprecated, use:

$header_text_color = get_header_textcolor();

inc/extras.php:292 Does your custom function do anything wp_trim_words() doesn't?
inc/extras.php:75 class_exists is case-insensitive, it may be worth changing to 'WooCommerce' for consistency though
inc/extras.php:403 $fieldlabel? doesn't appear to be escaped anywhere

inc/customizer.php:109 URL doesn't need to be escaped as there is no way it could be changed

Last edited 13 months ago by DannyCooper (previous) (diff)

#30 @themetracbot
13 months ago

  • Summary changed from THEME: StoreVilla – 1.0.9 to THEME: StoreVilla – 1.1.0

StoreVilla - 1.1.0

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.1.0
ZIP - https://wordpress.org/themes/download/storevilla.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.0.9&new_path=storevilla/1.1.0

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.1.0/screenshot.png

#31 @Access Keys
13 months ago

Dear @DannyCooper

We have fixed your feedback and submitted new version.

Thanks
Access Keys

#32 @DannyCooper
13 months ago

Thanks!

content.php, content-search.php and content-page.php need fixing to reflect the changes you have made to the thumbnail code.

Also I've noticed in the post meta, you are using this code:

<span class="sv-post-author"><?php _e('Post By :','storevilla'); ?>
<?php the_author_link(); ?>
</span>

I wanted to check you were aware that pulls the users website URL from their profile and not their posts url. Posts URL is done like so:

esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) );

#33 @Access Keys
13 months ago

Hi,

content.php, content-search.php and content-page.php need fixing to reflect the changes you have made to the thumbnail code.

Can you please explain this point in more detail. I did not get this point.

#34 @DannyCooper
13 months ago

On line 19 you have this code:

<img src="<?php echo esc_url( $image[0] ); ?>" alt="<?php the_title(); ?>">

$image is no longer an array so should be $image not $image[0]

#35 @Access Keys
13 months ago

yes, my mistake.. got it now. Thanks

Will upload the fixed version soon.

#36 @themetracbot
13 months ago

  • Summary changed from THEME: StoreVilla – 1.1.0 to THEME: StoreVilla – 1.1.1

StoreVilla - 1.1.1

StoreVilla is a free eCommerce theme based on WooCommerce Plugin and its extensions.The theme has all the feature that is needed to make a complete ecommerce website. The theme has 10+ custom widgets to create an attractive layout to feature your the product in an elegant way. The theme has beautiful design and is a perfect choice of fashion, digital, jewelery, cosemetics and online store. The theme is fully translation ready and is compatible with all major plugins. And never the less, the theme is very easy to configure and customize and create a online store in no time.

Theme URL - https://accesspressthemes.com/wordpress-themes/storevilla/
Author URL - https://accesspressthemes.com/

SVN - https://themes.svn.wordpress.org/storevilla/1.1.1
ZIP - https://wordpress.org/themes/download/storevilla.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storevilla/1.1.0&new_path=storevilla/1.1.1

History:

Ticket Summary Status Resolution Owner
#32604 THEME: StoreVilla – 1.1.1 closed live DannyCooper

(this ticket)

#38160 THEME: StoreVilla – 1.1.2 closed live themetracbot
#38576 THEME: StoreVilla – 1.1.3 closed live themetracbot
#41749 THEME: StoreVilla – 1.1.4 closed live themetracbot
#43364 THEME: StoreVilla – 1.1.5 closed live themetracbot
#43826 THEME: StoreVilla – 1.1.6 closed live themetracbot
#43978 THEME: StoreVilla – 1.1.7 closed live themetracbot
#44218 THEME: StoreVilla – 1.1.8 closed live themetracbot
#44706 THEME: StoreVilla – 1.1.9 closed live themetracbot
#44871 THEME: StoreVilla – 1.2.0 closed live themetracbot
#45215 THEME: StoreVilla – 1.2.1 closed live themetracbot
#47276 THEME: StoreVilla – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/storevilla/1.1.1/screenshot.png

#37 @DannyCooper
13 months ago

  • Status changed from reviewing to approved

Thanks for making the required changes. Theme approved pending admin review.

This ticket was mentioned in Slack in #themereview by wphoot. View the logs.


13 months ago

#39 @karmatosed
12 months ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

It may take a little while for your theme to show up in the directory, but it will.

Note: See TracTickets for help on using tickets.