WordPress.org

Make WordPress Themes

#32705 closed theme (not-approved)

THEME: Owner – 1.0.1

Reported by: mysterythemes Owned by: sakinshrestha
Priority: new theme Keywords: theme-owner
Cc: mysterythemes@…

Description

Owner - 1.0.0

Owner is a clean business theme which have a lots of features, clean and easy to use.

Theme URL - http://mysterythemes.com
Author URL - http://mysterythemes.com/wp-themes/owner/

SVN - https://themes.svn.wordpress.org/owner/1.0.0
ZIP - https://wordpress.org/themes/download/owner.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha

(this ticket)

#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour
#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.0/screenshot.jpg

Change History (3)

#1 @themetracbot
15 months ago

  • Summary changed from THEME: Owner – 1.0.0 to THEME: Owner – 1.0.1

Owner - 1.0.1

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - http://mysterythemes.com
Author URL - http://mysterythemes.com/wp-themes/owner/

SVN - https://themes.svn.wordpress.org/owner/1.0.1
ZIP - https://wordpress.org/themes/download/owner.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.0&new_path=owner/1.0.1

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha

(this ticket)

#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour
#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.1/screenshot.jpg

#2 @sakinshrestha
15 months ago

  • Owner set to sakinshrestha
  • Status changed from new to reviewing

#3 @sakinshrestha
15 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I am sorry but because the following errors (more then 5 errors) are present I am closing this ticket.

Required Issues

  • Function prefix issue
    • function __return_false_value is missing prefix. Check inc/customizer/additiona-panel.php
    • Further, I am not sure what this function actually does? Remove it if not of relevance
  • Escaping issue
    • Either use the_title_attribute() or escape the_title() using esc_attr() (First one recommended), if title needs to be used as attribute as sometimes html may break
      • Check /inc/widgets/owner-latest-blog-widget.php line 143
      • Check thoroughly as there are this type of issue throughout
    • Use antispambot() function to escape emails properly. Check inc/owner-hooks.php line 26
  • Author URL is not valid it shows 404 Page not found
    • Author URI is optional. If used it is required to link to an author’s personal website or project/development website.
  • There is issue in primary menu, you have registered owner_primary_menu and displayed it as primary_menu so menu is not shown properly
    • Further, default page menu has design issues as multi level menu is not properly displayed
  • Attribution for Font Awesome is missing readme file
  • Use esc_url_e() not echo_html()
    • Like in 404.php line 21
    • Also In 404.php line 21 there is spelling mistake. Make eroor to error
  • All the codes in functional php files should be inside a callback function and hooked properly check lines 81 to 104 in owner_functions.php
  • Third party scripts and styles should use their own handle rather than use a prefix, such as:
    • wp_enqueue_script( 'jquery-lightslider', get_template_directory_uri() . '/assets/js/lightslider.js', array('jquery'), '20151215', true );
      • It is recommended to use jquery- as prefix for scripts that use jquery as dependency
    • wp_enqueue_style( 'font-awesome', get_template_directory_uri().'/assets/library/font-awesome/css/font-awesome.min.css', array(), '4.5.0' );
    • check owner-functions.php line 45, 55, 62, etc
  • Remove commented code from owner-functions.php if it is not in use, line 22
  • When registering and enqueueing scripts in functions.php, you don't need to call wp_register_script() and wp_enqueue_script(). Just call wp_enqueue_script().
    wp_register_script( 'owner-media-uploader', get_template_directory_uri() . '/assets/js/media-uploader.js', array( 'jquery' ), 1.70 );
        wp_enqueue_script( 'owner-media-uploader' );
    

Should simply be:

wp_enqueue_script( 'owner-media-uploader', get_template_directory_uri() . '/assets/js/media-uploader.js', array( 'jquery' ), 1.70 );

Only register if you don't know if you're going to load it immediately.


Do not get discouraged. A closed ticket is not the end. We want you to resubmit your theme. We do ask that you spend a bit more time making sure that your theme meets all the requirements before we make it live.

If you need help with anything or want me to explain further, don’t hesitate to post here in this ticket. I’m happy to answer any questions you have. Or, feel free to post over on our Slack channel.

Note: See TracTickets for help on using tickets.