WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 5 weeks ago

#33057 closed theme (live)

THEME: Basic Shop – 1.04

Reported by: iografica Owned by: emy1982
Priority: new theme Keywords: theme-basic-shop
Cc: info@…, jcastenada

Description

Basic Shop - 1.00

Basic Shop is a simple, beautiful and fully customizable responsive WordPress theme.

Theme URL - http://www.iograficathemes.com/downloads/basic-shop/
Author URL - http://iograficathemes.com/

SVN - https://themes.svn.wordpress.org/basic-shop/1.00
ZIP - https://wordpress.org/themes/download/basic-shop.1.00.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33057 THEME: Basic Shop – 1.04 closed live emy1982

(this ticket)

#38944 THEME: Basic Shop – 1.05 closed live themetracbot
#39060 THEME: Basic Shop – 1.06 closed live themetracbot


https://themes.svn.wordpress.org/basic-shop/1.00/screenshot.png

Change History (35)

#1 @rabmalin
3 months ago

Your theme does not seem to be updated since 5 months. Please update and check your theme with latest WordPress. Keep in mind that if 5 or more issues found in the theme, then ticket will be closed. So please check your theme thoroughly.

#2 @iografica
3 months ago

Hi we will update the theme as soon as possible, we haven't updated the theme before for no lose the position in the queue.

#3 @rabmalin
3 months ago

You wont lose position. Please update your theme.

#4 @themetracbot
3 months ago

  • Owner set to shorms
  • Status changed from new to reviewing

#5 @themetracbot
3 months ago

  • Summary changed from THEME: Basic Shop – 1.00 to THEME: Basic Shop – 1.02

#6 @shorms
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

In file

 inc/admin/welcome/welcome-screen.php

It is recommended to use

get_template_part()

instead of

require_once()

on lines 73, 74, 75, 87, 93, 99

#7 follow-up: @iografica
3 months ago

Hi shorms,
first of all why have you closed the ticket? Give me the time to respond or fix the problem.
Second thing what are you telling is only a notice displayed with the theme check plugin and not an error! In the admin tab i can't use get_templatea_part() because it not work.
I will ask to an admin to reopen the thicket and please make more attention in your review, there is a work behind on making a theme!
@grapplerulrich (or another admin) can you help?

This ticket was mentioned in Slack in #themereview by iografica. View the logs.


3 months ago

#9 @greenshady
3 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#10 @greenshady
3 months ago

  • Status changed from reopened to reviewing

@shorms - Please do a full review of the theme before closing.

You can only close based on 5 or more distinct errors. What you have posted above is not an error.

#11 in reply to: ↑ 7 @shorms
3 months ago

@iografica @greenshady

Apologies and understood on the number of errors necessary before closing. I'm new to core reviewing so need to brush up on procedures.

Replying to iografica:

Hi shorms,
first of all why have you closed the ticket? Give me the time to respond or fix the problem.
Second thing what are you telling is only a notice displayed with the theme check plugin and not an error! In the admin tab i can't use get_templatea_part() because it not work.
I will ask to an admin to reopen the thicket and please make more attention in your review, there is a work behind on making a theme!
@grapplerulrich (or another admin) can you help?

#12 @iografica
3 months ago

@shorms, don't worry, take the right time to make your review, i only ask you to explain better if there are problems before to close the ticket, we have waited 5 months for this review!

#13 @iografica
3 months ago

Hi @shorms, i want only to know if you are making the review or not. If you have problems we can talk on Slack.

This ticket was mentioned in Slack in #themereview by iografica. View the logs.


3 months ago

#15 @Otto42
3 months ago

  • Owner shorms deleted

Putting back in queue due to lack of response from @shorms.

#16 @emy1982
3 months ago

Hi @Otto42 , i'm available for the review if is possible.

#17 @Otto42
3 months ago

  • Owner set to emy1982

@emy1982 Ok, it's all yours.

#18 @emy1982
3 months ago

  • Status changed from reviewing to approved

Hi @iografica,
i have not found issues with the theme, it can be approved.
Thank you

#19 @poena
7 weeks ago

  • Status changed from approved to reopened

#20 @poena
7 weeks ago

Hi!
I have completed the second review of the theme.

The theme cannot be used to advertise your other themes or unrelated plugins, nor third party sites: with or without affiliate codes.
-You can recommend the plugins that the theme is specifically designed to use, but remove the affiliate links.
(Note: Some of the links on the welcome page are also incorrect.)

If you have a similar set up in other themes in the WordPress.org directory, it needs to be removed from those themes as well.

You are allowed some upsell links in the customizer but the amount of links here is borderline spam.
The Advanced section has no settings available to the user, only premium links, and this falls under
"No options or panels/sections behind a paywall."
In the typography section you have no font settings, only premium links and color settings.
https://make.wordpress.org/themes/2016/05/03/may-3rd-meeting-notes/

You can't have your own urls as defaults for the social links (customizer-options.php lines 585 and forward).

-The custom css should be removed since 4.7 will have it's own custom css section in the customizer.
Remove any and all code, files or folders that are not used.
I don't believe igthemes_sanitize_css in customizer-sanitization.php is used in this version of the theme?

All untrusted data should be escaped before output, even color options.
See add_customizer_css() in customizer-settings.php, and igthemes_add_daynamic_css.
Here, the dynamic-style handle should also be prefixed.

The theme has the featured-image-header style tag, but I can't find a setting for this feature?

I am unable to find a copyright statement for the theme itself.
See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/


Please reply within 7 days, or the ticket may be closed as not approved.

Last edited 7 weeks ago by poena (previous) (diff)

#21 follow-up: @iografica
7 weeks ago

Hi @poena,
thank you for the deep review.

You can recommend the plugins that the theme is specifically designed to use, but remove ...

  • I'll do

You are allowed some upsell links in the customizer but the amount of links here is borderline spam.

  • I can remove links but I think is better to leave the pro "tag" so the users can see what the premium version will brings.

You can't have your own urls as defaults for the social links

  • I did not know, take them off

I don't believe igthemes_sanitize_css in customizer-sanitization.php is used in this version of the theme?

  • It is used in the premium version, I can use is_plugin_active() function? So it will be used only if the premium plugin is installed

All untrusted data should be escaped before output, even..

  • ok

The 'custom-header' function is written in the customizer.php but I think I forget to write the code to display it in the header, I'll fix it

I am unable to find a copyright statement for the theme itself

  • I wrote in the readme:
    * This theme, like WordPress, is licensed under the GPL 2.0.
    * This theme was built using _s.(http://underscores.me) that is licensed under GPL license.
    * normalize.css http://necolas.github.io/normalize.css/, (C) 2012-2015 Nicolas Gallagher and Jonathan Neal, [MIT](http://opensource.org/licenses/MIT)
    * HTML5 Shiv, copyright 2014 Alexander Farkas licensed under the MIT/GPL2 License, source: https://github.com/aFarkas/html5shiv/
    * Respond.js, copyright 2014 Scott Jehl licensed under the MIT license, source: http://j.mp/respondjs
    * Screenshot images are licensed under Creative Commons Deed CC0.
    

I only must add the theme Copyright, like Copyright 2016 Iografica Themes?

Please give me some days to do all the fixes, I think I will upload the theme new version in the next week.
Thank you

#22 in reply to: ↑ 21 @poena
6 weeks ago

Replying to iografica:

I don't believe igthemes_sanitize_css in customizer-sanitization.php is used in this version of the theme?

  • It is used in the premium version, I can use is_plugin_active() function? So it will be used only if the premium plugin is installed

I only must add the theme Copyright, like Copyright 2016 Iografica Themes?

Please give me some days to do all the fixes, I think I will upload the theme new version in the next week.
Thank you

Yes that is fine :)

#23 @iografica
6 weeks ago

Hi @poena,
can you explain me better this point:
"All untrusted data should be escaped before output, even color options.
See add_customizer_css() in customizer-settings.php, and igthemes_add_daynamic_css.
Here, the dynamic-style handle should also be prefixed."
Can you show me an example?
Thanks

#24 @themetracbot
6 weeks ago

  • Summary changed from THEME: Basic Shop – 1.02 to THEME: Basic Shop – 1.03

Basic Shop - 1.03

A basic and solid WordPress ecommerce theme

Theme URL - http://www.iograficathemes.com/downloads/basic-shop/
Author URL - http://www.iograficathemes.com

SVN - https://themes.svn.wordpress.org/basic-shop/1.03
ZIP - https://wordpress.org/themes/download/basic-shop.1.03.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=basic-shop/1.02&new_path=basic-shop/1.03

History:

Ticket Summary Status Resolution Owner
#33057 THEME: Basic Shop – 1.04 closed live emy1982

(this ticket)

#38944 THEME: Basic Shop – 1.05 closed live themetracbot
#39060 THEME: Basic Shop – 1.06 closed live themetracbot


https://themes.svn.wordpress.org/basic-shop/1.03/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#25 @iografica
6 weeks ago

Ok, I think I have solved all the problems.
Thank you

#26 @poena
6 weeks ago

Hi!
Yes the updates look good.

I have two concerns though and I'm sorry for not seeing this earlier,
the first is the customizer reset -@jcastenada do you mind checking?
I think the placement and the way the button is added can cause problems since it is not added with the customizer api.
-It is similar to how the upsell buttons used to be added, please see this trac ticket for background: https://core.trac.wordpress.org/ticket/37335

Secondly the new system information page, while I can agree that it can be helpful to users in some cases,
themes are for presentation, not functionality, and it should not be part of the theme. It is also not translation ready.

#27 @poena
6 weeks ago

  • Cc jcastenada added

#28 @iografica
5 weeks ago

Ok,
system info is to provide for better support, it is plugin territory?
For the button tell me what I must do :-(

#29 @poena
5 weeks ago

Yes it is plugin territory
Non-design related functionality is not allowed
https://make.wordpress.org/themes/handbook/review/required/#presentation-vs-functionality

We need help from @jcastenada when he has the time, the current code for the actual reset is too advanced for me.

#30 @themetracbot
5 weeks ago

  • Summary changed from THEME: Basic Shop – 1.03 to THEME: Basic Shop – 1.04

Basic Shop - 1.04

A basic and solid WordPress ecommerce theme

Theme URL - http://www.iograficathemes.com/downloads/basic-shop/
Author URL - http://www.iograficathemes.com

SVN - https://themes.svn.wordpress.org/basic-shop/1.04
ZIP - https://wordpress.org/themes/download/basic-shop.1.04.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=basic-shop/1.03&new_path=basic-shop/1.04

History:

Ticket Summary Status Resolution Owner
#33057 THEME: Basic Shop – 1.04 closed live emy1982

(this ticket)

#38944 THEME: Basic Shop – 1.05 closed live themetracbot
#39060 THEME: Basic Shop – 1.06 closed live themetracbot


https://themes.svn.wordpress.org/basic-shop/1.04/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#31 @iografica
5 weeks ago

Thank you @poena,
I've removed the system info tab and also the reset button.
It is all ok now?

#32 @poena
5 weeks ago

The beaver builder affiliate link still needs to be removed, I thought this was done in the first update.

#33 @iografica
5 weeks ago

Yes I will remove the link in the next update, you can approve the theme now?
Thank you

#34 @poena
5 weeks ago

  • Status changed from reopened to reviewing

#35 @poena
5 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.