WordPress.org

Make WordPress Themes

Opened 19 months ago

Closed 8 months ago

#33102 closed theme (live)

THEME: Hayley – 1.0.4

Reported by: devrix Owned by: bplv
Priority: new theme Keywords: theme-hayley
Cc: mpeshev@…

Change History (28)

#1 follow-up: @rabmalin
14 months ago

Your theme does not seem to be updated since 5 months. Please update and check your theme with latest WordPress. Keep in mind that if 5 or more issues found in the theme, then ticket will be closed. So please revisit Theme Review Guideline and check your theme thoroughly.

#2 in reply to: ↑ 1 @metodiew
14 months ago

hey @rabmalin,

Thanks for your comment! It has been a while, so we are going to test the theme once again and we'll submit a new version soon from the @devrix account :)

#3 @themetracbot
14 months ago

  • Owner set to annelieke
  • Status changed from new to reviewing

#4 follow-up: @rabmalin
13 months ago

@devrix @metodiew Do you still want this theme to be reviewed? It seems there is no sign of communication since 6 weeks.

#5 in reply to: ↑ 4 @metodiew
13 months ago

Replying to rabmalin:

@devrix @metodiew Do you still want this theme to be reviewed? It seems there is no sign of communication since 6 weeks.

Yes, we've been busy with the ongoing projects, but next week, we'll upload an updated version, so we can move forward with the review :)

#6 @themetracbot
12 months ago

  • Summary changed from THEME: Hayley – 1.0.0 to THEME: Hayley – 1.0.1

Hayley - 1.0.1

Hayley theme is based on _s starter theme. It’s a really nice and beautiful two-columns theme that’s suitable for bloggers and content writers. Hayley features custom header and background, custom menus, social icons and featured images. The theme is elegant, two-column and super simple to set up theme.

Theme URL - http://devrix.com/themes/hayley/
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/hayley/1.0.1
ZIP - https://wordpress.org/themes/download/hayley.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hayley/1.0.0&new_path=hayley/1.0.1

History:


https://themes.svn.wordpress.org/hayley/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @metodiew
12 months ago

Hey @rabmalin and @annelieke, I've submitted the updated version from our company's profile.

I'll follow the ticket updates closely, so let us know if there is anything else that has to be updated.

Cheers :)

#8 follow-up: @rabmalin
12 months ago

@annelieke Please continue review.

#9 in reply to: ↑ 8 @annelieke
12 months ago

Replying to rabmalin:

@annelieke Please continue review.

Hi,
I assigned myself to this ticket during WordCamp Milan. I thought I could do a theme review but it's much more technical than I expected. I'd have to learn a whole lot before I can do a proper theme review. So I'm sorry but I'm not going to be able to do this review.

How can I unassign myself from this ticket?

This ticket was mentioned in Slack in #themereview by metodiew. View the logs.


12 months ago

#11 @poena
12 months ago

  • Owner changed from annelieke to Dannycooper

#12 @grapplerulrich
12 months ago

  • Owner Dannycooper deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#13 @djrmom
12 months ago

  • Owner set to bplv

#14 @bplv
12 months ago

Hello,

I will be continuing the review here on and will be posting my review findings in a couple of days.

regards.

#15 @bplv
12 months ago

Hello,

I have reviewed your theme and found some issues that needs to be fixed before the theme is set LIVE.
Below are the list of the issues.

You will have seven days to fix the issue and upload an updated version. If you do need more time you can always ask by commenting on the ticket.

Lisence

  • Font awesome has two lisence, one for the font(SIL) and one for the css(MIT). You need to adress both of them on your resource declaration.
  • You have not properly declared the copyright. As a minimum, either in style.css or in the readme.txt file you need to have :

theme name WordPress Theme, Copyright (C) 2015, theme author
theme name is distributed under the terms of the GNU GPL

Overall your resource declaration you really have not supplied enough information.

  • Below is an example of a resource declaration specifying resource name, resource download link, copyright declaration, license type, license link:

jQuery Nivo Slider v3.2, http://nivo.dev7studios.com
Copyright 2012, Dev7studios, MIT License, http://www.opensource.org/licenses/mit-license.php

Licensing References

Stylesheets and Scripts

  • Please provide the un-minified version of the font-awesome.min.css and headroom.min.js file. ( You do not need to enqueue the unminified version you can just bundle it with the theme or if WP is in SCRIPT_DEBUG mode you can load the non-minified file. Your choice! )
  • You can remove the development files like grunt and sass files (recommended).
  • Google fonts are not enqueued properly rather than using "@import".

ref: https://premium.wpmudev.org/blog/custom-google-fonts/
ref: https://webdesignfromscratch.com/wordpress/using-google-web-fonts-with-wordpress-the-right-way/

  • You can remove the css and js files that are empty or not being used.

Code

  • Escaping missing on
    • functions.php line number 281, 311 (escape category and tag -> url and title)
    • header.php line number 21 ( escape header image url)
  • You do not need to prefix enqueue handlers of third-party assets like fontawesome. ref: functions.php 235

Style.css

  • IF the theme supports rtl please provide proper tag for it on the style.css, if you like also mention it on the readme.txt

#16 @themetracbot
11 months ago

  • Summary changed from THEME: Hayley – 1.0.1 to THEME: Hayley – 1.0.2

Hayley - 1.0.2

Hayley theme is based on _s starter theme. It’s a really nice and beautiful two-columns theme that’s suitable for bloggers and content writers. Hayley features custom header and background, custom menus, social icons and featured images. The theme is elegant, two-column and super simple to set up theme.

Theme URL - http://devrix.com/themes/hayley/
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/hayley/1.0.2
ZIP - https://wordpress.org/themes/download/hayley.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hayley/1.0.1&new_path=hayley/1.0.2

History:


https://themes.svn.wordpress.org/hayley/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#17 @metodiew
11 months ago

hey @bplv, I've just submitted the updated version of the theme from the DevriX account (as you can see) and we've fixed/updated all things from the list above.

The only thing I don't agree with is "You can remove the development files like grunt and sass files (recommended)." and usually we are leaving these files for people who want to adjust the theme if they like. I don't think that's a blocker though, since this is only a recommendation, but let me know if that's not the case.

I believe the theme is ready, but let me know if there is anything else that has to be adjusted.

Regards

#18 @bplv
11 months ago

Hello, @devrix @metodiew

Everything looks fine except just one thing, while escaping links and URL you should use esc_url() not esc_attr(). ref: functions.php line 290.

To know more about validation please refer https://codex.wordpress.org/Data_Validation

We are all good after that.
About the development files, yes it is just a recommendation :)

Regards.


#19 @themetracbot
11 months ago

  • Summary changed from THEME: Hayley – 1.0.2 to THEME: Hayley – 1.0.3

Hayley - 1.0.3

Hayley theme is based on _s starter theme. It’s a really nice and beautiful two-columns theme that’s suitable for bloggers and content writers. Hayley features custom header and background, custom menus, social icons and featured images. The theme is elegant, two-column and super simple to set up theme.

Theme URL - http://devrix.com/themes/hayley/
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/hayley/1.0.3
ZIP - https://wordpress.org/themes/download/hayley.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hayley/1.0.2&new_path=hayley/1.0.3

History:


https://themes.svn.wordpress.org/hayley/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#20 @themetracbot
11 months ago

  • Summary changed from THEME: Hayley – 1.0.3 to THEME: Hayley – 1.0.4

Hayley - 1.0.4

Hayley theme is based on _s starter theme. It’s a really nice and beautiful two-columns theme that’s suitable for bloggers and content writers. Hayley features custom header and background, custom menus, social icons and featured images. The theme is elegant, two-column and super simple to set up theme.

Theme URL - http://devrix.com/themes/hayley/
Author URL - http://devrix.com

SVN - https://themes.svn.wordpress.org/hayley/1.0.4
ZIP - https://wordpress.org/themes/download/hayley.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hayley/1.0.3&new_path=hayley/1.0.4

History:


https://themes.svn.wordpress.org/hayley/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#21 @metodiew
11 months ago

Sorry, I accidently uploaded Version 1.0.3 with .cache-location directory.
Version 1.0.4 has the fixes from your last comment :)

#22 @metodiew
11 months ago

hey @bplv, just checking if there is anything else left or the theme is ready for submission? :)

#23 @bplv
11 months ago

  • Status changed from reviewing to approved

Hello @metodiew @devrix,

Yes everything is fine. I'll approve the theme.

Next an admin reviewer will review your theme before it is set live.

Regards and good luck.

#24 @metodiew
10 months ago

Hey guys, it has been 6 weeks since the theme was approved and the ticket is still waiting. Any ideas when we can have the final admin review and pushing the theme live?

If we wait a few more weeks, most likely some of the requirements will be changed and we'll have to go over this process once again (see the first comment in the ticket).

#25 @rabmalin
10 months ago

This is the admin queue https://themes.trac.wordpress.org/report/24 Currently, time for admin queue is around 2 months.
Since you commented in the ticket, now ticket has been pushed to the bottom. So, avoid commenting here or mentioning ticket in Slack. Admin will check ticket and review accordingly as this has been pushed due to comment addition. Please be patient.

#26 @djrmom
8 months ago

Hi @devrix, @metodiew,

None of these are major blockers to going live but your google fonts are not being en-queued and I thought you might want to fix that and your screenshot before your theme is live. It is up to you, I know you have been waiting a long time, I will make it live and you can fix after if you prefer, just let me know. Thanks.

  • Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • prefix google_fonts function and the handle in wp_register_style( 'google_fonts', this never seems to be enqueued either

Other Fixes:

Notes:

  • You might want to remove development files - sass, grunt, etc and make them available instead via a git link instead

#27 @metodiew
8 months ago

Hey @djrmom thanks for the update! We'd like to see the theme live if these issues are not blockers and we can update/fix them with the next version.

Thanks! :)

#28 @djrmom
8 months ago

  • Resolution set to live
  • Status changed from approved to closed

No problem, please do fix the google_fonts prefix asap as this could cause an error if a plugin did the same function name.

Thanks

Note: See TracTickets for help on using tickets.