WordPress.org

Make WordPress Themes

Opened 19 months ago

Closed 13 months ago

Last modified 13 months ago

#33498 closed theme (live)

THEME: Ultra Framework – 1.0.3

Reported by: epress24 Owned by: rinkuyadav999
Priority: new theme Keywords: theme-ultra-framework
Cc: kontakt@…

Description

Ultra Framework - 1.0

This is united frameworks WordPress starter theme for speed up theme development. Ultra Framework put together power of two great “U”: Underscores (_s) by Automattic and UIKit by YOOtheme.This theme is framework, base, starting point and has to help developers develop, so don’t use it as parent theme, instead try turning Ultra into your next amazing theme. If you aren’t developer don’t worry – Ultra with basic styling is also ready to go out of box. If you like it, just go for it! Enjoy!

Theme URL - http://ultra.e-press24.com/
Author URL - http://e-press24.com/

SVN - https://themes.svn.wordpress.org/ultra-framework/1.0
ZIP - https://wordpress.org/themes/download/ultra-framework.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33498 THEME: Ultra Framework – 1.0.3 closed live rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/ultra-framework/1.0/screenshot.png

Change History (13)

#1 @karmatosed
19 months ago

This is just a note, the screenshot should be as close to what happens when you default load the theme. A mocked up image or single image will prevent the theme from being passed for review. Please resolve this before the review can be completed.

#2 @themetracbot
19 months ago

  • Summary changed from THEME: Ultra Framework – 1.0 to THEME: Ultra Framework – 1.0.1

Ultra Framework - 1.0.1

This is united frameworks WordPress starter theme for speed up theme development. Ultra Framework put together power of two great “U”: Underscores (_s) by Automattic and UIKit by YOOtheme.This theme is framework, base, starting point and has to help developers develop, so don’t use it as parent theme, instead try turning Ultra into your next amazing theme. If you aren’t developer don’t worry – Ultra with basic styling is also ready to go out of box. If you like it, just go for it! Enjoy!

Theme URL - http://ultra.e-press24.com/
Author URL - http://e-press24.com/

SVN - https://themes.svn.wordpress.org/ultra-framework/1.0.1
ZIP - https://wordpress.org/themes/download/ultra-framework.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=ultra-framework/1.0&new_path=ultra-framework/1.0.1

History:

Ticket Summary Status Resolution Owner
#33498 THEME: Ultra Framework – 1.0.3 closed live rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/ultra-framework/1.0.1/screenshot.png

#3 @rinkuyadav999
14 months ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

#4 follow-up: @rinkuyadav999
14 months ago

Hi @epress24

I have reviewed your theme and found some issues:

Minify

Please also provide unminify version of js and css files.

Prefix

Do not prefix script and style handler for third party plugin. This wp_enqueue_style( 'ultra-framework-uikit', should be wp_enqueue_style( 'uikit', it avoid loading same file two times.

Code

Please remove code instead making them comment in custom-header.php and other files.

inline CSS

Please use "wp add inline style" to add inline css code. custom-header.php L47-L66

Function check

i found "ultra-framework_entry_footer" template-tags.php L35. i think, it should "ultra_framework_entry_footer" ?

Thanks

#5 in reply to: ↑ 4 @epress24
14 months ago

Replying to rinkuyadav999:

Hi @epress24

I have reviewed your theme and found some issues:

Minify

Please also provide unminify version of js and css files.

Prefix

Do not prefix script and style handler for third party plugin. This wp_enqueue_style( 'ultra-framework-uikit', should be wp_enqueue_style( 'uikit', it avoid loading same file two times.

Code

Please remove code instead making them comment in custom-header.php and other files.

inline CSS

Please use "wp add inline style" to add inline css code. custom-header.php L47-L66

Function check

i found "ultra-framework_entry_footer" template-tags.php L35. i think, it should "ultra_framework_entry_footer" ?

Thanks

Hello,
First of all: thank you for your time and reviewing! I just have few doubts with some of your notices.

  1. Unminify version of js and css files.

Well, are you sure? Unminify is not problem of course, but these files are CSS framework core, so user shouldn't change them directly. Power of UIKit is lightweight. That's why they are minify. If user would like make safe changes in CSS, should use style.css file for overwrite CSS framework files instead. In other case after UIKit upgrade, user changes will be lost. I'm curious of your opinion.

  1. Custom header file.

Ultra Framework theme has help to speed up theme development. That's why in custom-header.php is example code of implementation this feature. When I'll remove this comment code this file won't makes sense. So, but if I gonna go wrong way, I think better solution in this case is remove custom header feature completely. Custom header isn't mandatory, it's option. In case of other your notices, you're absolutely right, I'll fix these issues soon. Thank you once again.
Regards,
Artur
@e-press24

#6 follow-up: @rinkuyadav999
14 months ago

Hi @epress24

No minification of scripts or files unless provide original files. https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Also please remove unused code and all above issues i written.

Thanks

#7 @themetracbot
14 months ago

  • Summary changed from THEME: Ultra Framework – 1.0.1 to THEME: Ultra Framework – 1.0.2

Ultra Framework - 1.0.2

This is united frameworks WordPress starter theme for speed up theme development. Ultra Framework put together power of two great “U”: Underscores (_s) by Automattic and UIKit by YOOtheme.This theme is framework, base, starting point and has to help developers develop, so don’t use it as parent theme, instead try turning Ultra into your next amazing theme. If you aren’t developer don’t worry – Ultra with basic styling is also ready to go out of box. If you like it, just go for it! Enjoy!

Theme URL - http://ultra.e-press24.com/
Author URL - http://e-press24.com/

SVN - https://themes.svn.wordpress.org/ultra-framework/1.0.2
ZIP - https://wordpress.org/themes/download/ultra-framework.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=ultra-framework/1.0.1&new_path=ultra-framework/1.0.2

History:

Ticket Summary Status Resolution Owner
#33498 THEME: Ultra Framework – 1.0.3 closed live rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/ultra-framework/1.0.2/screenshot.png

#8 in reply to: ↑ 6 @epress24
14 months ago

Replying to rinkuyadav999:

Hi @epress24

No minification of scripts or files unless provide original files. https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Also please remove unused code and all above issues i written.

Thanks

Hi,
I've updated Ultra Framework theme version to 1.0.2.:

  • Tweaked: unminified all JS and CSS files for better readability
  • Fixed: removed prefix script and style handler for third party plugin to avoid loading same file two times
  • Fixed: removed custom header feature in example files with unused code
  • Fixed: names of functions in template-tags.php file are correct now

also:

  • Updated: UIKit version to 2.27.2
  • Updated: compatibility with WordPress 4.6.1

Thanks,
Artur
@epress24

#9 follow-up: @rinkuyadav999
13 months ago

Hi

Theme URI is optional but if used, it must a theme information page instead installed theme with test unit data.

Thanks

#10 @themetracbot
13 months ago

  • Summary changed from THEME: Ultra Framework – 1.0.2 to THEME: Ultra Framework – 1.0.3

Ultra Framework - 1.0.3

This is united frameworks WordPress starter theme for speed up theme development. Ultra Framework put together power of two great “U”: Underscores (_s) by Automattic and UIKit by YOOtheme.This theme is framework, base, starting point and has to help developers develop, so don’t use it as parent theme, instead try turning Ultra into your next amazing theme. If you aren’t developer don’t worry – Ultra with basic styling is also ready to go out of box. If you like it, just go for it! Enjoy!

Theme URL -
Author URL - http://e-press24.com/

SVN - https://themes.svn.wordpress.org/ultra-framework/1.0.3
ZIP - https://wordpress.org/themes/download/ultra-framework.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=ultra-framework/1.0.2&new_path=ultra-framework/1.0.3

History:

Ticket Summary Status Resolution Owner
#33498 THEME: Ultra Framework – 1.0.3 closed live rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/ultra-framework/1.0.3/screenshot.png

#11 in reply to: ↑ 9 @epress24
13 months ago

Replying to rinkuyadav999:

Hi

Theme URI is optional but if used, it must a theme information page instead installed theme with test unit data.

Thanks

Hi,
I've updated Ultra Framework to version 1.0.3. I decided remove optional theme URI. Author URI is enough for now.
Regards,
Artur
@epress24

#12 follow-up: @rinkuyadav999
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @epress24

Looks good, setting live.

Thanks

#13 in reply to: ↑ 12 @epress24
13 months ago

Replying to rinkuyadav999:

Hi @epress24

Looks good, setting live.

Thanks

Hi,
Thank you very much for your time, attention and good reviewing!
All the best
@epress24

Note: See TracTickets for help on using tickets.