WordPress.org

Make WordPress Themes

Opened 17 months ago

Closed 11 months ago

Last modified 10 months ago

#33597 closed theme (live)

THEME: Antonine – 9

Reported by: pgogy Owned by: poena
Priority: new theme Keywords: theme-antonine
Cc: info@…, greenshady

Description

Antonine - 1.0

Our 2015 default theme is clean, blog-focused, and designed for clarity. Twenty Fifteen’s simple, straightforward typography is readable on a wide variety of screen sizes, and suitable for multiple languages. We designed it using a mobile-first approach, meaning your content takes center-stage, regardless of whether your visitors arrive by smartphone, tablet, laptop, or desktop computer.

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.0
ZIP - https://wordpress.org/themes/download/antonine.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/antonine/1.0/screenshot.png

Attachments (3)

WordPressTheme-Antonine-master.zip (783.7 KB) - added by pgogy 17 months ago.
New zip with changes
WordPressTheme-Antonine-master (2).zip (784.9 KB) - added by pgogy 16 months ago.
New theme zip
scroll.png (53.8 KB) - added by poena 11 months ago.

Download all attachments as: .zip

Change History (55)

#1 @pgogy
17 months ago

hey
Sorry I forgot to update the theme description and screenshot from default
Have made these changes on the github repo - https://github.com/pgogy/WordPressTheme-Antonine
Thanks
Pat

#2 @karmatosed
17 months ago

@pgogy reviewers will not take into account your GitHub repo, please reupload through the upload form.

@pgogy
17 months ago

New zip with changes

#3 @pgogy
17 months ago

@karmatosed sorry changes are only the screenshot and distinction and it felt a bit much to add the file again

#4 @karmatosed
17 months ago

We also can't accept zips. Please reupload via the theme upload form, just like you did originally.

#5 @pgogy
17 months ago

@karmatosed so close this ticket and start a new one?

#6 @karmatosed
17 months ago

No, just reupload and it will add to this.

#7 @themetracbot
17 months ago

  • Summary changed from THEME: Antonine – 1.0 to THEME: Antonine – 1.01

Antonine - 1.01

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.01
ZIP - https://wordpress.org/themes/download/antonine.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.0&new_path=antonine/1.01

History:


https://themes.svn.wordpress.org/antonine/1.01/screenshot.png

@pgogy
16 months ago

New theme zip

#8 @pgogy
16 months ago

Hello
Appreciate I've uploaded here - but the theme uploader is turned off and I've made some changes (multisite ajax issues and one fatal error)
thanks
Pat

#9 @themetracbot
14 months ago

  • Summary changed from THEME: Antonine – 1.01 to THEME: Antonine – 1.02

Antonine - 1.02

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.02
ZIP - https://wordpress.org/themes/download/antonine.1.02.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.01&new_path=antonine/1.02

History:


https://themes.svn.wordpress.org/antonine/1.02/screenshot.png

#10 @themetracbot
14 months ago

  • Summary changed from THEME: Antonine – 1.02 to THEME: Antonine – 1.04

Antonine - 1.04

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL - https://pgogywebstuff.com/antonine
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.04
ZIP - https://wordpress.org/themes/download/antonine.1.04.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.02&new_path=antonine/1.04

History:


https://themes.svn.wordpress.org/antonine/1.04/screenshot.png

#11 @themetracbot
14 months ago

  • Summary changed from THEME: Antonine – 1.04 to THEME: Antonine – 1.05

Antonine - 1.05

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL - https://pgogywebstuff.com/antonine
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.05
ZIP - https://wordpress.org/themes/download/antonine.1.05.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.04&new_path=antonine/1.05

History:


https://themes.svn.wordpress.org/antonine/1.05/screenshot.png

#12 @themetracbot
13 months ago

  • Summary changed from THEME: Antonine – 1.05 to THEME: Antonine – 1.06

Antonine - 1.06

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL - https://pgogywebstuff.com/antonine
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.06
ZIP - https://wordpress.org/themes/download/antonine.1.06.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.05&new_path=antonine/1.06

History:


https://themes.svn.wordpress.org/antonine/1.06/screenshot.png

#13 follow-up: @poena
11 months ago

  • Owner set to poena
  • Status changed from new to reviewing

Hi
Is poop really the word you want in your screenhot? :)

I will post the review as soon as it is complete. :)

#14 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 1.06 to THEME: Antonine – 1.07

Antonine - 1.07

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL - https://pgogywebstuff.com/antonine
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.07
ZIP - https://wordpress.org/themes/download/antonine.1.07.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.06&new_path=antonine/1.07

History:


https://themes.svn.wordpress.org/antonine/1.07/screenshot.png

#15 in reply to: ↑ 13 @pgogy
11 months ago

Replying to poena:

Hi
Is poop really the word you want in your screenhot? :)

I will post the review as soon as it is complete. :)

Maybe :)

POOP was the joke name for the project which paid for the theme. I have matured and censored myself. Thanks for your work. Interested in seeing the review as considering joining theme review but need an idea on skills and so on

#16 @poena
11 months ago

Hi
Your theme has been reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

Ok so the way you have setup your theme and the large amount of javascript is a bit unconventional, so even after the below issues have been fixed we might have to get a second reviewer for a final look.


Required

The theme URI is a 404. This link is optional, but it should not be broken.

There is a lot of functionality in the theme that is plugin territory and needs to be removed.
Themes are for presentation, if you add an advanced functionality that the user will loose if they switch themes, you lock the user to that theme.
The following is not allowed in themes:
creating categories ( You need to respect the users content and settings. You can provide setup instruction for the needed category.)
creating database tables
Subscription, sending e-mails
checking if posts have been read or not
Social sharing
meta tags such as creator, title, date: The user needs to be able to change these themselves for example with a SEO plugin.
Files (I'm afraid I did not understand how this is meant to work -please remember that any custom functionality or limitations must be documented.)

Themes are also not allowed to change the admin interface, like changing colors or adding items to the top admin bar.
(You are allowed one page in the admin, so you can add one menu time for example under Appearance, but not to the top bar).

You should also not force the utf-8 charset.

You need to remove the antonine_init() function. You should be using the default values in the customizer settings and on output (as a second parameter of get_theme_mod() ).
You need to:
Save options in a single array.
Use sane defaults and not write default setting values to the database.
https://make.wordpress.org/themes/handbook/review/required/#options-and-settings

All the options needs to be escaped on output, not only echoed. This includes color options.
See https://codex.wordpress.org/Data_Validation

You are required to use WordPress functionality if available.
Custom favicon functionality is no longer allowed: this is now provided by WordPress core in the customizer under Site Identity, Site Icon.
The same with the logo, see
https://developer.wordpress.org/reference/functions/the_custom_logo/
https://developer.wordpress.org/reference/functions/get_custom_logo/

Is there a reason to why you cannot use the core functionality for listing categories and tags?
-Please motivate why you need the custom code so that I can determine if it can be kept or needs to be replaced.
Is antonine_get_tags_links() used?
Please remove any and all unused code, (and code that is commented out) files or folders.

I found the following php notices and warnings when I loaded the theme:

Notice: Undefined variable: text in antonine\inc\template-tags.php on line 15
Warning: getimagesize(on): failed to open stream: No such file or directory inantonine\inc\social_media_headers.php on line 26

There is some text in the theme that is missing translation functions.
I am unable to list all of these texts, you will need to check all your files.
customizer.php line 56 "Show scroll to top". L87 "Display info" L129 "Display menu" and so on.
8 instances of "Nonce failed"
Translated texts in html attributes also needs to be escaped on output.

Why are you adding theme support for a custom background and custom header in functions.php only to remove it in customizer.php?
Please remove the custom-header tag from style.css if you don't plan to support it.

Did you mean to use main.css as editory style? Because you also have a editor-style.css file.

You have added support for the html5 search form, but also added a search-form.php file?
Please compare your form with the standard form:
https://developer.wordpress.org/reference/functions/get_search_form/
For example all instances of home_url() should be escaped as: esc_url( home_url('/') )

Scripts
You cannot hot link scripts or styles, see jquery-slider-css, line 91 in functions.php.
The fonts added in header/main.php needs to be enqueued.
You need to remove jquery-1.12.1.min from the theme folder.

I was unable to find a copyright statement for the theme itself.
See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/


This is all I have for this round. Please reply within 7 days, or your ticket may be closed as not approved. You need to reply, even if only to let me know if you need more time.


New reviewers are always welcome. You can learn a lot from reviewing themes, I think one of the most important "skills" is to know where to find information, like using the code reference https://developer.wordpress.org/reference/.
It does help to know php, and also if you have used the _s starter theme, since many themes are based on it.
Your first (6) themes will also be reviewed a second time by a key reviewer before they go live to make sure nothing was missed.

https://make.wordpress.org/themes/handbook/get-involved/become-a-reviewer/

All reviews are public here in the trac, so one way to learn more is by reading recent reviews.

#17 @pgogy
11 months ago

Hello,
I appreciate there is a lot of the theme which is definitely plugin - this is because it is designed for academics who want to try WordPress. As such, having the theme do everything is important in terms of adoption and simplicity - so removing some of functionality reduces the logic of the theme and so I think defeats its goal. If there is no flexibility on this I may stop.

The create categories can be dropped

The meta tags are for microformats and RDFa (to do it for the academic)

Files is designed to show any media uploaded, so if an academic adds a PDF or a PPT it can be be accessed from files and not digging round the site

The top bar stuff was designed to make things easier to use, I can remove, but consider it beneficial

I will look into the defaults and the customizer stuff (if the above isn't a deal breaker)

The core tags and categories functionality throws errors with WCAG accessibility compliance so I had to write some new code to pass.

Will go through language files

I developed on a full error reporting PHP so not sure why the errors happen - will check on a fresh site.

Sorry about the jquery - this was for accessibility testing and I left it in by mistake

So if there is too much pluggable, and that's a hard ruling, then I think I will neaten up the code but not progress further. If you could let me know if there is flexibility that'd be great. No worries if not and sorry for wasting your time

Pat

#18 @poena
11 months ago

Hi
No, there is no flexibility on those functionalities.
Having a theme that does everything does not make it easier to use WordPress, because as soon as you switch themes, you loose the functionality.
By combining plugins and themes they can change the look, the design, and still keep the functionality.

#19 @pgogy
11 months ago

Ok,
Am I allowed to use do_action in themes?
Thanks
Pat

#21 @poena
11 months ago

Hi -reminder, it has been 6 days

#22 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 1.07 to THEME: Antonine – 1.09

Antonine - 1.09

Antonine is a responsive, infinite scrolling theme with a variety of extra features including – facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/1.09
ZIP - https://wordpress.org/themes/download/antonine.1.09.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.07&new_path=antonine/1.09

History:


https://themes.svn.wordpress.org/antonine/1.09/screenshot.png

#23 @pgogy
11 months ago

The theme URI is a 404. This link is optional, but it should not be broken.

Removed

There is a lot of functionality in the theme that is plugin territory and needs to be removed.

Think I have removed it all - not sure on accessibility to left it in

Files (I'm afraid I did not understand how this is meant to work -please remember that any custom functionality or limitations must be documented.)

Have explained this in readme.txt

Themes are also not allowed to change the admin interface, like changing colors or adding items to the top admin bar.

Removed

You should also not force the utf-8 charset.

Removed

You need to remove the antonine_init() function. You should be using the default values in the customizer settings and on output (as a second parameter of get_theme_mod() ).

Removed

You need to:
Save options in a single array.
Use sane defaults and not write default setting values to the database.
https://make.wordpress.org/themes/handbook/review/required/#options-and-settings
All the options needs to be escaped on output, not only echoed. This includes color options.
See https://codex.wordpress.org/Data_Validation

Done

You are required to use WordPress functionality if available.
Custom favicon functionality is no longer allowed: this is now provided by WordPress core in the customizer under Site Identity, Site Icon.
The same with the logo, see
https://developer.wordpress.org/reference/functions/the_custom_logo/
https://developer.wordpress.org/reference/functions/get_custom_logo/

Done

Is there a reason to why you cannot use the core functionality for listing categories and tags?
-Please motivate why you need the custom code so that I can determine if it can be kept or needs to be replaced.

The use of I tags causes issues with WCAG compliance so I had to write custom code to get around it

Is antonine_get_tags_links() used?

No - template tags has been neatened and removed spurious code

Please remove any and all unused code, (and code that is commented out) files or folders.

Removed

I found the following php notices and warnings when I loaded the theme:
Notice: Undefined variable: text in antonine\inc\template-tags.php on line 15
Warning: getimagesize(on): failed to open stream: No such file or directory
inantonine\inc\social_media_headers.php on line 26

I don't get these, but have added traps to detect them

There is some text in the theme that is missing translation functions.
I am unable to list all of these texts, you will need to check all your files.
customizer.php line 56 "Show scroll to top". L87 "Display info" L129 "Display menu" and so on.

Done

8 instances of "Nonce failed"

Done

Translated texts in html attributes also needs to be escaped on output.

Done

Why are you adding theme support for a custom background and custom header in functions.php only to remove it in customizer.php?
Please remove the custom-header tag from style.css if you don't plan to support it.

Removed them

Did you mean to use main.css as editory style? Because you also have a editor-style.css file.

Have updated editor style .css

You have added support for the html5 search form, but also added a search-form.php file?
Please compare your form with the standard form:
https://developer.wordpress.org/reference/functions/get_search_form/
For example all instances of home_url() should be escaped as: esc_url( home_url('/') )

Used my own form and removed the html5 form

Scripts
You cannot hot link scripts or styles, see jquery-slider-css, line 91 in functions.php.

Downloaded and queued normally

The fonts added in header/main.php needs to be enqueued.

Enqueued

You need to remove jquery-1.12.1.min from the theme folder.

Removed

I was unable to find a copyright statement for the theme itself.

Added to the style.css

Thank you so much for time and work so far, hope this fixes it

#24 follow-up: @poena
11 months ago

I'm sorry if I'm not addressing all issues in this part of the review, I have a bit of brain fog because of the flu.

I've given it some more thought and asked other reviewers, and yes the accessibility settings needs to be removed.
It is plugin territory, and we don't normally allow cookies.

The social media image/logo and the open graph links (social_media_headers) are also plugin territory.
The user needs to be able to change these with plugins, and this data is not theme dependent. If this was kept in the theme, the user would loose it when they switch themes. TLDR: don't change any metas.

I see that your theme does not have an accessibility-ready tag. Have you read the accessibility requirements and recommendations?
https://make.wordpress.org/themes/handbook/review/accessibility/ Even if you don't plan to add the tag it is a good resource of information.

The file list is working now, in the last version it was just a blank area for me.

There are problems with the options.
First I couldn't get the license to show anywhere, then I tested the colors and none of the colors would change either.
Then I switched all the options that are "on" by default to "off", but nothing changed in the customizer preview or on the front.
I tried some different things (like a different server) but in the end the only thing I could do to get the options to work was rename them.
I was not able to find any document regarding the naming requirements, but removing the [] was the only thing that seemed to work.
Theme options are already prefixed. -It's a good idea to prefix everything since it helps us remember to prefix when it is needed,
but this particular prefix style did not work.

In customizer.php lines 9-12 you are removing a couple of sections, but you removed these features from the theme.

You are required to use the WordPress custom logo instead of your own custom logo code.
See
https://developer.wordpress.org/reference/functions/the_custom_logo/
https://developer.wordpress.org/reference/functions/get_custom_logo/

You can filter the output of the tag list:
get_the_tag_list( before, between, after )
See https://developer.wordpress.org/reference/functions/get_the_tag_list/

I am not finding any <i> tags for the category list either?
You can see the source here: https://developer.wordpress.org/reference/functions/get_the_category_list/
It just seems like a complicated way to show the lists. Have you looked at how other themes like the default themes solves this?

In content-all.php, what is your intention with this code?

/* translators: %s: Name of current post */
$content = get_the_excerpt();
$excerpt_pos = strpos($content,"[..---..]");
if($excerpt_pos===FALSE){
$excerpt_pos = 100;
}
echo substr($content,0,$excerpt_pos) . "...";		

#25 in reply to: ↑ 24 @pgogy
11 months ago

Replying to poena:

I'm sorry if I'm not addressing all issues in this part of the review, I have a bit of brain fog because of the flu.

Get well soon

I've given it some more thought and asked other reviewers, and yes the accessibility settings needs to be removed.
It is plugin territory, and we don't normally allow cookies.

Not got a new version ready yet, but have removed accessibility and cookies

The social media image/logo and the open graph links (social_media_headers) are also plugin territory.
The user needs to be able to change these with plugins, and this data is not theme dependent. If this was kept in the theme, the user would loose it when they switch themes. TLDR: don't change any metas.

Also removed

I see that your theme does not have an accessibility-ready tag. Have you read the accessibility requirements and recommendations?
https://make.wordpress.org/themes/handbook/review/accessibility/ Even if you don't plan to add the tag it is a good resource of information.

I didn't add the tag as I wanted to get the theme approved as quickly as possible, and felt this would slow it down

There are problems with the options.
First I couldn't get the license to show anywhere, then I tested the colors and none of the colors would change either.
Then I switched all the options that are "on" by default to "off", but nothing changed in the customizer preview or on the front.
I tried some different things (like a different server) but in the end the only thing I could do to get the options to work was rename them.
I was not able to find any document regarding the naming requirements, but removing the [] was the only thing that seemed to work.
Theme options are already prefixed. -It's a good idea to prefix everything since it helps us remember to prefix when it is needed,
but this particular prefix style did not work.

I am confused by the earlier request to save settings in an array - so this is why I added an array prefix. This seems to have broken things. I've tried to google as to how to save customizer options in an array but there isn't much which seems clear. I have looked at how 2016 does it, but that uses colour schemes and I am not sure that it works the same way.

If there is a save as array example somewhere please send it to me

In customizer.php lines 9-12 you are removing a couple of sections, but you removed these features from the theme.

removed

You are required to use the WordPress custom logo instead of your own custom logo code.
See
https://developer.wordpress.org/reference/functions/the_custom_logo/
https://developer.wordpress.org/reference/functions/get_custom_logo/

I am not sure which custom logo I am using or setting - if you could point it out to me i'd be grateful

You can filter the output of the tag list:
get_the_tag_list( before, between, after )
See https://developer.wordpress.org/reference/functions/get_the_tag_list/

I am not finding any <i> tags for the category list either?
You can see the source here: https://developer.wordpress.org/reference/functions/get_the_category_list/
It just seems like a complicated way to show the lists. Have you looked at how other themes like the default themes solves this?

I ran one accessibility checker which didn't like the default way the code did it, and once i've remembered which one it was I will try again and see if I can make it work using the default code. I didn't write it for no reason.

In content-all.php, what is your intention with this code?

/* translators: %s: Name of current post */
$content = get_the_excerpt();
$excerpt_pos = strpos($content,"[..---..]");
if($excerpt_pos===FALSE){
$excerpt_pos = 100;
}
echo substr($content,0,$excerpt_pos) . "...";		

It is used as part of the infinite scroll code (the string pattern allows me to do an explode safely on returned data)

Thanks for the reply and get well soon

#26 @poena
11 months ago

Thank you :)

I'm sorry for the confusion. The single array was in reference to how the defaults where added in the previous version, using multiple set_theme_mod.
The correct way is by using defaults in the customizer.
-The options where actually saved when I checked the database, but the output did not work.

If you don't want to support a logo, you don't have to. But if you do, you need to use the WordPress function.
You need to remove antonine_customize_register_social_media.
To add a logo, place add_theme_support( 'custom-logo' ); in antonine_setup() in functions.php.
To show the logo you can use

if ( function_exists( 'the_custom_logo' ) ) {
      the_custom_logo();
   }

https://make.wordpress.org/core/2016/03/10/custom-logo/

#27 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 1.09 to THEME: Antonine – 2

Antonine - 2

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/2
ZIP - https://wordpress.org/themes/download/antonine.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/1.09&new_path=antonine/2

History:


https://themes.svn.wordpress.org/antonine/2/screenshot.png

#28 @pgogy
11 months ago

New version up
Social media / custom logos removed
I remembered why I rewrote the categories - this was to add in RDFa / microformats
All changes discussed above are in this zip
Hope you're feeling better

This ticket was mentioned in Slack in #themereview by poena. View the logs.


11 months ago

#30 follow-up: @poena
11 months ago

It looks like front-page-files.js is included twice, see functions.php lines 93 and 115.

I'm also confused by how the antonine_custom_css is added, why is admin_url('admin-ajax.php') needed here?
usually, this is hooked to wp_head() or perhaps wp_add_inline_style().

Well, I've asked for some help with the javascripts but I'm not sure when someone will have the time to look at it.

The Display accessibility option is still available in the customizer.

What is the difference between the Site Header Text Colour and the Site Title Colour?
I believe all the other customizer color options are working once you save, but not all changes are shown in the customizer.

Is the theme meant to have a visible footer?
I found several references to .page-footer in antonine_customiser.js but this does not seem to be in the theme?
When the scroll option is on, I can see this in the source of the page, but I can't actually see an icon on the page so I can't click it.

<div id="antoninetopscroll">
	<p>	
		<span class="fa fa-angle-double-up"></span>
	</p>
</div>

You have some texts in your javascript that can't be translated.
Use wp_localize_script() to translate these.
front-page.js, antonine-library.js: All posts are shown

Last edited 11 months ago by poena (previous) (diff)

#31 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 2 to THEME: Antonine – 3

Antonine - 3

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/3
ZIP - https://wordpress.org/themes/download/antonine.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/2&new_path=antonine/3

History:


https://themes.svn.wordpress.org/antonine/3/screenshot.png

#32 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 3 to THEME: Antonine – 3.1

Antonine - 3.1

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/3.1
ZIP - https://wordpress.org/themes/download/antonine.3.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/3&new_path=antonine/3.1

History:


https://themes.svn.wordpress.org/antonine/3.1/screenshot.png

#33 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 3.1 to THEME: Antonine – 3.2

Antonine - 3.2

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/3.2
ZIP - https://wordpress.org/themes/download/antonine.3.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/3.1&new_path=antonine/3.2

History:


https://themes.svn.wordpress.org/antonine/3.2/screenshot.png

#34 in reply to: ↑ 30 @pgogy
11 months ago

Replying to poena:

It looks like front-page-files.js is included twice, see functions.php lines 93 and 115.

removed

I'm also confused by how the antonine_custom_css is added, why is admin_url('admin-ajax.php') needed here?
usually, this is hooked to wp_head() or perhaps wp_add_inline_style().

I needed to bypass using <style> and inline styles for accessibility so did this

Well, I've asked for some help with the javascripts but I'm not sure when someone will have the time to look at it.

Is there something in particular I could do to help?

The Display accessibility option is still available in the customizer.

Removed

What is the difference between the Site Header Text Colour and the Site Title Colour?
I believe all the other customizer color options are working once you save, but not all changes are shown in the customizer.

Removed

Is the theme meant to have a visible footer?
I found several references to .page-footer in antonine_customiser.js but this does not seem to be in the theme?

No - this was an error

When the scroll option is on, I can see this in the source of the page, but I can't actually see an icon on the page so I can't click it.

<div id="antoninetopscroll">
	<p>	
		<span class="fa fa-angle-double-up"></span>
	</p>
</div>

fixed it

You have some texts in your javascript that can't be translated.
Use wp_localize_script() to translate these.
front-page.js, antonine-library.js: All posts are shown


done

Thanks for your time

#35 follow-up: @poena
11 months ago

Hi
To me personally it just felt like a backwards way of doing things, it is not necessarily against the requirements, but I've never seen a theme done this way before. Which is why I keep asking a lot of questions. =)

For example the way the comments and files are loaded in the menu: -I don't know these techniques well enough. @Greenshady do you have time to help us out?
I mean I can't even figure out when https://themes.svn.wordpress.org/antonine/3.2/inc/infinite_scroll.php is used and when the normal loop is used.


You are concerned about the extra style tag, but there are other accessibility issues like the keyboard navigation (-I can't access the menu) and contrast that has a bigger impact for some users.


Besides the ajax/custom javascript there are some minor things left, I'm sorry for not catching all of them in the first reviews.

I think there is still some code left in the theme that is not used.
Is antonine_full_url() used? front-page-access.js should also be removed I think?

Translated texts in html attributes need to be escaped. See for example search-form/standard.php ( the value attribute)
-WordPress has a standard function and fall back for the search form, see
https://developer.wordpress.org/reference/functions/get_search_form/
As mentioned before you are required to use WordPress functionality if available. Please motivate why you need the custom file.

You can use minified files, but the original, non minified file needs to be included too.
I was unable to find the non minified version of font-awesome.min.css.

Recommended
"table_fix" "youtube-fix" -if these are not conditional, why not add them to the stylesheet instead of loading two extra files?

Notes
I'm also wondering how to reset the filter and return to the regular blog post listing?

When I changed the "Blog pages show at most" setting under Reading settings in the admin, something strange happened. I set it to 3 posts and the front page showed only 6 posts (I expected the infinite scroll to continue since there is no other next or previous post navigation).
And when the infinite scroll scrolled past the first 3 posts, the word "scroll!" showed up after the post title in a pale pink color. Like:
Template: Featured Image (Vertical)scroll!

Last edited 11 months ago by poena (previous) (diff)

@poena
11 months ago

#36 @poena
11 months ago

  • Cc greenshady added

#37 in reply to: ↑ 35 @pgogy
11 months ago

Replying to poena:

Hi
To me personally it just felt like a backwards way of doing things, it is not necessarily against the requirements, but I've never seen a theme done this way before. Which is why I keep asking a lot of questions. =)

That's fine, it isn't like any other theme i've made (or much like other WP themes I've used) - which is why I chose to submit this one first :)

For example the way the comments and files are loaded in the menu: -I don't know these techniques well enough. @Greenshady do you have time to help us out?

Nothing is per say loaded into the menu, it is done via ajax when you click on the button. So it isn't that far away from the recent comments widget.

I mean I can't even figure out when https://themes.svn.wordpress.org/antonine/3.2/inc/infinite_scroll.php is used and when the normal loop is used.

it is triggered when the scroll bar reaches the bottom of the page and the js fires an ajax request. See front-page-scroll.js


You are concerned about the extra style tag, but there are other accessibility issues like the keyboard navigation (-I can't access the menu) and contrast that has a bigger impact for some users.

With the tools i've used, I get no contrast errors at all - but happy to be corrected. I also gave the theme to someone who works for the government on accessibility, and he didn't report any issues with navigation. But I can work this in if needed now?

Besides the ajax/custom javascript there are some minor things left, I'm sorry for not catching all of them in the first reviews.

I think there is still some code left in the theme that is not used.
Is antonine_full_url() used? front-page-access.js should also be removed I think?

both removed

Translated texts in html attributes need to be escaped. See for example search-form/standard.php ( the value attribute)
-WordPress has a standard function and fall back for the search form, see
https://developer.wordpress.org/reference/functions/get_search_form/
As mentioned before you are required to use WordPress functionality if available. Please motivate why you need the custom file.

for WCAG compliance the input needs a label with a matching id (see for="") and each input needs a max length attribute. I've escaped the translation.

You can use minified files, but the original, non minified file needs to be included too.
I was unable to find the non minified version of font-awesome.min.css.

Added a maxed version of font-awesome

Recommended
"table_fix" "youtube-fix" -if these are not conditional, why not add them to the stylesheet instead of loading two extra files?

youtube fix needs to run on document loading (iirc)
Table fix added to css

Notes
I'm also wondering how to reset the filter and return to the regular blog post listing?

Added a link in to reset the filter

When I changed the "Blog pages show at most" setting under Reading settings in the admin, something strange happened. I set it to 3 posts and the front page showed only 6 posts (I expected the infinite scroll to continue since there is no other next or previous post navigation).
And when the infinite scroll scrolled past the first 3 posts, the word "scroll!" showed up after the post title in a pale pink color. Like:
Template: Featured Image (Vertical)scroll!

So I've dug around and I can't find "scroll!" anywhere in the code. I used to have that in a dev version, but it doesn't happen on any 3 of my test sites. Could you send me the url so I know which code is running and the html for "scroll!"

#38 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 3.2 to THEME: Antonine – 4

Antonine - 4

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/4
ZIP - https://wordpress.org/themes/download/antonine.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/3.2&new_path=antonine/4

History:


https://themes.svn.wordpress.org/antonine/4/screenshot.png

#39 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 4 to THEME: Antonine – 5

Antonine - 5

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/5
ZIP - https://wordpress.org/themes/download/antonine.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/4&new_path=antonine/5

History:


https://themes.svn.wordpress.org/antonine/5/screenshot.png

#40 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 5 to THEME: Antonine – 6

Antonine - 6

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/6
ZIP - https://wordpress.org/themes/download/antonine.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/5&new_path=antonine/6

History:


https://themes.svn.wordpress.org/antonine/6/screenshot.png

#41 follow-up: @poena
11 months ago

Hi! I'm sorry for the long wait. I have not recieved much feed back from the other reviewers, probably because of the holiday:

In functions.php please use admin_url('admin-ajax.php') instead of $ajax_base . "/wp-admin/admin-ajax.php"

In files.php, do not use $file->guid for the source of the file. The guid is not updated if for example the site is moved.
See:
https://codex.wordpress.org/Changing_The_Site_URL#Important_GUID_Note
If you look at the source of this functions you can see how they are first attempting to find the right directory and then use GUID as a fallback:
https://developer.wordpress.org/reference/functions/wp_get_attachment_url/
https://developer.wordpress.org/reference/functions/wp_get_attachment_image_src/

Untested but I'm thinking something like this should work:

src='" . wp_get_attachment_url( $file->ID ) . "'

I also looked through the latest version once more:

In search.php, please use either WP_Query or get_posts instead of query_posts.
Reset your query using wp_reset_postdata().
Also see antonine_filter.php where I believe the reset is missing.
See these pages for more info:
https://developer.wordpress.org/reference/classes/wp_query/
https://developer.wordpress.org/reference/functions/get_posts/
https://developer.wordpress.org/reference/functions/wp_reset_postdata/

In single.php line 22, I think you meant to use home_url().
The site_url template tag retrieves the site url for the current site (where the WordPress core files reside, where you would add /wp-admin to the end etc.), while home_url() is the home page (simplified).
This also needs to be escaped with esc_url():

esc_url( home_url( '/' ) )

You might also be interested in: https://developer.wordpress.org/reference/functions/has_post_format/
Instead of

if(get_post_format()!=""))

In tag.php, I don't think the global $wp_query is needed?

In parts/content/ there are several files that present content but that are missing wp_link_pages(), including page.php.
If you split the page into several pages (using page breaks in the editor), all of the content cannot be reached, only the first page is available.
See https://developer.wordpress.org/reference/functions/wp_link_pages/

In content-link.php, We don't know for sure if the content of the post is actually a link. This is unsafe and it needs to be removed.
When I tested the link post format with the WordPress theme unit test, the resulting source was:

<iframe width="100%" height="1000" src="&lt;a href=" http:="" make.wordpress.org="" themes"="" title="The WordPress Theme Review Team Website">The WordPress Theme Review Team Website&lt;/a&gt;"&gt;</iframe> 

And this returned a 404 inside the iframe.

There are a couple of places in the theme where you are using

<?PHP
$content = get_the_content();
?>
<?php echo $content; ?>

Please use

<?php the_content(); ?>

instead.

Please use the WordPress excerpt_length filter to adjust the length of the excerpts instead of custom functionality.
See content-all.php
See https://developer.wordpress.org/reference/hooks/excerpt_length/ for examples.

On line 4 of content-all.php you are echoing the_title(), but this is already echoed, please see: https://developer.wordpress.org/reference/functions/the_title/
On line 16 of content-all.php, you are echoing the_ID(), but this is already echoed, please see: https://developer.wordpress.org/reference/functions/the_id/

I still cannot get all the posts to load with the infinite scroll on the front page.
It only shows twice the ammount of post that I set in the "Blog pages show at most" setting and I can't reach
the older posts. I expect an infinite scroll theme to continue, and ignore this setting.

#42 in reply to: ↑ 41 @pgogy
11 months ago

In functions.php please use admin_url('admin-ajax.php') instead of $ajax_base . "/wp-admin/admin-ajax.php"

The code is as it is due to admin_url not working on sub domain multisites (due to ajax not working due to site security settings). It fails with admin_url.

In files.php, do not use $file->guid for the source of the file. The guid is not updated if for example the site is moved.
See:
https://codex.wordpress.org/Changing_The_Site_URL#Important_GUID_Note
If you look at the source of this functions you can see how they are first attempting to find the right directory and then use GUID as a fallback:
https://developer.wordpress.org/reference/functions/wp_get_attachment_url/
https://developer.wordpress.org/reference/functions/wp_get_attachment_image_src/

Untested but I'm thinking something like this should work:

src='" . wp_get_attachment_url( $file->ID ) . "'

Done, thanks.

I also looked through the latest version once more:

In search.php, please use either WP_Query or get_posts instead of query_posts.
Reset your query using wp_reset_postdata().

I have added a pre_get_posts hook in functions as this felt neater

Also see antonine_filter.php where I believe the reset is missing.
See these pages for more info:
https://developer.wordpress.org/reference/classes/wp_query/
https://developer.wordpress.org/reference/functions/get_posts/
https://developer.wordpress.org/reference/functions/wp_reset_postdata/

Added the reset into antonine filter

In single.php line 22, I think you meant to use home_url().
The site_url template tag retrieves the site url for the current site (where the WordPress core files reside, where you would add /wp-admin to the end etc.), while home_url() is the home page (simplified).
This also needs to be escaped with esc_url():

esc_url( home_url( '/' ) )

done

You might also be interested in: https://developer.wordpress.org/reference/functions/has_post_format/
Instead of

if(get_post_format()!=""))

swapped

In tag.php, I don't think the global $wp_query is needed?

no, removed, and from category.php

In parts/content/ there are several files that present content but that are missing wp_link_pages(), including page.php.
If you split the page into several pages (using page breaks in the editor), all of the content cannot be reached, only the first page is available.
See https://developer.wordpress.org/reference/functions/wp_link_pages/

done where applicable

In content-link.php, We don't know for sure if the content of the post is actually a link. This is unsafe and it needs to be removed.
When I tested the link post format with the WordPress theme unit test, the resulting source was:

<iframe width="100%" height="1000" src="&lt;a href=" http:="" make.wordpress.org="" themes"="" title="The WordPress Theme Review Team Website">The WordPress Theme Review Team Website&lt;/a&gt;"&gt;</iframe> 

And this returned a 404 inside the iframe.

removed the iframe

There are a couple of places in the theme where you are using

<?PHP
$content = get_the_content();
?>
<?php echo $content; ?>

Please use

<?php the_content(); ?>

instead.

done

Please use the WordPress excerpt_length filter to adjust the length of the excerpts instead of custom functionality.
See content-all.php
See https://developer.wordpress.org/reference/hooks/excerpt_length/ for examples.

have dropped the excerpt - i can't use excerpt hooks as I am not varying the number of words, but the amount of text returned

On line 4 of content-all.php you are echoing the_title(), but this is already echoed, please see: https://developer.wordpress.org/reference/functions/the_title/

done

On line 16 of content-all.php, you are echoing the_ID(), but this is already echoed, please see: https://developer.wordpress.org/reference/functions/the_id/

done

I still cannot get all the posts to load with the infinite scroll on the front page.
It only shows twice the ammount of post that I set in the "Blog pages show at most" setting and I can't reach
the older posts. I expect an infinite scroll theme to continue, and ignore this setting.

I have added the theme to my dev site - http://pgogywebstuff.com/wpdevelopment/wildcat/ - scroll works for me?

#43 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 6 to THEME: Antonine – 7

Antonine - 7

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/7
ZIP - https://wordpress.org/themes/download/antonine.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/6&new_path=antonine/7

History:


https://themes.svn.wordpress.org/antonine/7/screenshot.png

#44 follow-up: @poena
11 months ago

Hi!
Thank you for fixing these problems -but the infinite scroll is still not working,
neither on your dev site or my test site wpkitty.com. I'm on a PC if that matters, but I tried in different browsers.

I did not notice until I installed the theme on the live server, that different posts are shown depending on if I am logged in or not. When I am logged in, the Hello World post is duplicated.

#45 in reply to: ↑ 44 @pgogy
11 months ago

Replying to poena:

Hi!
Thank you for fixing these problems -but the infinite scroll is still not working,
neither on your dev site or my test site wpkitty.com. I'm on a PC if that matters, but I tried in different browsers.

I did not notice until I installed the theme on the live server, that different posts are shown depending on if I am logged in or not. When I am logged in, the Hello World post is duplicated.

Hello
Sorry, I copied the new theme up but for some reason the files didn't update.
Just re did it and now works for me (all browsers)
Also can't get posts to replicate (i.e differentiate on logged in or out)
Pat

P.S will remove .gitignore in next zip

#46 follow-up: @poena
11 months ago

Hi
Please try it with a different screen resolution. It (the wildcat test install) does not work for me in 1920x1200 or 1920x1080 but it worked when I changed it to 800x600 and when I tested it on my mobile.

#47 in reply to: ↑ 46 ; follow-up: @pgogy
11 months ago

Replying to poena:

Hi
Please try it with a different screen resolution. It (the wildcat test install) does not work for me in 1920x1200 or 1920x1080 but it worked when I changed it to 800x600 and when I tested it on my mobile.

My laptop only goes up to 1300

Does http://poop.hackstateedu.org/ work (console messages show scrolling status and so on)

#48 @themetracbot
11 months ago

  • Summary changed from THEME: Antonine – 7 to THEME: Antonine – 9

Antonine - 9

Antonine is a responsive, infinite scrolling theme with a variety of extra features including &#8211; facebook-esque notifications, WCAG compliance, new post subscription, fast file access and much more

Theme URL -
Author URL - https://pgogywebstuff.com/

SVN - https://themes.svn.wordpress.org/antonine/9
ZIP - https://wordpress.org/themes/download/antonine.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=antonine/7&new_path=antonine/9

History:


https://themes.svn.wordpress.org/antonine/9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#49 in reply to: ↑ 47 @pgogy
11 months ago

Replying to pgogy:

Replying to poena:

Hi
Please try it with a different screen resolution. It (the wildcat test install) does not work for me in 1920x1200 or 1920x1080 but it worked when I changed it to 800x600 and when I tested it on my mobile.

My laptop only goes up to 1300

Does http://poop.hackstateedu.org/ work (console messages show scrolling status and so on)

tested on partners and fixed it (new version up)

#50 follow-up: @poena
11 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

You did it! Great work. And with that, I believe the theme is ready. If any other issues arise they can be fixed in an update.
Your theme should be live shortly.

#51 in reply to: ↑ 50 @pgogy
11 months ago

Replying to poena:

You did it! Great work. And with that, I believe the theme is ready. If any other issues arise they can be fixed in an update.
Your theme should be live shortly.

Thank you so much for your time and so on - if there is a charity you like then let me know and I'll make a donation.

Should I purge old versions from the SVN?

Many many many thanks

#52 @poena
10 months ago

Hi!
If you like you can donate to the WordPress Foundation: http://wordpressfoundation.org/.

Theme authors don't have access to SVN.

Carolina

Last edited 10 months ago by poena (previous) (diff)
Note: See TracTickets for help on using tickets.