WordPress.org

Make WordPress Themes

Opened 17 months ago

Closed 9 months ago

Last modified 9 months ago

#33628 closed theme (live)

THEME: Read More – 1.0.2

Reported by: acmethemes Owned by: aveeshek
Priority: new theme Keywords: theme-read-more
Cc: acmethemes@…

Description

Change History (13)

#1 @themetracbot
12 months ago

  • Summary changed from THEME: Read More – 0.0.1 to THEME: Read More – 1.0.0

Read More - 1.0.0

Read More is an awesome WordPress theme for your blog that can improve every element of your blog. Read More is a theme built to overcome the needs of the modern and classic blogger, whether for casual and personal blogs or for professional, corporate and journalistic blogs. With a large number of highly crafted premium features you can easily customize the site as your need. Read More will showcase your well written content on any device. In addition, Read More is Cross browser compatible, responsive layout, WooCommerce ready and translation ready theme. A live customizer based theme with added custom widgets will make your site incredible. Read More is an intuitively constructed yet powerfully flexible WordPress theme for your blog. Header options are available for managing header sections, footer options are for footer and theme options are for managing overall site. Color Options, breadcrumb options, search options, custom CSS, social icons are the added features on this theme. Added custom widget for author help to provide the author information easily through the website. Users can choose the site layout with available options from the theme. Left sidebar, right sidebar, no sidebar are the layouts of the theme. Read More is SEO friendly theme which make it easy to find on Google and other search engines. A highly dedicated, professional and friendly support team will be available to resolve all pressing issues. Support: https://www.acmethemes.com/supports/ and Demo https://www.acmethemes.com/demo/?theme=read-more

Theme URL - https://www.acmethemes.com/themes/read-more
Author URL - https://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/read-more/1.0.0
ZIP - https://wordpress.org/themes/download/read-more.1.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=read-more/0.0.1&new_path=read-more/1.0.0

History:

Ticket Summary Status Resolution Owner
#33628 THEME: Read More – 1.0.2 closed live aveeshek

(this ticket)

#39493 THEME: Read More – 1.1.0 closed live themetracbot
#39847 THEME: Read More – 1.1.1 closed live themetracbot
#45027 THEME: Read More – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/read-more/1.0.0/screenshot.jpg

#2 @themetracbot
12 months ago

  • Owner set to aveeshek
  • Status changed from new to reviewing

#3 @themetracbot
12 months ago

  • Summary changed from THEME: Read More – 1.0.0 to THEME: Read More – 1.0.1

Read More - 1.0.1

Read More is an awesome WordPress theme for your blog that can improve every element of your blog. Read More is a theme built to overcome the needs of the modern and classic blogger, whether for casual and personal blogs or for professional, corporate and journalistic blogs. With a large number of highly crafted premium features you can easily customize the site as your need. Read More will showcase your well written content on any device. In addition, Read More is Cross browser compatible, responsive layout, WooCommerce ready and translation ready theme. A live customizer based theme with added custom widgets will make your site incredible. Read More is an intuitively constructed yet powerfully flexible WordPress theme for your blog. Header options are available for managing header sections, footer options are for footer and theme options are for managing overall site. Color Options, breadcrumb options, search options, custom CSS, social icons are the added features on this theme. Added custom widget for author help to provide the author information easily through the website. Users can choose the site layout with available options from the theme. Left sidebar, right sidebar, no sidebar are the layouts of the theme. Read More is SEO friendly theme which make it easy to find on Google and other search engines. A highly dedicated, professional and friendly support team will be available to resolve all pressing issues. Support: https://www.acmethemes.com/supports/ and Demo https://www.acmethemes.com/demo/?theme=read-more

Theme URL - https://www.acmethemes.com/themes/read-more
Author URL - https://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/read-more/1.0.1
ZIP - https://wordpress.org/themes/download/read-more.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=read-more/1.0.0&new_path=read-more/1.0.1

History:

Ticket Summary Status Resolution Owner
#33628 THEME: Read More – 1.0.2 closed live aveeshek

(this ticket)

#39493 THEME: Read More – 1.1.0 closed live themetracbot
#39847 THEME: Read More – 1.1.1 closed live themetracbot
#45027 THEME: Read More – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/read-more/1.0.1/screenshot.jpg

#4 @acmethemes
12 months ago

Hello @aveeshek ,

Thank you for taking our the for review.
Please let us know if you find any issues.

Best Regards,
Acme Themes

#5 @aveeshek
12 months ago

Read More Theme
================

Hello @acmethemes,

Plaese find below the issues found in the theme:

*Required
=========

CODE
====

  • Unused action hook "supernews_author_links" found in content-author.php L:21. If you are planning to use it prefix it with theme slug, otherwise remove.
  • Only three subject tags are allowed in style.css found four ( blog, e-commerce, education, portfolio )
  • Wrong file documentation : Found "* @since Weblog 1.0.0" in related-posts.php L: 5.
  • Use of 'ignore_sticky_posts ' => true,: While using in Wp_Query, the parameter is not strict enough and is not working in front-page.php L:88 Use strict parameters like 'postnot_in' => get_option( 'sticky_posts' ), option if you want to exclude sticky post in these cases. or remove the parameter.

Console
========

  • Infinite console log created by the slider. Infite console logs can create issue in the theme and should be removed.

cycle2] cycle-resumed

18read-more-custom.js?ver=0.0.2:31 171
jquery.cycle2.js?ver=1.3.3:608 [cycle2] cycle-paused
jquery.cycle2.js?ver=1.3.3:608 [cycle2] cycle-resumed
jquery.cycle2.js?ver=1.3.3:608 [cycle2] cycle-paused
jquery.cycle2.js?ver=1.3.3:608 [cycle2] cycle-resumed

  • Infinite loop of console.log() of post id found in single post page on each scroll and should be removed.

268
187read-more-custom.js?ver=0.0.2:31 268

Language and translation
========================

  • Wrong text-domain used in acmethemes/customizer/feature-section-blog/feature-blog.php L:37. the theme text-domain is "read-more" found "supernews".
  • Wrong text-domain used in acmethemes/customizer/feature-section/feature-slider.php L:25. the theme text-domain is "read-more" found "supernews".

Theme Directory
===============

  • Unused Images found in assets > img. Please remove any unused images / files from theme dir. Also remove the Licence attribution to the unused images in readme.txt.

Customizer Functionality
=========================

  • Please mention the requiresd image size for the front page featured slider in customizer either / or in featured image upload area.

*Recommended
============

CODE
====

  • You're setting all your theme mods as a global $read_more_customizer_all_values. Use get theme mod.
  • All theme mods are recommended to be saved in a single array. Used multiple variables in the theme currently.
  • "wp_reset_postdata" is recommended reset function after using custom WP_Query(). "wp_reset_query" found in acmethemes > hooks > front-page.php.

Responsive / Design
===================

  • It is recommended to show slider title even on mobile devices. currently slider only shows big "Read More" Button only in the front page.

=============================NOTE====================================================================

  • REQUIRED points should be resolved to make theme approved on wordpress.org. RECOMMENDED points includes best practices on theme development but theme will not be rejected on the base of RECOMMENDED points.
  • Please fix issues and reupload your theme. Update your theme version and changelog. https://wordpress.org/themes/upload/
  • Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#6 @themetracbot
12 months ago

  • Summary changed from THEME: Read More – 1.0.1 to THEME: Read More – 1.0.2

Read More - 1.0.2

Read More is an awesome WordPress theme for your blog that can improve every element of your blog. Read More is a theme built to overcome the needs of the modern and classic blogger, whether for casual and personal blogs or for professional, corporate and journalistic blogs. With a large number of highly crafted premium features you can easily customize the site as your need. Read More will showcase your well written content on any device. In addition, Read More is Cross browser compatible, responsive layout, WooCommerce ready and translation ready theme. A live customizer based theme with added custom widgets will make your site incredible. Read More is an intuitively constructed yet powerfully flexible WordPress theme for your blog. Header options are available for managing header sections, footer options are for footer and theme options are for managing overall site. Color Options, breadcrumb options, search options, custom CSS, social icons are the added features on this theme. Added custom widget for author help to provide the author information easily through the website. Users can choose the site layout with available options from the theme. Left sidebar, right sidebar, no sidebar are the layouts of the theme. Read More is SEO friendly theme which make it easy to find on Google and other search engines. A highly dedicated, professional and friendly support team will be available to resolve all pressing issues. Support: https://www.acmethemes.com/supports/ and Demo https://www.acmethemes.com/demo/?theme=read-more

Theme URL - https://www.acmethemes.com/themes/read-more
Author URL - https://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/read-more/1.0.2
ZIP - https://wordpress.org/themes/download/read-more.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=read-more/1.0.1&new_path=read-more/1.0.2

History:

Ticket Summary Status Resolution Owner
#33628 THEME: Read More – 1.0.2 closed live aveeshek

(this ticket)

#39493 THEME: Read More – 1.1.0 closed live themetracbot
#39847 THEME: Read More – 1.1.1 closed live themetracbot
#45027 THEME: Read More – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/read-more/1.0.2/screenshot.jpg

#7 @acmethemes
12 months ago

Hello @aveeshek,
Thank you so much for your awesome review. We updated the theme as per your review. Please check it.

*Required
=========
CODE
====

  • Unused action hook supernews_author_links removed.
  • Remove one tags and made it three.
  • Wrong file documentation corrected.
  • Sticky post corrected

Console
========

  • Both console error message solved.

Language and translation
========================

  • Text domain corrected.

Theme Directory
===============

  • The image is used as default image in the slider. If there is no header image selected, it will appeared in place of slider. Please look the codes in acmethemes/hooks/slider-selection.php L:19

Customizer Functionality
=========================

  • Description added in featured slider for slider image size recommendation.

Recommended
============

CODE
====

  • We are using get_theme_mod in acmethemes/customizer/customizer-core.php L:180 and setting it as global on acmethemes/hooks/header.php L:14 prefixing by theme slug. We believe that it does not create any issues. If you think it create any problems, please let us know.
  • Theme mods are already saved in a single array and we are accessing theme setting using single array. Please see here on acmethemes/customizer/customizer-core.php L:180, $read_more_get_theme_options = get_theme_mod( 'read_more_theme_options');. If you think it create any problems, please let us know.
  • wp_reset_postdata is already used and found in acmethemes > hooks > front-page.php L:143, please chek.

Responsive / Design
===================

  • As you recommend, we have shown slider title on mobile devices too , thanks a lot for your recommendation.
  • We solved one more issues as well. Global variable $image_size_options fixed by prefixing with theme slug $read_more_image_size_options;.

Regards,
Acme Themes

#8 @aveeshek
11 months ago

Hello @acmethemes,

Thanks for fixing the issues listed above. Most of the issues was found resolved in the theme. However I'd like to get some clarifications on the issue points listed below.

#Theme Directory :

  • Please guide me to the use of "continents-bg.png" and "no-image-400-320.png" images in the theme dir > assets > img. If they are not required please remove them.

#License Attribution :

All other issues seems to have resolved and no other issues are currently seen in the theme files.

Kindly address the points above.

Best Regards !!

#9 @acmethemes
11 months ago

Hello @aveeshek ,

Thanks for your reply.

#Theme Directory :
Can you please check and confirm again, "continents-bg.png" and "no-image-400-320.png" images in the theme dir > assets > img, there are no such images in the latest version ( 1.0.2 ) ,
https://themes.svn.wordpress.org/read-more/1.0.2/assets/img/

#License Attribution :
The mention image is in the screenshot, Can you please check and confirm.

Best Regards,
Acme Themes

#10 @aveeshek
11 months ago

  • Status changed from reviewing to approved

Hello @acmethemes,

Thank you very much for the clarification.

It was my mistake extracting the theme folder in my existing Folder.

As All the issues seems to be resolved and no more issues are currently found in the theme i am setting the theme status to approved.

Thank you for the Amazing theme, I would like to wish all the very best for the success of the theme and your future themes.

Best Regards !!

CHEERS !!

#11 @imon Hasan
9 months ago

@acmethemes doing final review

#12 @imon Hasan
9 months ago

  • Resolution set to live
  • Status changed from approved to closed

@aveeshek good job

Not find any major issue and everything resolved

@acmethemes Thank you your theme will be live within few minutes

#13 @acmethemes
9 months ago

Thanks @imon Hasan for setting our theme live.
@aveeshek Thanks.

Note: See TracTickets for help on using tickets.