WordPress.org

Make WordPress Themes

#33760 closed theme (not-approved)

THEME: Poetic – 1.0

Reported by: zeshanshani Owned by: trkr
Priority: new theme Keywords: theme-poetic
Cc: premiumsrapidshares@…

Description

Change History (2)

#1 @trkr
15 months ago

  • Owner set to trkr
  • Status changed from new to reviewing

Hi
Your theme has been partially reviewed against these requirements: https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

ISSUES

  • Theme URL should display informaion about the theme not a demo.
  • All texts should be translatable
    • <li>An <strong>out-of-date bookmark/favorite.</strong></li>
    • <li>A search engine that has an <strong>out-of-date listing for this site.</strong></li>
    • <li>A <strong>mis-typed address</strong>.</li>,
  • All unused files and codes should be removed
    • gulpfile.js
    • package.json
    • bower.json
  • You should use unique prefix for all functions, classes, constants etc.
    • function theme_slug_render_title() {
  • All scripts & styles should be enqueued rather than hard coding.
    • <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
    • <script src="<?php echo get_template_directory_uri(); ?>/js/respond.min.js"></script>
    • <script src="<?php echo get_template_directory_uri(); ?>/js/PIE.js"></script>
  • You should declare license of outsourced items (images, styles, scripts, etc) correctly.
  • Social share falls into plugin territory.

OUTCOME

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/

You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

If you have questions you can ask them here or in the #themereview channel on Slack.

Recommended reading:
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/
https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data

The coding standards are not required to pass the review, but they can be helpful when developing your theme.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods. It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

#2 @trkr
15 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.