WordPress.org

Make WordPress Themes

Opened 18 months ago

Closed 13 months ago

Last modified 13 months ago

#33859 closed theme (live)

THEME: Marvy – 1.0.1

Reported by: sagarjadhav Owned by: poena
Priority: new theme Keywords: theme-marvy
Cc: sagarjadhav27@…

Description

Marvy - 1.0

Marvy is a free Wordpress theme. It’s perfect for web agency business, corporate business, personal and parallax business portfolio, photography sites and freelancer. Is is responsive, clean, modern, flat and minimal.

Theme URL - http://marvythemes.com/
Author URL - https://github.com/sagarjadhav

SVN - https://themes.svn.wordpress.org/marvy/1.0
ZIP - https://wordpress.org/themes/download/marvy.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33859 THEME: Marvy – 1.0.1 closed live poena

(this ticket)

#37948 THEME: Marvy – 1.0.2 closed live themetracbot
#38877 THEME: Marvy – 1.0.3 closed live themetracbot
#44192 THEME: Marvy – 1.0.4 closed live themetracbot


https://themes.svn.wordpress.org/marvy/1.0/screenshot.png

Change History (6)

#1 @poena
13 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
13 months ago

Hi!
Your theme has been reviewed against these guidelines:
https://make.wordpress.org/themes/handbook/review/required/
There are a couple of things that needs to be solved before your theme can go live, you will find the full review below.


Remove any and all unused code, files or folders, inlcuding code that is commented out and the development files like the codesniffer and customizer-sample.php.
Is the home-social.php used? It is commented out in homepage.php and I didn't find a corresponding option.

Please keep one readme file. Make sure that the readme file corresponds to your theme, and that it is not only a copy of _s. Oh and also make sure the theme has been tested with 4.6 and preferably 4.7 beta, not only 4.2.2.

Theme URI is optional. If used, it is required to link to a page with information about the Theme. If a demonstration site is being used, the content must be related to the theme itself and not test data.
-The page should be helpful and useful to the user, for example including setup instructions, information on where to get support if this is provided, or perhaps upsell information.

License and copyright
You need to include a copyright statement for the theme itself. This is required to use GPL.
You need to add the license information for 'classie' in loader.js (MIT, see https://github.com/ded/bonzo)
I was unable to find any information about the included font. The theme needs to be 100% GPL compatible, and you need add the license information for the assets.
https://make.wordpress.org/themes/handbook/review/required/#licensing

Speaking of scripts, -you can use minified scripts, but you need to include the original, non minified version as well.
I was unable to find the non minified version of modernizr.
See https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Reduce the amount of content creation.
For example, you have 6 "feature" blocks that are fake custom post types that the user will loose when they switch themes.
You can use existing content for these like you have with the "Feature pages" and still combine it with an icon.
The about section consists of a text and an image: both posts and pages can provide this.
The icons as well as the section titles can be considered minor content creation and can be kept, but please reduce the overall amount of content creation.

Demo content
You need to remove all the demo content that promotes your theme, for example
"Marvy is incredibly spacious with a clean responsive design", Responsive & Flat Design", "Easy to Use",
-as well as the "Lorem ipsum".
There is no scenario where a user would want these kind of texts to display to their visitors.
The user should not have to "clean up" the theme by removing dummy texts to be able to use it.
In home-about-content.php you are including a default image with a picture of your theme, -this image can't be removed, only replaced by uploading another image.
See https://make.wordpress.org/themes/2016/03/31/what-is-demo-content/

Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.
In customizer-marvy.php you are using esc_textarea to sanitze several textareas.
esc_textarea is used to escape text inside actual textareas. Choose an appropriate sanitizing function for your type of content instead.

(-Also, why do you need a custom control for the textarea? There is already a textarea type in the customizer api. See https://developer.wordpress.org/themes/advanced-topics/customizer-api/#controls )

You need to escape all your options on output, this includes the color options in marvy-functions.php marvy_customize_css().
There are several places where you are only using "echo get_option", please double check all of your files.
See
https://make.wordpress.org/themes/handbook/review/required/#code
https://codex.wordpress.org/Data_Validation
https://developer.wordpress.org/reference/functions/esc_textarea/,

Backwards compatibility
Themes should only be backwards compatible for 3 versions.
In extras.php, remove the title fallback. In template-tags.php, remove the navigation-, archive title- and archive description fallbacks,
since these functions where added to WordPress more than 3 versions ago.

Remove any code referencing the Appearance > Header admin panel, this panel was also replaced by the customizer option in 4.1.
(It is only available in no-js environments, but it doesn't look like you plan to support no-js?)


Please reply within 7 days, or your ticket may be closed as not approved. Let me know if you need more time.

Last edited 13 months ago by poena (previous) (diff)

#3 @themetracbot
13 months ago

  • Summary changed from THEME: Marvy – 1.0 to THEME: Marvy – 1.0.1

Marvy - 1.0.1

Marvy is a free Wordpress theme. It’s perfect for web agency business, corporate business, personal and parallax business portfolio, photography sites and freelancer. Is is responsive, clean, modern, flat and minimal.

Theme URL -
Author URL - https://github.com/sagarjadhav

SVN - https://themes.svn.wordpress.org/marvy/1.0.1
ZIP - https://wordpress.org/themes/download/marvy.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=marvy/1.0&new_path=marvy/1.0.1

History:

Ticket Summary Status Resolution Owner
#33859 THEME: Marvy – 1.0.1 closed live poena

(this ticket)

#37948 THEME: Marvy – 1.0.2 closed live themetracbot
#38877 THEME: Marvy – 1.0.3 closed live themetracbot
#44192 THEME: Marvy – 1.0.4 closed live themetracbot


https://themes.svn.wordpress.org/marvy/1.0.1/screenshot.png

#4 @sagarjadhav
13 months ago

@poena Thanks for your detailed review. I have updated the codes with your given instructions. For now I have removed theme url, I will work on documentation and update the url later.

I really appreciate you efforts and time. Thanks again.

#5 @poena
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi
Great, I believe most of the problems have been fixed ( and theme is easy to set up :) ).
Your theme should be live shortly.

In your next version, remember to add whom the theme is copyrighted to , not only the year:
Marvy WordPress Theme, Copyright 2016 should be something like Marvy WordPress Theme, Copyright 2016 NAME

There are still some development files like the gruntfile that should be removed.

Note:
I also noticed that the fallback for the primary menu (that is displayed when no menu has been selected) is styled differently.


You might also be interested in this:
The dropdown_pages customizer control has a new ability in 4.7 that lets the user create a new page,
in case they don't want to select one from the list.

'allow_addition' => true,

(See https://core.trac.wordpress.org/changeset/38906/trunk/src/wp-includes/class-wp-customize-control.php)

#6 @sagarjadhav
13 months ago

@poena Thank you so much!
I will update the theme with given points in upcoming version.

Thanks Again!

Note: See TracTickets for help on using tickets.