WordPress.org

Make WordPress Themes

Opened 18 months ago

Closed 9 months ago

Last modified 7 months ago

#33885 closed theme (live)

THEME: Themelia – 1.0.19

Reported by: dariodev Owned by: WPDevHQ
Priority: new theme Keywords: theme-themelia accessibility-ready
Cc: dariodevcic@…

Description

Themelia - 1.0.0

Themelia is a mobile responsive WordPress theme built with speed, SEO and usability in mind. GP is compatible with major plugins like WooCommerce, WPML, bbPress and many more. It’s also mobile & tablet responsive, 100% valid HTML, Schema microdata integrated, search engine friendly, translated into over 15 languages and cross browser compatible (including IE8). GeneratePress has 8 widget areas, 5 navigation positions, 5 sidebar layouts, dropdown menus (click or hover), a back to top button and so much more. Navigate to Appearance > Customize to start customizing.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.0
ZIP - https://wordpress.org/themes/download/themelia.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.0/screenshot.png

Change History (117)

#1 @dariodev
18 months ago

Hello, I forgot to change Description text in the style.css. This is just a placeholder text from some other theme. After numerous tests, I missed this little thing, which is the first thing I saw after uploading :) I do not know if I can change it.

Here is the new description:

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. It has The theme is built on the rock-solid Hybrid Core theme framework.

#2 follow-up: @greenshady
18 months ago

To make changes, you have to upload a new version of your theme here: https://wordpress.org/themes/upload/

#3 @themetracbot
18 months ago

  • Summary changed from THEME: Themelia – 1.0.0 to THEME: Themelia – 1.0.1

Themelia - 1.0.1

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. It has The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.1
ZIP - https://wordpress.org/themes/download/themelia.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.0&new_path=themelia/1.0.1

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.1/screenshot.png

#4 in reply to: ↑ 2 @dariodev
18 months ago

Great, thank you! Now I see how things work. The new version is up!

Replying to greenshady:

To make changes, you have to upload a new version of your theme here: https://wordpress.org/themes/upload/

#5 @themetracbot
17 months ago

  • Summary changed from THEME: Themelia – 1.0.1 to THEME: Themelia – 1.0.2

Themelia - 1.0.2

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.2
ZIP - https://wordpress.org/themes/download/themelia.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.1&new_path=themelia/1.0.2

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.2/screenshot.png

#6 @themetracbot
17 months ago

  • Summary changed from THEME: Themelia – 1.0.2 to THEME: Themelia – 1.0.3

Themelia - 1.0.3

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.3
ZIP - https://wordpress.org/themes/download/themelia.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.2&new_path=themelia/1.0.3

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.3/screenshot.png

#7 @themetracbot
16 months ago

  • Summary changed from THEME: Themelia – 1.0.3 to THEME: Themelia – 1.0.4

Themelia - 1.0.4

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.4
ZIP - https://wordpress.org/themes/download/themelia.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.3&new_path=themelia/1.0.4

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.4/screenshot.png

#8 @themetracbot
15 months ago

  • Summary changed from THEME: Themelia – 1.0.4 to THEME: Themelia – 1.0.5

Themelia - 1.0.5

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.5
ZIP - https://wordpress.org/themes/download/themelia.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.4&new_path=themelia/1.0.5

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.5/screenshot.png

#9 @themetracbot
13 months ago

  • Owner set to frescutflorist
  • Status changed from new to reviewing

#10 @dariodev
13 months ago

Hi @frescutflorist please hold on with the reviewing. I will upload new version in next 12 hours.

#11 @themetracbot
13 months ago

  • Summary changed from THEME: Themelia – 1.0.5 to THEME: Themelia – 1.0.7

Themelia - 1.0.7

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.7
ZIP - https://wordpress.org/themes/download/themelia.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.5&new_path=themelia/1.0.7

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.7/screenshot.png

#12 @dariodev
13 months ago

Hi @frescutflorist
New version 1.0.7 is up and ready for the review, thank you!

#13 @dariodev
13 months ago

@frescutflorist are you around, still available for this review?

#14 @djrmom
13 months ago

  • Owner frescutflorist deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#15 @themetracbot
13 months ago

  • Owner set to f46vib

#16 @f46vib
13 months ago

Hi @dariodev.

I checked you the theme.
README.md and readme.txt is version number 1.0.6.
Please go to https://wordpress.org/themes/upload and reupload a new one.

#17 @grapplerulrich
12 months ago

@f46vib Did you find any other issues? The version number is a minor issue.

#18 @themetracbot
12 months ago

  • Summary changed from THEME: Themelia – 1.0.7 to THEME: Themelia – 1.0.8

Themelia - 1.0.8

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.8
ZIP - https://wordpress.org/themes/download/themelia.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.7&new_path=themelia/1.0.8

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.<br>The domains found are themelia, hybrid-core

#19 @dariodev
12 months ago

@grapplerulrich @greenshady Hi guys! My theme is now "under review" for a month. During that time, two reviewers did not even touch the code. There are themes that are older than mine and already reviewed or approved. Please could you remove this reviewer so that someone else may pick it up?

#20 @grapplerulrich
12 months ago

  • Owner f46vib deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#21 @themetracbot
12 months ago

  • Summary changed from THEME: Themelia – 1.0.8 to THEME: Themelia – 1.0.9

Themelia - 1.0.9

Welcome to Themelia, a meticulously crafted and balanced WordPress theme for personal and professional blogging. Designed for authors, freelancers, agencies and everyone else. Theme is built with search-engine optimization (SEO) in mind. It has consistent syntax structure, it’s a HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and [Schema.org](http://schema.org) microdata. The theme is built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.9
ZIP - https://wordpress.org/themes/download/themelia.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.8&new_path=themelia/1.0.9

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.<br>The domains found are themelia, hybrid-core

#22 @catchthemes
12 months ago

@grapplerulrich: I have doubt regarding name of this theme. Is themelia name allowed?


Issues:

  • Theme URL and Author URL is not valid
    • Theme URI is optional. If used, it is required to link to a page with information about the Theme. If a demonstration site is being used, the content must be related to the theme itself and not test data.
    • Author URI is optional. If used it is required to link to an author’s personal website or project/development website.
  • Add direct license of images used in screenshot

#23 @dariodev
12 months ago

@catchthemes Yes it is allowed. We already had conversation about this name on Slack. Just search for Themelia https://wordpress.slack.com/messages/themereview/search/themelia/

#24 @dariodev
12 months ago

@catchthemes Thank you for reviewing :)
Theme and author URLs are valid, but site is currently in the maintenance mode. I will make it live by the end of your review.

#25 @dariodev
12 months ago

@catchthemes did you find any other issue? Since these are minor issues I will wait for complete review before uploading new version.

#26 @grapplerulrich
12 months ago

@catchthemes The name seems to be fine.

#27 @themetracbot
12 months ago

  • Owner set to sali11

#28 follow-up: @dariodev
12 months ago

Hi @sali11, are you still available for this review?

#29 in reply to: ↑ 28 ; follow-up: @sali11
12 months ago

Replying to dariodev:

Hi @sali11, are you still available for this review?

#30 in reply to: ↑ 29 @dariodev
12 months ago

Hi @sali11, you just posted an empty reply. Are you doing a review?

Replying to sali11:

Replying to dariodev:

Hi @sali11, are you still available for this review?

This ticket was mentioned in Slack in #themereview by dariodev. View the logs.


12 months ago

#32 follow-up: @WPDevHQ
12 months ago

I'll take this review if @sali11 is unable to continue with it

#33 follow-up: @dariodev
12 months ago

Thank you, you are welcome :)
Just a quick question. I have a small update, just some styling issues. I guess you will find something anyway so I can wait with that changes. Or let me know if you want me to upload before you start with the reviewing.

#34 in reply to: ↑ 32 @sali11
12 months ago

Now i am back and give you a good review but you can also give a review here i know who you are?
i am busy in developing an other theme for a great page builder like elemntor and divi thats why can able to give fast review on that thing

#35 in reply to: ↑ 33 @sali11
12 months ago

thanks @dariodev for inviting me but i am so sorry for not giving a fast review because i am busy in some client work and also making a theme for a great page builder like Elementor and Divi but now i join you i will give you a review but not fast i hope you under stand me you can also text me directly so i check it first thanks

#36 @dariodev
12 months ago

Thank you for the update. @grapplerulrich if I understand correctly @sali11 is actually unavailable at this time. @WPDevHQ offered to take over, can you add him please?

#37 @dariodev
12 months ago

Hi @greenshady I need help here. Reviewer @sali11 is unable to continue with the review and in the same time @WPDevHQ is willing to take over. Could you assign this ticket to him?

#38 follow-up: @greenshady
12 months ago

  • Owner changed from sali11 to WPDevHQ

#39 @dariodev
12 months ago

Great, thank you @greenshady!

@WPDevHQ thank you very much! Please ping me before you start. I have prepared an update. Lots of changes but all just cosmetic fixes. I will try to upload before you begin. But if you start before it's OK, not a big deal, I will then wait for complete review.

#40 @WPDevHQ
12 months ago

Hey @dariodev no problem at all.

I'd prefer to review the latest version so please upload it when you are ready - the system will ping me when done and I'll commence the review :)

Last edited 12 months ago by WPDevHQ (previous) (diff)

#41 @themetracbot
12 months ago

  • Summary changed from THEME: Themelia – 1.0.9 to THEME: Themelia – 1.0.10

Themelia - 1.0.10

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.10
ZIP - https://wordpress.org/themes/download/themelia.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.9&new_path=themelia/1.0.10

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.10/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#42 in reply to: ↑ 38 @sali11
12 months ago

Thanks for assign other i hope you all dont feel bad when i am free i will back and help you guys thanks @dariodev changing owner

#43 @WPDevHQ
12 months ago

General Check.

  • I'm not sure that we allow emebding the Kirki framework into themes - will need a second opinion on this. @grapplerulrich

Code Check.

Required:

  • There's no need to register bundled scripts/styles and then enqueueing them - simply enqueue directly.
  • sidebars/primary.php, special.php and footer-widgets - Pointer/filler content is not allowed. If you'd like to have something showing on the sidebar then consider using the New WordPress starter content.
  • menu/primary.php - all text strings must be translatable. @line 10.
  • Only files that are in the library folder can retain the hybrid-core textdomain - all other files outside this folde must use the theme's textdomain

The "Required" issues must be resolved before submitting a revised version for further consideration. Please wait for a definitive clarification on embeding the Kirki framework before uploading a revised version.

If you have a ny questions please free to ask.

#44 @greenshady
12 months ago

Kirki is allowed to be bundled.

#45 @dariodev
12 months ago

Thank you for the review. I will make required changes asap!

#46 follow-up: @dariodev
12 months ago

I will need a few days more due to holidays. Is that OK?

#47 in reply to: ↑ 46 @WPDevHQ
12 months ago

Replying to dariodev:

I will need a few days more due to holidays. Is that OK?

Yes, that's fine. As long as you keep us updated I don't see any issues :)

#48 @themetracbot
11 months ago

  • Summary changed from THEME: Themelia – 1.0.10 to THEME: Themelia – 1.0.11

Themelia - 1.0.11

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.11
ZIP - https://wordpress.org/themes/download/themelia.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.10&new_path=themelia/1.0.11

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.11/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#49 @dariodev
11 months ago

Hi @WPDevHQ Happy New Year :)
I made required changes. Also I made a few more tweaks, but what is important I changed theme mod names, so for proper testing you should have a clean install.
Thank you!

#50 @dariodev
11 months ago

@WPDevHQ are you able to continue with the review?

#51 @WPDevHQ
11 months ago

  • Status changed from reviewing to approved

Yes sorry, had a look at the update a few days ago but didn't get the chance to post back - got busy in between.

The reported issues have been addressed satisfactorily and no futher issues found.

Resolving as resolved pending final Admin audit.

#52 @dariodev
11 months ago

This is great, thank you!

#53 @dariodev
11 months ago

@grapplerulrich I just noticed that my theme does not have the "accessibility-ready" keyword. Maybe it's because the "accessibility-ready" tag was not there from the beginning, I added it later.

#54 @grapplerulrich
11 months ago

  • Keywords accessibility-ready added

@dariodev Thanks, I have added it now. The system is not able to react when there is a change.

#55 @grapplerulrich
11 months ago

  • Status changed from approved to reopened

In that case let me reopen the ticket so that the accessibility-ready review happens before the final review. @ samikeijonen

#56 @dariodev
11 months ago

Thank you @grapplerulrich
I think @samikeijonen is not mentioned properly (space after @).

#57 @dariodev
11 months ago

I have an update. Fixed couple of issues - customizer style output for the main navigation and header/footer layout issues for specific customizer settings. Nothing that can affect the initial review or accessibility. Can I upload?

#58 @joedolson
11 months ago

@dariodev Yes! You can feel free to add your update.

#59 @themetracbot
11 months ago

  • Summary changed from THEME: Themelia – 1.0.11 to THEME: Themelia – 1.0.12

Themelia - 1.0.12

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

SVN - https://themes.svn.wordpress.org/themelia/1.0.12
ZIP - https://wordpress.org/themes/download/themelia.1.0.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.11&new_path=themelia/1.0.12

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.12/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#60 @dariodev
11 months ago

@joedolson thank you! New version is up and ready :)

#61 @sami.keijonen
11 months ago

@dariodev: I have time to review in 2 weeks because I'm travelling next week. Hope that's okay.

#62 @dariodev
11 months ago

@sami.keijonen it's OK, thank you.

#63 @sami.keijonen
11 months ago

Just a heads up that I'm back from travelling and trying to review this later this week.

#64 @sami.keijonen
10 months ago

Here is my initial review. Remember to check more details from the guidelines.

Main navigation seems to have most of the problems. I'll look at it again later on.

Keyboard Navigation

Fails

  • Dropdown menus are hidden using display:none, that's not allowed.
  • Can't access dropdown menus using keyboard Tab, Shift+Tab, and Enter. Arrow keys works well.
  • On mobile menu user should not be able to focus menu items until the menu is opened.
  • Also on mobile accessing to submenus is kind of weird: first Enter click opens the submenu and second click access the link itself.
  • I suggest that sub-arrow indicator should be a button, not a span element because you can't focus on span element and it doesn't have a11y API build in.
  • By clicking sub-arrow indicator you could open the submenu.

Controls

Passes

Skip Links

Passes

Forms

Passes

Headings

Passes

  • I'd consider should Primary sidebar heading be H2.

ARIA Landmark Roles

Fails

  • Add aria-label to Footer widget area also since you have it on Primary sidebar also.

Link Text

Fails

  • The post title should be used in addition to the string used for “Read more” text.
  • Also "Edit this" and "2 comments" links are considered repetative text. They should also have format like "2 comments on post title".
  • Post title can be inside screen-reader-class.

Contrasts

Fails

  • Links hover color doesn't have enough contrast.

Images

Passes

Media

Passes

Screen Reader Text

Passes

#65 @dariodev
10 months ago

Thank you, I will make required changes asap. There is a couple of things that I would like to argue about :) I will get back later! Thank you!

#66 @sami.keijonen
10 months ago

You can ask beforehand so we don't have to do extra work:)

#67 @dariodev
10 months ago

Please take my apologies for delay. I had a pretty busy week. I'm on this now and will have update and questions soon!

#68 @themetracbot
10 months ago

  • Summary changed from THEME: Themelia – 1.0.12 to THEME: Themelia – 1.0.13

Themelia - 1.0.13

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.13

SVN - https://themes.svn.wordpress.org/themelia/1.0.13
ZIP - https://wordpress.org/themes/download/themelia.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.12&new_path=themelia/1.0.13

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.13/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#69 @dariodev
10 months ago

Hi @sami.keijonen I fixed all required issues except first two. Please check my comments inline.

Keyboard Navigation

Dropdown menus are hidden using display:none, that's not allowed.

Can't access dropdown menus using keyboard Tab, Shift+Tab, and Enter

  • I can't replicate this issue. I tested in all browsers and works fine, accessing menus using Tab, Shift+Tab and Enter works as it should.

On mobile menu user should not be able to focus menu items until the menu is opened

  • Fixed

On mobile accessing to submenus is kind of weird: first Enter click opens the submenu and second click access the link itself

  • Yes, the menu behavior is exactly as you described but I don't think this is weird.

Suggest that sub-arrow indicator should be a button

  • If not required I choose span. I really don't find this needed on my menu.

ARIA Landmark Roles

Add aria-label to Footer widget area

  • Fixed

Link Text

The post title should be used in addition to the string used for “Read more” text.

  • Fixed

"Edit this" and "2 comments" links are considered repetative text.

  • "Edit this" appears only when admin is logged in and it is displayed on archive pages on each post.

Please let me know if you are available and ready to continue with review.
Thank you!

Last edited 10 months ago by dariodev (previous) (diff)

#70 @sami.keijonen
10 months ago

Hi and thanks for new version.

On Windows I still can't access dropdown menu items using Tab. With NVDA I can't even access submenu items using arrow keys.

From the guidelines.

Fails: Dropdown navigation menus are hidden using display:none; and brought into view on :hover

I'll ask @joedolson about this.

"Edit this" appears only when admin is logged in and it is displayed on archive pages on each post.

Site admin can be screen reader user so these should also be fixed. Both on comments and edit link.

I'll take a closer look later on this week.

#71 @dariodev
10 months ago

Thank you for prompt reply.
This is strange, I'm also on Windows and menu works fine using Tab, Shift+Tab, Enter. With NVDA installed left and right arrow keys does not navigate through the menu items, but Tab, Shift+Tab, Enter works OK. I tested on several Windows machines and one Mac, and always works.
Can you check on some other machine?
Also if you have time, I'm using the SmartMenus jQuery plugin, here you can check if this problem occurs on their demos https://www.smartmenus.org/about/themes/ and here is my demo http://preview.relishpress.com/themelia-basic/

#72 @sami.keijonen
10 months ago

Aah you have to activate it with Enter key.

I was expecting Enter key to activate the link. But not even the second Enter key activates the link. So how do I activate top menu link which have submenu items?

Hopefully Joe have time to comment on this ticket at some point.

#73 @dariodev
10 months ago

The first click/tap or pressing the Enter key, Spacebar or Down arrow, expands the sub menu, the second click/tap/Enter activates the item’s link. This is the same behavior as presented in Accessible Menu by Adobe https://adobe-accessibility.github.io/Accessible-Mega-Menu/

#74 @sami.keijonen
10 months ago

Ok, took me a while to get that :)

Meanwhile update the edit and comment links.

#75 @themetracbot
10 months ago

  • Summary changed from THEME: Themelia – 1.0.13 to THEME: Themelia – 1.0.14

Themelia - 1.0.14

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.14

SVN - https://themes.svn.wordpress.org/themelia/1.0.14
ZIP - https://wordpress.org/themes/download/themelia.1.0.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.13&new_path=themelia/1.0.14

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.14/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#76 @dariodev
10 months ago

Fixed post edit and comment links - added post title (wrapped in screen-reader-text).

#77 @joedolson
10 months ago

Re: the navigation menu. It's certainly accessible; but it is falling into a difficult area where accessibility and usability balance. It's perfectly usable - if you know how to do it. But communicating that information to somebody can be difficult.

Based on the ARIA feedback, which indicates that top level menu items are clickable and have collapsed sub menus, I think that this is fine. That said, you may get support requests caused by people not being able to figure out how to use the menu. However, as far as the guidelines go, we require only that you make your theme accessible; how you choose to implement that accessibility is up to you, as long as it meets the basic requirement that screen reader and keyboard users are able to interact with the menu.

#78 @dariodev
10 months ago

Thank you @joedolson, @sami.keijonen is that mean I'm free to go? :)
I'm going to upload new version in a minute as I messed the comments link with latest changes.

#79 @themetracbot
10 months ago

  • Summary changed from THEME: Themelia – 1.0.14 to THEME: Themelia – 1.0.15

Themelia - 1.0.15

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.15

SVN - https://themes.svn.wordpress.org/themelia/1.0.15
ZIP - https://wordpress.org/themes/download/themelia.1.0.15.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.14&new_path=themelia/1.0.15

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.15/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#80 @sami.keijonen
10 months ago

I'll check the latest a11y changes today or tomorrow.

#81 @sami.keijonen
10 months ago

I still see these issues.

  • "2 comments" links are considered repetative text.
  • Links hover color doesn't have enough contrast.

#82 @dariodev
10 months ago

  • "2 comments" links - You mean on the single post, right? There is only one comments link, right before post heading and there is a Comments heading right after the post and before comments section. Are you suggesting that I must remove one of these? I would like to have a comments link and keep the heading, can you suggest a solution?
  • Links hover color - There is text-decoration underline on hover, for all links. As I understand links color is not important if we use underline. Isn't that right?

#83 @sami.keijonen
10 months ago

I'm seeing repetative "2 comments" links in blog and archive pages.

As I understand links color is not important if we use underline. Isn't that right

Think of it this way. Underlining links are great for color blinds for example, so that we know there is a link. But color contrast is that we can actually see and read the link text.

#84 @dariodev
10 months ago

I'm confused about both things.

  • "repetitive comments links in blog and archive pages" - There is a comment link with each post that have comments. Are you saying that this is repetitive and shouldn't be there? What about Read More link then? It's a common thing on all blogs (including joedolson.com). Is that what you mean or have I got it wrong?
  • "color contrast" - I'm checking colors, contrast and other things using Firefox extension "tota11y" and I don't see any issues with color contrast. Please could you explain better what is wrong?

#85 follow-up: @sami.keijonen
10 months ago

There is a comment link with each post that have comments. Are you saying that this is repetitive and shouldn't be there?

Yes it's repetitive like "Read more" link text. Screen readers see only links "2 comments". It means that you can add post title in there also like 2 comments<span class="screen-reader-text"> on Markup: Image Alignment</span>

"color contrast" - I'm checking colors, contrast and other things using Firefox extension "tota11y" and I don't see any issues with color contrast. Please could you explain better what is wrong

Automated tools can't pick up everything. That's why manual testing is always needed. Here is great article about accessibility testing tools.

#2b8cc4 is hover color for links. It contrast on white background is 3.7 when it should be at least 4.5.

#86 @themetracbot
10 months ago

  • Summary changed from THEME: Themelia – 1.0.15 to THEME: Themelia – 1.0.16

Themelia - 1.0.16

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.16

SVN - https://themes.svn.wordpress.org/themelia/1.0.16
ZIP - https://wordpress.org/themes/download/themelia.1.0.16.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.15&new_path=themelia/1.0.16

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.16/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#87 in reply to: ↑ 85 @dariodev
10 months ago

@sami.keijonen I'm sorry for confusion, I was certain that I fixed that. That's why I didn't understand what are you talking about :) I even wrote in the changelog for previous version that I added the post title next to Comments and Read more links.
This is fixed now and also I added more contrast to links hover.
Please check latest version.
Thank you for your patience!

#88 @sami.keijonen
10 months ago

Sorry I totally missed your latest update. I'lll check in minute.

#89 @sami.keijonen
10 months ago

All accessibility issues are fixed now, you're good to go!

#90 @WPDevHQ
10 months ago

  • Status changed from reopened to reviewing

#91 @WPDevHQ
10 months ago

There are a couple of issues that need addressing before we can reapprove this theme.

REQUIRED:

File: themelia\inc\themelia.php
1 errors and 0 warnings
Line: 857 ERROR Silencing errors is forbidden

File: themelia\misc\comments-error.php
1 errors and 0 warnings
Line: 6 ERROR Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.

#92 @dariodev
10 months ago

Sami - Great, thank you for you time and patience in explaining things. Once again, sorry for confusion with Comments and Read more links. I'm learning about accessibility requirements, I knew it will be time consuming, but I feel it's worth it.

WPDevHQ, thank you, I'm on it!

#93 @dariodev
10 months ago

@WPDevHQ - I think both issues are false alarm:

1) This is a simple function to check existence of Gravatar and it's taken from the Codex https://codex.wordpress.org/Using_Gravatars#Checking_for_the_Existence_of_a_Gravatar

2) These placeholders should not be ordered. Please check it manually:

<?php
    // Translators: The two %s are placeholders for HTML. The order can't be changed.
    printf( esc_html__( 'Comments are closed, but %strackbacks%s and pingbacks are open.', 'themelia' ), '<a href="' . esc_url( get_trackback_url() ) . '">', '</a>' );
?>

I do have new version to upload, just a few minor changes in style.css and update .pot file, but I will wait for your thoughts on this.

#94 @WPDevHQ
10 months ago

That Gravatar functions is above my head so I'll defer it to @grapplerulrich to confirm its validity.

The errors are being returned by the NS Theme Check plugin - do we have false positives @grapplerulrich

#95 @grapplerulrich
10 months ago

Codex does not always have the best source of code. Where and why is this code being used? There must be a way to do it without error silencing.

That is an interesting way of forcing the order of the parameters.

@WPDevHQ The false positives should only be in warnings not errors.

#96 @WPDevHQ
10 months ago

Thank you @grapplerulrich

@dariodev Having re-read the codex link I see two issues with that function

a) The function seems to be for bakward compatibility with WordPress 2.5 and below

If you wish to develop a WordPress Theme with Avatars for 2.5 and below, add a check for the Gravatar function

Are the settings in WordPress under Settings >> Discussions not sufficient?

b) More than likely the function would fall under plugin territory. Its neither content presentation nor design oriented.

#97 @dariodev
10 months ago

This function is not for Backwards Compatibility. For the Backwards Compatibility is that a chunk of code above.

This code is being used in my function themelia_has_gravatar() to check the existence of authors Gravatar.

function themelia_has_gravatar( $email_address ) {
    // Build the Gravatar URL by hasing the email address
    $url = 'http://www.gravatar.com/avatar/' . md5( strtolower( trim ( $email_address ) ) ) . '?d=404';

    // Now check the headers...
    $headers = @get_headers( $url );

    // If 200 is found, the user has a Gravatar; otherwise, they don't.
    return preg_match( '|200|', $headers[0] ) ? true : false;
}

... and then the check in the author box

if( themelia_has_gravatar( $author_email )) { ... }

Function could not be simpler. I don't know for other way to check if email address has a Gravatar. WordPress settings are not sufficient. With use of this function I'm able to check if the user have gravatar or not, also it will show local avatars if the user has no gravatar. If there is no Gravatar or local avatar, nothing will be displayed. This is definitely design oriented and not under plugin territory.
I see no reason that this would not be allowed.

#98 @WPDevHQ
10 months ago

Even if we agree that its design oriented this $headers = @get_headers( $url ); doesn't pass the test and as @grapplerulrich stated, its not a false positive.

You may want to raise it on slack and see what other key reviewers have to say about it - someone migh have a better solution.

#99 @themetracbot
10 months ago

  • Summary changed from THEME: Themelia – 1.0.16 to THEME: Themelia – 1.0.17

Themelia - 1.0.17

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.17

SVN - https://themes.svn.wordpress.org/themelia/1.0.17
ZIP - https://wordpress.org/themes/download/themelia.1.0.17.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.16&new_path=themelia/1.0.17

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.17/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#100 @dariodev
10 months ago

@WPDevHQ - I realized you were right and I removed themelia_has_gravatar() function. New version is up and ready for recheck.

#101 @dariodev
9 months ago

Hi, @WPDevHQ do you think will have a time to look at it today?

#102 @WPDevHQ
9 months ago

Thank you for the update @dariodev and apologies for the delay, been a hectic week for me.

Why is it not possible to use the correct placeholders for the second error like the code below?

<?php
    // Translators: The two %s are placeholders for HTML. The order can't be changed.
    printf( esc_html__( 'Comments are closed, but %1$strackbacks%2$s and pingbacks are open.', 'themelia' ), '<a href="' . esc_url( get_trackback_url() ) . '">', '</a>' );
?>

#103 @dariodev
9 months ago

No probs @WPDevHQ, thank you for your time!

Becuase sprintf() argument swapping parameters does not work here. We don't translators to re-order placeholders in this case, because it is required to have the first variable,
<a href="' . esc_url( get_trackback_url() ) . '">
always on the first place and closing on the second place
</a>

#104 @dariodev
9 months ago

Have you seen my comment, is this OK?

#105 @dariodev
9 months ago

@grapplerulrich please can you check this. 8 weeks ago my theme was approved and in the admin queue. Then I noticed that theme is missing the "accessibility-ready" keyword (since I added the tag later). I asked about it and you re-opened the theme. 6-7 weeks later, my theme was finally approved to be accessibility-ready.
Back to review, where the reviewer finds 2 more issues. I corrected the first one immediately.
At the moment we discussing whether the use of argument swapping in translatable strings is required or maybe not in some cases. I believe there is no reason for holding the ticket.

I have two questions:
Can you see what it is about and push the theme back in the admin queue?
Given that my theme was already in the admin queue, 8 weeks ago, is there a chance to get a priority?

#106 @dariodev
9 months ago

@grapplerulrich do you have time to look at it?

#107 follow-up: @grapplerulrich
9 months ago

I just did the final review and found these issues or questions.

  • Why are you using locate_template instead of get_template_part
  • themelia_has_gravatar is still being used in themelia/misc/author-header.php
  • There are some unused variables in themelia/misc/author-header.php
  • The setting is not being escaped $classes[] = get_theme_mod( 'site_header_layout'
  • loop_columns() is not prefixed
  • The action storefront_make_me_cute has the wrong prefix

#108 in reply to: ↑ 107 @greenshady
9 months ago

Just popping in because I'm ready to see this theme go live. I keep getting emails on it. ;)

  • Why are you using locate_template instead of get_template_part

In the places that I've seen it used, it's more appropriate than get_template_part().

  • The setting is not being escaped $classes[] = get_theme_mod( 'site_header_layout'

Check line 128 of inc/customize.php.

#109 @themetracbot
9 months ago

  • Summary changed from THEME: Themelia – 1.0.17 to THEME: Themelia – 1.0.18

Themelia - 1.0.18

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.18

SVN - https://themes.svn.wordpress.org/themelia/1.0.18
ZIP - https://wordpress.org/themes/download/themelia.1.0.18.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.17&new_path=themelia/1.0.18

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.18/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#110 @dariodev
9 months ago

Thank you @greenshady for popping in. @grapplerulrich I cleaned all the mistakes, removed storefront_make_me_cute :), added prefix for loop_columns(), also I found other places where I really forgot escape get_theme_mod.
I hope this time it's all right.

#111 @grapplerulrich
9 months ago

In the places that I've seen it used, it's more appropriate than get_template_part().

Could you elaborate? @greenshady

As for the setting not being escaped. I later realized it was but forgot to remove the line of text.

I think this theme can be set live.

#112 @themetracbot
9 months ago

  • Summary changed from THEME: Themelia – 1.0.18 to THEME: Themelia – 1.0.19

Themelia - 1.0.19

Themelia is a meticulously crafted and balanced, highly responsive and retina-ready, simple and powerful, user friendly and efficiently coded WordPress theme. Themelia is built with search-engine optimization in mind. It has consistent syntax structure, it’s HTML5 valid, optimized for speed and SEO, utilizing most current HTML5 conventions and Schema.org microdata. Built on the rock-solid Hybrid Core theme framework.

Theme URL - http://relishpress.com/themes/themelia
Author URL - http://relishpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/themelia/1.0.19

SVN - https://themes.svn.wordpress.org/themelia/1.0.19
ZIP - https://wordpress.org/themes/download/themelia.1.0.19.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=themelia/1.0.18&new_path=themelia/1.0.19

History:

Ticket Summary Status Resolution Owner
#33885 THEME: Themelia – 1.0.19 closed live WPDevHQ

(this ticket)

#38620 THEME: Themelia Basic – 1.0.8 closed not-approved grapplerulrich
#41211 THEME: Themelia – 1.1.0 closed live themetracbot
#41332 THEME: Themelia – 1.1.1 closed live themetracbot
#41361 THEME: Themelia – 1.1.2 closed live themetracbot
#41363 THEME: Themelia – 1.1.3 closed live themetracbot
#45197 THEME: Themelia – 1.1.4 closed live themetracbot
#48402 THEME: Themelia – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/themelia/1.0.19/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are themelia, hybrid-core

#113 @dariodev
9 months ago

I just noticed and fixed a couple of mistakes:

  • removed unused variable in themelia/misc/author-header.php.
  • menu/secondary.php - forgot to remove the file, I thought I will not use it. The menu was not registered and not included anywhere in the theme. But now I decided to just add it in the footer.
  • fixed a few small glitches in style.css

That's it, no more. It's been 9 months. Who's going to be a midwife? :)

#114 @WPDevHQ
9 months ago

Sorry for the long absence guys - been tied up left right and center with development.

Giving it a last pass. Back in a bit!

#115 @WPDevHQ
9 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

No further issues detected, giving the multiple placeholder a pass since 2 key reviewers have had look at the theme.

Approved and setting as live.

Good luck.

#116 @dariodev
9 months ago

My first theme live... what a feeling :) Thank you, thank you all!

This ticket was mentioned in Slack in #themereview by dariodev. View the logs.


7 months ago

Note: See TracTickets for help on using tickets.