WordPress.org

Make WordPress Themes

Opened 18 months ago

Closed 13 months ago

Last modified 13 months ago

#33914 closed theme (live)

THEME: Isca – 2.0

Reported by: BinaryMoon Owned by: acosmin
Priority: new theme Keywords: theme-isca
Cc: binarymoon@…

Description

Isca - 1.1

An elegant magazine theme for WordPress, with a responsive design, and support for widgets, post thumbnails, custom headers and custom backgrounds.

Theme URL - https://prothemedesign.com/theme/isca/
Author URL - https://prothemedesign.com

SVN - https://themes.svn.wordpress.org/isca/1.1
ZIP - https://wordpress.org/themes/download/isca.1.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33914 THEME: Isca – 2.0 closed live acosmin

(this ticket)


https://themes.svn.wordpress.org/isca/1.1/screenshot.png

Change History (8)

#1 @acosmin
13 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#2 @acosmin
13 months ago

Theme check - ok

Required

  1. You are not allowed to redirect to a welcome page after theme install/activation.
  1. functions.php
    • line 65, get_header_textcolor() returns a theme mod which isn't escaped in Core. You'll have to escape it with esc_html() or esc_attr()
      • Recommended - you can use wp_add_inline_style() instead of hooking into wp_head
    • line 197 isn't being used.
    • Recommended - line 214, <hgroup> was removed from HTML5, you can use <header> instead
    • Replace isca_numeric_pagination() with the_posts_pagination(), it does the same thing.
  1. helpers\getting-started\index.php
    • you don't need to register that style, you can just enqueue it directly.
    • it's better if you use get_stylesheet_directory() with include() on lines 92-94
  1. helpers\getting-started\parts\theme-club.php
    • line 8, replace esc_html_e() with esc_attr_e()
  1. remove helpers\getting-started\parts\themes.php, it's not used anywhere.
  1. No hard coding of script and style files.
    • header.php, line 15.
  1. footer.php
    • line 34, http://wordpress.org/ needs to be escaped and translatable for locals, example
  1. archive.php
    • use the_archive_title() instead of lines 10-46;
  1. searchform.php
    • get_search_query() doesn't need escaping
  1. All actions need to be prefixed:
    • sidebar.php:l13, header.php:l22
  1. Declare licenses of any resources included such as fonts or images. (in readme.txt)
    • images used in the screenshot
    • js\html5.js
    • css\1140.css
    • images folder
    • example

That's about it!

Last edited 13 months ago by acosmin (previous) (diff)

#3 @BinaryMoon
13 months ago

Thanks for the review. Am working on the changes you mentioned but have a few comments:

  1. Regarding the esc_attr on get_search_query - I think that's still needed. get_search_query way be escaped but the output may not be suitable for an attribute (could contain valid characters like ' and ").
  1. Regarding licenses - the images in the images folder were all made by me. Do they still need a license? Aren't they implied GPL since they are included in the theme?
  1. The 1140 grid system that was used is no longer available online, and there's no record of it's license that I could find - only this - http://andytaylor.me/2013/04/09/1140px-css-grid-retired/

I'll upload the changed files tomorrow.

#4 @acosmin
13 months ago

  1. If you look in the source code, get_search_query() actually escapes its return with esc_attr(). You can see that here, click on Expand full source code. It also has an $escaped argument which is set to true by default.
  1. It's ok then.
  1. I guess it's ok, maybe mention Andy Taylor's name.

#5 @rabmalin
13 months ago

Regarding licenses - the images in the images folder were all made by me. Do they still need a license? Aren't they implied GPL since they are included in the theme?`

Even if you have created all those, license is required. Keep in readme, like, Images are created by theme author and are licensed under ... license.

#6 @themetracbot
13 months ago

  • Summary changed from THEME: Isca – 1.1 to THEME: Isca – 2.0

Isca - 2.0

An elegant magazine theme for WordPress, with a responsive design, and support for widgets, post thumbnails, custom headers and custom backgrounds.

Theme URL - https://prothemedesign.com/theme/isca/
Author URL - https://prothemedesign.com

SVN - https://themes.svn.wordpress.org/isca/2.0
ZIP - https://wordpress.org/themes/download/isca.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=isca/1.1&new_path=isca/2.0

History:

Ticket Summary Status Resolution Owner
#33914 THEME: Isca – 2.0 closed live acosmin

(this ticket)


https://themes.svn.wordpress.org/isca/2.0/screenshot.png

#7 @acosmin
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@BinaryMoon based on diff I am setting this theme live, it should appear in ~1 hour in the directory.

#8 @BinaryMoon
13 months ago

many thanks :)

Note: See TracTickets for help on using tickets.