WordPress.org

Make WordPress Themes

Opened 18 months ago

Closed 13 months ago

Last modified 13 months ago

#33916 closed theme (live)

THEME: Bexley – 2.0

Reported by: BinaryMoon Owned by: acosmin
Priority: new theme Keywords: theme-bexley
Cc: binarymoon@…

Description

Bexley - 1.1

Bexley is a photo blog – placing the photos at the forefront and giving you plenty of space to add your own writing around them.

Theme URL - https://wordpress.com/themes/bexley/
Author URL - https://prothemedesign.com/

SVN - https://themes.svn.wordpress.org/bexley/1.1
ZIP - https://wordpress.org/themes/download/bexley.1.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#33916 THEME: Bexley – 2.0 closed live acosmin

(this ticket)


https://themes.svn.wordpress.org/bexley/1.1/screenshot.png

Change History (6)

#1 @acosmin
13 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#2 @acosmin
13 months ago

Most of the review from your other ticket applies to this one :)

A few more notes for this theme:

  1. functions.php
    • line 37, you will need to urlencode the link, example
    • you will need to remove theme support for search-form because you're using searchform.php
    • line 125, use … instead of ...
    • line 214 needs esc_attr() for the theme mod
  1. You will need to add a license in readme.txt for: genericons, superfish.
  1. What is the purpose of having two style.css files?
Last edited 13 months ago by acosmin (previous) (diff)

#3 @BinaryMoon
13 months ago

Thanks - updated everything.

regarding style.css - I use Less to generate the main style.css which is in a subfolder. The theme is a couple years old and I've changed processes since making it. I may swap later but for now it's easier for me to maintain if it's like this :)

#4 @themetracbot
13 months ago

  • Summary changed from THEME: Bexley – 1.1 to THEME: Bexley – 2.0

Bexley - 2.0

Bexley is a photo blog – placing the photos at the forefront and giving you plenty of space to add your own writing around them.

Theme URL - https://wordpress.com/themes/bexley/
Author URL - https://prothemedesign.com/

SVN - https://themes.svn.wordpress.org/bexley/2.0
ZIP - https://wordpress.org/themes/download/bexley.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bexley/1.1&new_path=bexley/2.0

History:

Ticket Summary Status Resolution Owner
#33916 THEME: Bexley – 2.0 closed live acosmin

(this ticket)


https://themes.svn.wordpress.org/bexley/2.0/screenshot.png

#5 @acosmin
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@BinaryMoon Based on diff I am marking this theme as live

Not a big issue, but when you update both themes, Bexley & Isca, make sure you add a prefix to js_i18n. Didn't notice it until I checked this update :)

Thank you!

#6 @BinaryMoon
13 months ago

will do - thanks :)

Note: See TracTickets for help on using tickets.